138051 2014-10-24 11:51:42 -0700 Simplified IndexingType's hasAnyArrayStorage() 2014-10-24 12:18:11 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam oldest_to_newest 1044010 0 mark.lam 2014-10-24 11:51:42 -0700 IndexingType's hasAnyArrayStorage() currently does subtraction of ArrayStorageShape with the purpose of making non-ArrayStorage types underflow (with that subtraction) and have a result that exceeds SlowPutArrayStorageShape. What it is doing is basically checking for a shape value that is greater equal to ArrayStorageShape. We can just simplify the code as such. 1044011 1 240421 mark.lam 2014-10-24 11:57:11 -0700 Created attachment 240421 the patch. 1044013 2 240421 msaboff 2014-10-24 12:10:38 -0700 Comment on attachment 240421 the patch. View in context: https://bugs.webkit.org/attachment.cgi?id=240421&action=review r=me Fix the comment issues. > Source/JavaScriptCore/runtime/IndexingType.h:39 > + struct IndextingType { Spelling of IndextingType > Source/JavaScriptCore/runtime/IndexingType.h:42 > + uint8_t maHaveIndexedShapes:1; // bit 5 Should this be mayHaveIndexedShapes? 1044020 3 mark.lam 2014-10-24 12:18:11 -0700 Thanks. I also found 2 more errors in the comments (should not have tabs, and "mayHaveIndexedAccessors"instead of "mayHaveIndexedShape"). Fixed comments, and landed in r175172: <http://trac.webkit.org/r175172>. 240421 2014-10-24 11:57:11 -0700 2014-10-24 12:10:38 -0700 the patch. bug-138051.patch text/plain 2793 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTc1MTY5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDE0LTEwLTI0ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBT aW1wbGlmaWVkIEluZGV4aW5nVHlwZSdzIGhhc0FueUFycmF5U3RvcmFnZSgpLgorICAgICAgICA8 aHR0cHM6Ly93ZWJraXQub3JnL2IvMTM4MDUxPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEluZGV4aW5nVHlwZSdzIGhhc0FueUFycmF5U3RvcmFnZSgp IGN1cnJlbnRseSBkb2VzIHN1YnRyYWN0aW9uIG9mIEFycmF5U3RvcmFnZVNoYXBlCisgICAgICAg IHdpdGggdGhlIHB1cnBvc2Ugb2YgbWFraW5nIG5vbi1BcnJheVN0b3JhZ2UgdHlwZXMgdW5kZXJm bG93ICh3aXRoIHRoYXQgc3VidHJhY3Rpb24pCisgICAgICAgIGFuZCBoYXZlIGEgcmVzdWx0IHRo YXQgZXhjZWVkcyBTbG93UHV0QXJyYXlTdG9yYWdlU2hhcGUuICBXaGF0IGl0IGlzIGRvaW5nIGlz CisgICAgICAgIGJhc2ljYWxseSBjaGVja2luZyBmb3IgYSBzaGFwZSB2YWx1ZSB0aGF0IGlzIGdy ZWF0ZXIgZXF1YWwgdG8gQXJyYXlTdG9yYWdlU2hhcGUuCisgICAgICAgIFdlIGNhbiBqdXN0IHNp bXBsaWZ5IHRoZSBjb2RlIGFzIHN1Y2guCisKKyAgICAgICAgQWxzbyBhZGRlZCBhIGNvbW1lbnQg dG8gZGVzY3JpYmUgdGhlIGludGVuZGVkIHNoYXBlIG9mIHRoZSBiaXRzIGluIEluZGV4aW5nVHlw ZS4KKworICAgICAgICAqIHJ1bnRpbWUvSW5kZXhpbmdUeXBlLmg6CisgICAgICAgIChKU0M6Omhh c0FueUFycmF5U3RvcmFnZSk6CisKIDIwMTQtMTAtMjMgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29y YXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBQcm92aWRlIGEgd2F5IHRv IGhhdmUgYWx0ZXJuYXRlIGluc3BlY3RvciBhZ2VudHMKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL0luZGV4aW5nVHlwZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL0luZGV4aW5nVHlwZS5oCShyZXZpc2lvbiAxNzUxNDIpCisrKyBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9JbmRleGluZ1R5cGUuaAkod29ya2luZyBjb3B5KQpA QCAtMSw1ICsxLDUgQEAKIC8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMTIgQXBwbGUgSW5jLiBBbGwg cmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAyMDEyLCAyMDE0IEFwcGxlIEluYy4g QWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNv dXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICAqIG1vZGlmaWNhdGlvbiwg YXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwpAQCAt MzEsNiArMzEsMjIgQEAKIAogbmFtZXNwYWNlIEpTQyB7CiAKKy8qCisgICAgU3RydWN0dXJlIG9m IHRoZSBJbmRleGluZ1R5cGUKKyAgICA9PT09PT09PT09PT09PT09PT09PT09PT09PT09PQorICAg IENvbmNlcHR1YWxseSwgdGhlIEluZGV4aW5nVHlwZSBsb29rcyBsaWtlIHRoaXM6CisKKyAgICBz dHJ1Y3QgSW5kZXh0aW5nVHlwZSB7CisgICAgCXVpbnQ4X3QgaXNBcnJheToxOyAgICAgICAgICAg ICAgICAvLyBiaXQgMAorICAgIAl1aW50OF90IHNoYXBlOjQ7ICAgICAgICAgICAgICAgICAgLy8g Yml0IDEgLSA0CisgICAgCXVpbnQ4X3QgbWFIYXZlSW5kZXhlZFNoYXBlczoxOyAgICAvLyBiaXQg NQorICAgIH07CisKKyAgICBUaGUgc2hhcGUgdmFsdWVzIChlLmcuIEludDMyU2hhcGUsIENvbnRp Z3VvdXNTaGFwZSwgZXRjKSBhcmUgYW4gZW51bWVyYXRpb24gb2YKKyAgICB2YXJpb3VzIHNoYXBl cyAodGhvdWdoIG5vdCBuZWNlc3NhcmlseSBzZXF1ZW50aWFsIGluIHRlcm1zIG9mIHRoZWlyIHZh bHVlcykuCisgICAgSGVuY2UsIHNoYXBlIHZhbHVlcyBhcmUgbm90IGJpdHdpc2UgZXhjbHVzaXZl IHdpdGggcmVzcGVjdCB0byBlYWNoIG90aGVyLgorKi8KKwogdHlwZWRlZiB1aW50OF90IEluZGV4 aW5nVHlwZTsKIAogLy8gRmxhZ3MgZm9yIHRlc3RpbmcgdGhlIHByZXNlbmNlIG9mIGNhcGFiaWxp dGllcy4KQEAgLTEyOCw3ICsxNDQsNyBAQCBzdGF0aWMgaW5saW5lIGJvb2wgaGFzQXJyYXlTdG9y YWdlKEluZGV4CiAKIHN0YXRpYyBpbmxpbmUgYm9vbCBoYXNBbnlBcnJheVN0b3JhZ2UoSW5kZXhp bmdUeXBlIGluZGV4aW5nVHlwZSkKIHsKLSAgICByZXR1cm4gc3RhdGljX2Nhc3Q8dWludDhfdD4o KGluZGV4aW5nVHlwZSAmIEluZGV4aW5nU2hhcGVNYXNrKSAtIEFycmF5U3RvcmFnZVNoYXBlKSA8 PSBzdGF0aWNfY2FzdDx1aW50OF90PihTbG93UHV0QXJyYXlTdG9yYWdlU2hhcGUgLSBBcnJheVN0 b3JhZ2VTaGFwZSk7CisgICAgcmV0dXJuIHN0YXRpY19jYXN0PHVpbnQ4X3Q+KGluZGV4aW5nVHlw ZSAmIEluZGV4aW5nU2hhcGVNYXNrKSA+PSBBcnJheVN0b3JhZ2VTaGFwZTsKIH0KIAogc3RhdGlj IGlubGluZSBib29sIHNob3VsZFVzZVNsb3dQdXQoSW5kZXhpbmdUeXBlIGluZGV4aW5nVHlwZSkK