138038 2014-10-23 21:13:06 -0700 [iOS8][ARMv7(s)] Optimized Object.create in 'use strict' context sometimes breaks. 2015-09-14 06:07:03 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) iPhone / iPad iOS 8.0 RESOLVED FIXED InRadar P2 Critical --- 1 stefan.penner benjamin benjamin bugs.webkit.org ddkilzer dnelsen fpizlo ggaren mark.hatsell mjstaffa msaboff rshimazu sivakumar.ur.friend spencerwi unwttng webkit-bug-importer ysuzuki oldest_to_newest 1043931 0 stefan.penner 2014-10-23 21:13:06 -0700 (iOS8 seems to be missing from the OS dropdown, so I labeled it as other). It some that in sometimes (appears only when optimized, but not always) the new instance produced by `Object.create` somehow fails to be a proper instance, and setting properties results in a thrown exception. Example: ```js var a = Object.create(other); a.foo = 1; // => throws: TypeError Attempted to assign to readonly property ``` Interestingly, if the exception is caught and `a` inspected: `a.__proto__.foo` was set to `5`, not `a.foo` My suspicion is that it appears to be JIT related issue, as it manifests only in hot-sots and not specifically tied to any one occurrence of `Object.create`. affected: --------- iOS 8.1 (12B411) on iPhone 5. iPhone 4S iOS 8 iPhone 4 iPhone 5 Simulator iPhone 5c iOS 8 not-affected: ------------- iOS 8.0 (12A365) Simulator iPhone 6 iOS8 iPhone 5s iOS 8 iPad Retina Mini iOS 8 Demo: ----- (unfortunately I was not able to isolated further) http://emberjs.jsbin.com/vecuz/1/ all iOS 8 non-64bit devices http://jsbin.com/kegiya/6 (one scenario patched, but another creeps up when the page is added to the home screen) Workaround: ----------- * remove 'use strict' from the context using the `Object.create` * another option, although poor is to set build of the new object as a pojo, and then set __proto__ after the fact (https://github.com/emberjs/ember.js/issues/5629) related issues: --------------- http://stackoverflow.com/questions/25174594/typeerror-attempted-to-assign-to-readonly-property-on-ios8-safari https://github.com/emberjs/ember.js/issues/5606 https://github.com/emberjs/ember.js/issues/5629 (same as above, one early workaround) https://github.com/mozilla/pdf.js/issues/5341 Similar symptoms but I believe to not be the same: ----------------------------------------- as our issue is specific to non-64bit architectures and doesn't appear to have anything to do with WebIDL https://bugs.webkit.org/show_bug.cgi?id=49739 https://github.com/Polymer/platform/issues/66 https://github.com/uhop/dcl/issues/15 https://github.com/angular/angular.js/issues/9128 https://github.com/ibm-js/delite/issues/259 1043932 1 stefan.penner 2014-10-23 21:19:06 -0700 So basically this doesn't affect all, but it affects a good amount of ember 1.7+ (since we added 'use strict') apps in the wild. Scouring stack overflow it appears several angular users have the same problem. I suspect any app that has a hot Object.create in a 'use strict' context could suffer from this. Typically the result is a hard failure, and a broken app experience. 1043933 2 stefan.penner 2014-10-23 21:26:53 -0700 Also, for any ember users who stumble upon this. 1.7 -> 1.8beta5 (and those related canary builds) are affected as they include 'use strict' contexts There is a very strong probability that 1.8 final, will ship with 'use strict' stripped. But as a stop-gap, I am maintaining 1.7 and canary versions of ember that have 'use strict stripped' and do not appear to have this issue. 1.7: ---- bower users: -> yapplabs/ember-ios8-fix#1.7.0 https://github.com/yapplabs/ember-ios8-fix/tree/1.7.0 canary: ------- bower users: -> yapplabs/ember-ios8-fix https://github.com/yapplabs/ember-ios8-fix/tree/master 1043995 3 ggaren 2014-10-24 11:21:01 -0700 Do we have a way to reproduce this failure (even if not a reduced way)? 1044006 4 stefan.penner 2014-10-24 11:41:07 -0700 The JSBIn's included in DEMO should consistently fail on the affected devices. I can also make myself available for further discussion/questions if needed. 1044421 5 webkit-bug-importer 2014-10-27 22:38:36 -0700 <rdar://problem/18792571> 1069490 6 mjstaffa 2015-02-16 10:47:15 -0800 This is also affecting angularjs applications. Is this being worked on or is there something we can do to speed up the process? 1085106 7 unwttng 2015-04-14 04:43:56 -0700 +1 this is affecting our app. Response has been to remove use strict declarations but that's pretty undesirable. Is any work going on for the radar yet? 1085107 8 unwttng 2015-04-14 04:47:13 -0700 Also for more information towards the original report, in our codebase instead of "setting properties results in a thrown exception" we were often seeing what I'd describe as "setting properties invisibly does not happen". At one point, code like: ```js this.data = {}; console.log(this.data); ``` Would output `undefined`. At other points it would crash Safari, and we would get the app reload with the grey notification bar. In almost 100% of cases it would cease any useful communication with Safari desktop dev tools. 1085109 9 unwttng 2015-04-14 04:51:04 -0700 Lastly, great job pinning down a reproducible case for this Stefan, this is a seriously slippery bug in my recent experience. 1085699 10 benjamin 2015-04-15 14:58:15 -0700 Still broken on ToT :( 1085899 11 unwttng 2015-04-16 06:27:41 -0700 Update: we are still seeing the effects of this bug even after totally removing `'use strict';` declarations from our code, so as of the moment there's not a known workaround that is good for everyone. 1085911 12 stefan.penner 2015-04-16 07:09:34 -0700 @jack remember that JSC will inline code. As far as I can tell, if a non-use strict module that contains Object.create is inlined into a use strict module the problem returns. With ember, we also still saw the issues until all potential Object.create inline sites in the framework where also stripped of `use strict`. This is extremely brittle, as we do not control user-land code. And if the code is slightly refactored we may once again regress. We cant just strip use strict from our entire program, as we rely on subtle differences. This really needs to get fixed, hopefully with the recent burst of attention it will happen sooner. 1085914 13 unwttng 2015-04-16 07:38:34 -0700 Agreed, there's no even semi-good way round this. Good to see an @webkit edit to the ticket in the last few days, even if they didn't comment :( 1085921 14 stefan.penner 2015-04-16 08:06:55 -0700 I likely haven't done a good job of bringing attention to this issue. So I appreciate the extra eyes and support its getting now. My appologies for not doing more earlier 1094839 15 bugs.webkit.org 2015-05-14 10:53:33 -0700 We (Amplify Education) are also seeing this bug on 32-bit iPads, manifesting as an angularjs error when creating a new object. 1097797 16 253823 benjamin 2015-05-27 18:22:10 -0700 Created attachment 253823 Patch 1097829 17 253823 msaboff 2015-05-27 21:33:57 -0700 Comment on attachment 253823 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253823&action=review r=me > Source/JavaScriptCore/ChangeLog:24 > + and we fail the put_by_id because we try to set a property a on number. Wording - "... a on number", should this be "on a number"? 1097946 18 benjamin 2015-05-28 13:58:03 -0700 Committed r184960: <http://trac.webkit.org/changeset/184960> 1098103 19 unwttng 2015-05-29 03:13:39 -0700 Great to see a resolution. Next question is when this will make its way into mobile Safari? 1107075 20 spencerwi 2015-07-06 05:17:23 -0700 Great to see a patch/resolution for this. I do echo Jack's question though: is there any word yet on a timeline for fixing iOS Safari? This causes sporadic/nondeterministic issues with Angular.js webapps, and there's no real workaround except to recommend installing Chrome for its JS engine. 1107087 21 ddkilzer 2015-07-06 07:14:35 -0700 This was fixed in iOS 9 Dev Seed 2. 1107089 22 spencerwi 2015-07-06 07:18:23 -0700 (In reply to comment #21) > This was fixed in iOS 9 Dev Seed 2. Great! Thanks for the quick response. Are there any plans for a backport for iOS8 users? (pardon me if it's a question with an obvious answer; I'm not very familiar with the iOS ecosystem in general) 1107092 23 ddkilzer 2015-07-06 07:36:07 -0700 (In reply to comment #22) > (In reply to comment #21) > > This was fixed in iOS 9 Dev Seed 2. > > Great! Thanks for the quick response. Are there any plans for a backport for > iOS8 users? (pardon me if it's a question with an obvious answer; I'm not > very familiar with the iOS ecosystem in general) It is unlikely that this will be backported to iOS 8.x. 1107439 24 mark.hatsell 2015-07-07 06:17:17 -0700 This jsfiddle example still seems to fail for me on iOS 9 Beta 2. http://jsfiddle.net/adrian_vasiliu/ftyafr0d/ 1107481 25 stefan.penner 2015-07-07 10:41:30 -0700 > It is unlikely that this will be backported to iOS 8.x. This would be unfortunate, a large amount of devices and sites are affected by this. The solution is basically, hand tailor scenario by scenario and wait for armv7 devices on iOS8 to age out. Luckily iOS age out faster then android, Unfortunately this will still be years of time. Time where app authors have no reasonable solution. 1107482 26 stefan.penner 2015-07-07 10:42:57 -0700 (In reply to comment #24) > This jsfiddle example still seems to fail for me on iOS 9 Beta 2. > > http://jsfiddle.net/adrian_vasiliu/ftyafr0d/ This fiddle illustrates a different issue. Confusingly it manifests in a similar way as the one this bug is tracking. 1107557 27 ddkilzer 2015-07-07 13:55:43 -0700 (In reply to comment #26) > (In reply to comment #24) > > This jsfiddle example still seems to fail for me on iOS 9 Beta 2. > > > > http://jsfiddle.net/adrian_vasiliu/ftyafr0d/ > > This fiddle illustrates a different issue. Confusingly it manifests in a > similar way as the one this bug is tracking. Do we have a new bug tracking this issue? 1124216 28 sivakumar.ur.friend 2015-09-08 01:28:14 -0700 (In reply to comment #25) > > It is unlikely that this will be backported to iOS 8.x. > > This would be unfortunate, a large amount of devices and sites are affected > by this. The solution is basically, hand tailor scenario by scenario and > wait for armv7 devices on iOS8 to age out. > > Luckily iOS age out faster then android, Unfortunately this will still be > years of time. Time where app authors have no reasonable solution. Although I'm happy that this is fixed, I feel concerned that this isn't getting backported to iOS8. For those of us serving enterprise web apps this is a blocking issue since most of our users just can't use our apps because of this issue. The 'use strict' removal didn't work for us. Not entirely sure about the webkit process but there have been instances where such issues have been fixed at least in one prior version. Given that iOS9 isn't still out and would take a while for everyone to adapt please consider backporting this. 1124219 29 ddkilzer 2015-09-08 03:46:53 -0700 Thanks, Sivakumar. We will take this into consideration, but we rarely release updates to the previous major version of iOS after shipping a new major version. I would encourage you to continue looking for a workaround if possible. 1125587 30 unwttng 2015-09-14 06:07:03 -0700 If I might, I'll register again that this is impacting a large swathe of our users too, with no attempts at workarounds working. If you're not prepared to backport, I feel a certain amount of support towards the effort of finding viable workarounds would be a responsible way to treat this. It's a breaking issue in a core part of code. 253823 2015-05-27 18:22:10 -0700 2015-05-27 21:33:57 -0700 Patch bug-138038-20150527182158.patch text/plain 6975 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0ODY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh NWViNjg3OTQ5OTM1NGVkMTY4Y2RlOGY0NTNkMzBhYWJlMmE3NDlmLi40YmFjOGEyYzgwOWRiOGZj ZmRhYzk5YTZjNjNiZDhhODFhZTIxOGQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSw1MSBAQAorMjAxNS0wNS0yNyAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluQHdlYmtp dC5vcmc+CisKKyAgICAgICAgW2lPUzhdW0FSTXY3KHMpXSBPcHRpbWl6ZWQgT2JqZWN0LmNyZWF0 ZSBpbiAndXNlIHN0cmljdCcgY29udGV4dCBzb21ldGltZXMgYnJlYWtzLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4MDM4CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVEw7RFI6IHNvbWV0aW1lcyB0aGUg YmFzZWxpbmUgSklUIGNvdWxkIGFjY2lkZW50YWxseSBudWtlIHRoZSB0YWcgYmVmb3JlIGNhbGxp bmcKKyAgICAgICAgICAgICAgIHRvIEMrKywgbWFraW5nIHB1dF9ieV9pZCBiZWhhdmUgZXJyYXRp Y2FsbHkuCisKKyAgICAgICAgVGhlIGJ1ZyB3YXMgdGhhdCBwdXRfYnlfaWQgd291bGQgcmFuZG9t bHkgbm90IHdvcmsgY29ycmVjdGx5IGluIDMyYml0cy4gSXQgaGFwcGVuZWQKKyAgICAgICAgaW4g dGhlIGJhc2VsaW5lIEpJVCBpZiB3ZSB3ZXJlIHVubHVja3kgZW5vdWdoOgorICAgICAgICAtVGhl IGNvZGUgZ2V0IGhvdCBlbm91Z2ggYW5kIHRoZSBzdHJ1Y3R1cmUgaXMgc3RhYmxlIHNvIHdlIGdl dCBhIGZhc3QgcGF0aCBmb3IKKyAgICAgICAgIHB1dF9ieV9pZC4KKyAgICAgICAgLVdlIHJlcGF0 Y2ggdGhlIGZhc3QtcGF0aCBicmFuY2ggd2l0aCBhIHN0dWIgZ2VuZXJhdGVkIGJ5CisgICAgICAg ICBlbWl0UHV0VHJhbnNpdGlvblN0dWJBbmRHZXRPbGRTdHJ1Y3R1cmUoKS4KKyAgICAgICAgLUlu IGVtaXRQdXRUcmFuc2l0aW9uU3R1YkFuZEdldE9sZFN0cnVjdHVyZSgpLCB3ZSBvbmx5IHByZXNl cnZlIHRoZSBwYXlsb2FkIG9mIHRoZSBiYXNlCisgICAgICAgICByZWdpc3RlciwgdGhlIHRhZyBy ZWdpc3RlciBpcyBpZ25vcmVkLgorICAgICAgICAtZW1pdFB1dFRyYW5zaXRpb25TdHViQW5kR2V0 T2xkU3RydWN0dXJlKCkgYWxsb2NhdGUgMiB0byAzIHJlZ2lzdGVycy4gQW55IG9mIHRob3NlCisg ICAgICAgICBjb3VsZCBiZSB0aGUgb25lIHVzZWQgZm9yIHRoZSBiYXNlJ3MgdGFnIGJlZm9yZSB0 aGUgZmFzdCBwYXRoIGFuZCB0aGUgdmFsdWUgaXMgdHJhc2hlZC4KKyAgICAgICAgLUlmIHdlIGhp dCBvbmUgb2YgdGhlIGZhaWx1cmUgY2FzZSwgd2UgZmFsbGJhY2sgdG8gdGhlIHNsb3cgcGF0aCwg YnV0IHdlIGRlc3Ryb3llZAorICAgICAgICAgdGhlIHRhZyBwb2ludGVyLgorICAgICAgICAtV2Ug bm93IGhhdmUgdW5yZWxhdGVkIGJpdHMgaW4gdGhlIHRhZywgdGhlIG1vc3QgbGlrZWx5IHZhbHVl IHR5cGUgaXMgbm93ICJkb3VibGUiCisgICAgICAgICBhbmQgd2UgZmFpbCB0aGUgcHV0X2J5X2lk IGJlY2F1c2Ugd2UgdHJ5IHRvIHNldCBhIHByb3BlcnR5IGEgb24gbnVtYmVyLgorCisgICAgICAg IFRoZSBtb3N0IG9idmlvdXMgc29sdXRpb24gd291bGQgYmUgdG8gY2hhbmdlIGVtaXRQdXRUcmFu c2l0aW9uU3R1YkFuZEdldE9sZFN0cnVjdHVyZSgpCisgICAgICAgIHRvIHByZXNlcnZlIHRoZSB0 YWcgcmVnaXN0ZXIgaW4gYWRkaXRpb24gdG8gdGhlIHZhbHVlIHJlZ2lzdGVyLgorICAgICAgICBJ IGRlY2lkZWQgYWdhaW5zdCB0aGF0IG9wdGlvbiBiZWNhdXNlIG9mIHRoZSBhZGRlZCBjb21wbGV4 aXR5LiBUaGUgREZHIGRvZXMgbm90IG5lZWQKKyAgICAgICAgdGhhdCBjYXNlLCBzbyBJIHdvdWxk IGhhdmUgdG8gYWRkIGJyYW5jaGVzIGV2ZXJ5d2hlcmUgdG8gZGlzdGluZ3Vpc2ggdGhlIGNhc2Vz CisgICAgICAgIHdlcmUgd2UgbmVlZCB0byBwcmVzZXJ2ZSB0aGUgdGFnIG9yIG5vdC4KKworICAg ICAgICBJbnN0ZWFkLCBJIGp1c3QgbG9hZCB0aGUgdGFnIGJhY2sgZnJvbSBtZW1vcnkgaW4gdGhl IHNsb3cgcGF0aC4gVGhlIGZ1bmN0aW9uIGluIHRoZSBzbG93CisgICAgICAgIHBhdGggaXMgc2V2 ZXJhbCBvcmRlciBvZiBtYWduaXR1ZGUgc2xvd2VyIHRoYW4gYSBsb2FkLCBpdCBpcyBub3Qgd29y dGggZWxpbWluYXRpbmcgaXQsCisgICAgICAgIGVzcGVjaWFsbHkgaW4gYmFzZWxpbmUgSklULgor CisgICAgICAgIEkgYWxzbyBkaXNjb3ZlcmVkIDQgdXNlbGVzcyBsb2FkcyBpbiB0aGUgZmFzdCBw YXRoLCBzbyBldmVuIHdpdGggbXkgZXh0cmEgbG9hZCwgdGhpcyBwYXRjaAorICAgICAgICBtYWtl cyB0aGUgYmFzZWxpbmUgZmFzdGVyIDopCisKKyAgICAgICAgKiBqaXQvSklUUHJvcGVydHlBY2Nl c3MzMl82NC5jcHA6CisgICAgICAgIChKU0M6OkpJVDo6ZW1pdFNsb3dfb3BfcHV0X2J5X2lkKToK KyAgICAgICAgKEpTQzo6SklUOjplbWl0X29wX3B1dF9ieV9pZCk6IERlbGV0ZWQuCisgICAgICAg ICogdGVzdHMvc3RyZXNzL3B1dC1ieS1pZC1vbi1uZXctb2JqZWN0LWFmdGVyLXByb3RvdHlwZS10 cmFuc2l0aW9uLW5vbi1zdHJpY3QuanM6IEFkZGVkLgorICAgICAgICAob3BhcXVlTmV3T2JqZWN0 KToKKyAgICAgICAgKHB1dFZhbHVlT25OZXdPYmplY3QpOgorICAgICAgICAqIHRlc3RzL3N0cmVz cy9wdXQtYnktaWQtb24tbmV3LW9iamVjdC1hZnRlci1wcm90b3R5cGUtdHJhbnNpdGlvbi1zdHJp Y3QuanM6IEFkZGVkLgorICAgICAgICAoc3RyaW5nX2FwcGVhcmVkX2hlcmUub3BhcXVlTmV3T2Jq ZWN0KToKKyAgICAgICAgKHB1dFZhbHVlT25OZXdPYmplY3QpOgorCiAyMDE1LTA1LTI2ICBZdXN1 a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgogCiAgICAgICAgIElubGluZSBAQXJy YXkgLyBAT2JqZWN0IGNhbGxzaXRlcwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L2ppdC9KSVRQcm9wZXJ0eUFjY2VzczMyXzY0LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9q aXQvSklUUHJvcGVydHlBY2Nlc3MzMl82NC5jcHAKaW5kZXggMGExMWJiYTQ5ZTRmMmU2NmRkMGVk NGFlNjQ2ODE0NDFmMWEyODAyMC4uMDkwMTFiMTFhMmY2MTNjMTg0MzEwMDRkZjc1ODFmZjg5OTFk ZWU4OSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRQcm9wZXJ0eUFj Y2VzczMyXzY0LmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVFByb3BlcnR5 QWNjZXNzMzJfNjQuY3BwCkBAIC01MzUsOSArNTM1LDYgQEAgdm9pZCBKSVQ6OmVtaXRfb3BfcHV0 X2J5X2lkKEluc3RydWN0aW9uKiBjdXJyZW50SW5zdHJ1Y3Rpb24pCiAgICAgZW1pdExvYWQyKGJh c2UsIHJlZ1QxLCByZWdUMCwgdmFsdWUsIHJlZ1QzLCByZWdUMik7CiAgICAgCiAgICAgZW1pdEp1 bXBTbG93Q2FzZUlmTm90SlNDZWxsKGJhc2UsIHJlZ1QxKTsKLSAgICAKLSAgICBlbWl0TG9hZChi YXNlLCByZWdUMSwgcmVnVDApOwotICAgIGVtaXRMb2FkKHZhbHVlLCByZWdUMywgcmVnVDIpOwog CiAgICAgSklUUHV0QnlJZEdlbmVyYXRvciBnZW4oCiAgICAgICAgIG1fY29kZUJsb2NrLCBDb2Rl T3JpZ2luKG1fYnl0ZWNvZGVPZmZzZXQpLCBSZWdpc3RlclNldDo6c3BlY2lhbFJlZ2lzdGVycygp LApAQCAtNTU5LDcgKzU1NiwxMCBAQCB2b2lkIEpJVDo6ZW1pdFNsb3dfb3BfcHV0X2J5X2lkKElu c3RydWN0aW9uKiBjdXJyZW50SW5zdHJ1Y3Rpb24sIFZlY3RvcjxTbG93Q2FzZQogICAgIGxpbmtT bG93Q2FzZShpdGVyKTsKICAgICAKICAgICBMYWJlbCBjb2xkUGF0aEJlZ2luKHRoaXMpOwotICAg IAorCisgICAgLy8gSklUUHV0QnlJZEdlbmVyYXRvciBvbmx5IHByZXNlcnZlIHRoZSB2YWx1ZSBh bmQgdGhlIGJhc2UncyBwYXlsb2FkLCB3ZSBoYXZlIHRvIHJlbG9hZCB0aGUgdGFnLgorICAgIGVt aXRMb2FkVGFnKGJhc2UsIHJlZ1QxKTsKKwogICAgIEpJVFB1dEJ5SWRHZW5lcmF0b3ImIGdlbiA9 IG1fcHV0QnlJZHNbbV9wdXRCeUlkSW5kZXgrK107CiAgICAgCiAgICAgQ2FsbCBjYWxsID0gY2Fs bE9wZXJhdGlvbigKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9zdHJl c3MvcHV0LWJ5LWlkLW9uLW5ldy1vYmplY3QtYWZ0ZXItcHJvdG90eXBlLXRyYW5zaXRpb24tbm9u LXN0cmljdC5qcyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9zdHJlc3MvcHV0LWJ5LWlk LW9uLW5ldy1vYmplY3QtYWZ0ZXItcHJvdG90eXBlLXRyYW5zaXRpb24tbm9uLXN0cmljdC5qcwpu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwLi4xNWNjOWY5OWM5OTY0NWZhYjdhZTkyZWJlYmVlOGVhYmJmNTI0NWYzCi0tLSAv ZGV2L251bGwKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9wdXQtYnkt aWQtb24tbmV3LW9iamVjdC1hZnRlci1wcm90b3R5cGUtdHJhbnNpdGlvbi1ub24tc3RyaWN0Lmpz CkBAIC0wLDAgKzEsMzEgQEAKK2Z1bmN0aW9uIG9wYXF1ZU5ld09iamVjdChwcm90b3R5cGUpCit7 CisgICAgcmV0dXJuIE9iamVjdC5jcmVhdGUocHJvdG90eXBlKTsKK30KK25vSW5saW5lKG9wYXF1 ZU5ld09iamVjdCk7CisKK2Z1bmN0aW9uIHB1dFZhbHVlT25OZXdPYmplY3QodmFsdWUsIHByb3Rv dHlwZSkKK3sKKyAgICB2YXIgb2JqZWN0ID0gb3BhcXVlTmV3T2JqZWN0KHByb3RvdHlwZSk7Cisg ICAgb2JqZWN0Lm15UHJvcGVydHkgPSB2YWx1ZTsKKyAgICByZXR1cm4gb2JqZWN0OworfQorbm9J bmxpbmUocHV0VmFsdWVPbk5ld09iamVjdCkKKworZm9yICh2YXIgaSA9IDA7IGkgPCAxZTQ7ICsr aSkgeworICAgIHZhciBpbml0aWFsUHJvdG90eXBlID0gbmV3IE9iamVjdDsKKyAgICBmb3IgKHZh ciBqID0gMDsgaiA8IDU7ICsraikgeworICAgICAgICB2YXIgb2JqZWN0ID0gcHV0VmFsdWVPbk5l d09iamVjdChqLCBpbml0aWFsUHJvdG90eXBlKTsKKyAgICAgICAgaWYgKG9iamVjdFsibXlQcm9w ZXJ0eSJdICE9PSBqKSB7CisgICAgICAgICAgICB0aHJvdyAiT29vcHMsIHdlIG1lc3MgdXAgYmVm b3JlIHRoZSBwcm90b3R5cGUgY2hhbmdlIGF0IGl0ZXJhdGlvbiBpID0gIiArIGkgKyAiIGogPSAi ICsgajsKKyAgICAgICAgfQorICAgIH0KKworICAgIGluaXRpYWxQcm90b3R5cGUuZm9vID0gImJh ciI7CisgICAgZm9yICh2YXIgaiA9IDA7IGogPCA1OyArK2opIHsKKyAgICAgICAgdmFyIG9iamVj dCA9IHB1dFZhbHVlT25OZXdPYmplY3QoaiwgaW5pdGlhbFByb3RvdHlwZSk7CisgICAgICAgIGlm IChvYmplY3RbIm15UHJvcGVydHkiXSAhPT0gaikgeworICAgICAgICAgICAgdGhyb3cgIk9vb3Bz LCB3ZSBtZXNzIHVwIGF0IGl0ZXJhdGlvbiBpID0gIiArIGkgKyAiIGogPSAiICsgajsKKyAgICAg ICAgfQorICAgIH0KK30KXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCmRpZmYgLS1naXQgYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL3B1dC1ieS1pZC1vbi1uZXctb2JqZWN0 LWFmdGVyLXByb3RvdHlwZS10cmFuc2l0aW9uLXN0cmljdC5qcyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS90ZXN0cy9zdHJlc3MvcHV0LWJ5LWlkLW9uLW5ldy1vYmplY3QtYWZ0ZXItcHJvdG90eXBl LXRyYW5zaXRpb24tc3RyaWN0LmpzCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjQ1NDIyNDQzY2NhODEyMmQ0NzM0ODMz ODZhNjcyYWZjZTYzYTRhNzQKLS0tIC9kZXYvbnVsbAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvdGVzdHMvc3RyZXNzL3B1dC1ieS1pZC1vbi1uZXctb2JqZWN0LWFmdGVyLXByb3RvdHlwZS10 cmFuc2l0aW9uLXN0cmljdC5qcwpAQCAtMCwwICsxLDMzIEBACisidXNlIHN0cmljdCIKKworZnVu Y3Rpb24gb3BhcXVlTmV3T2JqZWN0KHByb3RvdHlwZSkKK3sKKyAgICByZXR1cm4gT2JqZWN0LmNy ZWF0ZShwcm90b3R5cGUpOworfQorbm9JbmxpbmUob3BhcXVlTmV3T2JqZWN0KTsKKworZnVuY3Rp b24gcHV0VmFsdWVPbk5ld09iamVjdCh2YWx1ZSwgcHJvdG90eXBlKQoreworICAgIHZhciBvYmpl Y3QgPSBvcGFxdWVOZXdPYmplY3QocHJvdG90eXBlKTsKKyAgICBvYmplY3QubXlQcm9wZXJ0eSA9 IHZhbHVlOworICAgIHJldHVybiBvYmplY3Q7Cit9Citub0lubGluZShwdXRWYWx1ZU9uTmV3T2Jq ZWN0KQorCitmb3IgKHZhciBpID0gMDsgaSA8IDFlNDsgKytpKSB7CisgICAgdmFyIGluaXRpYWxQ cm90b3R5cGUgPSBuZXcgT2JqZWN0OworICAgIGZvciAodmFyIGogPSAwOyBqIDwgNTsgKytqKSB7 CisgICAgICAgIHZhciBvYmplY3QgPSBwdXRWYWx1ZU9uTmV3T2JqZWN0KGosIGluaXRpYWxQcm90 b3R5cGUpOworICAgICAgICBpZiAob2JqZWN0WyJteVByb3BlcnR5Il0gIT09IGopIHsKKyAgICAg ICAgICAgIHRocm93ICJPb29wcywgd2UgbWVzcyB1cCBiZWZvcmUgdGhlIHByb3RvdHlwZSBjaGFu Z2UgYXQgaXRlcmF0aW9uIGkgPSAiICsgaSArICIgaiA9ICIgKyBqOworICAgICAgICB9CisgICAg fQorCisgICAgaW5pdGlhbFByb3RvdHlwZS5mb28gPSAiYmFyIjsKKyAgICBmb3IgKHZhciBqID0g MDsgaiA8IDU7ICsraikgeworICAgICAgICB2YXIgb2JqZWN0ID0gcHV0VmFsdWVPbk5ld09iamVj dChqLCBpbml0aWFsUHJvdG90eXBlKTsKKyAgICAgICAgaWYgKG9iamVjdFsibXlQcm9wZXJ0eSJd ICE9PSBqKSB7CisgICAgICAgICAgICB0aHJvdyAiT29vcHMsIHdlIG1lc3MgdXAgYXQgaXRlcmF0 aW9uIGkgPSAiICsgaSArICIgaiA9ICIgKyBqOworICAgICAgICB9CisgICAgfQorfQpcIE5vIG5l d2xpbmUgYXQgZW5kIG9mIGZpbGUK