<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>138037</bug_id>
          
          <creation_ts>2014-10-23 21:11:45 -0700</creation_ts>
          <short_desc>Make ScriptWrappable&apos;s destructor protected instead of public</short_desc>
          <delta_ts>2014-10-24 11:13:36 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>DOM</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Chris Dumez">cdumez</reporter>
          <assigned_to name="Chris Dumez">cdumez</assigned_to>
          <cc>ap</cc>
    
    <cc>benjamin</cc>
    
    <cc>commit-queue</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1043930</commentid>
    <comment_count>0</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2014-10-23 21:11:45 -0700</bug_when>
    <thetext>Make ScriptWrappable&apos;s destructor protected instead of public as it is not virtual and this class is subclassed a lot.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1043934</commentid>
    <comment_count>1</comment_count>
      <attachid>240389</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2014-10-23 21:27:51 -0700</bug_when>
    <thetext>Created attachment 240389
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1043991</commentid>
    <comment_count>2</comment_count>
      <attachid>240389</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-10-24 11:13:32 -0700</bug_when>
    <thetext>Comment on attachment 240389
Patch

Clearing flags on attachment: 240389

Committed r175168: &lt;http://trac.webkit.org/changeset/175168&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1043992</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-10-24 11:13:36 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>240389</attachid>
            <date>2014-10-23 21:27:51 -0700</date>
            <delta_ts>2014-10-24 11:13:32 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-138037-20141023212759.patch</filename>
            <type>text/plain</type>
            <size>1433</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1MTU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGQ5NjQ5MTBhODE2YWVk
N2FiNDAyODMzNjk2NTgzYzcxM2M1NjI4MC4uNDM5OTBkMTA4NmY1YTdjNWUwNmRlODAxMjVmNTI3
YTBjMDI3MGM5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE0LTEwLTIzICBDaHJp
cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgTWFrZSBTY3JpcHRXcmFwcGFi
bGUncyBkZXN0cnVjdG9yIHByb3RlY3RlZCBpbnN0ZWFkIG9mIHB1YmxpYworICAgICAgICBodHRw
czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4MDM3CisKKyAgICAgICAgUmV2
aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSBTY3JpcHRXcmFwcGFibGUn
cyBkZXN0cnVjdG9yIHByb3RlY3RlZCBpbnN0ZWFkIG9mIHB1YmxpYyBhcyBpdCBpcworICAgICAg
ICBub3QgdmlydHVhbCBhbmQgdGhpcyBjbGFzcyBpcyBzdWJjbGFzc2VkIGEgbG90LgorCisgICAg
ICAgIE5vIG5ldyB0ZXN0cywgbm8gYmVoYXZpb3IgY2hhbmdlLgorCisgICAgICAgICogYmluZGlu
Z3MvanMvU2NyaXB0V3JhcHBhYmxlLmg6CisgICAgICAgIChXZWJDb3JlOjpTY3JpcHRXcmFwcGFi
bGU6On5TY3JpcHRXcmFwcGFibGUpOgorCiAyMDE0LTEwLTIzICBaYWxhbiBCdWp0YXMgIDx6YWxh
bkBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViQ29udGVudCBjcmFzaCBhdCBXZWJDb3JlOjpSZW5k
ZXJUZXh0Q29udHJvbDo6dGV4dEZvcm1Db250cm9sRWxlbWVudCBjb25zdC4KZGlmZiAtLWdpdCBh
L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1NjcmlwdFdyYXBwYWJsZS5oIGIvU291cmNlL1dl
YkNvcmUvYmluZGluZ3MvanMvU2NyaXB0V3JhcHBhYmxlLmgKaW5kZXggNWI2YzY1ZTMwYjUzN2Y5
NWM1NGI2Njg2YzQ0ODVjYzcyMDcwNmIwZi4uYmZjNjg3MmRhZjNlNmU5NmYwZTZlMDhkN2NiNzU0
MTllYzI2YjE3MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0
V3JhcHBhYmxlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0V3JhcHBh
YmxlLmgKQEAgLTQ4LDYgKzQ4LDkgQEAgcHVibGljOgogICAgIHZvaWQgc2V0V3JhcHBlcihKU0RP
TVdyYXBwZXIqLCBKU0M6OldlYWtIYW5kbGVPd25lciosIHZvaWQqKTsKICAgICB2b2lkIGNsZWFy
V3JhcHBlcihKU0RPTVdyYXBwZXIqKTsKIAorcHJvdGVjdGVkOgorICAgIH5TY3JpcHRXcmFwcGFi
bGUoKSB7IH0KKwogcHJpdmF0ZToKICAgICBKU0M6OldlYWs8SlNET01XcmFwcGVyPiBtX3dyYXBw
ZXI7CiB9Owo=
</data>

          </attachment>
      

    </bug>

</bugzilla>