138031 2014-10-23 17:06:25 -0700 [iOS WK2] If a page has the exact same VisibleContentRect as the page before, its VisibleContentRectUpdate can be ignored 2014-10-23 17:44:03 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin simon.fraser oldest_to_newest 1043887 0 benjamin 2014-10-23 17:06:25 -0700 [iOS WK2] If a page has the exact same VisibleContentRect as the page before, its VisibleContentRectUpdate can be ignored 1043888 1 240379 benjamin 2014-10-23 17:19:34 -0700 Created attachment 240379 Patch 1043890 2 240379 simon.fraser 2014-10-23 17:31:53 -0700 Comment on attachment 240379 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240379&action=review Mumble testing mumble. > Source/WebKit2/UIProcess/WebPageProxy.cpp:2624 > + m_firstLayerTreeTransactionIdAfterDidCommitLoadForMainFrame = downcast<RemoteLayerTreeDrawingAreaProxy>(*drawingArea()).nextLayerTreeTransactionID(); It makes me slightly uneasy just fetching nextLayerTreeTransactionID(). How about changing it to m_layerTreeTransactionIdAtDidCommitLoad and just using the ID of the last received transaction? Then lower down you would have: layerTreeTransaction.transactionID() > m_layerTreeTransactionIdAtDidCommitLoad > Source/WebKit2/UIProcess/WebPageProxy.h:1361 > + bool m_hasReceivedLayerTreeTransactionAfterDidCommitLoadForMainFrame; > + uint64_t m_firstLayerTreeTransactionIdAfterDidCommitLoadForMainFrame; These names are really long. I think you could drop the "ForMainFrame". 1043897 3 benjamin 2014-10-23 17:44:03 -0700 Committed r175153: <http://trac.webkit.org/changeset/175153> 240379 2014-10-23 17:19:34 -0700 2014-10-23 17:31:53 -0700 Patch bug-138031-20141023171941.patch text/plain 6486 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1MTQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNzJmZTgzYWQxMmQ1YzFl ZTZjMjQ1YjQ3ZmZiN2MzYzBjNjFmM2ViNy4uMWUyYzdkN2QzNzE4YTZhNjVlNjdkNDgxNjQwZmU2 NmRiZmFkNDQxMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDQ3IEBACiAyMDE0LTEwLTIzICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgogCisgICAgICAgIFtpT1MgV0syXSBJ ZiBhIHBhZ2UgaGFzIHRoZSBleGFjdCBzYW1lIFZpc2libGVDb250ZW50UmVjdCBhcyB0aGUgcGFn ZSBiZWZvcmUsIGl0cyBWaXNpYmxlQ29udGVudFJlY3RVcGRhdGUgY2FuIGJlIGlnbm9yZWQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzODAzMQorICAg ICAgICByZGFyOi8vcHJvYmxlbS8xODczOTMzNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFNpbmNlIGFueSBWaXNpYmxlQ29udGVudFJlY3RVcGRhdGUg aXMgY29zdGx5IGZvciB0aGUgV2ViUHJvY2Vzcywgd2UgYXZvaWQgc2VuZGluZyB1cGRhdGVzCisg ICAgICAgIGlmIG5vbmUgb2YgdGhlIGltcG9ydGFudCBwYXJhbWV0ZXJzIGhhdmUgY2hhbmdlZCAo c2NhbGUgYW5kIGdlb21ldHJ5KS4KKworICAgICAgICBPbmUgdW5pbnRlbmRlZCBzaWRlIGVmZmVj dCBpcyB0aGF0IHRoZSB1cGRhdGUgb2YgYSBwYWdlIGNhbiBiZSBibG9ja2VkIGlmIHRoZSBwYXJh bWV0ZXJzCisgICAgICAgIG9mIHRoZSBwcmV2aW91cyBwYWdlIHdlcmUgaWRlbnRpY2FsLgorCisg ICAgICAgIFdoYXQgaGFwcGVuIGlzIHRoaXM6CisgICAgICAgIDEpIFBhZ2UgW0FdIHNlbmRzIGl0 cyBjb250ZW50IHJlY3QgdXBkYXRlIGFzIG5lZWRlZC4gV2ViUGFnZVByb3h5IHNhdmVzIHRoZSBs YXN0IHVwZGF0ZQorICAgICAgICAgICBpbiBtX2xhc3RWaXNpYmxlQ29udGVudFJlY3RVcGRhdGUg YW5kIHVzZSB0aGF0IHZhbHVlIHRvIGF2b2lkIHVzZWxlc3MgdXBkYXRlcy4KKyAgICAgICAgMikg UGFnZSBbQl0gbG9hZCBhZnRlciBwYWdlIFtBXSBhbmQgaGF2ZSB0aGUgZXhhY3QgVmlzaWJsZUNv bnRlbnRSZWN0LiBXaGVuIHJlY2VpdmluZyB0aGUgZmlyc3QKKyAgICAgICAgICAgbGF5ZXIgdHJl ZSBjb21taXQgYWZ0ZXIgZGlkQ29tbWl0TG9hZEZvckZyYW1lLCBXS1dlYlZpZXcgc2VuZHMgaXRz IFZpc2libGVDb250ZW50UmVjdAorICAgICAgICAgICB0byBXZWJQYWdlUHJveHkgdG8gc3luY2hy b25pemUgdGhlIHN0YXRlIG9mIHRoZSBXZWJQcm9jZXNzIHdpdGggd2hhdCBpcyBvbiBzY3JlZW4u CisgICAgICAgIDMpIFNpbmNlIHRoZSB0d28gVmlzaWJsZUNvbnRlbnRSZWN0IHVwZGF0ZSBoYXMg dGhlIHNhbWUgdmFsdWUgYXMgdGhlIG9uZXMgb2YgcGFnZSBbQV0sIFdlYlBhZ2VQcm94eQorICAg ICAgICAgICBkaXNjYXJkcyB0aGUgdXBkYXRlLiBUaGUgV2ViUHJvY2VzcyBoYXMgaXRzIGluaXRp YWxpemF0aW9uIHZpZXdwb3J0IGFuZCBpcyBub3QgdWRwYXRlZCB1bnRpbAorICAgICAgICAgICBh IG1ham9yIHBhcmFtZXRlciBjaGFuZ2VzIChzY2FsZSBvciBwb3NpdGlvbikuCisKKyAgICAgICAg SW4gcmRhcjovL3Byb2JsZW0vMTg3MzkzMzUsIHRoZSBwcm9ibGVtIGlzIHRoZSBzaW1pbGFyIGJ1 dCB3aXRoIGEgZGlmZmVyZW50IGZhaWx1cmUgcG9pbnQ6CisgICAgICAgIDEpIEV2ZXJ5dGhpbmcg YWJvdmUgaGFwcGVuZWQgYWxyZWFkeS4KKyAgICAgICAgMikgVGhlIGxheWVyIHRyZWUgdHJhbnNh Y3Rpb24gaGFzIGEgc2Nyb2xsaW5nIHJlcXVlc3QuIFRoaXMgaXMgcHJvY2Vzc2VkIGJ5IFdLV2Vi Vmlldy4KKyAgICAgICAgMykgU2luY2UgdGhlIHNjcm9sbGluZyBwb3NpdGlvbiBpcyBpbnZhbGlk LCB0aGUgcmVxdWVzdCBpcyBpZ25vcmVkIGFuZCB3ZSBzZW5kIHRoZSBsYXN0CisgICAgICAgICAg IFZpc2libGVDb250ZW50UmVjdCB0byB0aGUgV2ViUHJvY2VzcyB3aXRoIFdlYlBhZ2VQcm94eTo6 cmVzZW5kTGFzdFZpc2libGVDb250ZW50UmVjdHMoKS4KKyAgICAgICAgNCkgU2luY2UgdGhlIFZp c2libGVDb250ZW50UmVjdCB3YXMgbmV2ZXIgdXBkYXRlZCBhZnRlciBkaWRDb21taXRMb2FkRm9y RnJhbWUsIHRoZSBvbmUgd2Ugc2VuZAorICAgICAgICAgICBpcyBmb3IgdGhlIHByZXZpb3VzIHBh Z2UsIHdoaWNoIHRoZSB3ZWIgcHJvY2VzcyBjb3JyZWN0bHkgaWdub3Jlcy4KKworICAgICAgICBU aGlzIHBhdGNoIHNvbHZlcyB0aGUgcHJvYmxlbSBieSBudWtpbmcgdGhlIGNhY2hlZCBtX2xhc3RW aXNpYmxlQ29udGVudFJlY3RVcGRhdGUgYmVmb3JlCisgICAgICAgIGFueSB2YWxpZCBWaXNpYmxl Q29udGVudFJlY3RVcGRhdGUgZm9yIGEgbmV3IHBhZ2UuCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv V2ViUGFnZVByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5OjpXZWJQYWdl UHJveHkpOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OmRpZENvbW1pdExvYWRGb3JG cmFtZSk6CisgICAgICAgICogVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oOgorICAgICAgICAqIFVJ UHJvY2Vzcy9pb3MvV2ViUGFnZVByb3h5SU9TLm1tOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdl UHJveHk6OmRpZENvbW1pdExheWVyVHJlZSk6CisKKzIwMTQtMTAtMjMgIEJlbmphbWluIFBvdWxh aW4gIDxicG91bGFpbkBhcHBsZS5jb20+CisKICAgICAgICAgW2lPUyBXSzJdIE1ha2Ugc3VyZSBh bnkgZHluYW1pYyB2aWV3cG9ydCB1cGRhdGUgc2NoZWR1bGVzIGEgbGF5ZXIgdHJlZSBjb21taXQK ICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzODAyMQog CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcCBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCmluZGV4IGEzYzY0NGYz M2NiMWJiNzc5ODAyZDJlOTRlZGYwN2FjOTJlMWFmZDUuLjJhNzBhOTJlMmMyNzRiY2JhNDM5OTEz MWM4ZmYyNmNhN2UzNzZjYmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9X ZWJQYWdlUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJv eHkuY3BwCkBAIC0xMzEsNiArMTMxLDcgQEAKICNlbmRpZgogCiAjaWYgUExBVEZPUk0oSU9TKQor I2luY2x1ZGUgIlJlbW90ZUxheWVyVHJlZURyYXdpbmdBcmVhUHJveHkuaCIKICNpbmNsdWRlICJX ZWJWaWRlb0Z1bGxzY3JlZW5NYW5hZ2VyUHJveHkuaCIKICNpbmNsdWRlICJXZWJWaWRlb0Z1bGxz Y3JlZW5NYW5hZ2VyUHJveHlNZXNzYWdlcy5oIgogI2VuZGlmCkBAIC0yNjksNiArMjcwLDggQEAg V2ViUGFnZVByb3h5OjpXZWJQYWdlUHJveHkoUGFnZUNsaWVudCYgcGFnZUNsaWVudCwgV2ViUHJv Y2Vzc1Byb3h5JiBwcm9jZXNzLCB1aW4KICAgICAsIG1fbWFpbkZyYW1lKG51bGxwdHIpCiAgICAg LCBtX3VzZXJBZ2VudChzdGFuZGFyZFVzZXJBZ2VudCgpKQogI2lmIFBMQVRGT1JNKElPUykKKyAg ICAsIG1faGFzUmVjZWl2ZWRMYXllclRyZWVUcmFuc2FjdGlvbkFmdGVyRGlkQ29tbWl0TG9hZEZv ck1haW5GcmFtZSh0cnVlKQorICAgICwgbV9maXJzdExheWVyVHJlZVRyYW5zYWN0aW9uSWRBZnRl ckRpZENvbW1pdExvYWRGb3JNYWluRnJhbWUoMCkKICAgICAsIG1fZGV2aWNlT3JpZW50YXRpb24o MCkKICAgICAsIG1fZHluYW1pY1ZpZXdwb3J0U2l6ZVVwZGF0ZVdhaXRpbmdGb3JUYXJnZXQoZmFs c2UpCiAgICAgLCBtX2R5bmFtaWNWaWV3cG9ydFNpemVVcGRhdGVXYWl0aW5nRm9yTGF5ZXJUcmVl Q29tbWl0KGZhbHNlKQpAQCAtMjYxNSw2ICsyNjE4LDEzIEBAIHZvaWQgV2ViUGFnZVByb3h5Ojpk aWRDb21taXRMb2FkRm9yRnJhbWUodWludDY0X3QgZnJhbWVJRCwgdWludDY0X3QgbmF2aWdhdGlv bklECiAgICAgV2ViRnJhbWVQcm94eSogZnJhbWUgPSBtX3Byb2Nlc3MtPndlYkZyYW1lKGZyYW1l SUQpOwogICAgIE1FU1NBR0VfQ0hFQ0soZnJhbWUpOwogCisjaWYgUExBVEZPUk0oSU9TKQorICAg IGlmIChmcmFtZS0+aXNNYWluRnJhbWUoKSkgeworICAgICAgICBtX2hhc1JlY2VpdmVkTGF5ZXJU cmVlVHJhbnNhY3Rpb25BZnRlckRpZENvbW1pdExvYWRGb3JNYWluRnJhbWUgPSBmYWxzZTsKKyAg ICAgICAgbV9maXJzdExheWVyVHJlZVRyYW5zYWN0aW9uSWRBZnRlckRpZENvbW1pdExvYWRGb3JN YWluRnJhbWUgPSBkb3duY2FzdDxSZW1vdGVMYXllclRyZWVEcmF3aW5nQXJlYVByb3h5PigqZHJh d2luZ0FyZWEoKSkubmV4dExheWVyVHJlZVRyYW5zYWN0aW9uSUQoKTsKKyAgICB9CisjZW5kaWYK KwogICAgIGF1dG8gdHJhbnNhY3Rpb24gPSBtX3BhZ2VMb2FkU3RhdGUudHJhbnNhY3Rpb24oKTsK IAogICAgIGlmIChmcmFtZS0+aXNNYWluRnJhbWUoKSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9X ZWJQYWdlUHJveHkuaAppbmRleCA4MDkwYjI3Zjc3ZDcyOTA3ZDBjMjJmZGFhN2EyNmNkNDcyMjg1 YmJkLi5kMzZhNzY3Mjk5MjJkNzFmODk5MzU0ZjczNGUyZGI5MWQ0ZjE4NGU2IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmgKKysrIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oCkBAIC0xMzU3LDYgKzEzNTcsOCBAQCBwcml2 YXRlOgogI2lmIFBMQVRGT1JNKElPUykKICAgICBSZWZQdHI8V2ViVmlkZW9GdWxsc2NyZWVuTWFu YWdlclByb3h5PiBtX3ZpZGVvRnVsbHNjcmVlbk1hbmFnZXI7CiAgICAgVmlzaWJsZUNvbnRlbnRS ZWN0VXBkYXRlSW5mbyBtX2xhc3RWaXNpYmxlQ29udGVudFJlY3RVcGRhdGU7CisgICAgYm9vbCBt X2hhc1JlY2VpdmVkTGF5ZXJUcmVlVHJhbnNhY3Rpb25BZnRlckRpZENvbW1pdExvYWRGb3JNYWlu RnJhbWU7CisgICAgdWludDY0X3QgbV9maXJzdExheWVyVHJlZVRyYW5zYWN0aW9uSWRBZnRlckRp ZENvbW1pdExvYWRGb3JNYWluRnJhbWU7CiAgICAgaW50MzJfdCBtX2RldmljZU9yaWVudGF0aW9u OwogICAgIGJvb2wgbV9keW5hbWljVmlld3BvcnRTaXplVXBkYXRlV2FpdGluZ0ZvclRhcmdldDsK ICAgICBib29sIG1fZHluYW1pY1ZpZXdwb3J0U2l6ZVVwZGF0ZVdhaXRpbmdGb3JMYXllclRyZWVD b21taXQ7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dlYlBhZ2VQ cm94eUlPUy5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV2ViUGFnZVByb3h5SU9T Lm1tCmluZGV4IDBhYzg2YTE5ZTY5MzEzYWY0NDc0MDM5YThlMDFmYTIzNTk5MWNiNmQuLjE4MDM5 OTFkOGFhMjA1NmE0YmMxNDUyYjdkNDEyMTEyNDQ2MmFkNGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV2ViUGFnZVByb3h5SU9TLm1tCisrKyBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9pb3MvV2ViUGFnZVByb3h5SU9TLm1tCkBAIC0zMzYsNiArMzM2LDEzIEBA IHZvaWQgV2ViUGFnZVByb3h5OjpkaWRDb21taXRMYXllclRyZWUoY29uc3QgV2ViS2l0OjpSZW1v dGVMYXllclRyZWVUcmFuc2FjdGlvbiYKIHsKICAgICBtX3BhZ2VFeHRlbmRlZEJhY2tncm91bmRD b2xvciA9IGxheWVyVHJlZVRyYW5zYWN0aW9uLnBhZ2VFeHRlbmRlZEJhY2tncm91bmRDb2xvcigp OwogCisgICAgaWYgKCFtX2hhc1JlY2VpdmVkTGF5ZXJUcmVlVHJhbnNhY3Rpb25BZnRlckRpZENv bW1pdExvYWRGb3JNYWluRnJhbWUpIHsKKyAgICAgICAgaWYgKGxheWVyVHJlZVRyYW5zYWN0aW9u LnRyYW5zYWN0aW9uSUQoKSA+PSBtX2ZpcnN0TGF5ZXJUcmVlVHJhbnNhY3Rpb25JZEFmdGVyRGlk Q29tbWl0TG9hZEZvck1haW5GcmFtZSkgeworICAgICAgICAgICAgbV9oYXNSZWNlaXZlZExheWVy VHJlZVRyYW5zYWN0aW9uQWZ0ZXJEaWRDb21taXRMb2FkRm9yTWFpbkZyYW1lID0gdHJ1ZTsKKyAg ICAgICAgICAgIG1fbGFzdFZpc2libGVDb250ZW50UmVjdFVwZGF0ZSA9IFZpc2libGVDb250ZW50 UmVjdFVwZGF0ZUluZm8oKTsKKyAgICAgICAgfQorICAgIH0KKwogICAgIGlmICghbV9keW5hbWlj Vmlld3BvcnRTaXplVXBkYXRlV2FpdGluZ0ZvclRhcmdldCAmJiBtX2R5bmFtaWNWaWV3cG9ydFNp emVVcGRhdGVXYWl0aW5nRm9yTGF5ZXJUcmVlQ29tbWl0KSB7CiAgICAgICAgIGlmIChsYXllclRy ZWVUcmFuc2FjdGlvbi50cmFuc2FjdGlvbklEKCkgPj0gbV9keW5hbWljVmlld3BvcnRTaXplVXBk YXRlTGF5ZXJUcmVlVHJhbnNhY3Rpb25JRCkKICAgICAgICAgICAgIG1fZHluYW1pY1ZpZXdwb3J0 U2l6ZVVwZGF0ZVdhaXRpbmdGb3JMYXllclRyZWVDb21taXQgPSBmYWxzZTsK