138030 2014-10-23 16:32:47 -0700 [Mac] Optimize URL::createCFURL() for the common case 2014-10-23 18:29:54 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Mac Unspecified RESOLVED FIXED P2 Enhancement --- 1 cdumez cdumez ap barraclough benjamin commit-queue oldest_to_newest 1043874 0 cdumez 2014-10-23 16:32:47 -0700 Optimize URL::createCFURL() for the common case by adding a fast path for when the URL String is already 8-bit (common case). When the string is 8-bit, we don't need to copy the bytes in a temporary buffer and we can construct the CFURLRef directly from it. This makes URL::createCFURL() ~34% faster on my machine. 1043878 1 240376 cdumez 2014-10-23 16:39:48 -0700 Created attachment 240376 Patch 1043905 2 240376 commit-queue 2014-10-23 18:29:49 -0700 Comment on attachment 240376 Patch Clearing flags on attachment: 240376 Committed r175154: <http://trac.webkit.org/changeset/175154> 1043906 3 commit-queue 2014-10-23 18:29:54 -0700 All reviewed patches have been landed. Closing bug. 240376 2014-10-23 16:39:48 -0700 2014-10-23 18:29:49 -0700 Patch bug-138030-20141023163955.patch text/plain 1904 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1MTQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmNjNzVlNDY5OTNhYWU1 YTE3MTM2YTFkYzJlMWI3ZjQ2MTY3YjFlMi4uNzdkYjNjNzUwYmY1ZDBhNDcxNGZhZjExNTk0NTE4 YmI3ZDdlNzE1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE0LTEwLTIzICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW01hY10gT3B0aW1pemUgVVJM OjpjcmVhdGVDRlVSTCgpIGZvciB0aGUgY29tbW9uIGNhc2UKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzODAzMAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE9wdGltaXplIFVSTDo6Y3JlYXRlQ0ZVUkwoKSBm b3IgdGhlIGNvbW1vbiBjYXNlIGJ5IGFkZGluZyBhIGZhc3QgcGF0aAorICAgICAgICBmb3Igd2hl biB0aGUgVVJMIFN0cmluZyBpcyBhbHJlYWR5IDgtYml0IChjb21tb24gY2FzZSkuCisgICAgICAg IFdoZW4gdGhlIHN0cmluZyBpcyA4LWJpdCwgd2UgZG9uJ3QgbmVlZCB0byBjb3B5IHRoZSBieXRl cyBpbnRvIGEKKyAgICAgICAgdGVtcG9yYXJ5IGJ1ZmZlciBhbmQgd2UgY2FuIGNvbnN0cnVjdCB0 aGUgQ0ZVUkxSZWYgZGlyZWN0bHkgZnJvbSBpdC4KKworICAgICAgICBUaGlzIG1ha2VzIFVSTDo6 Y3JlYXRlQ0ZVUkwoKSB+MzQlIGZhc3RlciBvbiBteSBtYWNoaW5lLgorCisgICAgICAgIE5vIG5l dyB0ZXN0cywgbm8gYmVoYXZpb3IgY2hhbmdlLgorCisgICAgICAgICogcGxhdGZvcm0vbWFjL1VS TE1hYy5tbToKKyAgICAgICAgKFdlYkNvcmU6OlVSTDo6Y3JlYXRlQ0ZVUkwpOgorCiAyMDE0LTEw LTIzICBFcmljIENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFtN YWNdIGRvbid0IHVwZGF0ZSBjYXB0aW9uIHVzZXIgc3R5bGUgc2hlZXQgZHVyaW5nIHBhcnNpbmcK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9VUkxNYWMubW0gYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvVVJMTWFjLm1tCmluZGV4IDA2YTZhMDgzNWY0NjA2Nzhh YzNlOWYzZGIzZTI2Y2Y0ODFlMjYxM2IuLmU1YTdkNjFlMzY5YjBjMWI2Nzk0N2FlZTA1ZDVjMWJi NWE0YWE1N2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9VUkxNYWMu bW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1VSTE1hYy5tbQpAQCAtNjIsNiAr NjIsMTEgQEAgUmV0YWluUHRyPENGVVJMUmVmPiBVUkw6OmNyZWF0ZUNGVVJMKCkgY29uc3QKICAg ICAgICAgcmV0dXJuIHJlaW50ZXJwcmV0X2Nhc3Q8Q0ZVUkxSZWY+KGFkb3B0TlMoW1tOU1VSTCBh bGxvY10gaW5pdFdpdGhTdHJpbmc6QCIiXSkuZ2V0KCkpOwogICAgIH0KIAorICAgIC8vIEZhc3Qg cGF0aCBpZiB0aGUgaW5wdXQgZGF0YSBpcyA4LWJpdCB0byBhdm9pZCBjb3B5aW5nIGludG8gYSB0 ZW1wb3JhcnkgYnVmZmVyLgorICAgIGlmIChMSUtFTFkobV9zdHJpbmcuaXM4Qml0KCkpKQorICAg ICAgICByZXR1cm4gY3JlYXRlQ0ZVUkxGcm9tQnVmZmVyKHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3Qg Y2hhcio+KG1fc3RyaW5nLmNoYXJhY3RlcnM4KCkpLCBtX3N0cmluZy5sZW5ndGgoKSk7CisKKyAg ICAvLyBTbG93ZXIgcGF0aC4KICAgICBVUkxDaGFyQnVmZmVyIGJ1ZmZlcjsKICAgICBjb3B5VG9C dWZmZXIoYnVmZmVyKTsKICAgICByZXR1cm4gY3JlYXRlQ0ZVUkxGcm9tQnVmZmVyKGJ1ZmZlci5k YXRhKCksIGJ1ZmZlci5zaXplKCkpOwo=