138020 2014-10-23 14:04:38 -0700 A bunch of JS dates fail after r175078 2014-10-24 13:27:50 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 1 roger_fong webkit-unassigned benjamin cmarcelo commit-queue mark.lam roger_fong sun.shin xingri oldest_to_newest 1043829 0 roger_fong 2014-10-23 14:04:38 -0700 Tests failing: ecma/Date/15.9.3.1-1.js ecma/Date/15.9.3.1-2.js ecma/Date/15.9.3.1-3.js ecma/Date/15.9.3.1-4.js ecma/Date/15.9.3.1-5.js ecma/Date/15.9.3.2-1.js ecma/Date/15.9.3.2-2.js ecma/Date/15.9.3.2-3.js ecma/Date/15.9.3.2-4.js ecma/Date/15.9.3.2-5.js ecma/Date/15.9.4.2-1.js ecma/Date/15.9.5.26-1.js ecma/Date/15.9.5.27-1.js ecma/Date/15.9.5.28-1.js ecma/Date/15.9.5.30-1.js Skipping them here: http://trac.webkit.org/changeset/175142 1043830 1 mark.lam 2014-10-23 14:10:04 -0700 See also failures here: https://build.webkit.org/results/Apple%20Win%207%20Debug%20(Tests)/r175080%20(63295)/results.html 1043831 2 mark.lam 2014-10-23 14:11:53 -0700 From https://build.webkit.org/results/Apple%20Win%207%20Debug%20(Tests)/r175080%20(63295)/results.html: js/date-parse-comments-test.html js/date-parse-test.html js/date-parse-test.html js/dom/callback-function-with-handle-event.html js/dom/date-big-setmonth.html Not sure if these are new to this patch, but should probably take a look into it. 1043832 3 mark.lam 2014-10-23 14:23:11 -0700 Investigation notes: the following Date files have Windows specific implementations: WTF/wtf/DateMath.cpp WTF/wtf/GregorianDateTime.cpp JavaScriptCore/runtime/DateConversion.cpp JavaScriptCore/runtime/DatePrototype.cpp 1043884 4 240378 sun.shin 2014-10-23 16:57:34 -0700 Created attachment 240378 Patch 1043886 5 240378 mark.lam 2014-10-23 17:01:57 -0700 Comment on attachment 240378 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240378&action=review > Source/WTF/ChangeLog:10 > + Do not change input time offset in case of Windows operating system. This describes what you did but not why you did it. Can you please explain the reasoning behind this? What’s different about Windows such that this is needed? 1043889 6 sun.shin 2014-10-23 17:27:45 -0700 With a preliminary analysis, Widows returns default time milliseconds is based on UTC milliseconds unlike other OSs. 1043895 7 mark.lam 2014-10-23 17:43:37 -0700 (In reply to comment #6) > With a preliminary analysis, Widows returns default time milliseconds is > based on UTC milliseconds unlike other OSs. That’s nice to know, but it’s still not enough to tell us that this fix is correct and conclusive. Let’s get more data on why Windows is behaving this way. Also, if the timeType passed into calculateLocalTimeOffset() says that the incoming ms is in local time, then we would expect it to be in local time. If this is not the case on Windows, then something upstream is not obeying the contract. Hence, this is the wrong place to apply this fix. 1043898 8 240378 mark.lam 2014-10-23 17:45:22 -0700 Comment on attachment 240378 Patch Per my previous comment, this is the wrong fix. If Windows is passing in a UTC time value, then the fix must be somewhere up stream. It should either pass in a timeType of UTCTime, or ms should be in local time. 1043908 9 sun.shin 2014-10-23 18:46:16 -0700 I will keep working on it and update it as soon as I will find a root cause. 1044038 10 roger_fong 2014-10-24 13:09:15 -0700 If it helps, I also found some layout tests failing as a result: js/date-parse-comments-test.html [ Failure ] js/date-parse-test.html [ Failure ] js/date-set-to-nan.html [ Failure ] js/dom/date-big-setmonth.html [ Failure ] I'll be skipping these as well. 1044049 11 roger_fong 2014-10-24 13:27:50 -0700 (In reply to comment #10) > If it helps, I also found some layout tests failing as a result: > js/date-parse-comments-test.html [ Failure ] > js/date-parse-test.html [ Failure ] > js/date-set-to-nan.html [ Failure ] > js/dom/date-big-setmonth.html [ Failure ] > > I'll be skipping these as well. Skipped in a general windows gardening patch here: http://trac.webkit.org/changeset/175176 240378 2014-10-23 16:57:34 -0700 2014-10-23 17:45:22 -0700 Patch bug-138020-20141023165741.patch text/plain 1448 sun.shin U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1MTUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDVmYWE0MjVjNzEwNGQxZjc0OTYyMzBh NTM0ZTFkMGM1N2EwM2U3NDQuLjkzMzM1YzM3ZmRkNzJhMTkzNDkyMjBiZDU4ODMwYTA2NmM4MWQz NDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTQtMTAtMjMgIEJ5dW5nc2VvbiBTaGluICA8c3Vu LnNoaW5AbGdlLmNvbT4KKworICAgICAgICBbV2luXSBGaXggV2luZG93IHNwZWNpZmljIEpTIERh dGUgZXJyb3IgYWZ0ZXIgcjE3NTA3OAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTM4MDIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiB3dGYvRGF0ZU1hdGguY3BwOgorICAgICAgICAoV1RGOjpjYWxjdWxh dGVMb2NhbFRpbWVPZmZzZXQpOgorICAgICAgICBEbyBub3QgY2hhbmdlIGlucHV0IHRpbWUgb2Zm c2V0IGluIGNhc2Ugb2YgV2luZG93cyBvcGVyYXRpbmcgc3lzdGVtLgorCiAyMDE0LTEwLTIzICBK b3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3Bl Y3RvcjogUHJvdmlkZSBhIHdheSB0byBoYXZlIGFsdGVybmF0ZSBpbnNwZWN0b3IgYWdlbnRzCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9EYXRlTWF0aC5jcHAgYi9Tb3VyY2UvV1RGL3d0Zi9E YXRlTWF0aC5jcHAKaW5kZXggOTFhYjk1MDhjZWQ0ZmJhZGQ2YmNmZTNmNTlhOGE2ZWRiNDA4OTNh MC4uOTU2ZGJkYjYzM2EwMWJiMjc0ZjMxNzc0ZDc0M2JkMzllZTBhZjExNSAxMDA2NDQKLS0tIGEv U291cmNlL1dURi93dGYvRGF0ZU1hdGguY3BwCisrKyBiL1NvdXJjZS9XVEYvd3RmL0RhdGVNYXRo LmNwcApAQCAtNDc4LDggKzQ3OCwxMCBAQCBMb2NhbFRpbWVPZmZzZXQgY2FsY3VsYXRlTG9jYWxU aW1lT2Zmc2V0KGRvdWJsZSBtcywgVGltZVR5cGUgaW5wdXRUaW1lVHlwZSkKICNlbHNlCiAgICAg ZG91YmxlIGxvY2FsVG9VVENUaW1lT2Zmc2V0ID0gY2FsY3VsYXRlVVRDT2Zmc2V0KCk7CiAjZW5k aWYKKyNpZiAhT1MoV0lORE9XUykKICAgICBpZiAoaW5wdXRUaW1lVHlwZSA9PSBMb2NhbFRpbWUp CiAgICAgICAgIG1zIC09IGxvY2FsVG9VVENUaW1lT2Zmc2V0OworI2VuZGlmCiAKICAgICAvLyBP biBNYWMgT1MgWCwgdGhlIGNhbGwgdG8gbG9jYWx0aW1lIChzZWUgY2FsY3VsYXRlRFNUT2Zmc2V0 KSB3aWxsIHJldHVybiBoaXN0b3JpY2FsbHkgYWNjdXJhdGUKICAgICAvLyBEU1QgaW5mb3JtYXRp b24gKGUuZy4gTmV3IFplYWxhbmQgZGlkIG5vdCBoYXZlIERTVCBmcm9tIDE5NDYgdG8gMTk3NCkg aG93ZXZlciB0aGUgSmF2YVNjcmlwdAo=