138017 2014-10-23 13:24:26 -0700 offsets.rb:183:in `buildOffsetsMap': unhandled exception - is offlineasm dependency tracking broken? 2014-10-23 13:54:17 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 msaboff msaboff oldest_to_newest 1043817 0 msaboff 2014-10-23 13:24:26 -0700 Sometimes when changing build targets or updating source repository with changes to JavaScriptCore/llint/LowLevelInterpreter{32_64,64}.asm, building with Xcode will fail. The failure manifests in two different ways: A ruby exception from the Offline Assembler build phase offsets.rb:183:in `buildOffsetsMap': unhandled exception or a linker error when linking JavaScriptCore: Undefined symbols for architecture x86_64: "_llint_entry", referenced from: __ZN3JSC5LLInt10initializeEv in LLIntData.o (maybe you meant: _llint_entry_osr_function_for_construct_arityCheck, _llint_entry_osr_function_for_construct , _llint_entry_osr , _llint_entry_osr_function_for_call , _llint_entry_osr_function_for_call_arityCheck ) "_sanitizeStackForVMImpl", referenced from: __ZN3JSC18sanitizeStackForVMEPNS_2VME in VM.o "_vmEntryRecord", referenced from: __ZN3JSC9ExecState11callerFrameERPv in CallFrame.o "_vmEntryToJavaScript", referenced from: __ZN3JSC7JITCode7executeEPNS_2VMEPNS_14ProtoCallFrameE in JITCode.o "_vmEntryToNative", referenced from: __ZN3JSC11Interpreter11executeCallEPNS_9ExecStateEPNS_8JSObjectENS_8CallTypeERKNS_8CallDataENS_7JSValueERKNS_7ArgListE in Interpreter.o __ZN3JSC11Interpreter16executeConstructEPNS_9ExecStateEPNS_8JSObjectENS_13ConstructTypeERKNS_13ConstructDataERKNS_7ArgListE in Interpreter.o ld: symbol(s) not found for architecture x86_64 clang: error: linker command failed with exit code 1 (use -v to see invocation) This is due to the LLInt Offset build phase Generate Derived Sources has $(SRCROOT)/llint/LowLevelAssembler.asm declared as an input and $(BUILT_PRODUCTS_DIR)/LLIntOffsets/LLIntDesiredOffsets.h. When Xcode builds it does dependency analysis on those two files. These two file declarations can be eliminated as the ruby script itself does dependency analysis. rdar://problem/16974705 1043821 1 240364 msaboff 2014-10-23 13:31:14 -0700 Created attachment 240364 Patch 1043822 2 240364 mark.lam 2014-10-23 13:37:21 -0700 Comment on attachment 240364 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240364&action=review r=me with typo fix. > Source/JavaScriptCore/ChangeLog:8 > + Removed from the nput file $(SRCROOT)/llint/LowLevelAssembler.asm and output file typo: nput ==> input 1043825 3 msaboff 2014-10-23 13:54:17 -0700 Committed r175141: <http://trac.webkit.org/changeset/175141> 240364 2014-10-23 13:31:14 -0700 2014-10-23 13:37:21 -0700 Patch 138017.patch text/plain 1721 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTc1MTM4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDE0LTEwLTIzICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIG9mZnNldHMucmI6MTgzOmluIGBidWlsZE9mZnNldHNNYXAnOiB1bmhhbmRsZWQgZXhjZXB0 aW9uIC0gaXMgb2ZmbGluZWFzbSBkZXBlbmRlbmN5IHRyYWNraW5nIGJyb2tlbj8gKDEzMjY2OCkK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzODAxNwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZWQg ZnJvbSB0aGUgbnB1dCBmaWxlICQoU1JDUk9PVCkvbGxpbnQvTG93TGV2ZWxBc3NlbWJsZXIuYXNt IGFuZCBvdXRwdXQgZmlsZQorICAgICAgICAkKEJVSUxUX1BST0RVQ1RTX0RJUikvTExJbnRPZmZz ZXRzL0xMSW50RGVzaXJlZE9mZnNldHMuaCBmcm9tIHRoZSBHZW5lcmF0ZSBEZXJpdmVkIFNvdXJj ZXMKKyAgICAgICAgYnVpbGQgcGhhc2UgaW4gdGhlIExMSW50IE9mZnNldCB0YXJnZXQuICBUaGVy ZSBpcyBubyBuZWVkIGZvciBYY29kZSB0byBkbyBhbnkgZGVwZW5kZW5jeQorICAgICAgICBjaGVj a2luZyB3aXRoIHRoZXNlIGZpbGVzIGFzIHRoZSBydWJ5IHNjcmlwdCBvZmZsaW5lYXNtL2dlbmVy YXRlX29mZnNldF9leHRyYWN0b3IucmIgd2lsbAorICAgICAgICBkbyB0aGF0IGZvciB1cy4KKwor ICAgICAgICAqIEphdmFTY3JpcHRDb3JlLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2o6CisKIDIw MTQtMTAtMjMgIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CiAKICAgICAgICAg Q2hhbmdlIENhbGxGcmFtZTo6bGV4aWNhbEdsb2JhbE9iamVjdCgpIHRvIHVzZSBDYWxsZWUgaW5z dGVhZCBvZiBKU1Njb3BlCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENv cmUueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvago9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNj cmlwdENvcmUvSmF2YVNjcmlwdENvcmUueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvagkocmV2aXNp b24gMTc0OTk2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnhjb2Rl cHJvai9wcm9qZWN0LnBieHByb2oJKHdvcmtpbmcgY29weSkKQEAgLTYzNjcsMTEgKzYzNjcsOSBA QAogCQkJZmlsZXMgPSAoCiAJCQkpOwogCQkJaW5wdXRQYXRocyA9ICgKLQkJCQkiJChTUkNST09U KS9sbGludC9Mb3dMZXZlbEFzc2VtYmxlci5hc20iLAogCQkJKTsKIAkJCW5hbWUgPSAiR2VuZXJh dGUgRGVyaXZlZCBTb3VyY2VzIjsKIAkJCW91dHB1dFBhdGhzID0gKAotCQkJCSIkKEJVSUxUX1BS T0RVQ1RTX0RJUikvTExJbnRPZmZzZXRzL0xMSW50RGVzaXJlZE9mZnNldHMuaCIsCiAJCQkpOwog CQkJcnVuT25seUZvckRlcGxveW1lbnRQb3N0cHJvY2Vzc2luZyA9IDA7CiAJCQlzaGVsbFBhdGgg PSAvYmluL3NoOwo=