137997 2014-10-22 18:51:53 -0700 Refactoring to simplify some code in DatePrototype.cpp 2014-10-22 19:39:15 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam commit-queue oldest_to_newest 1043635 0 mark.lam 2014-10-22 18:51:53 -0700 A bunch of functions in DatePrototype.cpp have the pattern of loading a constant into a local variable only to pass it to a callee function immediately after. There is no other use for that variable. This adds additional verbosity with no added benefit. Will fix. 1043636 1 240319 mark.lam 2014-10-22 18:56:18 -0700 Created attachment 240319 the patch. 1043639 2 240319 fpizlo 2014-10-22 19:01:16 -0700 Comment on attachment 240319 the patch. Nice! 1043644 3 240319 commit-queue 2014-10-22 19:39:13 -0700 Comment on attachment 240319 the patch. Clearing flags on attachment: 240319 Committed r175080: <http://trac.webkit.org/changeset/175080> 1043645 4 commit-queue 2014-10-22 19:39:15 -0700 All reviewed patches have been landed. Closing bug. 240319 2014-10-22 18:56:18 -0700 2014-10-22 19:39:13 -0700 the patch. bug-137997.patch text/plain 5559 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTc1MDc5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMzIEBA CisyMDE0LTEwLTIyICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBS ZWZhY3RvcmluZyB0byBzaW1wbGlmeSBzb21lIGNvZGUgaW4gRGF0ZVByb3RvdHlwZS5jcHAuCisg ICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xMzc5OTc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQSBidW5jaCBvZiBmdW5jdGlvbnMgaW4gRGF0 ZVByb3RvdHlwZS5jcHAgaGF2ZSB0aGUgcGF0dGVybiBvZiBsb2FkaW5nIGEKKyAgICAgICAgY29u c3RhbnQgaW50byBhIGxvY2FsIHZhcmlhYmxlIG9ubHkgdG8gcGFzcyBpdCB0byBhIGNhbGxlZSBm dW5jdGlvbgorICAgICAgICBpbW1lZGlhdGVseSBhZnRlci4gIFRoZXJlIGlzIG5vIG90aGVyIHVz ZSBmb3IgdGhhdCB2YXJpYWJsZS4gIFRoaXMgYWRkcworICAgICAgICBhZGRpdGlvbmFsIHZlcmJv c2l0eSB3aXRoIG5vIGFkZGVkIGJlbmVmaXQuCisKKyAgICAgICAgVGhpcyBwYXRjaCByZWZhY3Rv cnMgdGhvc2UgZnVuY3Rpb25zIHRvIGp1c3QgcGFzcyB0aGUgY29uc3RhbnQgYXJnIGRpcmVjdGx5 LgorCisgICAgICAgICogcnVudGltZS9EYXRlUHJvdG90eXBlLmNwcDoKKyAgICAgICAgKEpTQzo6 ZGF0ZVByb3RvRnVuY1NldE1pbGxpU2Vjb25kcyk6CisgICAgICAgIChKU0M6OmRhdGVQcm90b0Z1 bmNTZXRVVENNaWxsaXNlY29uZHMpOgorICAgICAgICAoSlNDOjpkYXRlUHJvdG9GdW5jU2V0U2Vj b25kcyk6CisgICAgICAgIChKU0M6OmRhdGVQcm90b0Z1bmNTZXRVVENTZWNvbmRzKToKKyAgICAg ICAgKEpTQzo6ZGF0ZVByb3RvRnVuY1NldE1pbnV0ZXMpOgorICAgICAgICAoSlNDOjpkYXRlUHJv dG9GdW5jU2V0VVRDTWludXRlcyk6CisgICAgICAgIChKU0M6OmRhdGVQcm90b0Z1bmNTZXRIb3Vy cyk6CisgICAgICAgIChKU0M6OmRhdGVQcm90b0Z1bmNTZXRVVENIb3Vycyk6CisgICAgICAgIChK U0M6OmRhdGVQcm90b0Z1bmNTZXREYXRlKToKKyAgICAgICAgKEpTQzo6ZGF0ZVByb3RvRnVuY1Nl dFVUQ0RhdGUpOgorICAgICAgICAoSlNDOjpkYXRlUHJvdG9GdW5jU2V0TW9udGgpOgorICAgICAg ICAoSlNDOjpkYXRlUHJvdG9GdW5jU2V0VVRDTW9udGgpOgorICAgICAgICAoSlNDOjpkYXRlUHJv dG9GdW5jU2V0RnVsbFllYXIpOgorICAgICAgICAoSlNDOjpkYXRlUHJvdG9GdW5jU2V0VVRDRnVs bFllYXIpOgorCiAyMDE0LTEwLTIyICBCeXVuZ3Nlb24gU2hpbiAgPHN1bi5zaGluQGxnZS5jb20+ CiAKICAgICAgICAgU3RyaW5nKG5ldyBEYXRlKE1hciAzMCAyMDE0IDAxOjAwOjAwKSkgaXMgd3Jv bmcgaW4gQ0VUCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9EYXRlUHJvdG90 eXBlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9EYXRl UHJvdG90eXBlLmNwcAkocmV2aXNpb24gMTc1MDc4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvRGF0ZVByb3RvdHlwZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTk0MCw4NiArOTQw LDcyIEBAIHN0YXRpYyBFbmNvZGVkSlNWYWx1ZSBzZXROZXdWYWx1ZUZyb21EYXQKIAogRW5jb2Rl ZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBkYXRlUHJvdG9GdW5jU2V0TWlsbGlTZWNvbmRzKEV4ZWNT dGF0ZSogZXhlYykKIHsKLSAgICBjb25zdCBXVEY6OlRpbWVUeXBlIGlucHV0VGltZVR5cGUgPSBX VEY6OkxvY2FsVGltZTsKLSAgICByZXR1cm4gc2V0TmV3VmFsdWVGcm9tVGltZUFyZ3MoZXhlYywg MSwgaW5wdXRUaW1lVHlwZSk7CisgICAgcmV0dXJuIHNldE5ld1ZhbHVlRnJvbVRpbWVBcmdzKGV4 ZWMsIDEsIFdURjo6TG9jYWxUaW1lKTsKIH0KIAogRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FM TCBkYXRlUHJvdG9GdW5jU2V0VVRDTWlsbGlzZWNvbmRzKEV4ZWNTdGF0ZSogZXhlYykKIHsKLSAg ICBjb25zdCBXVEY6OlRpbWVUeXBlIGlucHV0VGltZVR5cGUgPSBXVEY6OlVUQ1RpbWU7Ci0gICAg cmV0dXJuIHNldE5ld1ZhbHVlRnJvbVRpbWVBcmdzKGV4ZWMsIDEsIGlucHV0VGltZVR5cGUpOwor ICAgIHJldHVybiBzZXROZXdWYWx1ZUZyb21UaW1lQXJncyhleGVjLCAxLCBXVEY6OlVUQ1RpbWUp OwogfQogCiBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGRhdGVQcm90b0Z1bmNTZXRTZWNv bmRzKEV4ZWNTdGF0ZSogZXhlYykKIHsKLSAgICBjb25zdCBXVEY6OlRpbWVUeXBlIGlucHV0VGlt ZVR5cGUgPSBXVEY6OkxvY2FsVGltZTsKLSAgICByZXR1cm4gc2V0TmV3VmFsdWVGcm9tVGltZUFy Z3MoZXhlYywgMiwgaW5wdXRUaW1lVHlwZSk7CisgICAgcmV0dXJuIHNldE5ld1ZhbHVlRnJvbVRp bWVBcmdzKGV4ZWMsIDIsIFdURjo6TG9jYWxUaW1lKTsKIH0KIAogRW5jb2RlZEpTVmFsdWUgSlND X0hPU1RfQ0FMTCBkYXRlUHJvdG9GdW5jU2V0VVRDU2Vjb25kcyhFeGVjU3RhdGUqIGV4ZWMpCiB7 Ci0gICAgY29uc3QgV1RGOjpUaW1lVHlwZSBpbnB1dFRpbWVUeXBlID0gV1RGOjpVVENUaW1lOwot ICAgIHJldHVybiBzZXROZXdWYWx1ZUZyb21UaW1lQXJncyhleGVjLCAyLCBpbnB1dFRpbWVUeXBl KTsKKyAgICByZXR1cm4gc2V0TmV3VmFsdWVGcm9tVGltZUFyZ3MoZXhlYywgMiwgV1RGOjpVVENU aW1lKTsKIH0KIAogRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBkYXRlUHJvdG9GdW5jU2V0 TWludXRlcyhFeGVjU3RhdGUqIGV4ZWMpCiB7Ci0gICAgY29uc3QgV1RGOjpUaW1lVHlwZSBpbnB1 dFRpbWVUeXBlID0gV1RGOjpMb2NhbFRpbWU7Ci0gICAgcmV0dXJuIHNldE5ld1ZhbHVlRnJvbVRp bWVBcmdzKGV4ZWMsIDMsIGlucHV0VGltZVR5cGUpOworICAgIHJldHVybiBzZXROZXdWYWx1ZUZy b21UaW1lQXJncyhleGVjLCAzLCBXVEY6OkxvY2FsVGltZSk7CiB9CiAKIEVuY29kZWRKU1ZhbHVl IEpTQ19IT1NUX0NBTEwgZGF0ZVByb3RvRnVuY1NldFVUQ01pbnV0ZXMoRXhlY1N0YXRlKiBleGVj KQogewotICAgIGNvbnN0IFdURjo6VGltZVR5cGUgaW5wdXRUaW1lVHlwZSA9IFdURjo6VVRDVGlt ZTsKLSAgICByZXR1cm4gc2V0TmV3VmFsdWVGcm9tVGltZUFyZ3MoZXhlYywgMywgaW5wdXRUaW1l VHlwZSk7CisgICAgcmV0dXJuIHNldE5ld1ZhbHVlRnJvbVRpbWVBcmdzKGV4ZWMsIDMsIFdURjo6 VVRDVGltZSk7CiB9CiAKIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgZGF0ZVByb3RvRnVu Y1NldEhvdXJzKEV4ZWNTdGF0ZSogZXhlYykKIHsKLSAgICBjb25zdCBXVEY6OlRpbWVUeXBlIGlu cHV0VGltZVR5cGUgPSBXVEY6OkxvY2FsVGltZTsKLSAgICByZXR1cm4gc2V0TmV3VmFsdWVGcm9t VGltZUFyZ3MoZXhlYywgNCwgaW5wdXRUaW1lVHlwZSk7CisgICAgcmV0dXJuIHNldE5ld1ZhbHVl RnJvbVRpbWVBcmdzKGV4ZWMsIDQsIFdURjo6TG9jYWxUaW1lKTsKIH0KIAogRW5jb2RlZEpTVmFs dWUgSlNDX0hPU1RfQ0FMTCBkYXRlUHJvdG9GdW5jU2V0VVRDSG91cnMoRXhlY1N0YXRlKiBleGVj KQogewotICAgIGNvbnN0IFdURjo6VGltZVR5cGUgaW5wdXRUaW1lVHlwZSA9IFdURjo6VVRDVGlt ZTsKLSAgICByZXR1cm4gc2V0TmV3VmFsdWVGcm9tVGltZUFyZ3MoZXhlYywgNCwgaW5wdXRUaW1l VHlwZSk7CisgICAgcmV0dXJuIHNldE5ld1ZhbHVlRnJvbVRpbWVBcmdzKGV4ZWMsIDQsIFdURjo6 VVRDVGltZSk7CiB9CiAKIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgZGF0ZVByb3RvRnVu Y1NldERhdGUoRXhlY1N0YXRlKiBleGVjKQogewotICAgIGNvbnN0IFdURjo6VGltZVR5cGUgaW5w dXRUaW1lVHlwZSA9IFdURjo6TG9jYWxUaW1lOwotICAgIHJldHVybiBzZXROZXdWYWx1ZUZyb21E YXRlQXJncyhleGVjLCAxLCBpbnB1dFRpbWVUeXBlKTsKKyAgICByZXR1cm4gc2V0TmV3VmFsdWVG cm9tRGF0ZUFyZ3MoZXhlYywgMSwgV1RGOjpMb2NhbFRpbWUpOwogfQogCiBFbmNvZGVkSlNWYWx1 ZSBKU0NfSE9TVF9DQUxMIGRhdGVQcm90b0Z1bmNTZXRVVENEYXRlKEV4ZWNTdGF0ZSogZXhlYykK IHsKLSAgICBjb25zdCBXVEY6OlRpbWVUeXBlIGlucHV0VGltZVR5cGUgPSBXVEY6OlVUQ1RpbWU7 Ci0gICAgcmV0dXJuIHNldE5ld1ZhbHVlRnJvbURhdGVBcmdzKGV4ZWMsIDEsIGlucHV0VGltZVR5 cGUpOworICAgIHJldHVybiBzZXROZXdWYWx1ZUZyb21EYXRlQXJncyhleGVjLCAxLCBXVEY6OlVU Q1RpbWUpOwogfQogCiBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGRhdGVQcm90b0Z1bmNT ZXRNb250aChFeGVjU3RhdGUqIGV4ZWMpCiB7Ci0gICAgY29uc3QgV1RGOjpUaW1lVHlwZSBpbnB1 dFRpbWVUeXBlID0gV1RGOjpMb2NhbFRpbWU7Ci0gICAgcmV0dXJuIHNldE5ld1ZhbHVlRnJvbURh dGVBcmdzKGV4ZWMsIDIsIGlucHV0VGltZVR5cGUpOworICAgIHJldHVybiBzZXROZXdWYWx1ZUZy b21EYXRlQXJncyhleGVjLCAyLCBXVEY6OkxvY2FsVGltZSk7CiB9CiAKIEVuY29kZWRKU1ZhbHVl IEpTQ19IT1NUX0NBTEwgZGF0ZVByb3RvRnVuY1NldFVUQ01vbnRoKEV4ZWNTdGF0ZSogZXhlYykK IHsKLSAgICBjb25zdCBXVEY6OlRpbWVUeXBlIGlucHV0VGltZVR5cGUgPSBXVEY6OlVUQ1RpbWU7 Ci0gICAgcmV0dXJuIHNldE5ld1ZhbHVlRnJvbURhdGVBcmdzKGV4ZWMsIDIsIGlucHV0VGltZVR5 cGUpOworICAgIHJldHVybiBzZXROZXdWYWx1ZUZyb21EYXRlQXJncyhleGVjLCAyLCBXVEY6OlVU Q1RpbWUpOwogfQogCiBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGRhdGVQcm90b0Z1bmNT ZXRGdWxsWWVhcihFeGVjU3RhdGUqIGV4ZWMpCiB7Ci0gICAgY29uc3QgV1RGOjpUaW1lVHlwZSBp bnB1dFRpbWVUeXBlID0gV1RGOjpMb2NhbFRpbWU7Ci0gICAgcmV0dXJuIHNldE5ld1ZhbHVlRnJv bURhdGVBcmdzKGV4ZWMsIDMsIGlucHV0VGltZVR5cGUpOworICAgIHJldHVybiBzZXROZXdWYWx1 ZUZyb21EYXRlQXJncyhleGVjLCAzLCBXVEY6OkxvY2FsVGltZSk7CiB9CiAKIEVuY29kZWRKU1Zh bHVlIEpTQ19IT1NUX0NBTEwgZGF0ZVByb3RvRnVuY1NldFVUQ0Z1bGxZZWFyKEV4ZWNTdGF0ZSog ZXhlYykKIHsKLSAgICBjb25zdCBXVEY6OlRpbWVUeXBlIGlucHV0VGltZVR5cGUgPSBXVEY6OlVU Q1RpbWU7Ci0gICAgcmV0dXJuIHNldE5ld1ZhbHVlRnJvbURhdGVBcmdzKGV4ZWMsIDMsIGlucHV0 VGltZVR5cGUpOworICAgIHJldHVybiBzZXROZXdWYWx1ZUZyb21EYXRlQXJncyhleGVjLCAzLCBX VEY6OlVUQ1RpbWUpOwogfQogCiBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGRhdGVQcm90 b0Z1bmNTZXRZZWFyKEV4ZWNTdGF0ZSogZXhlYykK