137992 2014-10-22 17:38:27 -0700 CachedFrame::destroy can detach the page from frames too soon 2022-08-16 18:16:21 -0700 1 1 1 Unclassified WebKit History 528+ (Nightly build) Unspecified Unspecified RESOLVED CONFIGURATION CHANGED InRadar P2 Normal --- 1 jeffrey+webkit jeffrey+webkit ahmad.saleem792 ap beidson bfulgham ddkilzer kling rniwa oldest_to_newest 1043614 0 jeffrey+webkit 2014-10-22 17:38:27 -0700 CachedFrame::destroy contains code that will detach the page, sometimes too soon, causing crashes or assertion failures when teardown code for frames assumes there is still an attached page. <rdar://problem/18550647> 1043615 1 240313 jeffrey+webkit 2014-10-22 17:40:18 -0700 Created attachment 240313 Patch 1043648 2 240313 ap 2014-10-22 19:44:40 -0700 Comment on attachment 240313 Patch This appears to break tests: fast/loader/image-in-page-cache.html [ Crash Timeout Pass ] fast/frames/frame-crash-with-page-cache.html [ Timeout ] 1889824 3 ahmad.saleem792 2022-08-08 16:05:22 -0700 I can see the following code being present in Webkit source from Github: https://github.com/WebKit/WebKit/blob/75043d22e2b75e0018914f38ab381214f048dba2/Source/WebCore/history/CachedFrame.cpp#L261 Although line order is different and it was done in this commit: https://github.com/WebKit/WebKit/commit/8506cd994976591f9a1db0dc5c10fc698768687f#diff-24fdd2b5535690eeec8038c328da95c097199ec9f376593c366505033eb18931 Considering this change landed in one way or form, I am going to mark this bug as "RESOLVED WONTFIX". Thanks! 240313 2014-10-22 17:40:18 -0700 2014-10-22 19:44:40 -0700 Patch bug-137992-20141022174024.patch text/plain 1858 jeffrey+webkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0OTIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDJjNmQzOTZhOWIyMzU3 MzA3Yzg4MWNjMTVhZWNiZjFjMDA3NTAzMC4uZjkyNjM4OTliN2VhZjQ2MzJlNzZjYmFjMGE1MDdh NjQxNmJjMTY5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE0LTEwLTIyICBKZWZm cmV5IFBmYXUgIDxqcGZhdUBhcHBsZS5jb20+CisKKyAgICAgICAgQ2FjaGVkRnJhbWU6OmRlc3Ry b3kgY2FuIGRldGFjaCB0aGUgcGFnZSBmcm9tIGZyYW1lcyB0b28gc29vbgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM3OTkyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2FjaGVkRnJhbWUgY29udGFpbmVk IGNvZGUgdGhhdCB3b3VsZCBkZXRhY2ggYSBmcmFtZS10by1iZS1kZXN0cm95ZWQKKyAgICAgICAg ZnJvbSB0aGUgcGFnZSwgd2hpY2ggd2FzIHJlZHVuZGFudCB3aXRoICBjb2RlIGxhdGVyIG9uIGlu IHRoZSBjb2RlcGF0aAorICAgICAgICB0aGF0IGRpZCB0aGUgc2FtZSB0aGluZy4gRnVydGhlcm1v cmUsIHRoZSBjb2RlIGluIENhY2hlZEZyYW1lIHdhcworICAgICAgICBzdGFsZSAoaXQgbGFja2Vk IGEgbWF0Y2hpbmcgY2FsbCB0byB3aWxsRGV0YWNoUGFnZSksIGFuZCBkZXRhY2hlZCB0b28KKyAg ICAgICAgZWFybHkgaW4gc29tZSByYXJlIGNhc2VzLCBjYXVzaW5nIG51bGwtcG9pbnRlciBkZXJl ZnMuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzOyB0aGVyZSBpcyBubyBiZWhhdmlvciBjaGFuZ2Ug aW4gbW9zdCBjYXNlcywgYW5kIGl0IGlzCisgICAgICAgIGltcG9zc2libGUgdG8gc2ltdWxhdGUg dGhlIHJhcmUgY2FzZXMgd2l0aG91dCBpbnRydXNpdmUgY29kZSBjaGFuZ2VzLgorCisgICAgICAg ICogaGlzdG9yeS9DYWNoZWRGcmFtZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDYWNoZWRGcmFt ZTo6ZGVzdHJveSk6CisKIDIwMTQtMTAtMTcgIEplZmZyZXkgUGZhdSAgPGpwZmF1QGFwcGxlLmNv bT4KIAogICAgICAgICBFbnN1cmUgYXR0YWNoZWQgZnJhbWUgY291bnQgZG9lc24ndCBleGNlZWQg dGhlIG1heGltdW0gYWxsb3dlZCBmcmFtZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2hp c3RvcnkvQ2FjaGVkRnJhbWUuY3BwIGIvU291cmNlL1dlYkNvcmUvaGlzdG9yeS9DYWNoZWRGcmFt ZS5jcHAKaW5kZXggNTBlNjU5NmQwYTczNWJlODdhNTI2OGNjZTY4NDE5NDk4N2Q4YzFiMC4uNjdj OWJlOGJlMTkzZmVkMzdkMTZjNGZkODk0MjhkYTBhNWEyZjhhNSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvaGlzdG9yeS9DYWNoZWRGcmFtZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaGlz dG9yeS9DYWNoZWRGcmFtZS5jcHAKQEAgLTI1MywxMSArMjUzLDYgQEAgdm9pZCBDYWNoZWRGcmFt ZTo6ZGVzdHJveSgpCiAKICAgICBtX2RvY3VtZW50LT5kb21XaW5kb3coKS0+d2lsbERlc3Ryb3lD YWNoZWRGcmFtZSgpOwogCi0gICAgaWYgKCFtX2lzTWFpbkZyYW1lKSB7Ci0gICAgICAgIG1fdmll dy0+ZnJhbWUoKS5kZXRhY2hGcm9tUGFnZSgpOwotICAgICAgICBtX3ZpZXctPmZyYW1lKCkubG9h ZGVyKCkuZGV0YWNoVmlld3NBbmREb2N1bWVudExvYWRlcigpOwotICAgIH0KLSAgICAKICAgICBm b3IgKGludCBpID0gbV9jaGlsZEZyYW1lcy5zaXplKCkgLSAxOyBpID49IDA7IC0taSkKICAgICAg ICAgbV9jaGlsZEZyYW1lc1tpXS0+ZGVzdHJveSgpOwogCg==