137991 2014-10-22 17:33:13 -0700 [iOS] iPhone should not allow selecting <optgroup> in <select multiple> 2014-10-28 12:05:56 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck dbates enrica joepeck simon.fraser oldest_to_newest 1043611 0 joepeck 2014-10-22 17:33:13 -0700 iPhone should not allow selecting <optgroup> in <select multiple> * TEST <select multiple="multiple"> <optgroup label="foo"> <option value="1">0001</option> <option value="2">0002</option> <option value="3">0003</option> </optgroup> </select> * STEPS TO REPRODUCE 1. Load test 2. Tap the "foo" group => expected nothing to be selected => actual results were "0001" is selected We should ignore taps on groups. 1043619 1 joepeck 2014-10-22 18:03:11 -0700 <rdar://problem/18745292> 1043624 2 240316 joepeck 2014-10-22 18:14:29 -0700 Created attachment 240316 [PATCH] Proposed Fix Patch may not apply as it may be waiting on another change near this. 1044493 3 240316 darin 2014-10-28 09:17:19 -0700 Comment on attachment 240316 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=240316&action=review > Source/WebKit2/UIProcess/ios/forms/WKFormSelectPicker.mm:284 > + // FIXME: <rdar://problem/18745253> > + // Group picker content view should not be checkable. If we get this delegate > + // reset the styles for the group content view so it still appears unselected. I don’t think this comment makes it clear enough that this is a workaround for the above bug and can be removed if it’s fixed. > Source/WebKit2/UIProcess/ios/forms/WKFormSelectPicker.mm:288 > + [[view titleLabel] setTextColor:[UIColor colorWithWhite:0.0 alpha:0.5]]; Hard-coding this seems really unfortunate and could cause us trouble later. What mitigates that, I suppose, is that we will remove this code when the above mentioned bug is fixed. 1044569 4 joepeck 2014-10-28 11:47:53 -0700 (In reply to comment #3) > Comment on attachment 240316 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=240316&action=review > > > Source/WebKit2/UIProcess/ios/forms/WKFormSelectPicker.mm:288 > > + [[view titleLabel] setTextColor:[UIColor colorWithWhite:0.0 alpha:0.5]]; > > Hard-coding this seems really unfortunate and could cause us trouble later. > What mitigates that, I suppose, is that we will remove this code when the > above mentioned bug is fixed. Seeing as we already had a constant for disabled options, I'll add one and share it for groups. This is only duplicating our own styles, not another framework's styles. 1044573 5 joepeck 2014-10-28 12:05:56 -0700 http://trac.webkit.org/changeset/175266 240316 2014-10-22 18:14:29 -0700 2014-10-28 11:37:57 -0700 [PATCH] Proposed Fix group-fix.patch text/plain 2027 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAzMmExZjBmLi5lYzUxYzg0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTkg QEAKIDIwMTQtMTAtMjIgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAor ICAgICAgICBbaU9TXSBpUGhvbmUgc2hvdWxkIG5vdCBhbGxvdyBzZWxlY3RpbmcgPG9wdGdyb3Vw PiBpbiA8c2VsZWN0IG11bHRpcGxlPgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTM3OTkxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgV2Ugc2VlbSB0byBiZSBnZXR0aW5nIHRoZSBkZWxlZ2F0ZSB3aGVuIHdl IGFyZSBub3Qgc3VwcG9zZWQgdG8uCisgICAgICAgIFdvcmthcm91bmQgdGhlIGlzc3VlIGFzIGJl c3Qgd2UgY2FuIGJ5IHJlc2V0aW5nIHRoZSBzdHlsZXMKKyAgICAgICAgZm9yIHRoZSBncm91cCdz IGNvbnRlbnQgdmlldyBhbmQgbm90IGNoYW5naW5nIHNlbGVjdGlvbnMuCisKKyAgICAgICAgKiBV SVByb2Nlc3MvaW9zL2Zvcm1zL1dLRm9ybVNlbGVjdFBpY2tlci5tbToKKyAgICAgICAgKC1bV0tN dWx0aXBsZVNlbGVjdFBpY2tlciBwaWNrZXJWaWV3OnJvdzpjb2x1bW46Y2hlY2tlZDpdKToKKwor MjAxNC0xMC0yMiAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAgICAg ICAgIFtpT1NdIGlQaG9uZSB1bnNlbGVjdGluZyBpdGVtcyBpbiA8c2VsZWN0IG11bHRpcGxlPiBz aG93cyBpbmNvcnJlY3QgdmFsdWVzIHNlbGVjdGVkCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzc5ODkKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL2lvcy9mb3Jtcy9XS0Zvcm1TZWxlY3RQaWNrZXIubW0gYi9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvaW9zL2Zvcm1zL1dLRm9ybVNlbGVjdFBpY2tlci5tbQppbmRleCA3NTY4 MDI2Li4zYWM2MjQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL2Zv cm1zL1dLRm9ybVNlbGVjdFBpY2tlci5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv aW9zL2Zvcm1zL1dLRm9ybVNlbGVjdFBpY2tlci5tbQpAQCAtMjc5LDYgKzI3OSwxNiBAQCBzdGF0 aWMgY29uc3QgZmxvYXQgRGlzYWJsZWRPcHRpb25BbHBoYSA9IDAuMzsKIAogICAgIE9wdGlvbkl0 ZW0mIGl0ZW0gPSBbX3ZpZXcgYXNzaXN0ZWROb2RlU2VsZWN0T3B0aW9uc11bcm93SW5kZXhdOwog CisgICAgLy8gRklYTUU6IDxyZGFyOi8vcHJvYmxlbS8xODc0NTI1Mz4KKyAgICAvLyBHcm91cCBw aWNrZXIgY29udGVudCB2aWV3IHNob3VsZCBub3QgYmUgY2hlY2thYmxlLiBJZiB3ZSBnZXQgdGhp cyBkZWxlZ2F0ZQorICAgIC8vIHJlc2V0IHRoZSBzdHlsZXMgZm9yIHRoZSBncm91cCBjb250ZW50 IHZpZXcgc28gaXQgc3RpbGwgYXBwZWFycyB1bnNlbGVjdGVkLgorICAgIGlmIChpdGVtLmlzR3Jv dXApIHsKKyAgICAgICAgVUlQaWNrZXJDb250ZW50VmlldyAqdmlldyA9IChVSVBpY2tlckNvbnRl bnRWaWV3ICopW3NlbGYgdmlld0ZvclJvdzpyb3dJbmRleCBmb3JDb21wb25lbnQ6Y29sdW1uSW5k ZXhdOworICAgICAgICBbdmlldyBzZXRDaGVja2VkOk5PXTsKKyAgICAgICAgW1t2aWV3IHRpdGxl TGFiZWxdIHNldFRleHRDb2xvcjpbVUlDb2xvciBjb2xvcldpdGhXaGl0ZTowLjAgYWxwaGE6MC41 XV07CisgICAgICAgIHJldHVybjsKKyAgICB9CisKICAgICBpZiAoW3NlbGYgYWxsb3dzTXVsdGlw bGVTZWxlY3Rpb25dKSB7CiAgICAgICAgIFtfdmlldyBwYWdlXS0+c2V0QXNzaXN0ZWROb2RlU2Vs ZWN0ZWRJbmRleChbc2VsZiBmaW5kSXRlbUluZGV4QXQ6cm93SW5kZXhdLCB0cnVlKTsKICAgICAg ICAgaXRlbS5pc1NlbGVjdGVkID0gaXNDaGVja2VkOwo=