137989 2014-10-22 17:26:14 -0700 [iOS] iPhone unselecting items in <select multiple> shows incorrect values selected 2014-10-23 12:48:46 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue ddkilzer enrica joepeck simon.fraser oldest_to_newest 1043606 0 joepeck 2014-10-22 17:26:14 -0700 iPhone unselecting items in <select multiple> shows incorrect values selected. * TEST <select multiple="multiple" id="stuff" name="stuff"> <option value="1">0001</option> <option value="2">0002</option> <option value="3">0003</option> </select> * STEPS TO REPRODUCE 1. Load test 2. Tap the <select> and select 0001, 0002, and 0003 3. Tap to unselect 0001, 0002, 0003 => expected to see "3 items" => "2 items" => "0003", => "0 Items" => actual results were "3 items" => "0001" => "0002" => "0003" We aren't treating taps on multi select form controls as multiple selection taps. We are treating them as full selections. 1043607 1 joepeck 2014-10-22 17:26:31 -0700 <rdar://problem/18729429> 1043608 2 240310 joepeck 2014-10-22 17:28:05 -0700 Created attachment 240310 [PATCH] Proposed Fix 1043801 3 240310 commit-queue 2014-10-23 12:38:25 -0700 Comment on attachment 240310 [PATCH] Proposed Fix Clearing flags on attachment: 240310 Committed r175135: <http://trac.webkit.org/changeset/175135> 240310 2014-10-22 17:28:05 -0700 2014-10-23 12:38:25 -0700 [PATCH] Proposed Fix multiple.patch text/plain 2061 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAxNDEwOWJjLi4zMmExZjBmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTQtMTAtMjIgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBbaU9TXSBpUGhvbmUgdW5zZWxlY3RpbmcgaXRlbXMgaW4gPHNlbGVjdCBtdWx0aXBs ZT4gc2hvd3MgaW5jb3JyZWN0IHZhbHVlcyBzZWxlY3RlZAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM3OTg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL2Zvcm1zL1dLRm9ybVNl bGVjdFBpY2tlci5tbToKKyAgICAgICAgKC1bV0tNdWx0aXBsZVNlbGVjdFBpY2tlciBwaWNrZXJW aWV3OnJvdzpjb2x1bW46Y2hlY2tlZDpdKToKKyAgICAgICAgVGhlIHNlY29uZCBhcmd1bWVudCBp cyAiYWxsb3dzTXVsdGlwbGVTZWxlY3Rpb24iIGFuZCBzaG91bGQgb25seSBiZSBzZXQKKyAgICAg ICAgd2hlbiB3ZSBhcmUgbWFraW5nIGEgc2VsZWN0aW9uIGluIGEgPHNlbGVjdCBtdWx0aXBsZT4u CisKIDIwMTQtMTAtMjAgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAog ICAgICAgICBXZWIgSW5zcGVjdG9yOiBQcm92aWRlIGEgd2F5IHRvIGhhdmUgYWx0ZXJuYXRlIGlu c3BlY3RvciBhZ2VudHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3Mv Zm9ybXMvV0tGb3JtU2VsZWN0UGlja2VyLm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lv cy9mb3Jtcy9XS0Zvcm1TZWxlY3RQaWNrZXIubW0KaW5kZXggNDZmYzY1ZC4uNzU2ODAyNiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9mb3Jtcy9XS0Zvcm1TZWxlY3RQ aWNrZXIubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9mb3Jtcy9XS0Zvcm1T ZWxlY3RQaWNrZXIubW0KQEAgLTI4MCw3ICsyODAsNyBAQCBzdGF0aWMgY29uc3QgZmxvYXQgRGlz YWJsZWRPcHRpb25BbHBoYSA9IDAuMzsKICAgICBPcHRpb25JdGVtJiBpdGVtID0gW192aWV3IGFz c2lzdGVkTm9kZVNlbGVjdE9wdGlvbnNdW3Jvd0luZGV4XTsKIAogICAgIGlmIChbc2VsZiBhbGxv d3NNdWx0aXBsZVNlbGVjdGlvbl0pIHsKLSAgICAgICAgW192aWV3IHBhZ2VdLT5zZXRBc3Npc3Rl ZE5vZGVTZWxlY3RlZEluZGV4KFtzZWxmIGZpbmRJdGVtSW5kZXhBdDpyb3dJbmRleF0sIGlzQ2hl Y2tlZCk7CisgICAgICAgIFtfdmlldyBwYWdlXS0+c2V0QXNzaXN0ZWROb2RlU2VsZWN0ZWRJbmRl eChbc2VsZiBmaW5kSXRlbUluZGV4QXQ6cm93SW5kZXhdLCB0cnVlKTsKICAgICAgICAgaXRlbS5p c1NlbGVjdGVkID0gaXNDaGVja2VkOwogICAgIH0gZWxzZSB7CiAgICAgICAgIC8vIFNpbmdsZSBz ZWxlY3Rpb24uCkBAIC0yOTAsNyArMjkwLDcgQEAgc3RhdGljIGNvbnN0IGZsb2F0IERpc2FibGVk T3B0aW9uQWxwaGEgPSAwLjM7CiAgICAgICAgIC8vIFRoaXMgcHJpdmF0ZSBkZWxlZ2F0ZSBvZnRl biBnZXRzIGNhbGxlZCBmb3IgbXVsdGlwbGUgcm93cyBpbiB0aGUgcGlja2VyLAogICAgICAgICAv LyBzbyB3ZSBvbmx5IGFjdGl2YXRlIGFuZCBzZXQgYXMgc2VsZWN0ZWQgdGhlIGNoZWNrZWQgaXRl bSBpbiBzaW5nbGUgc2VsZWN0aW9uLgogICAgICAgICBpZiAoaXNDaGVja2VkKSB7Ci0gICAgICAg ICAgICBbX3ZpZXcgcGFnZV0tPnNldEFzc2lzdGVkTm9kZVNlbGVjdGVkSW5kZXgoW3NlbGYgZmlu ZEl0ZW1JbmRleEF0OnJvd0luZGV4XSwgaXNDaGVja2VkKTsKKyAgICAgICAgICAgIFtfdmlldyBw YWdlXS0+c2V0QXNzaXN0ZWROb2RlU2VsZWN0ZWRJbmRleChbc2VsZiBmaW5kSXRlbUluZGV4QXQ6 cm93SW5kZXhdKTsKICAgICAgICAgICAgIGl0ZW0uaXNTZWxlY3RlZCA9IFlFUzsKICAgICAgICAg fQogICAgIH0K