137983 2014-10-22 15:07:30 -0700 [Mac] don't update caption user style sheet during parsing 2014-10-23 13:27:29 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eric.carlson eric.carlson commit-queue glenn jer.noble philipj sergio oldest_to_newest 1043562 0 eric.carlson 2014-10-22 15:07:30 -0700 CaptionUserPreferencesMediaAF::setInterestedInCaptionPreferenceChanges is called whenever a audio or video element is created. It calls updateCaptionStyleSheetOveride which generates and inserts a user style sheet. This is an expensive operation and it can happen during document parsing/creation, so it should be done after a brief delay. 1043772 1 240351 eric.carlson 2014-10-23 10:53:52 -0700 Created attachment 240351 Proposed patch. 1043783 2 240355 eric.carlson 2014-10-23 11:32:23 -0700 Created attachment 240355 Updated patch 1043818 3 240355 commit-queue 2014-10-23 13:27:25 -0700 Comment on attachment 240355 Updated patch Clearing flags on attachment: 240355 Committed r175139: <http://trac.webkit.org/changeset/175139> 1043819 4 commit-queue 2014-10-23 13:27:29 -0700 All reviewed patches have been landed. Closing bug. 240351 2014-10-23 10:53:52 -0700 2014-10-23 11:32:23 -0700 Proposed patch. delay_generating_css_patch_1.txt text/plain 1891 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NTA2OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTEwLTIyICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtNYWNdIGRvbid0IHVw ZGF0ZSBjYXB0aW9uIHVzZXIgc3R5bGUgc2hlZXQgZHVyaW5nIHBhcnNpbmcKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNzk4MworICAgICAgICByZGFy Oi8vcHJvYmxlbS8xODczNTM2NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgZXhpc3RpbmcgdGVzdHMgY292ZXIgdGhlIGNoYW5n ZXMuCisKKyAgICAgICAgKiBwYWdlL0NhcHRpb25Vc2VyUHJlZmVyZW5jZXNNZWRpYUFGLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkNhcHRpb25Vc2VyUHJlZmVyZW5jZXNNZWRpYUFGOjpzZXRJbnRl cmVzdGVkSW5DYXB0aW9uUHJlZmVyZW5jZUNoYW5nZXMpOiBXcmFwIGNhbGwgdG8KKyAgICAgICAg ICAgIHVwZGF0ZUNhcHRpb25TdHlsZVNoZWV0T3ZlcmlkZSBpbiBhIGNhbGxPbk1haW5UaHJlYWQg c28gaXQgaXMgY2FsbGVkIGFmdGVyIGEgc2xpZ2h0IGRlbGF5LgorCiAyMDE0LTEwLTIyICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgQXZvaWQgY29uZnVzaW9uIGJl dHdlZW4gQWNjZXNzaWJpbGl0eU9iamVjdDo6aXNUYWJsZSgpIC8gaXNBY2Nlc3NpYmlsaXR5VGFi bGUoKQpJbmRleDogU291cmNlL1dlYkNvcmUvcGFnZS9DYXB0aW9uVXNlclByZWZlcmVuY2VzTWVk aWFBRi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGFnZS9DYXB0aW9uVXNlclBy ZWZlcmVuY2VzTWVkaWFBRi5jcHAJKHJldmlzaW9uIDE3NTA2NCkKKysrIFNvdXJjZS9XZWJDb3Jl L3BhZ2UvQ2FwdGlvblVzZXJQcmVmZXJlbmNlc01lZGlhQUYuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0yMzYsNyArMjM2LDExIEBAIHZvaWQgQ2FwdGlvblVzZXJQcmVmZXJlbmNlc01lZGlhQUY6OnNl dEkKICAgICAgICAgQ0ZOb3RpZmljYXRpb25DZW50ZXJBZGRPYnNlcnZlcihDRk5vdGlmaWNhdGlv bkNlbnRlckdldExvY2FsQ2VudGVyKCksIHRoaXMsIHVzZXJDYXB0aW9uUHJlZmVyZW5jZXNDaGFu Z2VkTm90aWZpY2F0aW9uQ2FsbGJhY2ssIGtNQVhDYXB0aW9uQXBwZWFyYW5jZVNldHRpbmdzQ2hh bmdlZE5vdGlmaWNhdGlvbiwgMCwgQ0ZOb3RpZmljYXRpb25TdXNwZW5zaW9uQmVoYXZpb3JDb2Fs ZXNjZSk7CiAgICAgfQogCi0gICAgdXBkYXRlQ2FwdGlvblN0eWxlU2hlZXRPdmVyaWRlKCk7Cisg ICAgLy8gR2VuZXJhdGluZyBhbmQgcmVnaXN0ZXJpbmcgdGhlIGNhcHRpb24gc3R5bGVzaGVldCBj YW4gYmUgZXhwZW5zaXZlIGFuZCB0aGlzIG1ldGhvZCBpcyBjYWxsZWQgaW5kaXJlY3RseSB3aGVu IHRoZSBwYXJzZXIgY3JlYXRlcyBhbiBhdWRpbyBvcgorICAgIC8vIHZpZGVvIGVsZW1lbnQsIHNv IGRvIGl0IGFmdGVyIGEgYnJpZWYgcGF1c2UuCisgICAgY2FsbE9uTWFpblRocmVhZChbdGhpc10g eworICAgICAgICB1cGRhdGVDYXB0aW9uU3R5bGVTaGVldE92ZXJpZGUoKTsKKyAgICB9KTsKIH0K IAogdm9pZCBDYXB0aW9uVXNlclByZWZlcmVuY2VzTWVkaWFBRjo6Y2FwdGlvblByZWZlcmVuY2Vz Q2hhbmdlZCgpCg== 240355 2014-10-23 11:32:23 -0700 2014-10-23 13:27:25 -0700 Updated patch delay_generating_css_patch_2.txt text/plain 3828 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NTA2OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE0LTEwLTIyICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtNYWNdIGRvbid0IHVw ZGF0ZSBjYXB0aW9uIHVzZXIgc3R5bGUgc2hlZXQgZHVyaW5nIHBhcnNpbmcKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNzk4MworICAgICAgICByZGFy Oi8vcHJvYmxlbS8xODczNTM2NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgZXhpc3RpbmcgdGVzdHMgY292ZXIgdGhlIGNoYW5n ZXMuCisKKyAgICAgICAgKiBwYWdlL0NhcHRpb25Vc2VyUHJlZmVyZW5jZXNNZWRpYUFGLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkNhcHRpb25Vc2VyUHJlZmVyZW5jZXNNZWRpYUFGOjpDYXB0aW9u VXNlclByZWZlcmVuY2VzTWVkaWFBRik6IEluaXRpYWxpemUgbV91cGRhdGVTdHlsZVNoZWV0VGlt ZXIuCisgICAgICAgIChXZWJDb3JlOjpDYXB0aW9uVXNlclByZWZlcmVuY2VzTWVkaWFBRjo6dXBk YXRlVGltZXJGaXJlZCk6IENhbGwgdXBkYXRlQ2FwdGlvblN0eWxlU2hlZXRPdmVyaWRlLgorICAg ICAgICAoV2ViQ29yZTo6Q2FwdGlvblVzZXJQcmVmZXJlbmNlc01lZGlhQUY6OnNldEludGVyZXN0 ZWRJbkNhcHRpb25QcmVmZXJlbmNlQ2hhbmdlcyk6IFByaW1lIGEgdGltZXIgdG8gdXBkYXRlIAor ICAgICAgICAgICAgdGhlIGNhcHRpb25zIHN0eWxlIHNoZWV0IGFmdGVyIGEgc2xpZ2h0IGRlbGF5 LgorCiAyMDE0LTEwLTIyICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAg ICAgQXZvaWQgY29uZnVzaW9uIGJldHdlZW4gQWNjZXNzaWJpbGl0eU9iamVjdDo6aXNUYWJsZSgp IC8gaXNBY2Nlc3NpYmlsaXR5VGFibGUoKQpJbmRleDogU291cmNlL1dlYkNvcmUvcGFnZS9DYXB0 aW9uVXNlclByZWZlcmVuY2VzTWVkaWFBRi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvcGFnZS9DYXB0aW9uVXNlclByZWZlcmVuY2VzTWVkaWFBRi5jcHAJKHJldmlzaW9uIDE3NTA2 NCkKKysrIFNvdXJjZS9XZWJDb3JlL3BhZ2UvQ2FwdGlvblVzZXJQcmVmZXJlbmNlc01lZGlhQUYu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNDEsNiArMTQxLDcgQEAgc3RhdGljIHZvaWQgdXNlckNh cHRpb25QcmVmZXJlbmNlc0NoYW5nZQogQ2FwdGlvblVzZXJQcmVmZXJlbmNlc01lZGlhQUY6OkNh cHRpb25Vc2VyUHJlZmVyZW5jZXNNZWRpYUFGKFBhZ2VHcm91cCYgZ3JvdXApCiAgICAgOiBDYXB0 aW9uVXNlclByZWZlcmVuY2VzKGdyb3VwKQogI2lmIEhBVkUoTUVESUFfQUNDRVNTSUJJTElUWV9G UkFNRVdPUkspCisgICAgLCBtX3VwZGF0ZVN0eWxlU2hlZXRUaW1lcih0aGlzLCAmQ2FwdGlvblVz ZXJQcmVmZXJlbmNlc01lZGlhQUY6OnVwZGF0ZVRpbWVyRmlyZWQpCiAgICAgLCBtX2xpc3Rlbmlu Z0ZvclByZWZlcmVuY2VDaGFuZ2VzKGZhbHNlKQogI2VuZGlmCiB7CkBAIC0yMjMsNiArMjI0LDEx IEBAIGJvb2wgQ2FwdGlvblVzZXJQcmVmZXJlbmNlc01lZGlhQUY6OnVzZXIKICAgICByZXR1cm4g IShjYXB0aW9uaW5nTWVkaWFDaGFyYWN0ZXJpc3RpY3MgJiYgQ0ZBcnJheUdldENvdW50KGNhcHRp b25pbmdNZWRpYUNoYXJhY3RlcmlzdGljcy5nZXQoKSkpOwogfQogCit2b2lkIENhcHRpb25Vc2Vy UHJlZmVyZW5jZXNNZWRpYUFGOjp1cGRhdGVUaW1lckZpcmVkKFRpbWVyPENhcHRpb25Vc2VyUHJl ZmVyZW5jZXNNZWRpYUFGPiYpCit7CisgICAgdXBkYXRlQ2FwdGlvblN0eWxlU2hlZXRPdmVyaWRl KCk7Cit9CisKIHZvaWQgQ2FwdGlvblVzZXJQcmVmZXJlbmNlc01lZGlhQUY6OnNldEludGVyZXN0 ZWRJbkNhcHRpb25QcmVmZXJlbmNlQ2hhbmdlcygpCiB7CiAgICAgaWYgKCFNZWRpYUFjY2Vzc2li aWxpdHlMaWJyYXJ5KCkpCkBAIC0yMzYsNyArMjQyLDExIEBAIHZvaWQgQ2FwdGlvblVzZXJQcmVm ZXJlbmNlc01lZGlhQUY6OnNldEkKICAgICAgICAgQ0ZOb3RpZmljYXRpb25DZW50ZXJBZGRPYnNl cnZlcihDRk5vdGlmaWNhdGlvbkNlbnRlckdldExvY2FsQ2VudGVyKCksIHRoaXMsIHVzZXJDYXB0 aW9uUHJlZmVyZW5jZXNDaGFuZ2VkTm90aWZpY2F0aW9uQ2FsbGJhY2ssIGtNQVhDYXB0aW9uQXBw ZWFyYW5jZVNldHRpbmdzQ2hhbmdlZE5vdGlmaWNhdGlvbiwgMCwgQ0ZOb3RpZmljYXRpb25TdXNw ZW5zaW9uQmVoYXZpb3JDb2FsZXNjZSk7CiAgICAgfQogCi0gICAgdXBkYXRlQ2FwdGlvblN0eWxl U2hlZXRPdmVyaWRlKCk7CisgICAgLy8gR2VuZXJhdGluZyBhbmQgcmVnaXN0ZXJpbmcgdGhlIGNh cHRpb24gc3R5bGVzaGVldCBjYW4gYmUgZXhwZW5zaXZlIGFuZCB0aGlzIG1ldGhvZCBpcyBjYWxs ZWQgaW5kaXJlY3RseSB3aGVuIHRoZSBwYXJzZXIgY3JlYXRlcyBhbiBhdWRpbyBvcgorICAgIC8v IHZpZGVvIGVsZW1lbnQsIHNvIGRvIGl0IGFmdGVyIGEgYnJpZWYgcGF1c2UuCisgICAgaWYgKG1f dXBkYXRlU3R5bGVTaGVldFRpbWVyLmlzQWN0aXZlKCkpCisgICAgICAgIG1fdXBkYXRlU3R5bGVT aGVldFRpbWVyLnN0b3AoKTsKKyAgICBtX3VwZGF0ZVN0eWxlU2hlZXRUaW1lci5zdGFydE9uZVNo b3QoMCk7CiB9CiAKIHZvaWQgQ2FwdGlvblVzZXJQcmVmZXJlbmNlc01lZGlhQUY6OmNhcHRpb25Q cmVmZXJlbmNlc0NoYW5nZWQoKQpJbmRleDogU291cmNlL1dlYkNvcmUvcGFnZS9DYXB0aW9uVXNl clByZWZlcmVuY2VzTWVkaWFBRi5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2Uv Q2FwdGlvblVzZXJQcmVmZXJlbmNlc01lZGlhQUYuaAkocmV2aXNpb24gMTc1MDY0KQorKysgU291 cmNlL1dlYkNvcmUvcGFnZS9DYXB0aW9uVXNlclByZWZlcmVuY2VzTWVkaWFBRi5oCSh3b3JraW5n IGNvcHkpCkBAIC02OCw2ICs2OCw4IEBAIHB1YmxpYzoKIAogcHJpdmF0ZToKICNpZiBIQVZFKE1F RElBX0FDQ0VTU0lCSUxJVFlfRlJBTUVXT1JLKQorICAgIHZvaWQgdXBkYXRlVGltZXJGaXJlZChU aW1lcjxDYXB0aW9uVXNlclByZWZlcmVuY2VzTWVkaWFBRj4mKTsKKwogICAgIFN0cmluZyBjYXB0 aW9uc1dpbmRvd0NTUygpIGNvbnN0OwogICAgIFN0cmluZyBjYXB0aW9uc0JhY2tncm91bmRDU1Mo KSBjb25zdDsKICAgICBTdHJpbmcgY2FwdGlvbnNUZXh0Q29sb3JDU1MoKSBjb25zdDsKQEAgLTc4 LDYgKzgwLDcgQEAgcHJpdmF0ZToKICAgICBTdHJpbmcgY2FwdGlvbnNUZXh0RWRnZUNTUygpIGNv bnN0OwogICAgIFN0cmluZyBjc3NQcm9wZXJ0eVdpdGhUZXh0RWRnZUNvbG9yKENTU1Byb3BlcnR5 SUQsIGNvbnN0IFN0cmluZyYsIGNvbnN0IENvbG9yJiwgYm9vbCkgY29uc3Q7CiAgICAgU3RyaW5n IGNvbG9yUHJvcGVydHlDU1MoQ1NTUHJvcGVydHlJRCwgY29uc3QgQ29sb3ImLCBib29sKSBjb25z dDsKKyAgICBUaW1lcjxDYXB0aW9uVXNlclByZWZlcmVuY2VzTWVkaWFBRj4gbV91cGRhdGVTdHls ZVNoZWV0VGltZXI7CiAKICAgICBib29sIG1fbGlzdGVuaW5nRm9yUHJlZmVyZW5jZUNoYW5nZXM7 CiAjZW5kaWYK