137953 2014-10-22 04:36:18 -0700 [CMake] Use ld.gold if it is available to speedup builds 2014-11-20 23:07:06 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 137818 1 ossy ossy berto cgarcia clopez commit-queue gyuyoung.kim mrobinson ossy rakuco ryuan.choi sergio oldest_to_newest 1043417 0 ossy 2014-10-22 04:36:18 -0700 Now the incremental build takes 1m51s for me if I touch a random cpp in WebCore. There are 2 reasons for it: - CMake always run - bug137949 - There are 87 relinking: (+ 5 generator + 1 compile + 1 symlink genarating) [6/94] Linking CXX static library lib/libwebcore_efl.a [8/94] Linking CXX shared library lib/libewebkit2.so.1.11.0 [10/94] Linking CXX executable bin/NetworkProcess [11/94] Linking CXX executable bin/PluginProcess [12/94] Linking CXX shared library lib/libewebkit_extension_manager.so [13/94] Linking CXX executable bin/WebProcess [14/94] Linking CXX executable bin/TestWebKitAPI/EWebKit2/test_ewk2_application_cache_manager [15/94] Linking CXX executable bin/TestWebKitAPI/EWebKit2/test_ewk2_auth_request [16/94] Linking CXX executable bin/TestWebKitAPI/EWebKit2/test_ewk2_back_forward_list [17/94] Linking CXX executable bin/TestWebKitAPI/EWebKit2/test_ewk2_color_picker [18/94] Linking CXX executable bin/TestWebKitAPI/EWebKit2/test_ewk2_context [19/94] Linking CXX executable bin/TestWebKitAPI/EWebKit2/test_ewk2_context_history_callbacks [20/94] Linking CXX executable bin/TestWebKitAPI/EWebKit2/test_ewk2_cookie_manager [21/94] Linking CXX executable bin/TestWebKitAPI/EWebKit2/test_ewk2_database_manager [22/94] Linking CXX executable bin/TestWebKitAPI/EWebKit2/test_ewk2_eina_shared_string [23/94] Linking CXX executable bin/TestWebKitAPI/WebKit2/CloseThenTerminate [24/94] Linking CXX executable bin/TestWebKitAPI/EWebKit2/test_ewk2_favicon_database [25/94] Linking CXX executable bin/TestWebKitAPI/EWebKit2/test_ewk2_file_chooser_request [26/94] Linking CXX executable bin/TestWebKitAPI/EWebKit2/test_ewk2_object [27/94] Linking CXX executable bin/TestWebKitAPI/EWebKit2/test_ewk2_page_group [28/94] Linking CXX executable bin/TestWebKitAPI/EWebKit2/test_ewk2_settings [29/94] Linking CXX executable bin/TestWebKitAPI/EWebKit2/test_ewk2_popup_menu [30/94] Linking CXX executable bin/TestWebKitAPI/EWebKit2/test_ewk2_ssl [31/94] Linking CXX executable bin/TestWebKitAPI/EWebKit2/test_ewk2_storage_manager [32/94] Linking CXX executable bin/TestWebKitAPI/EWebKit2/test_ewk2_view [33/94] Linking CXX executable bin/TestWebKitAPI/EWebKit2/test_ewk2_window_features [34/94] Linking CXX shared library lib/libTestRunnerInjectedBundle.so [35/94] Linking CXX executable bin/WebKitTestRunner [36/94] Linking CXX executable bin/MiniBrowser [37/94] Linking CXX executable bin/CanHandleRequest [38/94] Linking CXX executable bin/TestWebKitAPI/WebKit2/AboutBlankLoad [39/94] Linking CXX executable bin/TestWebKitAPI/WebKit2/CookieManager [40/94] Linking CXX executable bin/ResizeReversePaginatedWebView [41/94] Linking CXX executable bin/DOMWindowExtensionBasic [42/94] Linking CXX executable bin/TestWebKitAPI/WebKit2/DOMWindowExtensionNoCache [43/94] Linking CXX executable bin/TestWebKitAPI/WebKit2/DidAssociateFormControls [44/94] Linking CXX executable bin/TestWebKitAPI/WebKit2/DocumentStartUserScriptAlertCrash [45/94] Linking CXX executable bin/DownloadDecideDestinationCrash [46/94] Linking CXX executable bin/TestWebKitAPI/WebKit2/EvaluateJavaScript [47/94] Linking CXX executable bin/TestWebKitAPI/WebKit2/FailedLoad [48/94] Linking CXX executable bin/TestWebKitAPI/WebKit2/Find [49/94] Linking CXX executable bin/TestWebKitAPI/WebKit2/FrameMIMETypeHTML [50/94] Linking CXX executable bin/TestWebKitAPI/WebKit2/ForceRepaint [51/94] Linking CXX executable bin/Geolocation [52/94] Linking CXX executable bin/TestWebKitAPI/WebKit2/FrameMIMETypePNG [53/94] Linking CXX executable bin/TestWebKitAPI/WebKit2/GetInjectedBundleInitializationUserDataCallback [54/94] Linking CXX executable bin/TestWebKitAPI/WebKit2/HitTestResultNodeHandle [55/94] Linking CXX executable bin/TestWebKitAPI/WebKit2/InjectedBundleBasic [56/94] Linking CXX executable bin/TestWebKitAPI/WebKit2/InjectedBundleFrameHitTest [57/94] Linking CXX executable bin/TestWebKitAPI/WebKit2/InjectedBundleInitializationUserDataCallbackWins [58/94] Linking CXX executable bin/TestWebKitAPI/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL [59/94] Linking CXX executable bin/TestWebKitAPI/WebKit2/LoadCanceledNoServerRedirectCallback [60/94] Linking CXX executable bin/TestWebKitAPI/WebCore/LayoutUnit [61/94] Linking CXX executable bin/LoadPageOnCrash [62/94] Linking CXX executable bin/NewFirstVisuallyNonEmptyLayoutFrames [63/94] Linking CXX executable bin/MouseMoveAfterCrash [64/94] Linking CXX executable bin/TestWebKitAPI/WebKit2/NewFirstVisuallyNonEmptyLayout [65/94] Linking CXX executable bin/TestWebKitAPI/WebKit2/NewFirstVisuallyNonEmptyLayoutFails [66/94] Linking CXX executable bin/TestWebKitAPI/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages [67/94] Linking CXX executable bin/TestWebKitAPI/WebKit2/PageLoadBasic [68/94] Linking CXX executable bin/TestWebKitAPI/WebKit2/PageLoadDidChangeLocationWithinPageForFrame [69/94] Linking CXX executable bin/TestWebKitAPI/WebKit2/PreventEmptyUserAgent [70/94] Linking CXX executable bin/TestWebKitAPI/WebKit2/ParentFrame [71/94] Linking CXX executable bin/TestWebKitAPI/WebKit2/PrivateBrowsingPushStateNoHistoryCallback [72/94] Linking CXX executable bin/ReloadPageAfterCrash [73/94] Linking CXX executable bin/TestWebKitAPI/WebKit2/ShouldGoToBackForwardListItem [74/94] Linking CXX executable bin/ResizeWindowAfterCrash [75/94] Linking CXX executable bin/TestWebKitAPI/WebKit2/ResponsivenessTimerDoesntFireEarly [76/94] Linking CXX executable bin/RestoreSessionStateContainingFormData [77/94] Linking CXX executable bin/ScrollPinningBehaviors [78/94] Linking CXX executable bin/TestWebKitAPI/JavaScriptCore/TestJavaScriptCore [79/94] Linking CXX executable bin/TestWebKitAPI/WebKit2/TerminateTwice [80/94] Linking CXX executable bin/TestWebKitAPI/WTF/TestWTF [81/94] Linking CXX shared library lib/libTestWebKitAPIInjectedBundle.so [82/94] Linking CXX executable bin/TestWebKitAPI/WebCore/URL [83/94] Linking CXX executable bin/UserMessage [84/94] Linking CXX executable bin/WKPageGetScaleFactorNotZero [85/94] Linking CXX executable bin/TestWebKitAPI/WebKit2/WKPreferences [86/94] Linking CXX executable bin/TestWebKitAPI/WebKit2/WKStringJSString [87/94] Linking CXX executable bin/TestWebKitAPI/WebKit2/WKURL [88/94] Linking CXX executable bin/TestWebKitAPI/WebKit2/WKString [89/94] Linking CXX executable bin/TestWebKitAPI/WebKit2/WKViewScrollTo [90/94] Linking CXX executable bin/TestWebKitAPI/WebKit2/WKViewClientWebProcessCallbacks [91/94] Linking CXX executable bin/TestWebKitAPI/WebKit2/WKViewRestoreZoomAndScrollBackForward [92/94] Linking CXX executable bin/TestWebKitAPI/WebKit2/WKViewUserViewportToContents [93/94] Linking CXX executable bin/WillLoad [94/94] Linking CXX executable bin/TestWebKitAPI/WebKit2/WillSendSubmitEvent This bug is to speedup relinking with using ld.gold instead of the very slow ld. 1043420 1 ossy 2014-10-22 05:03:33 -0700 Using ld.gold decreased the incremental build time from 1m51s to 50s when CMake always runs. After applying the optimization from bug137949 not to run CMake always, the build time is only 22s instead of the original 1m51s. 1043421 2 240267 ossy 2014-10-22 05:11:55 -0700 Created attachment 240267 WIP patch WIP patch, added a platform independent USE_GOLD_LINKER option, disabled by default. It can be enabled with build-webkit --cmakeargs="-DUSE_GOLD_LINKER=ON" 1043422 3 ossy 2014-10-22 05:19:13 -0700 cc-ing GTK folks too, maybe you are interested in it too. (The patch is based on your great DEBUG_FISSION option) The question is if we should make using ld.gold default or not. In this case I meant it can be disabled manually or the config could disable it automatically if it isn't available. (with or without warning the developer) Or do you think if using gold linker should be disabled by default for some reason, and should be an opt-in option? 1043428 4 clopez 2014-10-22 05:36:40 -0700 (In reply to comment #3) > cc-ing GTK folks too, maybe you are interested in it too. > (The patch is based on your great DEBUG_FISSION option) > > The question is if we should make using ld.gold default or not. > In this case I meant it can be disabled manually or the config > could disable it automatically if it isn't available. (with or > without warning the developer) > > Or do you think if using gold linker should be disabled by default > for some reason, and should be an opt-in option? We are using gold on the GTK buildbots, but we resort to the path trick: export PATH="/usr/lib/gold-ld:${PATH}" I never heard before of this "-fuse-ld=gold" parameter. Is that option supported upstream? because after a bit of googling it seems to be a debian/ubuntu only thing. So perhaps that can break non debian-based (fedora/arch/suse/tizen..). Check: https://bugs.webkit.org/show_bug.cgi?id=89312 1043430 5 berto 2014-10-22 05:59:20 -0700 (In reply to comment #4) > I never heard before of this "-fuse-ld=gold" parameter. It seems to be a normal GCC option: https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html I don't know when it was introduced, though. Probably not long ago. I don't have anything against using gold by default if available as long as it doesn't break the build with one of our supported versions of gcc. Then again it's also something that users can set up themselves easily in their build environments (in fact that's what I do), so ... 1043431 6 ossy 2014-10-22 05:59:44 -0700 I checked, it is available in upstream GCC too from 4.8.0: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55470 WebKit requires at least 4.7: http://trac.webkit.org/browser/trunk/Source/WTF/wtf/Compiler.h?order=name#L68 But it isn't a problem, because the cmake script can check if fuse-ls=gold GCC option is available or not. If no, we simply don't add it to C(XX)FLAGS. 1046788 7 241101 ossy 2014-11-06 05:48:30 -0800 Created attachment 241101 Patch I think we should use ld.gold if it is available, and disable it only if it isn't available. 1046789 8 commit-queue 2014-11-06 05:51:29 -0800 Attachment 241101 did not pass style-queue: ERROR: Source/cmake/OptionsCommon.cmake:52: One space between command "else" and its parentheses, should be "else (" [whitespace/parentheses] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1046790 9 241102 ossy 2014-11-06 05:53:07 -0800 Created attachment 241102 Patch style fixed 1048112 10 ossy 2014-11-11 23:42:06 -0800 any opinion? pros/cons? 1049903 11 ossy 2014-11-19 14:01:26 -0800 ping? 1050116 12 berto 2014-11-20 05:40:22 -0800 Hey, I don't really have a strong opinion about the idea of using gold by default. As I said earlier, choosing which linker to use is already easy enough My question is: how would you disable it with your patch? Is there an easy way to use the GNU linker even if gold is available? 1050121 13 ossy 2014-11-20 06:35:17 -0800 (In reply to comment #12) > Hey, I don't really have a strong opinion about the idea of using gold > by default. As I said earlier, choosing which linker to use is already > easy enough Yes, it is easy, you have to copy ld.gold somewhere else with ld name and put it in the path before the normal ld. Why not use it by default everywhere without local hacking? Now ld.bfd is the default and I would like to change it to ld.gold. > My question is: how would you disable it with your patch? Is there an > easy way to use the GNU linker even if gold is available? Good point, it isn't trivial with the attached patch. I'll update it immediately to let folks use the good old linker too. 1050122 14 241944 ossy 2014-11-20 06:39:08 -0800 Created attachment 241944 Patch Now ld.gold is used if it is available and isn't disabled explicitly with USE_LD_GOLD=OFF option. Additionally I removed the redundant check from DEBUG_FISSION code path. 1050123 15 berto 2014-11-20 07:03:59 -0800 (In reply to comment #13) > > choosing which linker to use is already easy enough > Yes, it is easy, you have to copy ld.gold somewhere else with ld > name and put it in the path before the normal ld. You don't really need to copy anything: $ PATH=/usr/lib/gold-ld:$PATH Tools/Scripts/build-webkit ... > Good point, it isn't trivial with the attached patch. I'll update it > immediately to let folks use the good old linker too. This patch looks good to me, thanks! 1050124 16 ossy 2014-11-20 07:07:33 -0800 (In reply to comment #15) > You don't really need to copy anything: > $ PATH=/usr/lib/gold-ld:$PATH Tools/Scripts/build-webkit ... Good point, I didn't realize that gold-ld directory is installed by default. :) 1050382 17 241944 cgarcia 2014-11-20 22:52:26 -0800 Comment on attachment 241944 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241944&action=review > ChangeLog:3 > + [EFL] Use ld.gold if it is available to speedup builds Please, remove the EFL prefix from the ChangeLog and commit message before landing this. 1050387 18 ossy 2014-11-20 23:06:24 -0800 Committed r176442: <http://trac.webkit.org/changeset/176442> 240267 2014-10-22 05:11:55 -0700 2014-11-06 05:48:24 -0800 WIP patch bug-137953-20141022141200.patch text/plain 1677 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1MDI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0NvbW1vbi5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCmluZGV4 IGZmY2RmZTUyOTY4NDAxOTUxMmY5NDc5NmRiMjZmYjQwMWQxMTBlZmQuLmI4YzMzY2JhMjIzNmI0 NDZjN2NjMGMzZGRlODJjZDgwYzBiYTFjMGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRp b25zQ29tbW9uLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCkBA IC0zMCw2ICszMCwxNiBAQCBpZiAoQ01BS0VfQ09NUElMRVJfSVNfR05VQ1hYIE9SICIke0NNQUtF X0NYWF9DT01QSUxFUl9JRH0iIFNUUkVRVUFMICJDbGFuZyIpCiAgICAgc2V0KENNQUtFX0NYWF9G TEFHUyAiJHtDTUFLRV9DWFhfRkxBR1N9IC1zdGQ9YysrMTEiKQogZW5kaWYgKCkKIAorb3B0aW9u KFVTRV9HT0xEX0xJTktFUiAiVXNlIEdudSBnb2xkIGxpbmtlciBpbnN0ZWFkIG9mIEdOVSBsZCIp CitpZiAoVVNFX0dPTERfTElOS0VSKQorICAgIGV4ZWN1dGVfcHJvY2VzcyhDT01NQU5EICR7Q01B S0VfQ19DT01QSUxFUn0gLWZ1c2UtbGQ9Z29sZCAtV2wsLS12ZXJzaW9uIEVSUk9SX1FVSUVUIE9V VFBVVF9WQVJJQUJMRSBMRF9WRVJTSU9OKQorICAgIGlmIChOT1QgIiR7TERfVkVSU0lPTn0iIE1B VENIRVMgIkdOVSBnb2xkIikKKyAgICAgICAgbWVzc2FnZShGQVRBTF9FUlJPUiAiR05VIGdvbGQg bGlua2VyIGlzbid0IGF2YWlsYWJsZS4iKQorICAgIGVuZGlmICgpCisgICAgc2V0KENNQUtFX0Nf RkxBR1MgIiR7Q01BS0VfQ19GTEFHU30gLWZ1c2UtbGQ9Z29sZCIpCisgICAgc2V0KENNQUtFX0NY WF9GTEFHUyAiJHtDTUFLRV9DWFhfRkxBR1N9IC1mdXNlLWxkPWdvbGQiKQorZW5kaWYgKCkKKwog b3B0aW9uKERFQlVHX0ZJU1NJT04gIlVzZSBEZWJ1ZyBGaXNzaW9uIHN1cHBvcnQiKQogaWYgKERF QlVHX0ZJU1NJT04pCiAgICAgZXhlY3V0ZV9wcm9jZXNzKENPTU1BTkQgJHtDTUFLRV9DX0NPTVBJ TEVSfSAtZnVzZS1sZD1nb2xkIC1XbCwtLXZlcnNpb24gRVJST1JfUVVJRVQgT1VUUFVUX1ZBUklB QkxFIExEX1ZFUlNJT04pCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXgg NjFjOGRiNzkyNGY4MDM3OTQwYjYyOGFjMDZhYWMwODZiMmI3YmEyNS4uMmVjNGU0ODJhOThmNDQx NjFkNjZmY2MyMDhlYjM3MTE1OGY2MzhlOSAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0No YW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE0LTEwLTIyICBDc2FiYSBPc3p0cm9nb27DoWMg IDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgW0VGTF0gVXNlIGxkLmdvbGQgaWYgaXQgaXMg YXZhaWxhYmxlIHRvIHNwZWVkdXAgYnVpbGRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMzc5NTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlOgor CiAyMDE0LTEwLTIxICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBnbWFpbC5jb20+CiAKICAgICAg ICAgW0VGTF0gUmVtb3ZlIHVubmVjZXNzYXJ5IEVOQUJMRV8zRF9SRU5ERVJJTkcgZGVmaW5pdGlv biBmcm9tIE9wdGlvbnNFZmwuY21ha2UK 241101 2014-11-06 05:48:30 -0800 2014-11-06 05:53:00 -0800 Patch bug-137953-20141106144840.patch text/plain 2073 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1NjkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0NvbW1vbi5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCmluZGV4 IGFiMjMwOWJiYTFmZmYwZjQ1MWNmZTA5MzZjYzMxZjVkMjViMmVlYjQuLjI0OGNiMWYwMzEzNWRh ODZhNzQ4MWQ2ZDZkYmU1OWFkMzhkNzhkYzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRp b25zQ29tbW9uLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCkBA IC00NCwxNCArNDQsMjMgQEAgaWYgKFdURl9DUFVfQVJNNjRfQ09SVEVYQTUzKQogICAgIGVuZGlm ICgpCiBlbmRpZiAoKQogCisjIFVzZSBsZC5nb2xkIGlmIGl0IGlzIGF2YWlsYWJsZQorZXhlY3V0 ZV9wcm9jZXNzKENPTU1BTkQgJHtDTUFLRV9DX0NPTVBJTEVSfSAtZnVzZS1sZD1nb2xkIC1XbCwt LXZlcnNpb24gRVJST1JfUVVJRVQgT1VUUFVUX1ZBUklBQkxFIExEX1ZFUlNJT04pCitpZiAoIiR7 TERfVkVSU0lPTn0iIE1BVENIRVMgIkdOVSBnb2xkIikKKyAgICBzZXQoQ01BS0VfQ19GTEFHUyAi JHtDTUFLRV9DX0ZMQUdTfSAtZnVzZS1sZD1nb2xkIikKKyAgICBzZXQoQ01BS0VfQ1hYX0ZMQUdT ICIke0NNQUtFX0NYWF9GTEFHU30gLWZ1c2UtbGQ9Z29sZCIpCitlbHNlKCkKKyAgICBtZXNzYWdl KFdBUk5JTkcgIkdOVSBnb2xkIGxpbmtlciBpc24ndCBhdmFpbGFibGUsIHVzaW5nIHRoZSBkZWZh dWx0IHN5c3RlbSBsaW5rZXIuIikKK2VuZGlmICgpCisKIG9wdGlvbihERUJVR19GSVNTSU9OICJV c2UgRGVidWcgRmlzc2lvbiBzdXBwb3J0IikKIGlmIChERUJVR19GSVNTSU9OKQogICAgIGV4ZWN1 dGVfcHJvY2VzcyhDT01NQU5EICR7Q01BS0VfQ19DT01QSUxFUn0gLWZ1c2UtbGQ9Z29sZCAtV2ws LS12ZXJzaW9uIEVSUk9SX1FVSUVUIE9VVFBVVF9WQVJJQUJMRSBMRF9WRVJTSU9OKQogICAgIGlm IChOT1QgIiR7TERfVkVSU0lPTn0iIE1BVENIRVMgIkdOVSBnb2xkIikKICAgICAgICAgbWVzc2Fn ZShGQVRBTF9FUlJPUiAiTmVlZCBHTlUgZ29sZCBsaW5rZXIgZm9yIERlYnVnIEZpc3Npb24gc3Vw cG9ydCIpCiAgICAgZW5kaWYgKCkKLSAgICBzZXQoQ01BS0VfQ19GTEFHUyAiJHtDTUFLRV9DX0ZM QUdTfSAtZ3NwbGl0LWR3YXJmIC1mdXNlLWxkPWdvbGQiKQotICAgIHNldChDTUFLRV9DWFhfRkxB R1MgIiR7Q01BS0VfQ1hYX0ZMQUdTfSAtZ3NwbGl0LWR3YXJmIC1mdXNlLWxkPWdvbGQiKQorICAg IHNldChDTUFLRV9DX0ZMQUdTICIke0NNQUtFX0NfRkxBR1N9IC1nc3BsaXQtZHdhcmYiKQorICAg IHNldChDTUFLRV9DWFhfRkxBR1MgIiR7Q01BS0VfQ1hYX0ZMQUdTfSAtZ3NwbGl0LWR3YXJmIikK ICAgICBzZXQoQ01BS0VfRVhFX0xJTktFUl9GTEFHUyAiJHtDTUFLRV9FWEVfTElOS0VSX0ZMQUdT fSAtV2wsLS1nZGItaW5kZXgiKQogICAgIHNldChDTUFLRV9TSEFSRURfTElOS0VSX0ZMQUdTICIk e0NNQUtFX0VYRV9MSU5LRVJfRkxBR1N9IC1XbCwtLWdkYi1pbmRleCIpCiBlbmRpZiAoKQpkaWZm IC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDllZGQ4YmIwOTIyNzBjNjA4Mzg4 ODUwMzFlMTQxY2RiZGM2NjI4MGMuLjllOTM2N2NlNjEzNGUyNmVkYzBhM2JjMDQ4ZjI2M2FmNmEy OGRkNDAgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx MiBAQAorMjAxNC0xMS0wNiAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgor CisgICAgICAgIFtFRkxdIFVzZSBsZC5nb2xkIGlmIGl0IGlzIGF2YWlsYWJsZSB0byBzcGVlZHVw IGJ1aWxkcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTM3OTUzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBTb3VyY2UvY21ha2UvT3B0aW9uc0NvbW1vbi5jbWFrZToKKwogMjAxNC0xMS0wMyAgRGVhbiBK YWNrc29uICA8ZGlub0BhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIEVOQUJMRV9GSUxURVJTX0xF VkVMXzIgZmVhdHVyZSBndWFyZC4K 241102 2014-11-06 05:53:07 -0800 2014-11-20 06:38:59 -0800 Patch bug-137953-20141106145317.patch text/plain 2074 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1NjkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0NvbW1vbi5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCmluZGV4 IGFiMjMwOWJiYTFmZmYwZjQ1MWNmZTA5MzZjYzMxZjVkMjViMmVlYjQuLmQ4ZWJiZTM2ZDg4MjBj YTAwZjgzMzRkY2VjMWFhM2UwMTI2ODcyMmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRp b25zQ29tbW9uLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCkBA IC00NCwxNCArNDQsMjMgQEAgaWYgKFdURl9DUFVfQVJNNjRfQ09SVEVYQTUzKQogICAgIGVuZGlm ICgpCiBlbmRpZiAoKQogCisjIFVzZSBsZC5nb2xkIGlmIGl0IGlzIGF2YWlsYWJsZQorZXhlY3V0 ZV9wcm9jZXNzKENPTU1BTkQgJHtDTUFLRV9DX0NPTVBJTEVSfSAtZnVzZS1sZD1nb2xkIC1XbCwt LXZlcnNpb24gRVJST1JfUVVJRVQgT1VUUFVUX1ZBUklBQkxFIExEX1ZFUlNJT04pCitpZiAoIiR7 TERfVkVSU0lPTn0iIE1BVENIRVMgIkdOVSBnb2xkIikKKyAgICBzZXQoQ01BS0VfQ19GTEFHUyAi JHtDTUFLRV9DX0ZMQUdTfSAtZnVzZS1sZD1nb2xkIikKKyAgICBzZXQoQ01BS0VfQ1hYX0ZMQUdT ICIke0NNQUtFX0NYWF9GTEFHU30gLWZ1c2UtbGQ9Z29sZCIpCitlbHNlICgpCisgICAgbWVzc2Fn ZShXQVJOSU5HICJHTlUgZ29sZCBsaW5rZXIgaXNuJ3QgYXZhaWxhYmxlLCB1c2luZyB0aGUgZGVm YXVsdCBzeXN0ZW0gbGlua2VyLiIpCitlbmRpZiAoKQorCiBvcHRpb24oREVCVUdfRklTU0lPTiAi VXNlIERlYnVnIEZpc3Npb24gc3VwcG9ydCIpCiBpZiAoREVCVUdfRklTU0lPTikKICAgICBleGVj dXRlX3Byb2Nlc3MoQ09NTUFORCAke0NNQUtFX0NfQ09NUElMRVJ9IC1mdXNlLWxkPWdvbGQgLVds LC0tdmVyc2lvbiBFUlJPUl9RVUlFVCBPVVRQVVRfVkFSSUFCTEUgTERfVkVSU0lPTikKICAgICBp ZiAoTk9UICIke0xEX1ZFUlNJT059IiBNQVRDSEVTICJHTlUgZ29sZCIpCiAgICAgICAgIG1lc3Nh Z2UoRkFUQUxfRVJST1IgIk5lZWQgR05VIGdvbGQgbGlua2VyIGZvciBEZWJ1ZyBGaXNzaW9uIHN1 cHBvcnQiKQogICAgIGVuZGlmICgpCi0gICAgc2V0KENNQUtFX0NfRkxBR1MgIiR7Q01BS0VfQ19G TEFHU30gLWdzcGxpdC1kd2FyZiAtZnVzZS1sZD1nb2xkIikKLSAgICBzZXQoQ01BS0VfQ1hYX0ZM QUdTICIke0NNQUtFX0NYWF9GTEFHU30gLWdzcGxpdC1kd2FyZiAtZnVzZS1sZD1nb2xkIikKKyAg ICBzZXQoQ01BS0VfQ19GTEFHUyAiJHtDTUFLRV9DX0ZMQUdTfSAtZ3NwbGl0LWR3YXJmIikKKyAg ICBzZXQoQ01BS0VfQ1hYX0ZMQUdTICIke0NNQUtFX0NYWF9GTEFHU30gLWdzcGxpdC1kd2FyZiIp CiAgICAgc2V0KENNQUtFX0VYRV9MSU5LRVJfRkxBR1MgIiR7Q01BS0VfRVhFX0xJTktFUl9GTEFH U30gLVdsLC0tZ2RiLWluZGV4IikKICAgICBzZXQoQ01BS0VfU0hBUkVEX0xJTktFUl9GTEFHUyAi JHtDTUFLRV9FWEVfTElOS0VSX0ZMQUdTfSAtV2wsLS1nZGItaW5kZXgiKQogZW5kaWYgKCkKZGlm ZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA5ZWRkOGJiMDkyMjcwYzYwODM4 ODg1MDMxZTE0MWNkYmRjNjYyODBjLi45ZTkzNjdjZTYxMzRlMjZlZGMwYTNiYzA0OGYyNjNhZjZh MjhkZDQwIDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTIgQEAKKzIwMTQtMTEtMDYgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4K KworICAgICAgICBbRUZMXSBVc2UgbGQuZ29sZCBpZiBpdCBpcyBhdmFpbGFibGUgdG8gc3BlZWR1 cCBidWlsZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEzNzk1MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogU291cmNlL2NtYWtlL09wdGlvbnNDb21tb24uY21ha2U6CisKIDIwMTQtMTEtMDMgIERlYW4g SmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBFTkFCTEVfRklMVEVSU19M RVZFTF8yIGZlYXR1cmUgZ3VhcmQuCg== 241944 2014-11-20 06:39:08 -0800 2014-11-20 23:07:06 -0800 Patch bug-137953-20141120153921.patch text/plain 2274 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTc2MzkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0NvbW1vbi5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCmluZGV4 IGM3NmFhOTBkZWQ3N2RlYjk3MTYxOTQxZGIzNGEwYjA1OWJhMWQxNzguLmQ5MTcxNTM0NzE4NTZl MWViZWU2NmI1Y2I2NzhmMjYyYzRhN2RhYTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRp b25zQ29tbW9uLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCkBA IC02MCwxNCArNjAsMjUgQEAgaWYgKFdURl9DUFVfQVJNNjRfQ09SVEVYQTUzKQogICAgIGVuZGlm ICgpCiBlbmRpZiAoKQogCisjIFVzZSBsZC5nb2xkIGlmIGl0IGlzIGF2YWlsYWJsZSBhbmQgaXNu J3QgZGlzYWJsZWQgZXhwbGljaXRseQorb3B0aW9uKFVTRV9MRF9HT0xEICJVc2UgR05VIGdvbGQg bGlua2VyIiBPTikKK2lmIChVU0VfTERfR09MRCkKKyAgICBleGVjdXRlX3Byb2Nlc3MoQ09NTUFO RCAke0NNQUtFX0NfQ09NUElMRVJ9IC1mdXNlLWxkPWdvbGQgLVdsLC0tdmVyc2lvbiBFUlJPUl9R VUlFVCBPVVRQVVRfVkFSSUFCTEUgTERfVkVSU0lPTikKKyAgICBpZiAoIiR7TERfVkVSU0lPTn0i IE1BVENIRVMgIkdOVSBnb2xkIikKKyAgICAgICAgc2V0KENNQUtFX0NfRkxBR1MgIiR7Q01BS0Vf Q19GTEFHU30gLWZ1c2UtbGQ9Z29sZCIpCisgICAgICAgIHNldChDTUFLRV9DWFhfRkxBR1MgIiR7 Q01BS0VfQ1hYX0ZMQUdTfSAtZnVzZS1sZD1nb2xkIikKKyAgICBlbHNlICgpCisgICAgICAgIG1l c3NhZ2UoV0FSTklORyAiR05VIGdvbGQgbGlua2VyIGlzbid0IGF2YWlsYWJsZSwgdXNpbmcgdGhl IGRlZmF1bHQgc3lzdGVtIGxpbmtlci4iKQorICAgIGVuZGlmICgpCitlbmRpZiAoKQorCiBvcHRp b24oREVCVUdfRklTU0lPTiAiVXNlIERlYnVnIEZpc3Npb24gc3VwcG9ydCIpCiBpZiAoREVCVUdf RklTU0lPTikKLSAgICBleGVjdXRlX3Byb2Nlc3MoQ09NTUFORCAke0NNQUtFX0NfQ09NUElMRVJ9 IC1mdXNlLWxkPWdvbGQgLVdsLC0tdmVyc2lvbiBFUlJPUl9RVUlFVCBPVVRQVVRfVkFSSUFCTEUg TERfVkVSU0lPTikKLSAgICBpZiAoTk9UICIke0xEX1ZFUlNJT059IiBNQVRDSEVTICJHTlUgZ29s ZCIpCisgICAgaWYgKE5PVCBVU0VfTERfR09MRCkKICAgICAgICAgbWVzc2FnZShGQVRBTF9FUlJP UiAiTmVlZCBHTlUgZ29sZCBsaW5rZXIgZm9yIERlYnVnIEZpc3Npb24gc3VwcG9ydCIpCiAgICAg ZW5kaWYgKCkKLSAgICBzZXQoQ01BS0VfQ19GTEFHUyAiJHtDTUFLRV9DX0ZMQUdTfSAtZ3NwbGl0 LWR3YXJmIC1mdXNlLWxkPWdvbGQiKQotICAgIHNldChDTUFLRV9DWFhfRkxBR1MgIiR7Q01BS0Vf Q1hYX0ZMQUdTfSAtZ3NwbGl0LWR3YXJmIC1mdXNlLWxkPWdvbGQiKQorICAgIHNldChDTUFLRV9D X0ZMQUdTICIke0NNQUtFX0NfRkxBR1N9IC1nc3BsaXQtZHdhcmYiKQorICAgIHNldChDTUFLRV9D WFhfRkxBR1MgIiR7Q01BS0VfQ1hYX0ZMQUdTfSAtZ3NwbGl0LWR3YXJmIikKICAgICBzZXQoQ01B S0VfRVhFX0xJTktFUl9GTEFHUyAiJHtDTUFLRV9FWEVfTElOS0VSX0ZMQUdTfSAtV2wsLS1nZGIt aW5kZXgiKQogICAgIHNldChDTUFLRV9TSEFSRURfTElOS0VSX0ZMQUdTICIke0NNQUtFX0VYRV9M SU5LRVJfRkxBR1N9IC1XbCwtLWdkYi1pbmRleCIpCiBlbmRpZiAoKQpkaWZmIC0tZ2l0IGEvQ2hh bmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDg4OGNlZWQxZGZhYmM2YmE2Mzk0ZGEwMWU5NmY0ZmRj ZWZiZGI1YjguLjVhZTFkMmIxZDAxNmQ0ZDg4OWEwMDhhYTA5NGU2NmRlMjE4OTczNjEgMTAwNjQ0 Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxNC0x MS0yMCAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgorCisgICAgICAgIFtF RkxdIFVzZSBsZC5nb2xkIGlmIGl0IGlzIGF2YWlsYWJsZSB0byBzcGVlZHVwIGJ1aWxkcworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM3OTUzCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTb3VyY2UvY21h a2UvT3B0aW9uc0NvbW1vbi5jbWFrZToKKwogMjAxNC0xMS0xOSAgQWtvcyBLaXNzICA8YWtpc3NA aW5mLnUtc3plZ2VkLmh1PgogCiAgICAgICAgIEZpeCB0aGUgZGV0ZWN0aW9uIG9mIHRvb2xjaGFp biBzdXBwb3J0IGZvciBDb3J0ZXgtQTUzIGVycmF0dW0gODM1NzY5IHdvcmthcm91bmQK