137949 2014-10-22 04:10:57 -0700 [EFL] build-webkit should try harder to avoid re-running cmake 2014-10-29 03:45:29 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 137818 1 ossy ossy cgarcia commit-queue dbates gyuyoung.kim mrobinson ossy ryuan.choi oldest_to_newest 1043404 0 ossy 2014-10-22 04:10:57 -0700 GTK already re-run cmake only if it is necessary: http://trac.webkit.org/changeset/162545 ( bug127073 ) I think the configuration change detection in shouldRemoveCMakeCache() is safe, and it seems it has worked well since half years for GTK. So I propose to use this mechanism for EFL port too. It would make incremantal build faster for developers and buildbots too. 1043409 1 240262 ossy 2014-10-22 04:19:41 -0700 Created attachment 240262 Patch 1043414 2 ossy 2014-10-22 04:25:54 -0700 This change decreased the incremental build time from 36 seconds to 8 seconds on my desktop machine if I didn't touch any files. 1044735 3 240262 commit-queue 2014-10-29 03:45:24 -0700 Comment on attachment 240262 Patch Clearing flags on attachment: 240262 Committed r175327: <http://trac.webkit.org/changeset/175327> 1044736 4 commit-queue 2014-10-29 03:45:29 -0700 All reviewed patches have been landed. Closing bug. 240262 2014-10-22 04:19:41 -0700 2014-10-29 03:45:24 -0700 Patch bug-137949-20141022131946.patch text/plain 1896 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1MDI4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDA0OTU2ZWQyYjczM2FiZjY1NGYwNmY1OGU4NWU2MDVk YmRkYWYxMC4uYzA2MWU0NGExNTVkMmIzOTBiYTgwYjQ0ODRhMTczMGEyMGE5NzQ3ZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE0LTEwLTIyICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisK KyAgICAgICAgW0VGTF0gYnVpbGQtd2Via2l0IHNob3VsZCB0cnkgaGFyZGVyIHRvIGF2b2lkIHJl LXJ1bm5pbmcgY21ha2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEzNzk0OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBtOgorICAgICAgICAoc2hvdWxkUmVtb3ZlQ01h a2VDYWNoZSk6IERvbid0IHJlbW92ZSBDTWFrZUNhY2hlIHVuY29uZGl0aW9uYWxseSBmb3IgRUZM LgorICAgICAgICAoZ2VuZXJhdGVCdWlsZFN5c3RlbUZyb21DTWFrZVByb2plY3QpOiBDb21tZW50 IGZpeCBhZnRlciByMTc0NjgxLgorCiAyMDE0LTEwLTIxICBBbGV4ZXkgUHJvc2t1cnlha292ICA8 YXBAYXBwbGUuY29tPgogCiAgICAgICAgIGJ1aWxkLndlYmtpdC5vcmcvZGFzaGJvYXJkOiBDYW5u b3QgY2xpY2sgb24gZ3JlZW4gdGVzdGVyIGJ1YmJsZXMKZGlmZiAtLWdpdCBhL1Rvb2xzL1Njcmlw dHMvd2Via2l0ZGlycy5wbSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQppbmRleCBkZGM0 OWYwZDAxNWZkMzQzYjljNmY5Y2U4YTBjOGMxMTQ0ZGQ2M2Y3Li43ODA5YTllZmJjMGRkM2I0OTNi Y2Q2MmMyMzA0MTMyODQ2ZjM4ZGU2IDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRp cnMucG0KKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCkBAIC0xNjgyLDEwICsxNjgy LDYgQEAgc3ViIHNob3VsZFJlbW92ZUNNYWtlQ2FjaGUoQCkKIHsKICAgICBteSAoJGNhY2hlRmls ZVBhdGgsIEBidWlsZEFyZ3MpID0gQF87CiAKLSAgICBpZiAoIWlzR3RrKCkpIHsKLSAgICAgICAg cmV0dXJuIDE7Ci0gICAgfQotCiAgICAgIyBXZSBjaGVjayB0aGlzIGZpcnN0LCBiZWNhdXNlIHdl IGFsd2F5cyB3YW50IHRvIGNyZWF0ZSB0aGlzIGZpbGUgZm9yIGEgZnJlc2ggYnVpbGQuCiAgICAg bXkgJHByb2R1Y3REaXIgPSBGaWxlOjpTcGVjLT5jYXRkaXIoYmFzZVByb2R1Y3REaXIoKSwgY29u ZmlndXJhdGlvbigpKTsKICAgICBteSAkb3B0aW9uc0NhY2hlID0gRmlsZTo6U3BlYy0+Y2F0ZGly KCRwcm9kdWN0RGlyLCAiYnVpbGQtd2Via2l0LW9wdGlvbnMudHh0Iik7CkBAIC0xNzU5LDcgKzE3 NTUsNyBAQCBzdWIgZ2VuZXJhdGVCdWlsZFN5c3RlbUZyb21DTWFrZVByb2plY3QKICAgICBteSAk b3JpZ2luYWxXb3JraW5nRGlyZWN0b3J5ID0gZ2V0Y3dkKCk7CiAgICAgY2hkaXIoJGJ1aWxkUGF0 aCkgb3IgZGllOwogCi0gICAgIyBGb3IgR1RLKyB3ZSB0cnkgdG8gYmUgc21hcnQgYWJvdXQgd2hl biB0byByZXJ1biBjbWFrZSwgc28gdGhhdCB3ZSBjYW4gaGF2ZSBmYXN0ZXIgaW5jcmVtZW50YWwg YnVpbGRzLgorICAgICMgV2UgdHJ5IHRvIGJlIHNtYXJ0IGFib3V0IHdoZW4gdG8gcmVydW4gY21h a2UsIHNvIHRoYXQgd2UgY2FuIGhhdmUgZmFzdGVyIGluY3JlbWVudGFsIGJ1aWxkcy4KICAgICBt eSAkd2lsbFVzZU5pbmphID0gY2FuVXNlTmluamEoKTsKICAgICBpZiAoLWUgY21ha2VDYWNoZVBh dGgoKSAmJiAtZSBjbWFrZUdlbmVyYXRlZEJ1aWxkZmlsZSgkd2lsbFVzZU5pbmphKSkgewogICAg ICAgICByZXR1cm4gMDsK