137948 2014-10-22 00:11:34 -0700 [EFL] webview should be updated from (0,0) when using the evasGL. 2015-05-26 18:08:51 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hs85.jeong hs85.jeong commit-queue gyuyoung.kim hw1008.kim lucas.de.marchi oldest_to_newest 1043376 0 hs85.jeong 2014-10-22 00:11:34 -0700 When using the evasGL, evas_object of webview have to update from (0,0) to the size of webview. 1043378 1 hs85.jeong 2014-10-22 00:15:26 -0700 Now, webview didn't update the part of top in minibrowser. You can watch this error when scrolling the any page. 1043383 2 240255 hs85.jeong 2014-10-22 01:23:52 -0700 Created attachment 240255 Patch 1043413 3 hs85.jeong 2014-10-22 04:25:31 -0700 Hyowon, Could review this patch? 1043416 4 hs85.jeong 2014-10-22 04:26:41 -0700 Could you review this patch? 1043554 5 240255 ryuan.choi 2014-10-22 14:35:13 -0700 Comment on attachment 240255 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240255&action=review > Source/WebKit2/UIProcess/API/efl/EwkView.cpp:564 > - // sd->image is tied to a native surface, which is in the parent's coordinates. > - evas_object_image_data_update_add(sd->image, sd->view.x, sd->view.y, sd->view.w, sd->view.h); > + // sd->image have to update as the size of webview from (0,0) when using the evasGL. > + evas_object_image_data_update_add(sd->image, 0, 0, sd->view.w, sd->view.h); I need more clear description about it. At least, I want to know how to reproduce the issue. If I remember correctly, it was tried but reverted long time ago. 1070057 6 246804 hs85.jeong 2015-02-17 23:34:37 -0800 Created attachment 246804 Patch 1087366 7 246804 gyuyoung.kim 2015-04-22 07:27:13 -0700 Comment on attachment 246804 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246804&action=review > Source/WebKit2/ChangeLog:3 > + [EFL] webview have to update from (0,0) to the size of webView after r180134. s/have/has/g > Source/WebKit2/ChangeLog:9 > + (EwkView::displayTimerFired): Changed the point of start position to update the evasobject. Could you explain what is problem now ? > Source/WebKit2/UIProcess/API/efl/EwkView.cpp:578 > + // sd->image have to update as the size of webview from (0,0) when using the evasGL. I don't understand this comment well. Do you mean sd->image should be updated from (0, 0) when we use evasGL for graphics backend ? 1087660 8 hs85.jeong 2015-04-22 17:42:28 -0700 (In reply to comment #7) > Comment on attachment 246804 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=246804&action=review > > > Source/WebKit2/ChangeLog:3 > > + [EFL] webview have to update from (0,0) to the size of webView after r180134. > > s/have/has/g > > > Source/WebKit2/ChangeLog:9 > > + (EwkView::displayTimerFired): Changed the point of start position to update the evasobject. > > Could you explain what is problem now ? In my Minibrowser, The top part of the screen wasn't updated. Looks like freeze. I try to test at other PC but that also occurred. Is your Minibrowser okay? > > > Source/WebKit2/UIProcess/API/efl/EwkView.cpp:578 > > + // sd->image have to update as the size of webview from (0,0) when using the evasGL. > > I don't understand this comment well. Do you mean sd->image should be > updated from (0, 0) when we use evasGL for graphics backend ? Yes, sd->image should be updated from (0,0) if using the graphics backend. 1087679 9 246804 gyuyoung.kim 2015-04-22 18:47:21 -0700 Comment on attachment 246804 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246804&action=review >>> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:578 >>> + // sd->image have to update as the size of webview from (0,0) when using the evasGL. >> >> I don't understand this comment well. Do you mean sd->image should be updated from (0, 0) when we use evasGL for graphics backend ? > > Yes, sd->image should be updated from (0,0) if using the graphics backend. I see. Please update this patch description and comment according to my comment again. 1087729 10 251405 hs85.jeong 2015-04-22 22:11:35 -0700 Created attachment 251405 Patch 1097280 11 251405 gyuyoung.kim 2015-05-26 00:32:05 -0700 Comment on attachment 251405 Patch It would be nicer if Ryuan has a final review before landing. 1097561 12 251405 commit-queue 2015-05-26 18:08:45 -0700 Comment on attachment 251405 Patch Clearing flags on attachment: 251405 Committed r184892: <http://trac.webkit.org/changeset/184892> 1097562 13 commit-queue 2015-05-26 18:08:51 -0700 All reviewed patches have been landed. Closing bug. 240255 2014-10-22 01:23:52 -0700 2015-02-17 23:34:29 -0800 Patch bug-137948-20141022172357.patch text/plain 1548 hs85.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0OTE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOTgyMzUxNzcyZmQwZWUz ZmRjMDEyZDBjZGQ2ZTJiMGNhYmIyYjA0Ni4uN2JhY2IyYmJjMjZjMDIxOTNlNDI2YzczNWM1NTI4 NWNmZDhiNDMzOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE0LTEwLTIyICBIdW5z ZW9wIEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSB3ZWJ2 aWV3IGhhdmUgdG8gdXBkYXRlIGZyb20gKDAsMCkgdG8gdGhlIHNpemUgb2Ygd2ViVmlldworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM3OTQ4CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv QVBJL2VmbC9Fd2tWaWV3LmNwcDoKKyAgICAgICAgKEV3a1ZpZXc6OmRpc3BsYXlUaW1lckZpcmVk KTogQ2hhbmdlZCB0aGUgcG9pbnQgb2Ygc3RhcnQgcG9zaXRpb24gdG8gdXBkYXRlIHRoZSBldmFz b2JqZWN0LgorCiAyMDE0LTEwLTIwICBCZXRoIERha2luICA8YmRha2luQGFwcGxlLmNvbT4KIAog ICAgICAgICBBY3Rpb24gbWVudSBpdGVtcyBzaG91bGQgaGF2ZSB0YWdzCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3LmNwcCBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXcuY3BwCmluZGV4IDFhNDEwZGEwMDU0ZmJmNjc0 M2IyYTJkNzVlYWM0MmE2OThmYzI4ZmQuLjFjZGVhMGJkODA2MDE2ODAzNDAzMGYyYTJhYmFjMmI2 M2Q5ZjI3NjYgMTAwNzU1Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3 a1ZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXcu Y3BwCkBAIC01NjAsOCArNTYwLDggQEAgdm9pZCBFd2tWaWV3OjpkaXNwbGF5VGltZXJGaXJlZChU aW1lcjxFd2tWaWV3PiopCiAKICAgICBXS1ZpZXdQYWludFRvQ3VycmVudEdMQ29udGV4dCh3a1Zp ZXcoKSk7CiAKLSAgICAvLyBzZC0+aW1hZ2UgaXMgdGllZCB0byBhIG5hdGl2ZSBzdXJmYWNlLCB3 aGljaCBpcyBpbiB0aGUgcGFyZW50J3MgY29vcmRpbmF0ZXMuCi0gICAgZXZhc19vYmplY3RfaW1h Z2VfZGF0YV91cGRhdGVfYWRkKHNkLT5pbWFnZSwgc2QtPnZpZXcueCwgc2QtPnZpZXcueSwgc2Qt PnZpZXcudywgc2QtPnZpZXcuaCk7CisgICAgLy8gc2QtPmltYWdlIGhhdmUgdG8gdXBkYXRlIGFz IHRoZSBzaXplIG9mIHdlYnZpZXcgZnJvbSAoMCwwKSB3aGVuIHVzaW5nIHRoZSBldmFzR0wuCisg ICAgZXZhc19vYmplY3RfaW1hZ2VfZGF0YV91cGRhdGVfYWRkKHNkLT5pbWFnZSwgMCwgMCwgc2Qt PnZpZXcudywgc2QtPnZpZXcuaCk7CiB9CiAKIHZvaWQgRXdrVmlldzo6c2NoZWR1bGVVcGRhdGVE aXNwbGF5KCkK 246804 2015-02-17 23:34:37 -0800 2015-04-22 22:11:28 -0700 Patch bug-137948-20150218163433.patch text/plain 1595 hs85.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwMjU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMjQ4YzRlYWE2YjcyN2Y4 YWE0NDYwNjE3YjJmMWYwMDBkOTMwODMzYy4uZTYwMWYwYWE2NTA0ZTRjMWIzZWE3OTVjMTVlZjA4 YTFlNjczYTAyNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE1LTAyLTE3ICBIdW5z ZW9wIEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSB3ZWJ2 aWV3IGhhdmUgdG8gdXBkYXRlIGZyb20gKDAsMCkgdG8gdGhlIHNpemUgb2Ygd2ViVmlldyBhZnRl ciByMTgwMTM0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTM3OTQ4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3LmNwcDoKKyAgICAgICAgKEV3a1ZpZXc6OmRp c3BsYXlUaW1lckZpcmVkKTogQ2hhbmdlZCB0aGUgcG9pbnQgb2Ygc3RhcnQgcG9zaXRpb24gdG8g dXBkYXRlIHRoZSBldmFzb2JqZWN0LgorCiAyMDE1LTAyLTE3ICBUaW1vdGh5IEhvcnRvbiAgPHRp bW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChyMTc4NTk1KTog Q2xpY2tpbmcgb24gREQgaGlnaGxpZ2h0cyBzb21ldGltZXMgZG8gbm90IHdvcmsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXcuY3BwIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlldy5jcHAKaW5kZXggZWU1MDNhNzRhMjVk NjdiMWUyYTIwZTRhNDkzMDhmYWE2NzI2YzEwMC4uMmJiOTU5Y2ViY2EzM2U5Zjk2YTRkOThiMmJj Y2YzM2JmMzliOTM3OSAxMDA3NTUKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9l ZmwvRXdrVmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvRXdr Vmlldy5jcHAKQEAgLTU3NSw4ICs1NzUsOCBAQCB2b2lkIEV3a1ZpZXc6OmRpc3BsYXlUaW1lckZp cmVkKCkKIAogICAgIFdLVmlld1BhaW50VG9DdXJyZW50R0xDb250ZXh0KHdrVmlldygpKTsKIAot ICAgIC8vIHNkLT5pbWFnZSBpcyB0aWVkIHRvIGEgbmF0aXZlIHN1cmZhY2UsIHdoaWNoIGlzIGlu IHRoZSBwYXJlbnQncyBjb29yZGluYXRlcy4KLSAgICBldmFzX29iamVjdF9pbWFnZV9kYXRhX3Vw ZGF0ZV9hZGQoc2QtPmltYWdlLCBzZC0+dmlldy54LCBzZC0+dmlldy55LCBzZC0+dmlldy53LCBz ZC0+dmlldy5oKTsKKyAgICAvLyBzZC0+aW1hZ2UgaGF2ZSB0byB1cGRhdGUgYXMgdGhlIHNpemUg b2Ygd2VidmlldyBmcm9tICgwLDApIHdoZW4gdXNpbmcgdGhlIGV2YXNHTC4KKyAgICBldmFzX29i amVjdF9pbWFnZV9kYXRhX3VwZGF0ZV9hZGQoc2QtPmltYWdlLCAwLCAwLCBzZC0+dmlldy53LCBz ZC0+dmlldy5oKTsKIH0KIAogdm9pZCBFd2tWaWV3OjpzY2hlZHVsZVVwZGF0ZURpc3BsYXkoKQo= 251405 2015-04-22 22:11:35 -0700 2015-05-26 18:08:45 -0700 Patch bug-137948-20150423141030.patch text/plain 1639 hs85.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzMTYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMmVlODg2NTQ3NjBiMTk3 YjAxNjY3NTUzODI3NWQ5YzZhZGJlZTA0Yi4uZGFlNWEwNjdkMjM3N2U5NTZmNDJjZTRhNGRkNjU3 MmMzZjM5MTY3ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA0LTIyICBIdW5z ZW9wIEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSB3ZWJ2 aWV3IHNob3VsZCBiZSB1cGRhdGVkIGZyb20gKDAsMCkgd2hlbiB1c2luZyB0aGUgZXZhc0dMLgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM3OTQ4CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hhbmdlZCB0 aGUgcG9pbnQgb2YgdGhlIHN0YXJ0IHBvc2l0aW9uIHRvIHVwZGF0ZSB0aGUgZXZhc09iamVjdAor ICAgICAgICBjb3JyZWN0bHkgd2hlbiB1c2luZyB0aGUgZXZhc0dMIGZvciBncmFwaGljcyBiYWNr ZW5kLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlldy5jcHA6CisgICAgICAg IChFd2tWaWV3OjpkaXNwbGF5VGltZXJGaXJlZCk6CisKIDIwMTUtMDQtMjIgIEJyZW50IEZ1bGdo YW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CiAKICAgICAgICAgVmlzaWJsZVNlbGVjdGlvbiBzaG91 bGQgb25seSBhY2NlcHQgUmFuZ2UgYnkgcmVmZXJlbmNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvZWZsL0V3a1ZpZXcuY3BwCmluZGV4IGE0MWEzYjllMTUwMWI3MDBlOWE4ZjVkNGU5 ZDczMjU0YTA2MzQzN2IuLjU4MjQzNjFjMDNjMjFhODQyMWVmOGY0YTcwMTU2ZDE1ZWNlMDJmNmIg MTAwNzU1Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXcuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXcuY3BwCkBAIC01 NzYsOCArNTc2LDggQEAgdm9pZCBFd2tWaWV3OjpkaXNwbGF5VGltZXJGaXJlZCgpCiAKICAgICBX S1ZpZXdQYWludFRvQ3VycmVudEdMQ29udGV4dCh3a1ZpZXcoKSk7CiAKLSAgICAvLyBzZC0+aW1h Z2UgaXMgdGllZCB0byBhIG5hdGl2ZSBzdXJmYWNlLCB3aGljaCBpcyBpbiB0aGUgcGFyZW50J3Mg Y29vcmRpbmF0ZXMuCi0gICAgZXZhc19vYmplY3RfaW1hZ2VfZGF0YV91cGRhdGVfYWRkKHNkLT5p bWFnZSwgc2QtPnZpZXcueCwgc2QtPnZpZXcueSwgc2QtPnZpZXcudywgc2QtPnZpZXcuaCk7Cisg ICAgLy8gc2QtPmltYWdlIHNob3VsZCBiZSB1cGRhdGVkIGZyb20gKDAsMCkgd2hlbiB1c2luZyB0 aGUgZXZhc0dMIGZvciBncmFwaGljcyBiYWNrZW5kLgorICAgIGV2YXNfb2JqZWN0X2ltYWdlX2Rh dGFfdXBkYXRlX2FkZChzZC0+aW1hZ2UsIDAsIDAsIHNkLT52aWV3LncsIHNkLT52aWV3LmgpOwog fQogCiB2b2lkIEV3a1ZpZXc6OnNjaGVkdWxlVXBkYXRlRGlzcGxheSgpCg==