137937 2014-10-21 16:58:39 -0700 Remove erroneous canUseJIT() in the intrinsics version of JITThunks::hostFunctionStub(). 2014-10-21 17:52:42 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam commit-queue oldest_to_newest 1043310 0 mark.lam 2014-10-21 16:58:39 -0700 This version of JITThunks::hostFunctionStub() can only be called from the intrinsics version of VM::getHostFunction() which asserts canUseJIT(). Hence, we can eliminate the canUseJIT() check in JITThunks::hostFunctionStub(). We don't handle the !canUseJIT() case properly there anyway. 1043315 1 240230 mark.lam 2014-10-21 17:12:23 -0700 Created attachment 240230 the patch. 1043316 2 240230 msaboff 2014-10-21 17:14:00 -0700 Comment on attachment 240230 the patch. r=me 1043324 3 240230 commit-queue 2014-10-21 17:52:39 -0700 Comment on attachment 240230 the patch. Clearing flags on attachment: 240230 Committed r175005: <http://trac.webkit.org/changeset/175005> 1043325 4 commit-queue 2014-10-21 17:52:42 -0700 All reviewed patches have been landed. Closing bug. 240230 2014-10-21 17:12:23 -0700 2014-10-21 17:52:39 -0700 the patch. bug-137937.patch text/plain 2154 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTc1MDAyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDE0LTEwLTIxICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBS ZW1vdmUgZXJyb25lb3VzIGNhblVzZUpJVCgpIGluIHRoZSBpbnRyaW5zaWNzIHZlcnNpb24gb2Yg SklUVGh1bmtzOjpob3N0RnVuY3Rpb25TdHViKCkuCisgICAgICAgIDxodHRwczovL3dlYmtpdC5v cmcvYi8xMzc5Mzc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgVGhpcyB2ZXJzaW9uIG9mIEpJVFRodW5rczo6aG9zdEZ1bmN0aW9uU3R1YigpIGNhbiBv bmx5IGJlIGNhbGxlZCBmcm9tIHRoZSBpbnRyaW5zaWNzCisgICAgICAgIHZlcnNpb24gb2YgVk06 OmdldEhvc3RGdW5jdGlvbigpIHdoaWNoIGFzc2VydHMgY2FuVXNlSklUKCkuICBIZW5jZSwgd2Ug Y2FuIGVsaW1pbmF0ZQorICAgICAgICB0aGUgY2FuVXNlSklUKCkgY2hlY2sgaW4gSklUVGh1bmtz Ojpob3N0RnVuY3Rpb25TdHViKCkuICBXZSBkb24ndCBoYW5kbGUgdGhlCisgICAgICAgICFjYW5V c2VKSVQoKSBjYXNlIHByb3Blcmx5IHRoZXJlIGFueXdheS4KKworICAgICAgICAqIGppdC9KSVRU aHVua3MuY3BwOgorICAgICAgICAoSlNDOjpKSVRUaHVua3M6Omhvc3RGdW5jdGlvblN0dWIpOgor CiAyMDE0LTEwLTIxICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgogCiAgICAg ICAgIEFkZCBvcGVyYXRvcj09KFByb3BlcnR5TmFtZSwgY29uc3QgY2hhciopCkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVFRodW5rcy5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L0phdmFTY3JpcHRDb3JlL2ppdC9KSVRUaHVua3MuY3BwCShyZXZpc2lvbiAxNzUwMDIpCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVFRodW5rcy5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTk2LDE2ICs5NiwxNSBAQCBOYXRpdmVFeGVjdXRhYmxlKiBKSVRUaHVua3M6Omhvc3RGdW5jdGlv CiBOYXRpdmVFeGVjdXRhYmxlKiBKSVRUaHVua3M6Omhvc3RGdW5jdGlvblN0dWIoVk0qIHZtLCBO YXRpdmVGdW5jdGlvbiBmdW5jdGlvbiwgVGh1bmtHZW5lcmF0b3IgZ2VuZXJhdG9yLCBJbnRyaW5z aWMgaW50cmluc2ljKQogewogICAgIEFTU0VSVCghaXNDb21waWxhdGlvblRocmVhZCgpKTsgICAg CisgICAgQVNTRVJUKHZtLT5jYW5Vc2VKSVQoKSk7CiAKICAgICBpZiAoTmF0aXZlRXhlY3V0YWJs ZSogbmF0aXZlRXhlY3V0YWJsZSA9IG1faG9zdEZ1bmN0aW9uU3R1Yk1hcC0+Z2V0KHN0ZDo6bWFr ZV9wYWlyKGZ1bmN0aW9uLCAmY2FsbEhvc3RGdW5jdGlvbkFzQ29uc3RydWN0b3IpKSkKICAgICAg ICAgcmV0dXJuIG5hdGl2ZUV4ZWN1dGFibGU7CiAKICAgICBSZWZQdHI8SklUQ29kZT4gZm9yQ2Fs bDsKICAgICBpZiAoZ2VuZXJhdG9yKSB7Ci0gICAgICAgIGlmICh2bS0+Y2FuVXNlSklUKCkpIHsK LSAgICAgICAgICAgIE1hY3JvQXNzZW1ibGVyQ29kZVJlZiBlbnRyeSA9IGdlbmVyYXRvcih2bSk7 Ci0gICAgICAgICAgICBmb3JDYWxsID0gYWRvcHRSZWYobmV3IERpcmVjdEpJVENvZGUoZW50cnks IGVudHJ5LmNvZGUoKSwgSklUQ29kZTo6SG9zdENhbGxUaHVuaykpOwotICAgICAgICB9CisgICAg ICAgIE1hY3JvQXNzZW1ibGVyQ29kZVJlZiBlbnRyeSA9IGdlbmVyYXRvcih2bSk7CisgICAgICAg IGZvckNhbGwgPSBhZG9wdFJlZihuZXcgRGlyZWN0SklUQ29kZShlbnRyeSwgZW50cnkuY29kZSgp LCBKSVRDb2RlOjpIb3N0Q2FsbFRodW5rKSk7CiAgICAgfSBlbHNlCiAgICAgICAgIGZvckNhbGwg PSBhZG9wdFJlZihuZXcgTmF0aXZlSklUQ29kZShKSVQ6OmNvbXBpbGVDVElOYXRpdmVDYWxsKHZt LCBmdW5jdGlvbiksIEpJVENvZGU6Okhvc3RDYWxsVGh1bmspKTsKICAgICAK