137934 2014-10-21 15:08:10 -0700 import-w3c-tests should use re.escape() wherever it's handling file paths 2014-10-28 10:52:31 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rhauck webkit-unassigned commit-queue glenn oldest_to_newest 1043287 0 rhauck 2014-10-21 15:08:10 -0700 test_converter.py does some path conversions where it uses re.sub(). Since filepaths can have regex characters in them, they should all be escaped. 1043577 1 240301 rhauck 2014-10-22 16:08:49 -0700 Created attachment 240301 Patch 1044508 2 240301 bjonesbe 2014-10-28 09:37:50 -0700 Comment on attachment 240301 Patch r=me 1044540 3 240301 commit-queue 2014-10-28 10:52:28 -0700 Comment on attachment 240301 Patch Clearing flags on attachment: 240301 Committed r175257: <http://trac.webkit.org/changeset/175257> 1044541 4 commit-queue 2014-10-28 10:52:31 -0700 All reviewed patches have been landed. Closing bug. 240301 2014-10-22 16:08:49 -0700 2014-10-28 10:52:28 -0700 Patch bug-137934-20141022160854.patch text/plain 2505 rhauck U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1MDY4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNmIyOTQ0MzY5ZDY1OTA5YzNhY2Y1NDk1MTc0MDNkNzUy NDcwZWNmYi4uNzQxMWM3NTEzMTk4NGJkZTE3MTUzM2FkZDgwMmY4MTdjNzY5NzJjNiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE0LTEwLTIyICBSZWJlY2NhIEhhdWNrICA8cmhhdWNrQGFkb2JlLmNvbT4KKworICAg ICAgICBpbXBvcnQtdzNjLXRlc3RzIHNob3VsZCB1c2UgcmUuZXNjYXBlKCkgd2hlcmV2ZXIgaXQn cyBoYW5kbGluZyBmaWxlIHBhdGhzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMzc5MzQKKworICAgICAgICBUaGlzIHBhdGNoIGFkZHMgcmUuZXNjYXBl KCkgdG8gYSBmZXcgcGxhY2VzIHdoZXJlIHdlJ3JlIGRvaW5nIHN0cmluZworICAgICAgICBjb252 ZXJzaW9ucy4gVGhpcyBwcmV2ZW50cyBlcnJvcnMgd2hlbiBhdHRyaWJ1dGUgdmFsdWVzIGNvaW5j aWRlbnRhbGx5CisgICAgICAgIGhhdmUgY2hhcmFjdGVyIHNlcXVlbmNlcyB0aGF0IGNhbiBiZSBp bnRlcnByZXRlZCBhcyByZWd1bGFyIGV4cHJlc3Npb25zLgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS93M2MvdGVzdF9j b252ZXJ0ZXIucHk6CisgICAgICAgIChfVzNDVGVzdENvbnZlcnRlci5jb252ZXJ0X2F0dHJpYnV0 ZXNfaWZfbmVlZGVkKToKKwogMjAxNC0xMC0yMiAgSmFrZSBOaWVsc2VuICA8amFjb2JfbmllbHNl bkBhcHBsZS5jb20+CiAKICAgICAgICAgUGF0Y2hBbmFseXNpc1Rhc2suX3Rlc3RfcGF0Y2goKSBu ZWVkcyByZWZhY3RvcmluZwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS93M2Mv dGVzdF9jb252ZXJ0ZXIucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3czYy90ZXN0X2NvbnZl cnRlci5weQppbmRleCA0ODBiYzc0YjZlOTIxYTgwZjA2ZjhlODUxZWI4NDNiMGQwMGFkNmRlLi40 OTkwNzhlNWMwZTkyYzliZTMxZGMyZTE4N2FhMDZmMjAyYzc2YzE4IDEwMDY0NAotLS0gYS9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L3czYy90ZXN0X2NvbnZlcnRlci5weQorKysgYi9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L3czYy90ZXN0X2NvbnZlcnRlci5weQpAQCAtMTcyLDE5ICsxNzIsMTkgQEAg Y2xhc3MgX1czQ1Rlc3RDb252ZXJ0ZXIoSFRNTFBhcnNlcik6CiAgICAgICAgICAgICBmb3IgYXR0 ciBpbiBhdHRyczoKICAgICAgICAgICAgICAgICBpZiBhdHRyWzBdID09IGF0dHJfbmFtZToKICAg ICAgICAgICAgICAgICAgICAgbmV3X3BhdGggPSByZS5zdWIoc2VsZi50ZXN0X2hhcm5lc3NfcmUs IHNlbGYubmV3X3Rlc3RfaGFybmVzc19wYXRoICsgJy90ZXN0aGFybmVzcycsIGF0dHJbMV0pCi0g ICAgICAgICAgICAgICAgICAgIGNvbnZlcnRlZCA9IHJlLnN1YihhdHRyWzFdLCBuZXdfcGF0aCwg Y29udmVydGVkKQorICAgICAgICAgICAgICAgICAgICBjb252ZXJ0ZWQgPSByZS5zdWIocmUuZXNj YXBlKGF0dHJbMV0pLCBuZXdfcGF0aCwgY29udmVydGVkKQogCiAgICAgICAgIGZvciBhdHRyIGlu IGF0dHJzOgogICAgICAgICAgICAgaWYgYXR0clswXSA9PSAnc3R5bGUnOgogICAgICAgICAgICAg ICAgIG5ld19zdHlsZSA9IHNlbGYuY29udmVydF9zdHlsZV9kYXRhKGF0dHJbMV0pCi0gICAgICAg ICAgICAgICAgY29udmVydGVkID0gcmUuc3ViKGF0dHJbMV0sIG5ld19zdHlsZSwgY29udmVydGVk KQorICAgICAgICAgICAgICAgIGNvbnZlcnRlZCA9IHJlLnN1YihyZS5lc2NhcGUoYXR0clsxXSks IG5ld19zdHlsZSwgY29udmVydGVkKQogCiAgICAgICAgIHNyY190YWdzID0gKCdzY3JpcHQnLCAn c3R5bGUnLCAnaW1nJywgJ2ZyYW1lJywgJ2lmcmFtZScsICdpbnB1dCcsICdsYXllcicsICd0ZXh0 YXJlYScsICd2aWRlbycsICdhdWRpbycpCiAgICAgICAgIGlmIHRhZyBpbiBzcmNfdGFncyBhbmQg c2VsZi5yZWZlcmVuY2Vfc3VwcG9ydF9pbmZvIGlzIG5vdCBOb25lIGFuZCAgc2VsZi5yZWZlcmVu Y2Vfc3VwcG9ydF9pbmZvICE9IHt9OgogICAgICAgICAgICAgZm9yIGF0dHJfbmFtZSwgYXR0cl92 YWx1ZSBpbiBhdHRyczoKICAgICAgICAgICAgICAgICBpZiBhdHRyX25hbWUgPT0gJ3NyYyc6CiAg ICAgICAgICAgICAgICAgICAgIG5ld19wYXRoID0gc2VsZi5jb252ZXJ0X3JlZmVyZW5jZV9yZWxw YXRocyhhdHRyX3ZhbHVlKQotICAgICAgICAgICAgICAgICAgICBjb252ZXJ0ZWQgPSByZS5zdWIo YXR0cl92YWx1ZSwgbmV3X3BhdGgsIGNvbnZlcnRlZCkKKyAgICAgICAgICAgICAgICAgICAgY29u dmVydGVkID0gcmUuc3ViKHJlLmVzY2FwZShhdHRyX3ZhbHVlKSwgbmV3X3BhdGgsIGNvbnZlcnRl ZCkKIAogICAgICAgICBzZWxmLmNvbnZlcnRlZF9kYXRhLmFwcGVuZChjb252ZXJ0ZWQpCiAK