137932 2014-10-21 13:34:10 -0700 [Win] Run DumpRenderTree using native controls, not SafariTheme.dll 2014-10-21 17:26:49 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 25592 1 bfulgham bfulgham bfulgham oldest_to_newest 1043266 0 bfulgham 2014-10-21 13:34:10 -0700 It's time to stop using SafariTheme.dll during DumpRenderTree testing. We don't ship software using SafariTheme.dll anymore, so it's silly to use its output as the basis for our rendering health. Furthermore, with the release of Yosemite, the drawing style used in SafariTheme no longer matches our Mac baselines. Consequently, many tests will begin failing anyway. Let's seize this opportunity to rebaseline Windows against its native drawing style. 1043267 1 240220 bfulgham 2014-10-21 13:37:43 -0700 Created attachment 240220 Patch 1043279 2 bfulgham 2014-10-21 14:13:51 -0700 Committed r174998: <http://trac.webkit.org/changeset/174998> 1043318 3 bfulgham 2014-10-21 17:26:49 -0700 Small set of test expectations updated in r175004. <http://trac.webkit.org/changeset/175004>. 240220 2014-10-21 13:37:43 -0700 2014-10-21 14:11:59 -0700 Patch bug-137932-20141021133749.patch text/plain 2043 bfulgham SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE3NDk5NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE5IEBACisyMDE0LTEwLTIxICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29t PgorCisgICAgICAgIFtXaW5dIFJ1biBEdW1wUmVuZGVyVHJlZSB1c2luZyBuYXRpdmUgY29udHJv bHMsIG5vdCBTYWZhcmlUaGVtZS5kbGwuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMzc5MzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUaGlzIGlzIHRoZSBmaXJzdCBzdGVwIGluIG1vdmluZyBvdmVyIHRv IG5hdGl2ZSBXaW5kb3dzIHJlbmRlcmluZyBmb3Igb3VyIGxheW91dCB0ZXN0cy4KKyAgICAgICAg T25jZSB0aGlzIGNoYW5nZSBsYW5kcywgYXBwcm94aW1hdGVseSAzMDAgdGVzdHMgd2lsbCBzdGFy dCBmYWlsaW5nIG9uIFdpbmRvd3MuIEkgd2lsbAorICAgICAgICByZWJhc2VsaW5lIHRoZXNlIGNo YW5nZXMgYWdhaW5zdCBvdXIgdGVzdCBoYXJkd2FyZSBhbmQgdXBkYXRlIHRoaXMgYnVnIHdpdGgg dGhlCisgICAgICAgIGNvbW1pdHMgcmVsYXRlZCB0byB0aGF0IHdvcmsuCisKKyAgICAgICAgKiBE dW1wUmVuZGVyVHJlZS93aW4vRHVtcFJlbmRlclRyZWUuY3BwOgorICAgICAgICAocmVzZXREZWZh dWx0c1RvQ29uc2lzdGVudFZhbHVlcyk6IENhbGwgJ3NldFNob3VsZFBhaW50TmF0aXZlQ29udHJv bHMoVFJVRSknIHNvIHRoYXQKKyAgICAgICAgd2UgdXNlIG5hdGl2ZSBXaW5kb3dzIGRyYXdpbmcg c3R5bGUuCisKIDIwMTQtMTAtMjEgIETDoW5pZWwgQsOhdHlhaSAgPGRiYXR5YWkudS1zemVnZWRA cGFydG5lci5zYW1zdW5nLmNvbT4KIAogICAgICAgICBGaXggRlRMIE5hdGl2ZSBJbmxpbmluZyBm b3IgRUZMCkluZGV4OiBUb29scy9EdW1wUmVuZGVyVHJlZS93aW4vRHVtcFJlbmRlclRyZWUuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFRvb2xzL0R1bXBSZW5kZXJUcmVlL3dpbi9EdW1wUmVuZGVyVHJlZS5j cHAJKHJldmlzaW9uIDE3NDkwNSkKKysrIFRvb2xzL0R1bXBSZW5kZXJUcmVlL3dpbi9EdW1wUmVu ZGVyVHJlZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTgyOSw3ICs4MjksNyBAQCBzdGF0aWMgdm9p ZCByZXNldERlZmF1bHRzVG9Db25zaXN0ZW50VmFsCiAgICAgICAgIHByZWZzUHJpdmF0ZS0+c2V0 QXV0aG9yQW5kVXNlclN0eWxlc0VuYWJsZWQoVFJVRSk7CiAgICAgICAgIHByZWZzUHJpdmF0ZS0+ c2V0RGV2ZWxvcGVyRXh0cmFzRW5hYmxlZChGQUxTRSk7CiAgICAgICAgIHByZWZzUHJpdmF0ZS0+ c2V0RXhwZXJpbWVudGFsTm90aWZpY2F0aW9uc0VuYWJsZWQoVFJVRSk7Ci0gICAgICAgIHByZWZz UHJpdmF0ZS0+c2V0U2hvdWxkUGFpbnROYXRpdmVDb250cm9scyhGQUxTRSk7IC8vIEZJWE1FIC0g bmVlZCB0byBtYWtlIERSVCBwYXNzIHdpdGggV2luZG93cyBuYXRpdmUgY29udHJvbHMgPGh0dHA6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI1NTkyPgorICAgICAgICBwcmVmc1By aXZhdGUtPnNldFNob3VsZFBhaW50TmF0aXZlQ29udHJvbHMoVFJVRSk7IC8vIEZJWE1FIC0gbmVl ZCB0byBtYWtlIERSVCBwYXNzIHdpdGggV2luZG93cyBuYXRpdmUgY29udHJvbHMgPGh0dHA6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI1NTkyPgogICAgICAgICBwcmVmc1ByaXZh dGUtPnNldEphdmFTY3JpcHRDYW5BY2Nlc3NDbGlwYm9hcmQoVFJVRSk7CiAgICAgICAgIHByZWZz UHJpdmF0ZS0+c2V0WFNTQXVkaXRvckVuYWJsZWQoRkFMU0UpOwogICAgICAgICBwcmVmc1ByaXZh dGUtPnNldE9mZmxpbmVXZWJBcHBsaWNhdGlvbkNhY2hlRW5hYmxlZChUUlVFKTsK