137930 2014-10-21 11:49:42 -0700 Fullscreen video dismissal can put application to incorrect orientation on iOS 2014-11-04 16:22:46 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rabbasian webkit-unassigned commit-queue darin eric.carlson glenn jeremyj-wk jer.noble jonlee philipj sergio oldest_to_newest 1043243 0 rabbasian 2014-10-21 11:49:42 -0700 Under some circumstances, when a fullscreen video gets dismissed programmatically, it can make the application to have an incorrect interface orientation. 1043247 1 240214 rabbasian 2014-10-21 12:05:59 -0700 Created attachment 240214 Fix Patch 1043297 2 240214 darin 2014-10-21 15:54:43 -0700 Comment on attachment 240214 Fix Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240214&action=review > Source/WebCore/ChangeLog:11 > + When a fullscreen video gets dismissed programmatically, for instance for removing > + a webview from the view hierarchy, it can put the device in an incorrect orientation. > + Make sure we retain the window of parentView when we attempt to go to fullscreen and use > + the retained window for putting the device in correct orientation after dismissal. Instead of retaining the UIWindow, could we just store the result of calling interfaceOrientation? Or is it helpful to call the interfaceOrientation method at the time of dismissal? 1043298 3 rabbasian 2014-10-21 16:00:58 -0700 (In reply to comment #2) > Comment on attachment 240214 [details] > Fix Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=240214&action=review > > > Source/WebCore/ChangeLog:11 > > + When a fullscreen video gets dismissed programmatically, for instance for removing > > + a webview from the view hierarchy, it can put the device in an incorrect orientation. > > + Make sure we retain the window of parentView when we attempt to go to fullscreen and use > > + the retained window for putting the device in correct orientation after dismissal. > > Instead of retaining the UIWindow, could we just store the result of calling > interfaceOrientation? Or is it helpful to call the interfaceOrientation > method at the time of dismissal? It is necessary that we get the interfaceOrientation at the time of dismissal, because after entering the fullscreen video, the user could start rotating the device and depending on window's view controller rotation handling code, possibly change the orientation of the window. 1043300 4 240214 jer.noble 2014-10-21 16:16:27 -0700 Comment on attachment 240214 Fix Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240214&action=review >>> Source/WebCore/ChangeLog:11 >>> + the retained window for putting the device in correct orientation after dismissal. >> >> Instead of retaining the UIWindow, could we just store the result of calling interfaceOrientation? Or is it helpful to call the interfaceOrientation method at the time of dismissal? > > It is necessary that we get the interfaceOrientation at the time of dismissal, because after entering the fullscreen video, the user could start rotating the device and depending on window's view controller rotation handling code, possibly change the orientation of the window. One alternative would be to use delegate notifications (e.g., - window:willRotateToInterfaceOrientation:duration:) that the window's orientation will change, and save the result. 1043305 5 rabbasian 2014-10-21 16:46:23 -0700 (In reply to comment #4) > Comment on attachment 240214 [details] > Fix Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=240214&action=review > > >>> Source/WebCore/ChangeLog:11 > >>> + the retained window for putting the device in correct orientation after dismissal. > >> > >> Instead of retaining the UIWindow, could we just store the result of calling interfaceOrientation? Or is it helpful to call the interfaceOrientation method at the time of dismissal? > > > > It is necessary that we get the interfaceOrientation at the time of dismissal, because after entering the fullscreen video, the user could start rotating the device and depending on window's view controller rotation handling code, possibly change the orientation of the window. > > One alternative would be to use delegate notifications (e.g., - > window:willRotateToInterfaceOrientation:duration:) that the window's > orientation will change, and save the result. I considered this approach. window:willRotateToInterfaceOrientation:duration: type of callbacks seem to be intended for UIViewController usage and UIViewControllers can implement those methods to get callbacks. Also there is no way to register as the recipient of these calls. One other alternative approach that I considered is to listen to window rotation change notifications. But this approach would also need the window object since we need to make sure that each time the notification is being received, it is from the window that we are interested in. I think the approach that I took may be the simplest way to address this issue. 1046224 6 240963 rabbasian 2014-11-04 15:37:55 -0800 Created attachment 240963 Under some circumstances, when a fullscreen video gets dismissed programmatically, it can make the application to have an incorrect interface orientation. Fixed some commit conflicts. 1046259 7 240963 commit-queue 2014-11-04 16:22:41 -0800 Comment on attachment 240963 Under some circumstances, when a fullscreen video gets dismissed programmatically, it can make the application to have an incorrect interface orientation. Clearing flags on attachment: 240963 Committed r175585: <http://trac.webkit.org/changeset/175585> 1046260 8 commit-queue 2014-11-04 16:22:46 -0800 All reviewed patches have been landed. Closing bug. 240214 2014-10-21 12:05:59 -0700 2014-11-04 15:37:55 -0800 Fix Patch webkit_patch_fullscreenvideo.txt text/plain 4655 rabbasian Y29tbWl0IGUzODZlYjg2ZmI4YzBlODdiN2U2MGYwMjVmMzc3MDlmZTc3M2E0MmIKQXV0aG9yOiBS ZXphIEFiYmFzaWFuIDxyYWJiYXNpYW5AYXBwbGUuY29tPgpEYXRlOiAgIFR1ZSBPY3QgMjEgMTI6 MDI6MDIgMjAxNCAtMDcwMAoKICAgIFtpT1NdIEZpeCBpbmNvcnJlY3QgaW50ZXJmYWNlIG9yaWVu dGF0aW9uIHRoYXQgY2FuIGJlIGNhdXNlZCBieSBmdWxsc2NyZWVuIHZpZGVvIGRpc21pc3NhbC4K ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzc5MzAKICAgIAog ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCiAgICAKICAgIFdoZW4gYSBmdWxsc2NyZWVu IHZpZGVvIGdldHMgZGlzbWlzc2VkIHByb2dyYW1tYXRpY2FsbHksIGZvciBpbnN0YW5jZSBmb3Ig cmVtb3ZpbmcKICAgIGEgd2VidmlldyBmcm9tIHRoZSB2aWV3IGhpZXJhcmNoeSwgaXQgY2FuIHB1 dCB0aGUgZGV2aWNlIGluIGFuIGluY29ycmVjdCBvcmllbnRhdGlvbi4KICAgIE1ha2Ugc3VyZSB3 ZSByZXRhaW4gdGhlIHdpbmRvdyBvZiBwYXJlbnRWaWV3IHdoZW4gd2UgYXR0ZW1wdCB0byBnbyB0 byBmdWxsc2NyZWVuIGFuZCB1c2UKICAgIHRoZSByZXRhaW5lZCB3aW5kb3cgZm9yIHB1dHRpbmcg dGhlIGRldmljZSBpbiBjb3JyZWN0IG9yaWVudGF0aW9uIGFmdGVyIGRpc21pc3NhbC4KICAgIAog ICAgKiBwbGF0Zm9ybS9pb3MvV2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQuaDoKICAg ICogcGxhdGZvcm0vaW9zL1dlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0Lm1tOgogICAg KFdlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0OjpzZXR1cEZ1bGxzY3JlZW4pOgogICAg KFdlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0OjpjbGVhbnVwRnVsbHNjcmVlbik6CiAg ICAoV2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQ6OmludmFsaWRhdGUpOgoKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZwppbmRleCAwNTI0ZWZiLi44YTBiZmY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIw MTQtMTAtMjEgIFJlemEgQWJiYXNpYW4gIDxyYWJiYXNpYW5AYXBwbGUuY29tPgorCisgICAgICAg IFtpT1NdIEZpeCBpbmNvcnJlY3QgaW50ZXJmYWNlIG9yaWVudGF0aW9uIHRoYXQgY2FuIGJlIGNh dXNlZCBieSBmdWxsc2NyZWVuIHZpZGVvIGRpc21pc3NhbC4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNzkzMAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgV2hlbiBhIGZ1bGxzY3JlZW4gdmlk ZW8gZ2V0cyBkaXNtaXNzZWQgcHJvZ3JhbW1hdGljYWxseSwgZm9yIGluc3RhbmNlIGZvciByZW1v dmluZworICAgICAgICBhIHdlYnZpZXcgZnJvbSB0aGUgdmlldyBoaWVyYXJjaHksIGl0IGNhbiBw dXQgdGhlIGRldmljZSBpbiBhbiBpbmNvcnJlY3Qgb3JpZW50YXRpb24uCisgICAgICAgIE1ha2Ug c3VyZSB3ZSByZXRhaW4gdGhlIHdpbmRvdyBvZiBwYXJlbnRWaWV3IHdoZW4gd2UgYXR0ZW1wdCB0 byBnbyB0byBmdWxsc2NyZWVuIGFuZCB1c2UKKyAgICAgICAgdGhlIHJldGFpbmVkIHdpbmRvdyBm b3IgcHV0dGluZyB0aGUgZGV2aWNlIGluIGNvcnJlY3Qgb3JpZW50YXRpb24gYWZ0ZXIgZGlzbWlz c2FsLgorCisgICAgICAgICogcGxhdGZvcm0vaW9zL1dlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFj ZUFWS2l0Lmg6CisgICAgICAgICogcGxhdGZvcm0vaW9zL1dlYlZpZGVvRnVsbHNjcmVlbkludGVy ZmFjZUFWS2l0Lm1tOgorICAgICAgICAoV2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQ6 OnNldHVwRnVsbHNjcmVlbik6CisgICAgICAgIChXZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VB VktpdDo6Y2xlYW51cEZ1bGxzY3JlZW4pOgorICAgICAgICAoV2ViVmlkZW9GdWxsc2NyZWVuSW50 ZXJmYWNlQVZLaXQ6OmludmFsaWRhdGUpOgorCiAyMDE0LTEwLTIwICBEZWFuIEphY2tzb24gIDxk aW5vQGFwcGxlLmNvbT4KIAogICAgICAgICBbTWFjXSBTdXBwb3J0ICJpbnZlcnRlZC1jb2xvcnMi IGFuZCAibW9ub2Nocm9tZSIgbWVkaWEgZmVhdHVyZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2lvcy9XZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdC5oIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1dlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0 LmgKaW5kZXggZDdjMTI0NC4uMTc0ZWE3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vaW9zL1dlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0LmgKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vaW9zL1dlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0LmgK QEAgLTc1LDYgKzc1LDcgQEAgY2xhc3MgV2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQK ICAgICBSZXRhaW5QdHI8VUlXaW5kb3c+IG1fd2luZG93OwogICAgIFJldGFpblB0cjxVSVZpZXdD b250cm9sbGVyPiBtX3ZpZXdDb250cm9sbGVyOwogICAgIFJldGFpblB0cjxVSVZpZXc+IG1fcGFy ZW50VmlldzsKKyAgICBSZXRhaW5QdHI8VUlXaW5kb3c+IG1fcGFyZW50V2luZG93OwogCiAgICAg V2ViQVZQbGF5ZXJDb250cm9sbGVyICpwbGF5ZXJDb250cm9sbGVyKCk7CiAgICAgCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvV2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJm YWNlQVZLaXQubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvV2ViVmlkZW9GdWxsc2Ny ZWVuSW50ZXJmYWNlQVZLaXQubW0KaW5kZXggOWUzMmFkMC4uMDFlY2Q5ZiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1dlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFW S2l0Lm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9XZWJWaWRlb0Z1bGxzY3Jl ZW5JbnRlcmZhY2VBVktpdC5tbQpAQCAtNzgzLDYgKzc4Myw3IEBAIHZvaWQgV2ViVmlkZW9GdWxs c2NyZWVuSW50ZXJmYWNlQVZLaXQ6OnNldHVwRnVsbHNjcmVlbihQbGF0Zm9ybUxheWVyJiB2aWRl b0xheWVyCiAgICAgICAgIFtDQVRyYW5zYWN0aW9uIGJlZ2luXTsKICAgICAgICAgW0NBVHJhbnNh Y3Rpb24gc2V0RGlzYWJsZUFjdGlvbnM6WUVTXTsKICAgICAgICAgbV9wYXJlbnRWaWV3ID0gcGFy ZW50VmlldzsKKyAgICAgICAgbV9wYXJlbnRXaW5kb3cgPSBwYXJlbnRWaWV3LndpbmRvdzsKIAog ICAgICAgICBpZiAoIWFwcGxpY2F0aW9uSXNBZFNoZWV0KCkpIHsKICAgICAgICAgICAgIG1fd2lu ZG93ID0gYWRvcHROUyhbW2dldFVJV2luZG93Q2xhc3MoKSBhbGxvY10gaW5pdFdpdGhGcmFtZTpb W2dldFVJU2NyZWVuQ2xhc3MoKSBtYWluU2NyZWVuXSBib3VuZHNdXSk7CkBAIC05MDEsNyArOTAy LDggQEAgdm9pZCBXZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdDo6Y2xlYW51cEZ1bGxz Y3JlZW4oKQogICAgICAgICBpZiAobV93aW5kb3cpIHsKICAgICAgICAgICAgIFttX3dpbmRvdyBz ZXRIaWRkZW46WUVTXTsKICAgICAgICAgICAgIFttX3dpbmRvdyBzZXRSb290Vmlld0NvbnRyb2xs ZXI6bmlsXTsKLSAgICAgICAgICAgIFtbZ2V0VUlBcHBsaWNhdGlvbkNsYXNzKCkgc2hhcmVkQXBw bGljYXRpb25dIF9zZXRTdGF0dXNCYXJPcmllbnRhdGlvbjpbW21fcGFyZW50VmlldyB3aW5kb3dd IGludGVyZmFjZU9yaWVudGF0aW9uXV07CisgICAgICAgICAgICBpZiAobV9wYXJlbnRXaW5kb3cp CisgICAgICAgICAgICAgICAgW1tnZXRVSUFwcGxpY2F0aW9uQ2xhc3MoKSBzaGFyZWRBcHBsaWNh dGlvbl0gX3NldFN0YXR1c0Jhck9yaWVudGF0aW9uOlttX3BhcmVudFdpbmRvdyBpbnRlcmZhY2VP cmllbnRhdGlvbl1dOwogICAgICAgICB9CiAgICAgICAgIFttX3BsYXllclZpZXdDb250cm9sbGVy IHNldERlbGVnYXRlOm5pbF07CiAgICAgICAgIFtbbV9wbGF5ZXJWaWV3Q29udHJvbGxlciB2aWV3 XSByZW1vdmVGcm9tU3VwZXJ2aWV3XTsKQEAgLTkxOCw2ICs5MjAsNyBAQCB2b2lkIFdlYlZpZGVv RnVsbHNjcmVlbkludGVyZmFjZUFWS2l0OjpjbGVhbnVwRnVsbHNjcmVlbigpCiAgICAgICAgIG1f dmlld0NvbnRyb2xsZXIgPSBuaWw7CiAgICAgICAgIG1fd2luZG93ID0gbmlsOwogICAgICAgICBt X3BhcmVudFZpZXcgPSBuaWw7CisgICAgICAgIG1fcGFyZW50V2luZG93ID0gbmlsOwogICAgICAg ICAKICAgICAgICAgV2ViVGhyZWFkUnVuKF57CiAgICAgICAgICAgICBpZiAobV9mdWxsc2NyZWVu Q2hhbmdlT2JzZXJ2ZXIpCkBAIC05NDgsNiArOTUxLDcgQEAgdm9pZCBXZWJWaWRlb0Z1bGxzY3Jl ZW5JbnRlcmZhY2VBVktpdDo6aW52YWxpZGF0ZSgpCiAgICAgbV92aWV3Q29udHJvbGxlciA9IG5p bDsKICAgICBtX3dpbmRvdyA9IG5pbDsKICAgICBtX3BhcmVudFZpZXcgPSBuaWw7CisgICAgbV9w YXJlbnRXaW5kb3cgPSBuaWw7CiB9CiAKIHZvaWQgV2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNl QVZLaXQ6OnJlcXVlc3RIaWRlQW5kRXhpdEZ1bGxzY3JlZW4oKQo= 240963 2014-11-04 15:37:55 -0800 2014-11-04 16:22:41 -0800 Under some circumstances, when a fullscreen video gets dismissed programmatically, it can make the application to have an incorrect interface orientation. fullscreenvideo_patch.txt text/plain 4633 rabbasian Y29tbWl0IGVhNWMzM2FlMzQ5YjQxNjM3N2E2MjBmYjc3NDQxNTk2MDZjNjMwZTcKQXV0aG9yOiBS ZXphIEFiYmFzaWFuIDxyYWJiYXNpYW5AYXBwbGUuY29tPgpEYXRlOiAgIFR1ZSBOb3YgNCAxNToz MjowMCAyMDE0IC0wODAwCgogICAgW2lPU10gRml4IGluY29ycmVjdCBpbnRlcmZhY2Ugb3JpZW50 YXRpb24gdGhhdCBjYW4gYmUgY2F1c2VkIGJ5IGZ1bGxzY3JlZW4gdmlkZW8gZGlzbWlzc2FsLgog ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNzkzMC4KICAgIAog ICAgUmV2aWV3ZWQgYnkgSmVyIE5vYmxlLgogICAgCiAgICBXaGVuIGEgZnVsbHNjcmVlbiB2aWRl byBnZXRzIGRpc21pc3NlZCBwcm9ncmFtbWF0aWNhbGx5LCBmb3IgaW5zdGFuY2UgZm9yIHJlbW92 aW5nCiAgICBhIHdlYnZpZXcgZnJvbSB0aGUgdmlldyBoaWVyYXJjaHksIGl0IGNhbiBwdXQgdGhl IGRldmljZSBpbiBhbiBpbmNvcnJlY3Qgb3JpZW50YXRpb24uCiAgICBNYWtlIHN1cmUgd2UgcmV0 YWluIHRoZSB3aW5kb3cgb2YgcGFyZW50VmlldyB3aGVuIHdlIGF0dGVtcHQgdG8gZ28gdG8gZnVs bHNjcmVlbiBhbmQgdXNlCiAgICB0aGUgcmV0YWluZWQgd2luZG93IGZvciBwdXR0aW5nIHRoZSBk ZXZpY2UgaW4gY29ycmVjdCBvcmllbnRhdGlvbiBhZnRlciBkaXNtaXNzYWwuCiAgICAKICAgICog cGxhdGZvcm0vaW9zL1dlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0Lmg6CiAgICAqIHBs YXRmb3JtL2lvcy9XZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdC5tbToKICAgIChXZWJW aWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdDo6c2V0dXBGdWxsc2NyZWVuKToKICAgIChXZWJW aWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdDo6Y2xlYW51cEZ1bGxzY3JlZW4pOgogICAgKFdl YlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0OjppbnZhbGlkYXRlKToKCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5k ZXggNGE0MjU2Ny4uZTYxODY0NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE0LTEx LTA0ICBSZXphIEFiYmFzaWFuICA8cmFiYmFzaWFuQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9T XSBGaXggaW5jb3JyZWN0IGludGVyZmFjZSBvcmllbnRhdGlvbiB0aGF0IGNhbiBiZSBjYXVzZWQg YnkgZnVsbHNjcmVlbiB2aWRlbyBkaXNtaXNzYWwuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzc5MzAuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgSmVy IE5vYmxlLgorCisgICAgICAgIFdoZW4gYSBmdWxsc2NyZWVuIHZpZGVvIGdldHMgZGlzbWlzc2Vk IHByb2dyYW1tYXRpY2FsbHksIGZvciBpbnN0YW5jZSBmb3IgcmVtb3ZpbmcKKyAgICAgICAgYSB3 ZWJ2aWV3IGZyb20gdGhlIHZpZXcgaGllcmFyY2h5LCBpdCBjYW4gcHV0IHRoZSBkZXZpY2UgaW4g YW4gaW5jb3JyZWN0IG9yaWVudGF0aW9uLgorICAgICAgICBNYWtlIHN1cmUgd2UgcmV0YWluIHRo ZSB3aW5kb3cgb2YgcGFyZW50VmlldyB3aGVuIHdlIGF0dGVtcHQgdG8gZ28gdG8gZnVsbHNjcmVl biBhbmQgdXNlCisgICAgICAgIHRoZSByZXRhaW5lZCB3aW5kb3cgZm9yIHB1dHRpbmcgdGhlIGRl dmljZSBpbiBjb3JyZWN0IG9yaWVudGF0aW9uIGFmdGVyIGRpc21pc3NhbC4KKworICAgICAgICAq IHBsYXRmb3JtL2lvcy9XZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdC5oOgorICAgICAg ICAqIHBsYXRmb3JtL2lvcy9XZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdC5tbToKKyAg ICAgICAgKFdlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0OjpzZXR1cEZ1bGxzY3JlZW4p OgorICAgICAgICAoV2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQ6OmNsZWFudXBGdWxs c2NyZWVuKToKKyAgICAgICAgKFdlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0OjppbnZh bGlkYXRlKToKKwogMjAxNC0xMS0wNCAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgog CiAgICAgICAgIFdpbmRvd3MgYnVpbGQgZml4IGFmdGVyIHIxNzU1NjUuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvV2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZL aXQuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9XZWJWaWRlb0Z1bGxzY3JlZW5JbnRl cmZhY2VBVktpdC5oCmluZGV4IDMwNWZhYzcuLjNhODVkMDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2lvcy9XZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdC5oCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9XZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZh Y2VBVktpdC5oCkBAIC0xMDEsNiArMTAxLDcgQEAgcHJvdGVjdGVkOgogICAgIFJldGFpblB0cjxV SVdpbmRvdz4gbV93aW5kb3c7CiAgICAgUmV0YWluUHRyPFVJVmlld0NvbnRyb2xsZXI+IG1fdmll d0NvbnRyb2xsZXI7CiAgICAgUmV0YWluUHRyPFVJVmlldz4gbV9wYXJlbnRWaWV3OworICAgIFJl dGFpblB0cjxVSVdpbmRvdz4gbV9wYXJlbnRXaW5kb3c7CiAgICAgSFRNTE1lZGlhRWxlbWVudDo6 VmlkZW9GdWxsc2NyZWVuTW9kZSBtX21vZGU7CiAgICAgYm9vbCBtX2V4aXRSZXF1ZXN0ZWQ7CiAg ICAgYm9vbCBtX2V4aXRDb21wbGV0ZWQ7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9pb3MvV2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQubW0gYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9pb3MvV2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQubW0KaW5k ZXggYjFkYmY4My4uNmNhNzM3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v aW9zL1dlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0Lm1tCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2lvcy9XZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdC5tbQpAQCAt ODAyLDYgKzgwMiw3IEBAIHZvaWQgV2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQ6OnNl dHVwRnVsbHNjcmVlbihQbGF0Zm9ybUxheWVyJiB2aWRlb0xheWVyCiAgICAgICAgIFtDQVRyYW5z YWN0aW9uIGJlZ2luXTsKICAgICAgICAgW0NBVHJhbnNhY3Rpb24gc2V0RGlzYWJsZUFjdGlvbnM6 WUVTXTsKICAgICAgICAgbV9wYXJlbnRWaWV3ID0gcGFyZW50VmlldzsKKyAgICAgICAgbV9wYXJl bnRXaW5kb3cgPSBwYXJlbnRWaWV3LndpbmRvdzsKIAogICAgICAgICBpZiAoIWFwcGxpY2F0aW9u SXNBZFNoZWV0KCkpIHsKICAgICAgICAgICAgIG1fd2luZG93ID0gYWRvcHROUyhbW2dldFVJV2lu ZG93Q2xhc3MoKSBhbGxvY10gaW5pdFdpdGhGcmFtZTpbW2dldFVJU2NyZWVuQ2xhc3MoKSBtYWlu U2NyZWVuXSBib3VuZHNdXSk7CkBAIC05NzksNyArOTgwLDggQEAgdm9pZCBXZWJWaWRlb0Z1bGxz Y3JlZW5JbnRlcmZhY2VBVktpdDo6Y2xlYW51cEZ1bGxzY3JlZW4oKQogICAgICAgICBpZiAobV93 aW5kb3cpIHsKICAgICAgICAgICAgIFttX3dpbmRvdyBzZXRIaWRkZW46WUVTXTsKICAgICAgICAg ICAgIFttX3dpbmRvdyBzZXRSb290Vmlld0NvbnRyb2xsZXI6bmlsXTsKLSAgICAgICAgICAgIFtb Z2V0VUlBcHBsaWNhdGlvbkNsYXNzKCkgc2hhcmVkQXBwbGljYXRpb25dIF9zZXRTdGF0dXNCYXJP cmllbnRhdGlvbjpbW21fcGFyZW50VmlldyB3aW5kb3ddIGludGVyZmFjZU9yaWVudGF0aW9uXV07 CisgICAgICAgICAgICBpZiAobV9wYXJlbnRXaW5kb3cpCisgICAgICAgICAgICAgICAgW1tnZXRV SUFwcGxpY2F0aW9uQ2xhc3MoKSBzaGFyZWRBcHBsaWNhdGlvbl0gX3NldFN0YXR1c0Jhck9yaWVu dGF0aW9uOlttX3BhcmVudFdpbmRvdyBpbnRlcmZhY2VPcmllbnRhdGlvbl1dOwogICAgICAgICB9 CiAgICAgICAgIFttX3BsYXllclZpZXdDb250cm9sbGVyIHNldERlbGVnYXRlOm5pbF07CiAgICAg ICAgIFtbbV9wbGF5ZXJWaWV3Q29udHJvbGxlciB2aWV3XSByZW1vdmVGcm9tU3VwZXJ2aWV3XTsK QEAgLTk5Niw2ICs5OTgsNyBAQCB2b2lkIFdlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0 OjpjbGVhbnVwRnVsbHNjcmVlbigpCiAgICAgICAgIG1fdmlld0NvbnRyb2xsZXIgPSBuaWw7CiAg ICAgICAgIG1fd2luZG93ID0gbmlsOwogICAgICAgICBtX3BhcmVudFZpZXcgPSBuaWw7CisgICAg ICAgIG1fcGFyZW50V2luZG93ID0gbmlsOwogICAgICAgICAKICAgICAgICAgV2ViVGhyZWFkUnVu KF57CiAgICAgICAgICAgICBpZiAobV9mdWxsc2NyZWVuQ2hhbmdlT2JzZXJ2ZXIpCkBAIC0xMDI2 LDYgKzEwMjksNyBAQCB2b2lkIFdlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0OjppbnZh bGlkYXRlKCkKICAgICBtX3ZpZXdDb250cm9sbGVyID0gbmlsOwogICAgIG1fd2luZG93ID0gbmls OwogICAgIG1fcGFyZW50VmlldyA9IG5pbDsKKyAgICBtX3BhcmVudFdpbmRvdyA9IG5pbDsKIH0K IAogdm9pZCBXZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdDo6cmVxdWVzdEhpZGVBbmRF eGl0RnVsbHNjcmVlbigpCg==