137921 2014-10-21 07:04:26 -0700 [GTK]: Fix unused parameter build warnings in WebCore/platform module 2014-10-22 03:12:05 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kumar.rohit webkit-unassigned cgarcia commit-queue oldest_to_newest 1043167 0 kumar.rohit 2014-10-21 07:04:26 -0700 Remove following build warning in WebKit GTK build [192/4427] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/dfg/DFGCommon.cpp.o [2493/4427] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/platform/ScrollAnimatorNone.cpp.o ../../Source/WebCore/platform/ScrollAnimatorNone.cpp:199:1: warning: unused parameter ‘parent’ [-Wunused-parameter] ScrollAnimatorNone::PerAxisData::PerAxisData(ScrollAnimatorNone* parent, float* currentPosition, int visibleLength) ^ ../../Source/WebCore/platform/ScrollAnimatorNone.cpp:494:6: warning: unused parameter ‘timer’ [-Wunused-parameter] void ScrollAnimatorNone::animationTimerFired(Timer<ScrollAnimatorNone>* timer) ^ [2555/4427] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/platform/graphics/cairo/CairoUtilities.cpp.o 1043168 1 240200 kumar.rohit 2014-10-21 07:07:54 -0700 Created attachment 240200 Patch 1043170 2 commit-queue 2014-10-21 07:10:31 -0700 Attachment 240200 did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1043380 3 240200 cgarcia 2014-10-22 00:27:55 -0700 Comment on attachment 240200 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240200&action=review > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). You should remove this line 1043389 4 240258 kumar.rohit 2014-10-22 02:15:09 -0700 Created attachment 240258 Patch for landing 1043396 5 240258 commit-queue 2014-10-22 03:12:01 -0700 Comment on attachment 240258 Patch for landing Clearing flags on attachment: 240258 Committed r175037: <http://trac.webkit.org/changeset/175037> 1043397 6 commit-queue 2014-10-22 03:12:05 -0700 All reviewed patches have been landed. Closing bug. 240200 2014-10-21 07:07:54 -0700 2014-10-22 02:14:55 -0700 Patch bug-137921-20141021193915.patch text/plain 1911 kumar.rohit U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0OTQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjc2YTU0YjUxODA1Y2Q4 NDQ0ZDUxMTVlZDQyOTJiOTYzMWI3NTJkMi4uMzQyNDQ3OTA2Njk1YjUzNzk2ZDJmZmExNDQzN2I4 Y2ViZGEyZDk2YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTEwLTIxICBSb2hp dCBLdW1hciAgPGt1bWFyLnJvaGl0QHNhbXN1bmcuY29tPgorCisgICAgICAgIFtHVEtdOiBGaXgg dW51c2VkIHBhcmFtZXRlciBidWlsZCB3YXJuaW5ncyBpbiBXZWJDb3JlL3BsYXRmb3JtIG1vZHVs ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM3OTIx CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3 IHRlc3RzIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9TY3JvbGxBbmltYXRvck5vbmUu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsQW5pbWF0b3JOb25lOjpQZXJBeGlzRGF0YTo6 UGVyQXhpc0RhdGEpOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsQW5pbWF0b3JOb25lOjphbmlt YXRpb25UaW1lckZpcmVkKToKKwogMjAxNC0xMC0yMSAgTWFudWVsIFJlZ28gQ2FzYXNub3ZhcyAg PHJlZ29AaWdhbGlhLmNvbT4KIAogICAgICAgICBBU1NFUlRJT04gRkFJTEVEOiAhZ3JpZFdhc1Bv cHVsYXRlZCgpIGluIFdlYkNvcmU6OlJlbmRlckdyaWQ6OnBsYWNlSXRlbXNPbkdyaWQKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbEFuaW1hdG9yTm9uZS5jcHAgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxBbmltYXRvck5vbmUuY3BwCmluZGV4IDJmMDJk NDY5ZjBiMWNmYWE3OGVmMmJlYjhmZTY0YzM2OWViNmNlOTMuLjM1ZDhjZjQ2NjU2ZmM0YmRjMjk0 YTdmYmZiZjkzZDU5MGQwZGYyMWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L1Njcm9sbEFuaW1hdG9yTm9uZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Ny b2xsQW5pbWF0b3JOb25lLmNwcApAQCAtMTk2LDcgKzE5Niw3IEBAIGRvdWJsZSBTY3JvbGxBbmlt YXRvck5vbmU6OlBlckF4aXNEYXRhOjpyZWxlYXNlQXJlYShDdXJ2ZSBjdXJ2ZSwgZG91YmxlIHN0 YXJ0VCwKICAgICByZXR1cm4gZW5kVmFsdWUgLSBzdGFydFZhbHVlOwogfQogCi1TY3JvbGxBbmlt YXRvck5vbmU6OlBlckF4aXNEYXRhOjpQZXJBeGlzRGF0YShTY3JvbGxBbmltYXRvck5vbmUqIHBh cmVudCwgZmxvYXQqIGN1cnJlbnRQb3NpdGlvbiwgaW50IHZpc2libGVMZW5ndGgpCitTY3JvbGxB bmltYXRvck5vbmU6OlBlckF4aXNEYXRhOjpQZXJBeGlzRGF0YShTY3JvbGxBbmltYXRvck5vbmUq LCBmbG9hdCogY3VycmVudFBvc2l0aW9uLCBpbnQgdmlzaWJsZUxlbmd0aCkKICAgICA6IG1fY3Vy cmVudFBvc2l0aW9uKGN1cnJlbnRQb3NpdGlvbikKICAgICAsIG1fdmlzaWJsZUxlbmd0aCh2aXNp YmxlTGVuZ3RoKQogewpAQCAtNDkxLDcgKzQ5MSw3IEBAIHZvaWQgU2Nyb2xsQW5pbWF0b3JOb25l Ojp1cGRhdGVWaXNpYmxlTGVuZ3RocygpCiB9CiAKICNpZiBVU0UoUkVRVUVTVF9BTklNQVRJT05f RlJBTUVfVElNRVIpCi12b2lkIFNjcm9sbEFuaW1hdG9yTm9uZTo6YW5pbWF0aW9uVGltZXJGaXJl ZChUaW1lcjxTY3JvbGxBbmltYXRvck5vbmU+KiB0aW1lcikKK3ZvaWQgU2Nyb2xsQW5pbWF0b3JO b25lOjphbmltYXRpb25UaW1lckZpcmVkKFRpbWVyPFNjcm9sbEFuaW1hdG9yTm9uZT4qKQogewog ICAgIGFuaW1hdGlvblRpbWVyRmlyZWQoKTsKIH0K 240258 2014-10-22 02:15:09 -0700 2014-10-22 03:12:01 -0700 Patch for landing bug-137921-20141022144629.patch text/plain 1832 kumar.rohit U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1MDI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMThlMDk0MWI2YmE5YTg5 OTkyNDdjNGYwOTc2MzZkNTk5MTBhY2MyNi4uODQ3NDIyYjY2YzE2MTQwYTZhZGMxZmEyMzk0N2Fk MTFiNmIwZjhhYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE0LTEwLTIyICBSb2hp dCBLdW1hciAgPGt1bWFyLnJvaGl0QHNhbXN1bmcuY29tPgorCisgICAgICAgIFtHVEtdOiBGaXgg dW51c2VkIHBhcmFtZXRlciBidWlsZCB3YXJuaW5ncyBpbiBXZWJDb3JlL3BsYXRmb3JtIG1vZHVs ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM3OTIx CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQ2FybG9zIEdhcmNpYSBDYW1wb3MuCisKKyAgICAgICAg KiBwbGF0Zm9ybS9TY3JvbGxBbmltYXRvck5vbmUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2Ny b2xsQW5pbWF0b3JOb25lOjpQZXJBeGlzRGF0YTo6UGVyQXhpc0RhdGEpOgorICAgICAgICAoV2Vi Q29yZTo6U2Nyb2xsQW5pbWF0b3JOb25lOjphbmltYXRpb25UaW1lckZpcmVkKToKKwogMjAxNC0x MC0yMSAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CiAKICAgICAgICAgT25lIG1vcmUg aU9TIGJ1aWxkIGZpeCBhZnRlciByMTc1MDEzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vU2Nyb2xsQW5pbWF0b3JOb25lLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L1Njcm9sbEFuaW1hdG9yTm9uZS5jcHAKaW5kZXggMmYwMmQ0NjlmMGIxY2ZhYTc4ZWYyYmViOGZl NjRjMzY5ZWI2Y2U5My4uMzVkOGNmNDY2NTZmYzRiZGMyOTRhN2ZiZmJmOTNkNTkwZDBkZjIxZiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsQW5pbWF0b3JOb25lLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxBbmltYXRvck5vbmUuY3BwCkBA IC0xOTYsNyArMTk2LDcgQEAgZG91YmxlIFNjcm9sbEFuaW1hdG9yTm9uZTo6UGVyQXhpc0RhdGE6 OnJlbGVhc2VBcmVhKEN1cnZlIGN1cnZlLCBkb3VibGUgc3RhcnRULAogICAgIHJldHVybiBlbmRW YWx1ZSAtIHN0YXJ0VmFsdWU7CiB9CiAKLVNjcm9sbEFuaW1hdG9yTm9uZTo6UGVyQXhpc0RhdGE6 OlBlckF4aXNEYXRhKFNjcm9sbEFuaW1hdG9yTm9uZSogcGFyZW50LCBmbG9hdCogY3VycmVudFBv c2l0aW9uLCBpbnQgdmlzaWJsZUxlbmd0aCkKK1Njcm9sbEFuaW1hdG9yTm9uZTo6UGVyQXhpc0Rh dGE6OlBlckF4aXNEYXRhKFNjcm9sbEFuaW1hdG9yTm9uZSosIGZsb2F0KiBjdXJyZW50UG9zaXRp b24sIGludCB2aXNpYmxlTGVuZ3RoKQogICAgIDogbV9jdXJyZW50UG9zaXRpb24oY3VycmVudFBv c2l0aW9uKQogICAgICwgbV92aXNpYmxlTGVuZ3RoKHZpc2libGVMZW5ndGgpCiB7CkBAIC00OTEs NyArNDkxLDcgQEAgdm9pZCBTY3JvbGxBbmltYXRvck5vbmU6OnVwZGF0ZVZpc2libGVMZW5ndGhz KCkKIH0KIAogI2lmIFVTRShSRVFVRVNUX0FOSU1BVElPTl9GUkFNRV9USU1FUikKLXZvaWQgU2Ny b2xsQW5pbWF0b3JOb25lOjphbmltYXRpb25UaW1lckZpcmVkKFRpbWVyPFNjcm9sbEFuaW1hdG9y Tm9uZT4qIHRpbWVyKQordm9pZCBTY3JvbGxBbmltYXRvck5vbmU6OmFuaW1hdGlvblRpbWVyRmly ZWQoVGltZXI8U2Nyb2xsQW5pbWF0b3JOb25lPiopCiB7CiAgICAgYW5pbWF0aW9uVGltZXJGaXJl ZCgpOwogfQo=