137920 2014-10-21 06:36:13 -0700 [Curl] Optimization; avoid string reallocation. 2014-10-21 12:41:49 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned alex.christensen bfulgham commit-queue galpeter oldest_to_newest 1043164 0 peavo 2014-10-21 06:36:13 -0700 Profiling reveals that the cookiesForDOM function is spending time on removing a character from a string. 1043165 1 240198 peavo 2014-10-21 06:42:49 -0700 Created attachment 240198 Patch 1043246 2 240198 bfulgham 2014-10-21 12:05:51 -0700 Comment on attachment 240198 Patch r=me. It's always great to avoid having to create/modify a string when all you want to do is query it! 1043252 3 peavo 2014-10-21 12:33:57 -0700 (In reply to comment #2) > Comment on attachment 240198 [details] > Patch > > r=me. It's always great to avoid having to create/modify a string when all > you want to do is query it! Thanks! 1043255 4 240198 commit-queue 2014-10-21 12:41:46 -0700 Comment on attachment 240198 Patch Clearing flags on attachment: 240198 Committed r174993: <http://trac.webkit.org/changeset/174993> 1043256 5 commit-queue 2014-10-21 12:41:49 -0700 All reviewed patches have been landed. Closing bug. 240198 2014-10-21 06:42:49 -0700 2014-10-21 12:41:46 -0700 Patch bug-137920-20141021154250.patch text/plain 2861 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NDk1NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE0LTEwLTIxICBwZWF2b0Bv dXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtDdXJsXSBPcHRpbWl6 YXRpb247IGF2b2lkIHN0cmluZyByZWFsbG9jYXRpb24uCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzc5MjAKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQcm9maWxpbmcgcmV2ZWFscyB0aGF0IHRoZSBjb29r aWVzRm9yRE9NIGZ1bmN0aW9uIGlzIHNwZW5kaW5nIHRpbWUgb24gcmVtb3ZpbmcgYSBjaGFyYWN0 ZXIgZnJvbSBhIHN0cmluZy4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvY3VybC9Db29r aWVKYXJDdXJsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmRvbWFpbk1hdGNoKToKKyAgICAgICAg KFdlYkNvcmU6OmFkZE1hdGNoaW5nQ3VybENvb2tpZSk6CisKIDIwMTQtMTAtMjEgIE1hbnVlbCBS ZWdvIENhc2Fzbm92YXMgIDxyZWdvQGlnYWxpYS5jb20+CiAKICAgICAgICAgQVNTRVJUSU9OIEZB SUxFRDogIWdyaWRXYXNQb3B1bGF0ZWQoKSBpbiBXZWJDb3JlOjpSZW5kZXJHcmlkOjpwbGFjZUl0 ZW1zT25HcmlkCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ29v a2llSmFyQ3VybC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0 d29yay9jdXJsL0Nvb2tpZUphckN1cmwuY3BwCShyZXZpc2lvbiAxNzQ5NTApCisrKyBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ29va2llSmFyQ3VybC5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTQzLDYgKzQzLDI5IEBAIHN0YXRpYyB2b2lkIHJlYWRDdXJsQ29va2llVG9rZW4o Y29uc3QgY2gKICAgICAgICAgY29va2llKys7CiB9CiAKK3N0YXRpYyBib29sIGRvbWFpbk1hdGNo KGNvbnN0IFN0cmluZyYgY29va2llRG9tYWluLCBjb25zdCBTdHJpbmcmIGhvc3QpCit7CisgICAg c2l6ZV90IGluZGV4ID0gaG9zdC5maW5kKGNvb2tpZURvbWFpbik7CisKKyAgICBib29sIHRhaWxN YXRjaCA9IChpbmRleCAhPSBXVEY6Om5vdEZvdW5kICYmIGluZGV4ICsgY29va2llRG9tYWluLmxl bmd0aCgpID09IGhvc3QubGVuZ3RoKCkpOworCisgICAgLy8gQ2hlY2sgaWYgaG9zdCBlcXVhbHMg Y29va2llIGRvbWFpbi4KKyAgICBpZiAodGFpbE1hdGNoICYmICFpbmRleCkKKyAgICAgICAgcmV0 dXJuIHRydWU7CisKKyAgICAvLyBDaGVjayBpZiBob3N0IGlzIGEgc3ViZG9tYWluIG9mIHRoZSBk b21haW4gaW4gdGhlIGNvb2tpZS4KKyAgICAvLyBDdXJsIHVzZXMgYSAnLicgaW4gZnJvbnQgb2Yg ZG9tYWlucyB0byBpbmRpY2F0ZSBpdCdzIHZhbGlkIG9uIHN1YmRvbWFpbnMuCisgICAgaWYgKHRh aWxNYXRjaCAmJiBpbmRleCA+IDAgJiYgaG9zdFtpbmRleF0gPT0gJy4nKQorICAgICAgICByZXR1 cm4gdHJ1ZTsKKworICAgIC8vIENoZWNrIHRoZSBzcGVjaWFsIGNhc2Ugd2hlcmUgaG9zdCBlcXVh bHMgdGhlIGNvb2tpZSBkb21haW4sIGV4Y2VwdCBmb3IgYSBsZWFkaW5nICcuJyBpbiB0aGUgY29v a2llIGRvbWFpbi4KKyAgICAvLyBFLmcuIGNvb2tpZSBkb21haW4gaXMgLmFwcGxlLmNvbSBhbmQg aG9zdCBpcyBhcHBsZS5jb20uIAorICAgIGlmIChjb29raWVEb21haW5bMF0gPT0gJy4nICYmIGNv b2tpZURvbWFpbi5maW5kKGhvc3QpID09IDEpCisgICAgICAgIHJldHVybiB0cnVlOworCisgICAg cmV0dXJuIGZhbHNlOworfQorCiBzdGF0aWMgdm9pZCBhZGRNYXRjaGluZ0N1cmxDb29raWUoY29u c3QgY2hhciogY29va2llLCBjb25zdCBTdHJpbmcmIGRvbWFpbiwgY29uc3QgU3RyaW5nJiBwYXRo LCBTdHJpbmdCdWlsZGVyJiBjb29raWVzLCBib29sIGh0dHBvbmx5KQogewogICAgIC8vIENoZWNr IGlmIHRoZSBjb29raWUgbWF0Y2hlcyBkb21haW4gYW5kIHBhdGgsIGFuZCBpcyBub3QgZXhwaXJl ZC4KQEAgLTgwLDE4ICsxMDMsNyBAQCBzdGF0aWMgdm9pZCBhZGRNYXRjaGluZ0N1cmxDb29raWUo Y29uc3QKICAgICAgICAgICAgIHJldHVybjsKICAgICB9CiAKLQotICAgIGlmIChjb29raWVEb21h aW5bMF0gPT0gJy4nKSB7Ci0gICAgICAgIC8vIENoZWNrIGlmIGRvbWFpbiBpcyBhIHN1YmRvbWFp biBvZiB0aGUgZG9tYWluIGluIHRoZSBjb29raWUuCi0gICAgICAgIC8vIEN1cmwgdXNlcyBhICcu JyBpbiBmcm9udCBvZiBkb21haW5zIHRvIGluZGljYXRlIGl0cyB2YWxpZCBvbiBzdWJkb21haW5z LgotICAgICAgICBjb29raWVEb21haW4ucmVtb3ZlKDApOwotICAgICAgICBpbnQgbGVuRGlmZiA9 IGRvbWFpbi5sZW5ndGgoKSAtIGNvb2tpZURvbWFpbi5sZW5ndGgoKTsKLSAgICAgICAgaW50IGlu ZGV4ID0gZG9tYWluLmZpbmQoY29va2llRG9tYWluKTsKLSAgICAgICAgaWYgKGluZGV4ID09IGxl bkRpZmYpCi0gICAgICAgICAgICBzdWJEb21haW4gPSB0cnVlOwotICAgIH0KLQotICAgIGlmICgh c3ViRG9tYWluICYmIGNvb2tpZURvbWFpbiAhPSBkb21haW4pCisgICAgaWYgKCFkb21haW5NYXRj aChjb29raWVEb21haW4sIGRvbWFpbikpCiAgICAgICAgIHJldHVybjsKIAogICAgIFN0cmluZyBz dHJCb29sZWFuOwo=