137916 2014-10-21 04:53:37 -0700 REGRESSION(r174676): It broke the !ENABLE(VIDEO) build 2014-10-21 11:09:55 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 137683 1 ossy cdumez cdumez commit-queue esprehn+autocc glenn kondapallykalyan mihnea ossy simon.fraser oldest_to_newest 1043153 0 ossy 2014-10-21 04:53:37 -0700 error log: ../../Source/WebCore/rendering/RenderLayerBacking.cpp: In member function 'bool WebCore::RenderLayerBacking::isDirectlyCompositedImage() const': ../../Source/WebCore/rendering/RenderLayerBacking.cpp:1823:44: error: 'RenderMedia' was not declared in this scope ../../Source/WebCore/rendering/RenderLayerBacking.cpp:1823:67: error: no matching function for call to 'is(WebCore::RenderLayerModelObject&)' RenderMedia class is inside ENABLE(VIDEO) guard, that's why it causes build failure. The previous renderer().isMedia() worked, because isMedia() is defined unconditionally in RenderObject (returns false) - the base class of RenderMedia (returns true). 1043195 1 cdumez 2014-10-21 09:43:43 -0700 Thanks for the bug report Ossy, I'm on it! 1043197 2 cdumez 2014-10-21 09:46:10 -0700 Committed r174978: <http://trac.webkit.org/changeset/174978> 1043207 3 ossy 2014-10-21 09:57:12 -0700 (In reply to comment #2) > Committed r174978: <http://trac.webkit.org/changeset/174978> But the whole RenderMedia.h is inside ENABLE(VIDEO) guard, it can't fix the build. 1043208 4 cdumez 2014-10-21 09:58:56 -0700 Apparently did not fix the build. 1043211 5 240210 cdumez 2014-10-21 10:06:25 -0700 Created attachment 240210 Patch 1043212 6 cdumez 2014-10-21 10:07:07 -0700 Ossy, sorry about the quick / insufficient build fix. What do you think about this one? 1043213 7 ossy 2014-10-21 10:12:08 -0700 (In reply to comment #6) > Ossy, sorry about the quick / insufficient build fix. What do you think > about this one? Looks good for the error in the description, let me check if it is enough, maybe there are other issues later. 1043220 8 240210 ossy 2014-10-21 10:33:34 -0700 Comment on attachment 240210 Patch Thanks, I tested, it is enough to fix the build, r=me. 1043221 9 cdumez 2014-10-21 10:34:17 -0700 (In reply to comment #8) > Comment on attachment 240210 [details] > Patch > > Thanks, I tested, it is enough to fix the build, r=me. Great, thanks for double-checking and sorry about the breakage. 1043231 10 240210 commit-queue 2014-10-21 11:09:48 -0700 Comment on attachment 240210 Patch Clearing flags on attachment: 240210 Committed r174989: <http://trac.webkit.org/changeset/174989> 1043232 11 commit-queue 2014-10-21 11:09:55 -0700 All reviewed patches have been landed. Closing bug. 240210 2014-10-21 10:06:25 -0700 2014-10-21 11:09:48 -0700 Patch bug-137916-20141021100631.patch text/plain 1996 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0OTc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGJlN2EzN2RiMTY1NGY4 NDQxYTliZDY3OTc5ZGU1NTVmNGE3NzQyYy4uNjBkMTMxMTg4ODljYjY1NzRjYjA0Y2EwYTIyY2Fk NzVhY2ZiNjg4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMyw2ICszLDE5IEBACiAgICAgICAgIFJFR1JFU1NJ T04ocjE3NDY3Nik6IEl0IGJyb2tlIHRoZSAhRU5BQkxFKFZJREVPKSBidWlsZAogICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM3OTE2CiAKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IHRoZSAhRU5BQkxFKFZJ REVPKSBidWlsZCBieSBhZGRpbmcgYW4gI2lmIEVOQUJMRShWSURFTykgd2hlcmUKKyAgICAgICAg bmVlZGVkLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllckJhY2tpbmc6OmlzRGlyZWN0bHlDb21wb3NpdGVk SW1hZ2UpOgorCisyMDE0LTEwLTIxICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisK KyAgICAgICAgUkVHUkVTU0lPTihyMTc0Njc2KTogSXQgYnJva2UgdGhlICFFTkFCTEUoVklERU8p IGJ1aWxkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x Mzc5MTYKKwogICAgICAgICBVbnJldmlld2VkIGJ1aWxkIGZpeC4gQWRkIG1pc3NpbmcgaGVhZGVy IGluY2x1ZGUuCiAKICAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNwcDoK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcu Y3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHAKaW5k ZXggMDk4NGI0MTk3Yzg3MzhlMGI1MmM2MTZiYzUxY2EyZmM0M2QwNjY5MS4uYjQyYmY1MTY0NjAx NzRiY2NhZDcwY2M4ZTkyMTNkOWJiOTU3NDQwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHAKQEAgLTE4MjEsOSArMTgyMSwxNCBAQCBib29s IFJlbmRlckxheWVyQmFja2luZzo6Y29udGFpbnNQYWludGVkQ29udGVudChib29sIGlzU2ltcGxl Q29udGFpbmVyKSBjb25zdAogLy8gdGhhdCByZXF1aXJlIHBhaW50aW5nLiBEaXJlY3QgY29tcG9z aXRpbmcgc2F2ZXMgYmFja2luZyBzdG9yZS4KIGJvb2wgUmVuZGVyTGF5ZXJCYWNraW5nOjppc0Rp cmVjdGx5Q29tcG9zaXRlZEltYWdlKCkgY29uc3QKIHsKLSAgICBpZiAoIWlzPFJlbmRlckltYWdl PihyZW5kZXJlcigpKSB8fCBpczxSZW5kZXJNZWRpYT4ocmVuZGVyZXIoKSkgfHwgbV9vd25pbmdM YXllci5oYXNCb3hEZWNvcmF0aW9uc09yQmFja2dyb3VuZCgpIHx8IHJlbmRlcmVyKCkuaGFzQ2xp cCgpKQorICAgIGlmICghaXM8UmVuZGVySW1hZ2U+KHJlbmRlcmVyKCkpIHx8IG1fb3duaW5nTGF5 ZXIuaGFzQm94RGVjb3JhdGlvbnNPckJhY2tncm91bmQoKSB8fCByZW5kZXJlcigpLmhhc0NsaXAo KSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCisjaWYgRU5BQkxFKFZJREVPKQorICAgIGlmIChp czxSZW5kZXJNZWRpYT4ocmVuZGVyZXIoKSkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKyNlbmRp ZgorCiAgICAgYXV0byYgaW1hZ2VSZW5kZXJlciA9IGRvd25jYXN0PFJlbmRlckltYWdlPihyZW5k ZXJlcigpKTsKICAgICBpZiAoQ2FjaGVkSW1hZ2UqIGNhY2hlZEltYWdlID0gaW1hZ2VSZW5kZXJl ci5jYWNoZWRJbWFnZSgpKSB7CiAgICAgICAgIGlmICghY2FjaGVkSW1hZ2UtPmhhc0ltYWdlKCkp Cg==