137897 2014-10-20 15:51:31 -0700 Use glFinish instead of glFlush when drawing final GL output to screen 2014-10-20 18:07:56 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 roger_fong webkit-unassigned bfulgham commit-queue dino jonlee kondapallykalyan noam roger_fong oldest_to_newest 1042991 0 roger_fong 2014-10-20 15:51:31 -0700 When we want to draw the final WebGL output to the screen we call drawInCGLContext which in turn calls GraphicsContext3D::prepareTexture. We used to call glFinish here, which pushes all buffered gl operations and blocks until every operation has been completed and every last pixel has been drawn. glFlush also pushes all buffered gl operations but returns immediately. Using glFinish is a huge performance hit and based on my testing does not seem to offer any particular benefit over glFlush. Thus we will switch to using glFlush. This gives us a 20% performance boost on Unity 3d tests and a 33% boost on the frame rate on http://threejs.org/examples/#webgl_performance. 1042992 1 240154 roger_fong 2014-10-20 15:54:52 -0700 Created attachment 240154 patch 1042993 2 roger_fong 2014-10-20 15:57:02 -0700 We should commit this, live on it, and keep an eye out for any unforeseen consequences. 1042994 3 roger_fong 2014-10-20 15:58:09 -0700 rdar://problem/15846550 1043002 4 240154 bfulgham 2014-10-20 16:16:31 -0700 Comment on attachment 240154 patch Looks good! r=me. 1043044 5 roger_fong 2014-10-20 18:07:56 -0700 http://trac.webkit.org/changeset/174915 240154 2014-10-20 15:54:52 -0700 2014-10-20 16:16:31 -0700 patch patch.patch text/plain 1521 roger_fong SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NDkwOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTEwLTIwICBSb2dlciBG b25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgVXNlIGdsRmluaXNoIGluc3Rl YWQgb2YgZ2xGbHVzaCB3aGVuIGRyYXdpbmcgV2ViR0wgb3V0cHV0IHRvIHNjcmVlbi4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNzg5Ny4KKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzE1ODQ2NTUwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFBhc3NlcyBhbGwgY29uZm9ybWFuY2UgdGVzdHMuCisgICAg ICAgIFBlcmZvcm1hbmNlIHRlc3RlZCBieSBodHRwOi8vdGhyZWVqcy5vcmcvZXhhbXBsZXMvI3dl YmdsX3BlcmZvcm1hbmNlIGFuZCBVbml0eSBXZWJHTCBwZXJmb3JtYW5jZSB0ZXN0cy4KKworICAg ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9HcmFwaGljc0NvbnRleHQzRE9wZW5HTENv bW1vbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQzRDo6cHJlcGFyZVRl eHR1cmUpOgorCiAyMDE0LTEwLTIwICBCZXRoIERha2luICA8YmRha2luQGFwcGxlLmNvbT4KIAog ICAgICAgICBTcGVjdWxhdGl2ZSBidWlsZCBmaXguCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR3JhcGhpY3NDb250ZXh0M0RPcGVuR0xDb21tb24uY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9HcmFw aGljc0NvbnRleHQzRE9wZW5HTENvbW1vbi5jcHAJKHJldmlzaW9uIDE3NDc5NSkKKysrIFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9HcmFwaGljc0NvbnRleHQzRE9wZW5H TENvbW1vbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIyMyw3ICsyMjMsNyBAQCB2b2lkIEdyYXBo aWNzQ29udGV4dDNEOjpwcmVwYXJlVGV4dHVyZSgpCiAgICAgOjpnbEFjdGl2ZVRleHR1cmUobV9z dGF0ZS5hY3RpdmVUZXh0dXJlKTsKICAgICBpZiAobV9zdGF0ZS5ib3VuZEZCTyAhPSBtX2ZibykK ICAgICAgICAgOjpnbEJpbmRGcmFtZWJ1ZmZlckVYVChHcmFwaGljc0NvbnRleHQzRDo6RlJBTUVC VUZGRVIsIG1fc3RhdGUuYm91bmRGQk8pOwotICAgIDo6Z2xGaW5pc2goKTsKKyAgICA6OmdsRmx1 c2goKTsKIH0KIAogdm9pZCBHcmFwaGljc0NvbnRleHQzRDo6cmVhZFJlbmRlcmluZ1Jlc3VsdHMo dW5zaWduZWQgY2hhciAqcGl4ZWxzLCBpbnQgcGl4ZWxzU2l6ZSkK