137888 2014-10-20 11:41:42 -0700 Factor out JITCode::typeName() for debugging use 2014-12-04 16:45:15 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 139274 1 mark.lam mark.lam oldest_to_newest 1042901 0 mark.lam 2014-10-20 11:41:42 -0700 JITCode's printInternal() currently decodes the JITType into a string and prints it. This change factors out the part that decodes the JITType into JITCode::typeName() so that we can call it from lldb while debugging to quickly decode a JITType value. 1042902 1 240133 mark.lam 2014-10-20 11:44:36 -0700 Created attachment 240133 the patch. 1042904 2 240133 ggaren 2014-10-20 11:47:09 -0700 Comment on attachment 240133 the patch. View in context: https://bugs.webkit.org/attachment.cgi?id=240133&action=review > Source/JavaScriptCore/jit/JITCode.cpp:54 > + case None: return "None"; > + case HostCallThunk: return "Host"; > + case InterpreterThunk: return "LLInt"; > + case BaselineJIT: return "Baseline"; > + case DFGJIT: return "DFG"; > + case FTLJIT: return "FTL"; Coding style is wrong here. Please reuse the existing style. 1042906 3 240134 mark.lam 2014-10-20 11:48:55 -0700 Created attachment 240134 updated patch 1042909 4 240134 ggaren 2014-10-20 11:50:28 -0700 Comment on attachment 240134 updated patch r=me 1042910 5 mark.lam 2014-10-20 11:53:30 -0700 Thanks for the review. Landed in r174897: <http://trac.webkit.org/r174897>. 1052596 6 240134 fpizlo 2014-12-04 15:48:10 -0800 Comment on attachment 240134 updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=240134&action=review > Source/JavaScriptCore/ChangeLog:9 > + JITCode's printInternal() currently decodes the JITType into a string and > + prints it. This change factors out the part that decodes the JITType into Why can't lldb call this directly? > Source/JavaScriptCore/jit/JITCode.cpp:257 > + out.print("%s", JSC::JITCode::typeName(type)); This is wrong. PrintStream::print() doesn't take a format string. 1052613 7 242597 mark.lam 2014-12-04 16:39:08 -0800 Created attachment 242597 follow up patch to fix use of PrintStream::print(). 1052616 8 242597 mark.lam 2014-12-04 16:45:15 -0800 Comment on attachment 242597 follow up patch to fix use of PrintStream::print(). Fix already addressed in https://bugs.webkit.org/show_bug.cgi?id=139274. 240133 2014-10-20 11:44:36 -0700 2014-10-20 11:48:55 -0700 the patch. bug-137888.patch text/plain 2809 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTc0ODk1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDE0LTEwLTIwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBG YWN0b3Igb3V0IEpJVENvZGU6OnR5cGVOYW1lKCkgZm9yIGRlYnVnZ2luZyB1c2UuCisgICAgICAg IDxodHRwczovL3dlYmtpdC5vcmcvYi8xMzc4ODg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgSklUQ29kZSdzIHByaW50SW50ZXJuYWwoKSBjdXJyZW50 bHkgZGVjb2RlcyB0aGUgSklUVHlwZSBpbnRvIGEgc3RyaW5nIGFuZAorICAgICAgICBwcmludHMg aXQuICBUaGlzIGNoYW5nZSBmYWN0b3JzIG91dCB0aGUgcGFydCB0aGF0IGRlY29kZXMgdGhlIEpJ VFR5cGUgaW50bworICAgICAgICBKSVRDb2RlOjp0eXBlTmFtZSgpIHNvIHRoYXQgd2UgY2FuIGNh bGwgaXQgZnJvbSBsbGRiIHdoaWxlIGRlYnVnZ2luZyB0bworICAgICAgICBxdWlja2x5IGRlY29k ZSBhIEpJVFR5cGUgdmFsdWUuCisKKyAgICAgICAgKiBqaXQvSklUQ29kZS5jcHA6CisgICAgICAg IChKU0M6OkpJVENvZGU6OnR5cGVOYW1lKToKKyAgICAgICAgKFdURjo6cHJpbnRJbnRlcm5hbCk6 CisgICAgICAgICogaml0L0pJVENvZGUuaDoKKwogMjAxNC0xMC0yMCAgTWFyayBMYW0gIDxtYXJr LmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IHBsYWNlbWVudCBvZiBhIGZldyBpdGVtcyBp biB2Y3hwcm9qIEl0ZW1Hcm91cHMuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJ VENvZGUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUQ29k ZS5jcHAJKHJldmlzaW9uIDE3NDg5NSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklU Q29kZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQzLDYgKzQzLDIxIEBAIEpJVENvZGU6On5KSVRD b2RlKCkKIHsKIH0KIAorY29uc3QgY2hhciogSklUQ29kZTo6dHlwZU5hbWUoSklUVHlwZSBqaXRU eXBlKQoreworICAgIHN3aXRjaCAoaml0VHlwZSkgeworICAgIGNhc2UgTm9uZTogcmV0dXJuICJO b25lIjsKKyAgICBjYXNlIEhvc3RDYWxsVGh1bms6IHJldHVybiAiSG9zdCI7CisgICAgY2FzZSBJ bnRlcnByZXRlclRodW5rOiByZXR1cm4gIkxMSW50IjsKKyAgICBjYXNlIEJhc2VsaW5lSklUOiBy ZXR1cm4gIkJhc2VsaW5lIjsKKyAgICBjYXNlIERGR0pJVDogcmV0dXJuICJERkciOworICAgIGNh c2UgRlRMSklUOiByZXR1cm4gIkZUTCI7CisgICAgZGVmYXVsdDoKKyAgICAgICAgQ1JBU0goKTsK KyAgICAgICAgcmV0dXJuICIiOworICAgIH0KK30KKwogSlNWYWx1ZSBKSVRDb2RlOjpleGVjdXRl KFZNKiB2bSwgUHJvdG9DYWxsRnJhbWUqIHByb3RvQ2FsbEZyYW1lKQogewogICAgIHZvaWQqIGVu dHJ5QWRkcmVzczsKQEAgLTIzMywyOSArMjQ4LDcgQEAgbmFtZXNwYWNlIFdURiB7CiAKIHZvaWQg cHJpbnRJbnRlcm5hbChQcmludFN0cmVhbSYgb3V0LCBKU0M6OkpJVENvZGU6OkpJVFR5cGUgdHlw ZSkKIHsKLSAgICBzd2l0Y2ggKHR5cGUpIHsKLSAgICBjYXNlIEpTQzo6SklUQ29kZTo6Tm9uZToK LSAgICAgICAgb3V0LnByaW50KCJOb25lIik7Ci0gICAgICAgIHJldHVybjsKLSAgICBjYXNlIEpT Qzo6SklUQ29kZTo6SG9zdENhbGxUaHVuazoKLSAgICAgICAgb3V0LnByaW50KCJIb3N0Iik7Ci0g ICAgICAgIHJldHVybjsKLSAgICBjYXNlIEpTQzo6SklUQ29kZTo6SW50ZXJwcmV0ZXJUaHVuazoK LSAgICAgICAgb3V0LnByaW50KCJMTEludCIpOwotICAgICAgICByZXR1cm47Ci0gICAgY2FzZSBK U0M6OkpJVENvZGU6OkJhc2VsaW5lSklUOgotICAgICAgICBvdXQucHJpbnQoIkJhc2VsaW5lIik7 Ci0gICAgICAgIHJldHVybjsKLSAgICBjYXNlIEpTQzo6SklUQ29kZTo6REZHSklUOgotICAgICAg ICBvdXQucHJpbnQoIkRGRyIpOwotICAgICAgICByZXR1cm47Ci0gICAgY2FzZSBKU0M6OkpJVENv ZGU6OkZUTEpJVDoKLSAgICAgICAgb3V0LnByaW50KCJGVEwiKTsKLSAgICAgICAgcmV0dXJuOwot ICAgIGRlZmF1bHQ6Ci0gICAgICAgIENSQVNIKCk7Ci0gICAgICAgIHJldHVybjsKLSAgICB9Cisg ICAgb3V0LnByaW50KCIlcyIsIEpTQzo6SklUQ29kZTo6dHlwZU5hbWUodHlwZSkpOwogfQogCiB9 IC8vIG5hbWVzcGFjZSBXVEYKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUQ29k ZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUQ29kZS5oCShy ZXZpc2lvbiAxNzQ4OTUpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVENvZGUuaAko d29ya2luZyBjb3B5KQpAQCAtNjIsNiArNjIsOCBAQCBwdWJsaWM6CiAgICAgICAgIEZUTEpJVAog ICAgIH07CiAgICAgCisgICAgc3RhdGljIGNvbnN0IGNoYXIqIHR5cGVOYW1lKEpJVFR5cGUpOwor CiAgICAgc3RhdGljIEpJVFR5cGUgYm90dG9tVGllckpJVCgpCiAgICAgewogICAgICAgICByZXR1 cm4gQmFzZWxpbmVKSVQ7Cg== 240134 2014-10-20 11:48:55 -0700 2014-10-20 11:50:28 -0700 updated patch bug-137888.patch text/plain 2863 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTc0ODk1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDE0LTEwLTIwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBG YWN0b3Igb3V0IEpJVENvZGU6OnR5cGVOYW1lKCkgZm9yIGRlYnVnZ2luZyB1c2UuCisgICAgICAg IDxodHRwczovL3dlYmtpdC5vcmcvYi8xMzc4ODg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgSklUQ29kZSdzIHByaW50SW50ZXJuYWwoKSBjdXJyZW50 bHkgZGVjb2RlcyB0aGUgSklUVHlwZSBpbnRvIGEgc3RyaW5nIGFuZAorICAgICAgICBwcmludHMg aXQuICBUaGlzIGNoYW5nZSBmYWN0b3JzIG91dCB0aGUgcGFydCB0aGF0IGRlY29kZXMgdGhlIEpJ VFR5cGUgaW50bworICAgICAgICBKSVRDb2RlOjp0eXBlTmFtZSgpIHNvIHRoYXQgd2UgY2FuIGNh bGwgaXQgZnJvbSBsbGRiIHdoaWxlIGRlYnVnZ2luZyB0bworICAgICAgICBxdWlja2x5IGRlY29k ZSBhIEpJVFR5cGUgdmFsdWUuCisKKyAgICAgICAgKiBqaXQvSklUQ29kZS5jcHA6CisgICAgICAg IChKU0M6OkpJVENvZGU6OnR5cGVOYW1lKToKKyAgICAgICAgKFdURjo6cHJpbnRJbnRlcm5hbCk6 CisgICAgICAgICogaml0L0pJVENvZGUuaDoKKwogMjAxNC0xMC0yMCAgTWFyayBMYW0gIDxtYXJr LmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IHBsYWNlbWVudCBvZiBhIGZldyBpdGVtcyBp biB2Y3hwcm9qIEl0ZW1Hcm91cHMuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJ VENvZGUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUQ29k ZS5jcHAJKHJldmlzaW9uIDE3NDg5NSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklU Q29kZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQzLDYgKzQzLDI3IEBAIEpJVENvZGU6On5KSVRD b2RlKCkKIHsKIH0KIAorY29uc3QgY2hhciogSklUQ29kZTo6dHlwZU5hbWUoSklUVHlwZSBqaXRU eXBlKQoreworICAgIHN3aXRjaCAoaml0VHlwZSkgeworICAgIGNhc2UgTm9uZToKKyAgICAgICAg cmV0dXJuICJOb25lIjsKKyAgICBjYXNlIEhvc3RDYWxsVGh1bms6CisgICAgICAgIHJldHVybiAi SG9zdCI7CisgICAgY2FzZSBJbnRlcnByZXRlclRodW5rOgorICAgICAgICByZXR1cm4gIkxMSW50 IjsKKyAgICBjYXNlIEJhc2VsaW5lSklUOgorICAgICAgICByZXR1cm4gIkJhc2VsaW5lIjsKKyAg ICBjYXNlIERGR0pJVDoKKyAgICAgICAgcmV0dXJuICJERkciOworICAgIGNhc2UgRlRMSklUOgor ICAgICAgICByZXR1cm4gIkZUTCI7CisgICAgZGVmYXVsdDoKKyAgICAgICAgQ1JBU0goKTsKKyAg ICAgICAgcmV0dXJuICIiOworICAgIH0KK30KKwogSlNWYWx1ZSBKSVRDb2RlOjpleGVjdXRlKFZN KiB2bSwgUHJvdG9DYWxsRnJhbWUqIHByb3RvQ2FsbEZyYW1lKQogewogICAgIHZvaWQqIGVudHJ5 QWRkcmVzczsKQEAgLTIzMywyOSArMjU0LDcgQEAgbmFtZXNwYWNlIFdURiB7CiAKIHZvaWQgcHJp bnRJbnRlcm5hbChQcmludFN0cmVhbSYgb3V0LCBKU0M6OkpJVENvZGU6OkpJVFR5cGUgdHlwZSkK IHsKLSAgICBzd2l0Y2ggKHR5cGUpIHsKLSAgICBjYXNlIEpTQzo6SklUQ29kZTo6Tm9uZToKLSAg ICAgICAgb3V0LnByaW50KCJOb25lIik7Ci0gICAgICAgIHJldHVybjsKLSAgICBjYXNlIEpTQzo6 SklUQ29kZTo6SG9zdENhbGxUaHVuazoKLSAgICAgICAgb3V0LnByaW50KCJIb3N0Iik7Ci0gICAg ICAgIHJldHVybjsKLSAgICBjYXNlIEpTQzo6SklUQ29kZTo6SW50ZXJwcmV0ZXJUaHVuazoKLSAg ICAgICAgb3V0LnByaW50KCJMTEludCIpOwotICAgICAgICByZXR1cm47Ci0gICAgY2FzZSBKU0M6 OkpJVENvZGU6OkJhc2VsaW5lSklUOgotICAgICAgICBvdXQucHJpbnQoIkJhc2VsaW5lIik7Ci0g ICAgICAgIHJldHVybjsKLSAgICBjYXNlIEpTQzo6SklUQ29kZTo6REZHSklUOgotICAgICAgICBv dXQucHJpbnQoIkRGRyIpOwotICAgICAgICByZXR1cm47Ci0gICAgY2FzZSBKU0M6OkpJVENvZGU6 OkZUTEpJVDoKLSAgICAgICAgb3V0LnByaW50KCJGVEwiKTsKLSAgICAgICAgcmV0dXJuOwotICAg IGRlZmF1bHQ6Ci0gICAgICAgIENSQVNIKCk7Ci0gICAgICAgIHJldHVybjsKLSAgICB9CisgICAg b3V0LnByaW50KCIlcyIsIEpTQzo6SklUQ29kZTo6dHlwZU5hbWUodHlwZSkpOwogfQogCiB9IC8v IG5hbWVzcGFjZSBXVEYKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUQ29kZS5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUQ29kZS5oCShyZXZp c2lvbiAxNzQ4OTUpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVENvZGUuaAkod29y a2luZyBjb3B5KQpAQCAtNjIsNiArNjIsOCBAQCBwdWJsaWM6CiAgICAgICAgIEZUTEpJVAogICAg IH07CiAgICAgCisgICAgc3RhdGljIGNvbnN0IGNoYXIqIHR5cGVOYW1lKEpJVFR5cGUpOworCiAg ICAgc3RhdGljIEpJVFR5cGUgYm90dG9tVGllckpJVCgpCiAgICAgewogICAgICAgICByZXR1cm4g QmFzZWxpbmVKSVQ7Cg== 242597 2014-12-04 16:39:08 -0800 2014-12-04 16:45:15 -0800 follow up patch to fix use of PrintStream::print(). bug-137888b.patch text/plain 1118 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTc2ODIzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDE0LTEyLTA0ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBG YWN0b3Igb3V0IEpJVENvZGU6OnR5cGVOYW1lKCkgZm9yIGRlYnVnZ2luZyB1c2UgW2ZvbGxvdyB1 cF0uCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xMzc4ODg+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBqaXQvSklUQ29kZS5jcHA6Cisg ICAgICAgIChXVEY6OnByaW50SW50ZXJuYWwpOgorICAgICAgICAtIEZpeGluZyBiZWNhdXNlIFBy aW50U3RyZWFtOjpwcmludCgpIGRvZXNuJ3QgbmVlZCBhIGZvcm1hdGluZyBzdHJpbmcuCisKIDIw MTQtMTItMDQgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBN YXJrZWQgc29tZSBmaW5hbCB0aGluZ3MgZmluYWwuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENv cmUvaml0L0pJVENvZGUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9q aXQvSklUQ29kZS5jcHAJKHJldmlzaW9uIDE3NjgyMykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9qaXQvSklUQ29kZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI1NCw3ICsyNTQsNyBAQCBuYW1l c3BhY2UgV1RGIHsKIAogdm9pZCBwcmludEludGVybmFsKFByaW50U3RyZWFtJiBvdXQsIEpTQzo6 SklUQ29kZTo6SklUVHlwZSB0eXBlKQogewotICAgIG91dC5wcmludCgiJXMiLCBKU0M6OkpJVENv ZGU6OnR5cGVOYW1lKHR5cGUpKTsKKyAgICBvdXQucHJpbnQoSlNDOjpKSVRDb2RlOjp0eXBlTmFt ZSh0eXBlKSk7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdURgo=