137885 2014-10-20 10:55:09 -0700 Make post checkin suggested changes to r174847 2014-10-20 18:21:00 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 msaboff msaboff oldest_to_newest 1042881 0 msaboff 2014-10-20 10:55:09 -0700 From https://bugs.webkit.org/show_bug.cgi?id=137839#c4 View in context: https://bugs.webkit.org/attachment.cgi?id=240045&action=review > Source/WebCore/bindings/js/JSHTMLDocumentCustom.cpp:65 > + if (propertyName == Identifier(exec, "open")) { I believe this is less efficient than: if (propertyName == "open") { > Source/WebCore/bindings/js/JSHTMLDocumentCustom.cpp:76 > + const HashTableValue* entry = JSHTMLDocument::info()->staticPropHashTable->entry(propertyName); > + if (entry) { Would be nice to put this definition inside the if. 1042978 1 240147 msaboff 2014-10-20 14:49:23 -0700 Created attachment 240147 Patch 1042985 2 240147 mark.lam 2014-10-20 15:24:23 -0700 Comment on attachment 240147 Patch r=me 1043014 3 msaboff 2014-10-20 16:37:59 -0700 Committed r174913: <http://trac.webkit.org/changeset/174913> 1043052 4 msaboff 2014-10-20 18:20:17 -0700 (In reply to comment #3) > Committed r174913: <http://trac.webkit.org/changeset/174913> Changes didn't land with this revision due to webkit-patch issue. 1043053 5 msaboff 2014-10-20 18:21:00 -0700 Committed r174918: <http://trac.webkit.org/changeset/174918> 240147 2014-10-20 14:49:23 -0700 2014-10-20 15:24:23 -0700 Patch 137885.patch text/plain 2000 msaboff SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NDkwNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE0LTEwLTIwICBNaWNoYWVs IFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAgICAgIE1ha2UgcG9zdCBjaGVja2lu IHN1Z2dlc3RlZCBjaGFuZ2VzIHRvIHIxNzQ4NDcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNzg4NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEVsaW1pbmF0ZWQgdGhlIGNyZWF0aW9uIG9mIGEgdGVtcG9y YXJ5IElkZW50aWZpZXIgd2hlbiBjb21wYXJpbmcgcHJvcGVydHlOYW1lIHRvICJvcGVuIi4KKyAg ICAgICAgTWFkZSB0aGUgc3VnZ2VzdGVkIHBvc3QgY2hlY2tpbiBjaGFuZ2UgdG8gcHV0IHRoZSBk ZWNsYXJhdGlvbiBvZiAiZW50cnkiIGludG8gdGhlIGlmLgorCisgICAgICAgICogYmluZGluZ3Mv anMvSlNIVE1MRG9jdW1lbnRDdXN0b20uY3BwOgorICAgICAgICAoV2ViQ29yZTo6SlNIVE1MRG9j dW1lbnQ6OmdldE93blByb3BlcnR5U2xvdCk6CisKIDIwMTQtMTAtMjAgIERlYW4gSmFja3NvbiAg PGRpbm9AYXBwbGUuY29tPgogCiAgICAgICAgIFtNYWNdIFN1cHBvcnQgImludmVydGVkLWNvbG9y cyIgYW5kICJtb25vY2hyb21lIiBtZWRpYSBmZWF0dXJlLgpJbmRleDogU291cmNlL1dlYkNvcmUv YmluZGluZ3MvanMvSlNIVE1MRG9jdW1lbnRDdXN0b20uY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTSFRNTERvY3VtZW50Q3VzdG9tLmNwcAkocmV2aXNpb24g MTc0OTA3KQorKysgU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNIVE1MRG9jdW1lbnRDdXN0 b20uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02Miw3ICs2Miw3IEBAIGJvb2wgSlNIVE1MRG9jdW1l bnQ6OmdldE93blByb3BlcnR5U2xvdCgKICAgICBKU0hUTUxEb2N1bWVudCogdGhpc09iamVjdCA9 IGpzQ2FzdDxKU0hUTUxEb2N1bWVudCo+KG9iamVjdCk7CiAgICAgQVNTRVJUX0dDX09CSkVDVF9J TkhFUklUUyh0aGlzT2JqZWN0LCBpbmZvKCkpOwogCi0gICAgaWYgKHByb3BlcnR5TmFtZSA9PSBJ ZGVudGlmaWVyKGV4ZWMsICJvcGVuIikpIHsKKyAgICBpZiAoZXF1YWwocHJvcGVydHlOYW1lLnB1 YmxpY05hbWUoKSwgIm9wZW4iKSkgewogICAgICAgICBzbG90LnNldEN1c3RvbSh0aGlzT2JqZWN0 LCBSZWFkT25seSB8IERvbnREZWxldGUgfCBEb250RW51bSwgbm9uQ2FjaGluZ1N0YXRpY0Z1bmN0 aW9uR2V0dGVyPGpzSFRNTERvY3VtZW50UHJvdG90eXBlRnVuY3Rpb25PcGVuLCAyPik7CiAgICAg ICAgIHJldHVybiB0cnVlOwogICAgIH0KQEAgLTcyLDggKzcyLDcgQEAgYm9vbCBKU0hUTUxEb2N1 bWVudDo6Z2V0T3duUHJvcGVydHlTbG90KAogICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9CiAK LSAgICBjb25zdCBIYXNoVGFibGVWYWx1ZSogZW50cnkgPSBKU0hUTUxEb2N1bWVudDo6aW5mbygp LT5zdGF0aWNQcm9wSGFzaFRhYmxlLT5lbnRyeShwcm9wZXJ0eU5hbWUpOwotICAgIGlmIChlbnRy eSkgeworICAgIGlmIChjb25zdCBIYXNoVGFibGVWYWx1ZSogZW50cnkgPSBKU0hUTUxEb2N1bWVu dDo6aW5mbygpLT5zdGF0aWNQcm9wSGFzaFRhYmxlLT5lbnRyeShwcm9wZXJ0eU5hbWUpKSB7CiAg ICAgICAgIHNsb3Quc2V0Q2FjaGVhYmxlQ3VzdG9tKHRoaXNPYmplY3QsIGVudHJ5LT5hdHRyaWJ1 dGVzKCksIGVudHJ5LT5wcm9wZXJ0eUdldHRlcigpKTsKICAgICAgICAgcmV0dXJuIHRydWU7CiAg ICAgfQo=