137876 2014-10-20 04:14:55 -0700 Avoid unnecessary NSURLResponse construction for QuickLook on iOS 2014-10-20 10:20:34 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 koivisto webkit-unassigned aestes ddkilzer psolanki oldest_to_newest 1042780 0 koivisto 2014-10-20 04:14:55 -0700 QuickLook specific code path creates NSURLResponse in the web process for every response. It is rarely needed so this is unnecessary work. 1042781 1 240109 koivisto 2014-10-20 04:22:47 -0700 Created attachment 240109 patch 1042825 2 240109 psolanki 2014-10-20 08:53:52 -0700 Comment on attachment 240109 patch Does this work in WebKit1? 1042831 3 240109 aestes 2014-10-20 09:19:36 -0700 Comment on attachment 240109 patch View in context: https://bugs.webkit.org/attachment.cgi?id=240109&action=review > Source/WebCore/ChangeLog:21 > + Switch inteface to take ResourceResponse. interface 1042837 4 koivisto 2014-10-20 09:35:54 -0700 (In reply to comment #2) > Comment on attachment 240109 [details] > patch > > Does this work in WebKit1? WK1 shouldn't be affected as these code paths are WK2 only. 1042851 5 240109 darin 2014-10-20 10:01:09 -0700 Comment on attachment 240109 patch View in context: https://bugs.webkit.org/attachment.cgi?id=240109&action=review > Source/WebCore/platform/network/ios/QuickLook.mm:501 > + std::unique_ptr<QuickLookHandle> quickLookHandle(new QuickLookHandle([loader.originalRequest().nsURLRequest(DoNotUpdateHTTPBody) URL], nil, response.nsURLResponse(), delegate.get())); The correct style here is to use std::make_unique, not new. But I imagine if we tried that we’d have to change what’s public. > Source/WebCore/platform/network/ios/QuickLook.mm:504 > return WTF::move(quickLookHandle); Normally we don’t need WTF::move for a return value in a case like this. 1042861 6 koivisto 2014-10-20 10:20:34 -0700 https://trac.webkit.org/r174889 240109 2014-10-20 04:22:47 -0700 2014-10-20 09:19:36 -0700 patch quicklook-no-nsurlresponse-2.patch text/plain 7612 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NDg2NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDE0LTEwLTE5ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBBdm9pZCB1bm5lY2Vzc2FyeSBO U1VSTFJlc3BvbnNlIGNvbnN0cnVjdGlvbiBmb3IgUXVpY2tMb29rIG9uIGlPUworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM3ODc2CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUXVpY2tMb29rIHNwZWNpZmlj IGNvZGUgcGF0aCBjcmVhdGVzIE5TVVJMUmVzcG9uc2UgaW4gdGhlIHdlYiBwcm9jZXNzIGZvciBl dmVyeSByZXNwb25zZS4KKyAgICAgICAgSXQgaXMgcmFyZWx5IG5lZWRlZCBzbyB0aGlzIGlzIHVu bmVjZXNzYXJ5IHdvcmsuCisKKyAgICAgICAgKiBXZWJDb3JlLmV4cC5pbjoKKyAgICAgICAgKiBw bGF0Zm9ybS9uZXR3b3JrL2lvcy9RdWlja0xvb2suaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3 b3JrL2lvcy9RdWlja0xvb2subW06CisgICAgICAgIChXZWJDb3JlOjppc01haW5SZXNvdXJjZUxv YWRlcik6CisgICAgICAgIChXZWJDb3JlOjpRdWlja0xvb2tIYW5kbGU6OnNob3VsZENyZWF0ZUZv ck1JTUVUeXBlKToKKworICAgICAgICAgICAgU2VwYXJhdGUgZnVuY3Rpb24gZm9yIHRlc3Rpbmcg aWYgUXVpY2tMb29rSGFuZGxlIGlzIG5lZWRlZC4KKworICAgICAgICAoV2ViQ29yZTo6UXVpY2tM b29rSGFuZGxlOjpjcmVhdGUpOgorCisgICAgICAgICAgICBTd2l0Y2ggaW50ZWZhY2UgdG8gdGFr ZSBSZXNvdXJjZVJlc3BvbnNlLgorCiAyMDE0LTEwLTE4ICBDaHJpcyBEdW1leiAgPGNkdW1lekBh cHBsZS5jb20+CiAKICAgICAgICAgW01hY10gVXNlIEZhc3QgZW51bWVyYXRpb24gY29uc2lzdGVu dGx5IGluIFdlYkZvbnRDYWNoZS5tbQpJbmRleDogU291cmNlL1dlYkNvcmUvV2ViQ29yZS5leHAu aW4KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvV2ViQ29yZS5leHAuaW4JKHJldmlzaW9u IDE3NDgxNCkKKysrIFNvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZXhwLmluCSh3b3JraW5nIGNvcHkp CkBAIC0zMzM0LDcgKzMzMzQsOCBAQCBfd2tJc1B1YmxpY1N1ZmZpeAogX19aTjdXZWJDb3JlMTVR dWlja0xvb2tIYW5kbGUxMG5zUmVzcG9uc2VFdgogX19aTjdXZWJDb3JlMTVRdWlja0xvb2tIYW5k bGUxNGRpZFJlY2VpdmVEYXRhRVBLOF9fQ0ZEYXRhCiBfX1pON1dlYkNvcmUxNVF1aWNrTG9va0hh bmRsZTE2ZGlkRmluaXNoTG9hZGluZ0V2Ci1fX1pON1dlYkNvcmUxNVF1aWNrTG9va0hhbmRsZTZj cmVhdGVFUE5TXzE0UmVzb3VyY2VMb2FkZXJFUDEzTlNVUkxSZXNwb25zZQorX19aTjdXZWJDb3Jl MTVRdWlja0xvb2tIYW5kbGUyM3Nob3VsZENyZWF0ZUZvck1JTUVUeXBlRVJLTjNXVEY2U3RyaW5n RQorX19aTjdXZWJDb3JlMTVRdWlja0xvb2tIYW5kbGU2Y3JlYXRlRVJOU18xNFJlc291cmNlTG9h ZGVyRVJLTlNfMTZSZXNvdXJjZVJlc3BvbnNlRQogX19aTjdXZWJDb3JlMTVRdWlja0xvb2tIYW5k bGU3ZGlkRmFpbEV2CiBfX1pON1dlYkNvcmUxNVF1aWNrTG9va0hhbmRsZUQxRXYKIF9fWk43V2Vi Q29yZTIxUmVzb3VyY2VMb2FkU2NoZWR1bGVyMjZtYXliZUxvYWRRdWlja0xvb2tSZXNvdXJjZUVS TlNfMTRSZXNvdXJjZUxvYWRlckUKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvaW9zL1F1aWNrTG9vay5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvaW9zL1F1aWNrTG9vay5oCShyZXZpc2lvbiAxNzQ4MTQpCisrKyBTb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9uZXR3b3JrL2lvcy9RdWlja0xvb2suaAkod29ya2luZyBjb3B5KQpAQCAt NTQsNiArNTQsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiBjbGFzcyBRdWlja0xvb2tIYW5kbGVD bGllbnQ7CiBjbGFzcyBSZXNvdXJjZUhhbmRsZTsKIGNsYXNzIFJlc291cmNlTG9hZGVyOworY2xh c3MgUmVzb3VyY2VSZXNwb25zZTsKIGNsYXNzIFN5bmNocm9ub3VzUmVzb3VyY2VIYW5kbGVDRlVS TENvbm5lY3Rpb25EZWxlZ2F0ZTsKIAogQ2xhc3MgUUxQcmV2aWV3Q29udmVydGVyQ2xhc3MoKTsK QEAgLTgyLDExICs4MywxNSBAQCBXRUJDT1JFX0VYUE9SVCBOU1N0cmluZyAqY3JlYXRlVGVtcG9y YXJ5CiBjbGFzcyBRdWlja0xvb2tIYW5kbGUgewogICAgIFdURl9NQUtFX05PTkNPUFlBQkxFKFF1 aWNrTG9va0hhbmRsZSk7CiBwdWJsaWM6CisgICAgV0VCQ09SRV9FWFBPUlQgc3RhdGljIGJvb2wg c2hvdWxkQ3JlYXRlRm9yTUlNRVR5cGUoY29uc3QgU3RyaW5nJik7CisKICAgICBzdGF0aWMgc3Rk Ojp1bmlxdWVfcHRyPFF1aWNrTG9va0hhbmRsZT4gY3JlYXRlKFJlc291cmNlSGFuZGxlKiwgTlNV UkxDb25uZWN0aW9uICosIE5TVVJMUmVzcG9uc2UgKiwgaWQgZGVsZWdhdGUpOwogI2lmIFVTRShD Rk5FVFdPUkspCiAgICAgc3RhdGljIHN0ZDo6dW5pcXVlX3B0cjxRdWlja0xvb2tIYW5kbGU+IGNy ZWF0ZShSZXNvdXJjZUhhbmRsZSosIFN5bmNocm9ub3VzUmVzb3VyY2VIYW5kbGVDRlVSTENvbm5l Y3Rpb25EZWxlZ2F0ZSosIENGVVJMUmVzcG9uc2VSZWYpOwogI2VuZGlmCi0gICAgV0VCQ09SRV9F WFBPUlQgc3RhdGljIHN0ZDo6dW5pcXVlX3B0cjxRdWlja0xvb2tIYW5kbGU+IGNyZWF0ZShSZXNv dXJjZUxvYWRlciosIE5TVVJMUmVzcG9uc2UgKik7CisgICAgLy8gRklYTUU6IFVzZSBvZiBSZXNv dXJjZUxvYWRlciBoZXJlIGlzIGEgcGxhdGZvcm0gdmlvbGF0aW9uLgorICAgIFdFQkNPUkVfRVhQ T1JUIHN0YXRpYyBzdGQ6OnVuaXF1ZV9wdHI8UXVpY2tMb29rSGFuZGxlPiBjcmVhdGUoUmVzb3Vy Y2VMb2FkZXImLCBjb25zdCBSZXNvdXJjZVJlc3BvbnNlJik7CisKICAgICBXRUJDT1JFX0VYUE9S VCB+UXVpY2tMb29rSGFuZGxlKCk7CiAKICAgICBXRUJDT1JFX0VYUE9SVCBib29sIGRpZFJlY2Vp dmVEYXRhQXJyYXkoQ0ZBcnJheVJlZik7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9u ZXR3b3JrL2lvcy9RdWlja0xvb2subW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbmV0d29yay9pb3MvUXVpY2tMb29rLm1tCShyZXZpc2lvbiAxNzQ4MTQpCisrKyBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2lvcy9RdWlja0xvb2subW0JKHdvcmtpbmcgY29w eSkKQEAgLTQ4OCwyMSArNDg4LDE5IEBAIENGVVJMUmVzcG9uc2VSZWYgUXVpY2tMb29rSGFuZGxl OjpjZlJlc3AKIH0KICNlbmRpZgogCi1zdGF0aWMgaW5saW5lIGJvb2wgaXNNYWluUmVzb3VyY2VM b2FkZXIoUmVzb3VyY2VMb2FkZXIqIGxvYWRlcikKK2Jvb2wgUXVpY2tMb29rSGFuZGxlOjpzaG91 bGRDcmVhdGVGb3JNSU1FVHlwZShjb25zdCBTdHJpbmcmIG1pbWVUeXBlKQogewotICAgIHJldHVy biBsb2FkZXItPmRvY3VtZW50TG9hZGVyKCktPm1haW5SZXNvdXJjZUxvYWRlcigpID09IGxvYWRl cjsKKyAgICByZXR1cm4gW1dlYkNvcmU6OlFMUHJldmlld0dldFN1cHBvcnRlZE1JTUVUeXBlc1Nl dCgpIGNvbnRhaW5zT2JqZWN0Om1pbWVUeXBlXTsKIH0KIAotc3RkOjp1bmlxdWVfcHRyPFF1aWNr TG9va0hhbmRsZT4gUXVpY2tMb29rSGFuZGxlOjpjcmVhdGUoUmVzb3VyY2VMb2FkZXIqIGxvYWRl ciwgTlNVUkxSZXNwb25zZSAqcmVzcG9uc2UpCitzdGQ6OnVuaXF1ZV9wdHI8UXVpY2tMb29rSGFu ZGxlPiBRdWlja0xvb2tIYW5kbGU6OmNyZWF0ZShSZXNvdXJjZUxvYWRlciYgbG9hZGVyLCBjb25z dCBSZXNvdXJjZVJlc3BvbnNlJiByZXNwb25zZSkKIHsKLSAgICBBU1NFUlRfQVJHKGxvYWRlciwg bG9hZGVyKTsKLSAgICBpZiAoIWlzTWFpblJlc291cmNlTG9hZGVyKGxvYWRlcikgfHwgIVtXZWJD b3JlOjpRTFByZXZpZXdHZXRTdXBwb3J0ZWRNSU1FVHlwZXNTZXQoKSBjb250YWluc09iamVjdDpb cmVzcG9uc2UgTUlNRVR5cGVdXSkKLSAgICAgICAgcmV0dXJuIG51bGxwdHI7CisgICAgQVNTRVJU KHNob3VsZENyZWF0ZUZvck1JTUVUeXBlKHJlc3BvbnNlLm1pbWVUeXBlKCkpKTsKIAotICAgIFJl dGFpblB0cjxXZWJSZXNvdXJjZUxvYWRlclF1aWNrTG9va0RlbGVnYXRlPiBkZWxlZ2F0ZSA9IGFk b3B0TlMoW1tXZWJSZXNvdXJjZUxvYWRlclF1aWNrTG9va0RlbGVnYXRlIGFsbG9jXSBpbml0V2l0 aFJlc291cmNlTG9hZGVyOmxvYWRlcl0pOwotICAgIHN0ZDo6dW5pcXVlX3B0cjxRdWlja0xvb2tI YW5kbGU+IHF1aWNrTG9va0hhbmRsZShuZXcgUXVpY2tMb29rSGFuZGxlKFtsb2FkZXItPm9yaWdp bmFsUmVxdWVzdCgpLm5zVVJMUmVxdWVzdChEb05vdFVwZGF0ZUhUVFBCb2R5KSBVUkxdLCBuaWws IHJlc3BvbnNlLCBkZWxlZ2F0ZS5nZXQoKSkpOworICAgIFJldGFpblB0cjxXZWJSZXNvdXJjZUxv YWRlclF1aWNrTG9va0RlbGVnYXRlPiBkZWxlZ2F0ZSA9IGFkb3B0TlMoW1tXZWJSZXNvdXJjZUxv YWRlclF1aWNrTG9va0RlbGVnYXRlIGFsbG9jXSBpbml0V2l0aFJlc291cmNlTG9hZGVyOiZsb2Fk ZXJdKTsKKyAgICBzdGQ6OnVuaXF1ZV9wdHI8UXVpY2tMb29rSGFuZGxlPiBxdWlja0xvb2tIYW5k bGUobmV3IFF1aWNrTG9va0hhbmRsZShbbG9hZGVyLm9yaWdpbmFsUmVxdWVzdCgpLm5zVVJMUmVx dWVzdChEb05vdFVwZGF0ZUhUVFBCb2R5KSBVUkxdLCBuaWwsIHJlc3BvbnNlLm5zVVJMUmVzcG9u c2UoKSwgZGVsZWdhdGUuZ2V0KCkpKTsKICAgICBbZGVsZWdhdGUgc2V0UXVpY2tMb29rSGFuZGxl OnF1aWNrTG9va0hhbmRsZS5nZXQoKV07Ci0gICAgbG9hZGVyLT5kaWRDcmVhdGVRdWlja0xvb2tI YW5kbGUoKnF1aWNrTG9va0hhbmRsZSk7CisgICAgbG9hZGVyLmRpZENyZWF0ZVF1aWNrTG9va0hh bmRsZSgqcXVpY2tMb29rSGFuZGxlKTsKICAgICByZXR1cm4gV1RGOjptb3ZlKHF1aWNrTG9va0hh bmRsZSk7CiB9CiAKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NDgxNCkKKysrIFNvdXJjZS9X ZWJLaXQyL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTEw LTE5ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBBdm9pZCB1 bm5lY2Vzc2FyeSBOU1VSTFJlc3BvbnNlIGNvbnN0cnVjdGlvbiBmb3IgUXVpY2tMb29rIG9uIGlP UworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM3ODc2 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQ cm9jZXNzL05ldHdvcmsvV2ViUmVzb3VyY2VMb2FkZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpX ZWJSZXNvdXJjZUxvYWRlcjo6ZGlkUmVjZWl2ZVJlc3BvbnNlKToKKworICAgICAgICAgICAgU3dp dGNoIHRvIHRoZSBtb2RpZmllZCBRdWlja0xvb2tIYW5kbGUgaW50ZXJmYWNlIHRoYXQgZG9lcyBu b3QgbmVlZCBOU1VSTFJlc3BvbnNlLgorCiAyMDE0LTEwLTE2ICBQYXNjYWwgSmFjcXVlbWFydCAg PHAuamFjcXVlbWFydEBzYW1zdW5nLmNvbT4KIAogICAgICAgICBSZW1vdmluZyBDVVNUT01fUFJP VE9DT0xTIGd1YXJkCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL05ldHdvcmsvV2Vi UmVzb3VyY2VMb2FkZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvTmV0d29yay9XZWJSZXNvdXJjZUxvYWRlci5jcHAJKHJldmlzaW9uIDE3NDgxNCkKKysrIFNv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvTmV0d29yay9XZWJSZXNvdXJjZUxvYWRlci5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTExMiwxMyArMTEyLDE4IEBAIHZvaWQgV2ViUmVzb3VyY2VMb2FkZXI6 OmRpZFJlY2VpdmVSZXNwb24KICAgICBpZiAobV9jb3JlTG9hZGVyLT5kb2N1bWVudExvYWRlcigp LT5hcHBsaWNhdGlvbkNhY2hlSG9zdCgpLT5tYXliZUxvYWRGYWxsYmFja0ZvclJlc3BvbnNlKG1f Y29yZUxvYWRlci5nZXQoKSwgcmVzcG9uc2UpKQogICAgICAgICByZXR1cm47CiAKKyAgICBib29s IHNob3VkQ2FsbENvcmVMb2FkZXJEaWRSZWNlaXZlUmVzcG9uc2UgPSB0cnVlOwogI2lmIFVTRShR VUlDS19MT09LKQogICAgIC8vIFJlZnJhaW4gZnJvbSBjYWxsaW5nIGRpZFJlY2VpdmVSZXNwb25z ZSBpZiBRdWlja0xvb2sgd2lsbCBjb252ZXJ0IHRoaXMgcmVzcG9uc2UsIHNpbmNlIHRoZSBNSU1F IHR5cGUgb2YgdGhlCiAgICAgLy8gY29udmVydGVkIHJlc291cmNlIGlzbid0IHlldCBrbm93bi4g V2ViUmVzb3VyY2VMb2FkZXJRdWlja0xvb2tEZWxlZ2F0ZSB3aWxsIGxhdGVyIGNhbGwgZGlkUmVj ZWl2ZVJlc3BvbnNlIHVwb24KICAgICAvLyByZWNlaXZpbmcgdGhlIGNvbnZlcnRlZCBkYXRhLgot ICAgIG1fY29yZUxvYWRlci0+ZG9jdW1lbnRMb2FkZXIoKS0+c2V0UXVpY2tMb29rSGFuZGxlKFF1 aWNrTG9va0hhbmRsZTo6Y3JlYXRlKHJlc291cmNlTG9hZGVyKCksIHJlc3BvbnNlLm5zVVJMUmVz cG9uc2UoKSkpOwotICAgIGlmICghbV9jb3JlTG9hZGVyLT5kb2N1bWVudExvYWRlcigpLT5xdWlj a0xvb2tIYW5kbGUoKSkKKyAgICBib29sIGlzTWFpbkxvYWQgPSBtX2NvcmVMb2FkZXItPmRvY3Vt ZW50TG9hZGVyKCktPm1haW5SZXNvdXJjZUxvYWRlcigpID09IG1fY29yZUxvYWRlcjsKKyAgICBp ZiAoaXNNYWluTG9hZCAmJiBRdWlja0xvb2tIYW5kbGU6OnNob3VsZENyZWF0ZUZvck1JTUVUeXBl KHJlc3BvbnNlLm1pbWVUeXBlKCkpKSB7CisgICAgICAgIG1fY29yZUxvYWRlci0+ZG9jdW1lbnRM b2FkZXIoKS0+c2V0UXVpY2tMb29rSGFuZGxlKFF1aWNrTG9va0hhbmRsZTo6Y3JlYXRlKCptX2Nv cmVMb2FkZXIsIHJlc3BvbnNlKSk7CisgICAgICAgIHNob3VkQ2FsbENvcmVMb2FkZXJEaWRSZWNl aXZlUmVzcG9uc2UgPSBmYWxzZTsKKyAgICB9CiAjZW5kaWYKKyAgICBpZiAoc2hvdWRDYWxsQ29y ZUxvYWRlckRpZFJlY2VpdmVSZXNwb25zZSkKICAgICAgICAgbV9jb3JlTG9hZGVyLT5kaWRSZWNl aXZlUmVzcG9uc2UocmVzcG9uc2UpOwogCiAgICAgLy8gSWYgbV9jb3JlTG9hZGVyIGJlY29tZXMg bnVsbCBhcyBhIHJlc3VsdCBvZiB0aGUgZGlkUmVjZWl2ZVJlc3BvbnNlIGNhbGxiYWNrLCB3ZSBj YW4ndCB1c2UgdGhlIHNlbmQgZnVuY3Rpb24oKS4gCg==