137872 2014-10-20 02:44:37 -0700 [GTK] Remove the factory method from DragAndDropHandler 2014-10-20 02:54:56 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned berto commit-queue gustavo mrobinson svillar oldest_to_newest 1042761 0 cgarcia 2014-10-20 02:44:37 -0700 Use std::make_unique instead. 1042762 1 240103 cgarcia 2014-10-20 02:46:27 -0700 Created attachment 240103 Patch 1042763 2 240103 svillar 2014-10-20 02:47:50 -0700 Comment on attachment 240103 Patch Yeah 1042764 3 commit-queue 2014-10-20 02:48:53 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1042765 4 cgarcia 2014-10-20 02:54:56 -0700 Committed r174881: <http://trac.webkit.org/changeset/174881> 240103 2014-10-20 02:46:27 -0700 2014-10-20 02:47:50 -0700 Patch wk2-dnd-factory-method.diff text/plain 3199 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAxMDlmYjU4Li4wNzJjZjE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjAg QEAKIDIwMTQtMTAtMjAgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCisgICAgICAgIFtHVEtdIFJlbW92ZSB0aGUgZmFjdG9yeSBtZXRob2QgZnJvbSBEcmFnQW5k RHJvcEhhbmRsZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEzNzg3MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIE1ha2UgdGhlIGNvbnN0cnVjdG9yIHB1YmxpYyBhbmQgdXNlIHN0ZDo6bWFrZV91bmlxdWUg aW5zdGVhZC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNl LmNwcDoKKyAgICAgICAgKHdlYmtpdFdlYlZpZXdCYXNlRHJhZ0FuZERyb3BIYW5kbGVyKToKKyAg ICAgICAgKiBVSVByb2Nlc3MvZ3RrL0RyYWdBbmREcm9wSGFuZGxlci5jcHA6CisgICAgICAgIChX ZWJLaXQ6OkRyYWdBbmREcm9wSGFuZGxlcjo6Y3JlYXRlKTogRGVsZXRlZC4KKyAgICAgICAgKiBV SVByb2Nlc3MvZ3RrL0RyYWdBbmREcm9wSGFuZGxlci5oOgorCisyMDE0LTEwLTIwICBDYXJsb3Mg R2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKwogICAgICAgICBbR1RLXSBBZGQg aW5pdGlhbCBnZXN0dXJlcyBzdXBwb3J0CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMzc4MTIKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwCmluZGV4IDQ5ODgzNDcuLjk2ODVj NTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdl YlZpZXdCYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJL aXRXZWJWaWV3QmFzZS5jcHAKQEAgLTEwOTIsNyArMTA5Miw3IEBAIERyYWdBbmREcm9wSGFuZGxl ciYgd2Via2l0V2ViVmlld0Jhc2VEcmFnQW5kRHJvcEhhbmRsZXIoV2ViS2l0V2ViVmlld0Jhc2Uq IHdlYlZpCiB7CiAgICAgV2ViS2l0V2ViVmlld0Jhc2VQcml2YXRlKiBwcml2ID0gd2ViVmlld0Jh c2UtPnByaXY7CiAgICAgaWYgKCFwcml2LT5kcmFnQW5kRHJvcEhhbmRsZXIpCi0gICAgICAgIHBy aXYtPmRyYWdBbmREcm9wSGFuZGxlciA9IERyYWdBbmREcm9wSGFuZGxlcjo6Y3JlYXRlKCpwcml2 LT5wYWdlUHJveHkpOworICAgICAgICBwcml2LT5kcmFnQW5kRHJvcEhhbmRsZXIgPSBzdGQ6Om1h a2VfdW5pcXVlPERyYWdBbmREcm9wSGFuZGxlcj4oKnByaXYtPnBhZ2VQcm94eSk7CiAgICAgcmV0 dXJuICpwcml2LT5kcmFnQW5kRHJvcEhhbmRsZXI7CiB9CiAjZW5kaWYgLy8gRU5BQkxFKERSQUdf U1VQUE9SVCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9ndGsvRHJhZ0Fu ZERyb3BIYW5kbGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9ndGsvRHJhZ0FuZERy b3BIYW5kbGVyLmNwcAppbmRleCA1YWE0OGJhLi45ZTQ0NmE4IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL0RyYWdBbmREcm9wSGFuZGxlci5jcHAKKysrIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL2d0ay9EcmFnQW5kRHJvcEhhbmRsZXIuY3BwCkBAIC00MywxMSAr NDMsNiBAQCB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKIAogbmFtZXNwYWNlIFdlYktpdCB7CiAK LXN0ZDo6dW5pcXVlX3B0cjxEcmFnQW5kRHJvcEhhbmRsZXI+IERyYWdBbmREcm9wSGFuZGxlcjo6 Y3JlYXRlKFdlYlBhZ2VQcm94eSYgcGFnZSkKLXsKLSAgICByZXR1cm4gc3RkOjp1bmlxdWVfcHRy PERyYWdBbmREcm9wSGFuZGxlcj4obmV3IERyYWdBbmREcm9wSGFuZGxlcihwYWdlKSk7Ci19Ci0K IERyYWdBbmREcm9wSGFuZGxlcjo6RHJhZ0FuZERyb3BIYW5kbGVyKFdlYlBhZ2VQcm94eSYgcGFn ZSkKICAgICA6IG1fcGFnZShwYWdlKQogewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL2d0ay9EcmFnQW5kRHJvcEhhbmRsZXIuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9ndGsvRHJhZ0FuZERyb3BIYW5kbGVyLmgKaW5kZXggMWE5ZTYyNi4uMzRlZjljMiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2d0ay9EcmFnQW5kRHJvcEhhbmRsZXIuaAor KysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL0RyYWdBbmREcm9wSGFuZGxlci5oCkBA IC00OSw3ICs0OSw3IEBAIGNsYXNzIFdlYlBhZ2VQcm94eTsKIGNsYXNzIERyYWdBbmREcm9wSGFu ZGxlciB7CiAgICAgV1RGX01BS0VfTk9OQ09QWUFCTEUoRHJhZ0FuZERyb3BIYW5kbGVyKTsKIHB1 YmxpYzoKLSAgICBzdGF0aWMgc3RkOjp1bmlxdWVfcHRyPERyYWdBbmREcm9wSGFuZGxlcj4gY3Jl YXRlKFdlYlBhZ2VQcm94eSYpOworICAgIERyYWdBbmREcm9wSGFuZGxlcihXZWJQYWdlUHJveHkm KTsKIAogICAgIHZvaWQgc3RhcnREcmFnKGNvbnN0IFdlYkNvcmU6OkRyYWdEYXRhJiwgUGFzc1Jl ZlB0cjxTaGFyZWFibGVCaXRtYXA+IGRyYWdJbWFnZSk7CiAgICAgdm9pZCBmaWxsRHJhZ0RhdGEo R2RrRHJhZ0NvbnRleHQqLCBHdGtTZWxlY3Rpb25EYXRhKiwgdW5zaWduZWQgaW5mbyk7CkBAIC03 MSw4ICs3MSw2IEBAIHByaXZhdGU6CiAgICAgICAgIGJvb2wgZHJvcEhhcHBlbmVkOwogICAgIH07 CiAKLSAgICBEcmFnQW5kRHJvcEhhbmRsZXIoV2ViUGFnZVByb3h5Jik7Ci0KICAgICBXZWJDb3Jl OjpEYXRhT2JqZWN0R3RrKiBkYXRhT2JqZWN0Rm9yRHJvcERhdGEoR2RrRHJhZ0NvbnRleHQqLCBH dGtTZWxlY3Rpb25EYXRhKiwgdW5zaWduZWQgaW5mbywgV2ViQ29yZTo6SW50UG9pbnQmIHBvc2l0 aW9uKTsKICAgICBXZWJDb3JlOjpEYXRhT2JqZWN0R3RrKiByZXF1ZXN0RHJhZ0RhdGEoR2RrRHJh Z0NvbnRleHQqLCBjb25zdCBXZWJDb3JlOjpJbnRQb2ludCYgcG9zaXRpb24sIHVuc2lnbmVkIHRp bWUpOwogCg==