<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>137859</bug_id>
          
          <creation_ts>2014-10-18 17:36:35 -0700</creation_ts>
          <short_desc>[SOUP] Disable SSLv3</short_desc>
          <delta_ts>2014-10-21 00:35:09 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Major</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Michael Catanzaro">mcatanzaro</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>cgarcia</cc>
    
    <cc>commit-queue</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>mrobinson</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1042653</commentid>
    <comment_count>0</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2014-10-18 17:36:35 -0700</bug_when>
    <thetext>We need to disable SSLv3 in order to fix the POODLE vulnerability.

Discussion on why the environment variable approach was chosen, and why it&apos;s not set in the GTK+ port instead of in shared soup code: https://bugzilla.gnome.org/show_bug.cgi?id=738633

Quick security test: https://www.ssllabs.com/ssltest/viewMyClient.html

GnuTLS security advisory: http://www.gnutls.org/security.html#GNUTLS-SA-2014-4</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1042654</commentid>
    <comment_count>1</comment_count>
      <attachid>240078</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2014-10-18 17:39:27 -0700</bug_when>
    <thetext>Created attachment 240078
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1042656</commentid>
    <comment_count>2</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2014-10-18 17:43:15 -0700</bug_when>
    <thetext>If we go with this fix, then we need to notify the EFL port so it gets fixed there too.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1042672</commentid>
    <comment_count>3</comment_count>
      <attachid>240078</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2014-10-18 23:53:14 -0700</bug_when>
    <thetext>Comment on attachment 240078
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240078&amp;action=review

&gt; Source/WebKit2/ChangeLog:10
&gt; +        * NetworkProcess/gtk/NetworkProcessMainGtk.cpp:
&gt; +        (WebKit::NetworkProcessMainUnix):
&gt; +        Set G_TLS_GNUTLS_PRIORITY if unset.

You should do the same in the web process, since the network process is only used in multi-webprocess model

&gt; Source/WebKit2/NetworkProcess/gtk/NetworkProcessMainGtk.cpp:70
&gt; +    // Disable SSLv3 very early because it is practically impossible to safely
&gt; +    // use setenv() when multiple threads are running, as another thread calling
&gt; +    // getenv() could cause a crash, and many functions use getenv() internally.
&gt; +    // This workaround will stop working if glib-networking switches away from
&gt; +    // GnuTLS or simply stops parsing this variable. We intentionally do not
&gt; +    // overwrite this priority string if it&apos;s already set by the user.
&gt; +    // https://bugzilla.gnome.org/show_bug.cgi?id=738633
&gt; +    g_setenv(&quot;G_TLS_GNUTLS_PRIORITY&quot;, &quot;NORMAL:%COMPAT:!VERS-SSL3.0&quot;, FALSE);

You can do it even earlier in NetworkProcessMain.cpp and it will be disabled for EFL too.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1042682</commentid>
    <comment_count>4</comment_count>
      <attachid>240085</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2014-10-19 08:12:57 -0700</bug_when>
    <thetext>Created attachment 240085
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1042740</commentid>
    <comment_count>5</comment_count>
      <attachid>240085</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2014-10-19 23:55:26 -0700</bug_when>
    <thetext>Comment on attachment 240085
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240085&amp;action=review

It seems this doesn&apos;t build for EFL, you probably need to include stdlib.h. I guess it&apos;s not possible or easy to tests this?

&gt; Source/WebKit2/ChangeLog:13
&gt; +        * NetworkProcess/EntryPoint/unix/NetworkProcessMain.cpp:
&gt; +        (main):
&gt; +        Set G_TLS_GNUTLS_PRIORITY if unset.
&gt; +        * WebProcess/EntryPoint/unix/WebProcessMain.cpp:
&gt; +        (main):
&gt; +        Set G_TLS_GNUTLS_PRIORITY if unset.

If the comment is the same for all files, move it after the Reviewed by line, as a global comment instead of duplicating it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1043035</commentid>
    <comment_count>6</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2014-10-20 17:48:19 -0700</bug_when>
    <thetext>(In reply to comment #5)
&gt; I guess it&apos;s not possible or easy to tests this?

&quot;Manual verification&quot; (see comment #0). :/  I don&apos;t see how we can write a real test case: the only way to ensure the test server uses SSLv3 is with the this same environment variable, but changing the environment will cause the test to randomly crash.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1043037</commentid>
    <comment_count>7</comment_count>
      <attachid>240166</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2014-10-20 17:49:41 -0700</bug_when>
    <thetext>Created attachment 240166
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1043127</commentid>
    <comment_count>8</comment_count>
      <attachid>240166</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-10-21 00:35:04 -0700</bug_when>
    <thetext>Comment on attachment 240166
Patch

Clearing flags on attachment: 240166

Committed r174927: &lt;http://trac.webkit.org/changeset/174927&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1043128</commentid>
    <comment_count>9</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-10-21 00:35:09 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>240078</attachid>
            <date>2014-10-18 17:39:27 -0700</date>
            <delta_ts>2014-10-19 08:12:49 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-137859-20141018193932.patch</filename>
            <type>text/plain</type>
            <size>1927</size>
            <attacher name="Michael Catanzaro">mcatanzaro</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0ODYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNzEwZDk2ZDMxYjg1ZjNi
MGM4MDY5ZTIzYjJhOWIwZmM2MWZiMjgyYy4uZmI3ODc0NzM0ZjJiZGI2ZGRmM2RjZDM3YjYwM2Qw
NjlkYzU1OTUyNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDE0LTEwLTE4ICBNaWNo
YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KIAorICAgICAgICBbR1RLXSBE
aXNhYmxlIFNTTHYzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn
aT9pZD0xMzc4NTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg
ICAgICAqIE5ldHdvcmtQcm9jZXNzL2d0ay9OZXR3b3JrUHJvY2Vzc01haW5HdGsuY3BwOgorICAg
ICAgICAoV2ViS2l0OjpOZXR3b3JrUHJvY2Vzc01haW5Vbml4KToKKyAgICAgICAgU2V0IEdfVExT
X0dOVVRMU19QUklPUklUWSBpZiB1bnNldC4KKworMjAxNC0xMC0xOCAgTWljaGFlbCBDYXRhbnph
cm8gIDxtY2F0YW56YXJvQGlnYWxpYS5jb20+CisKICAgICAgICAgW0dUS10gSW1wcm92ZSBkb2N1
bWVudGF0aW9uIG9mIHdlYmtpdF93ZWJfdmlld19nZXRfdGxzX2luZm8oKQogICAgICAgICBodHRw
czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM3ODUyCiAKZGlmZiAtLWdpdCBh
L1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL2d0ay9OZXR3b3JrUHJvY2Vzc01haW5HdGsu
Y3BwIGIvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvZ3RrL05ldHdvcmtQcm9jZXNzTWFp
bkd0ay5jcHAKaW5kZXggNDY0YjYxNGIxOTQ2OTFmYzcyZTUyNWRkYmQzNjI2MjExZWZkZGFhMS4u
MWE0ZDM2MDAzMDZhNDk3ZGU5NDJiYzcyZmRjMjU3ZjYzM2RlOTMxMiAxMDA2NDQKLS0tIGEvU291
cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvZ3RrL05ldHdvcmtQcm9jZXNzTWFpbkd0ay5jcHAK
KysrIGIvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvZ3RrL05ldHdvcmtQcm9jZXNzTWFp
bkd0ay5jcHAKQEAgLTYwLDYgKzYwLDE1IEBAIHB1YmxpYzoKIAogaW50IE5ldHdvcmtQcm9jZXNz
TWFpblVuaXgoaW50IGFyZ2MsIGNoYXIqKiBhcmd2KQogeworICAgIC8vIERpc2FibGUgU1NMdjMg
dmVyeSBlYXJseSBiZWNhdXNlIGl0IGlzIHByYWN0aWNhbGx5IGltcG9zc2libGUgdG8gc2FmZWx5
CisgICAgLy8gdXNlIHNldGVudigpIHdoZW4gbXVsdGlwbGUgdGhyZWFkcyBhcmUgcnVubmluZywg
YXMgYW5vdGhlciB0aHJlYWQgY2FsbGluZworICAgIC8vIGdldGVudigpIGNvdWxkIGNhdXNlIGEg
Y3Jhc2gsIGFuZCBtYW55IGZ1bmN0aW9ucyB1c2UgZ2V0ZW52KCkgaW50ZXJuYWxseS4KKyAgICAv
LyBUaGlzIHdvcmthcm91bmQgd2lsbCBzdG9wIHdvcmtpbmcgaWYgZ2xpYi1uZXR3b3JraW5nIHN3
aXRjaGVzIGF3YXkgZnJvbQorICAgIC8vIEdudVRMUyBvciBzaW1wbHkgc3RvcHMgcGFyc2luZyB0
aGlzIHZhcmlhYmxlLiBXZSBpbnRlbnRpb25hbGx5IGRvIG5vdAorICAgIC8vIG92ZXJ3cml0ZSB0
aGlzIHByaW9yaXR5IHN0cmluZyBpZiBpdCdzIGFscmVhZHkgc2V0IGJ5IHRoZSB1c2VyLgorICAg
IC8vIGh0dHBzOi8vYnVnemlsbGEuZ25vbWUub3JnL3Nob3dfYnVnLmNnaT9pZD03Mzg2MzMKKyAg
ICBnX3NldGVudigiR19UTFNfR05VVExTX1BSSU9SSVRZIiwgIk5PUk1BTDolQ09NUEFUOiFWRVJT
LVNTTDMuMCIsIEZBTFNFKTsKKwogICAgIHJldHVybiBDaGlsZFByb2Nlc3NNYWluPE5ldHdvcmtQ
cm9jZXNzLCBOZXR3b3JrUHJvY2Vzc01haW4+KGFyZ2MsIGFyZ3YpOwogfQogCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>240085</attachid>
            <date>2014-10-19 08:12:57 -0700</date>
            <delta_ts>2014-10-20 17:49:34 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-137859-20141019101302.patch</filename>
            <type>text/plain</type>
            <size>3171</size>
            <attacher name="Michael Catanzaro">mcatanzaro</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0ODY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggM2ZhMDllZjcxMWRiNzU2
NThhZGJlNjM1ZWM3YTcyOGE5OGQ4ZmRjMi4uNmFmYTMwOWY4ZDBiYThmNzYwZjk0ODkzZWVlY2Zk
YTIxNjlkOGNkNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE0LTEwLTE5ICBNaWNo
YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBbU09VUF0g
RGlzYWJsZSBTU0x2MworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9MTM3ODU5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg
ICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9FbnRyeVBvaW50L3VuaXgvTmV0d29ya1Byb2Nlc3NNYWlu
LmNwcDoKKyAgICAgICAgKG1haW4pOgorICAgICAgICBTZXQgR19UTFNfR05VVExTX1BSSU9SSVRZ
IGlmIHVuc2V0LgorICAgICAgICAqIFdlYlByb2Nlc3MvRW50cnlQb2ludC91bml4L1dlYlByb2Nl
c3NNYWluLmNwcDoKKyAgICAgICAgKG1haW4pOgorICAgICAgICBTZXQgR19UTFNfR05VVExTX1BS
SU9SSVRZIGlmIHVuc2V0LgorCiAyMDE0LTEwLTE5ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNn
YXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBNb3ZlIEd0a0RyYWdBbmREcm9wSGVs
cGVyIGZyb20gUGxhdGZvcm0gdG8gV2ViS2l0MgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv
TmV0d29ya1Byb2Nlc3MvRW50cnlQb2ludC91bml4L05ldHdvcmtQcm9jZXNzTWFpbi5jcHAgYi9T
b3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9FbnRyeVBvaW50L3VuaXgvTmV0d29ya1Byb2Nl
c3NNYWluLmNwcAppbmRleCA4ZDQyODdiMzcxM2VlOTNjMGRiODBkMTc4MDg5MTEyZTE1ODllNTNi
Li41Nzc3OWVkY2IzODliNWI0MGE0ZDk0YTk2MDI0MTE2MjE1MDdlZjEzIDEwMDY0NAotLS0gYS9T
b3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9FbnRyeVBvaW50L3VuaXgvTmV0d29ya1Byb2Nl
c3NNYWluLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9FbnRyeVBvaW50
L3VuaXgvTmV0d29ya1Byb2Nlc3NNYWluLmNwcApAQCAtMjksNSArMjksMTUgQEAgdXNpbmcgbmFt
ZXNwYWNlIFdlYktpdDsKIAogaW50IG1haW4oaW50IGFyZ2MsIGNoYXIqKiBhcmd2KQogeworICAg
IC8vIERpc2FibGUgU1NMdjMgdmVyeSBlYXJseSBiZWNhdXNlIGl0IGlzIHByYWN0aWNhbGx5IGlt
cG9zc2libGUgdG8gc2FmZWx5CisgICAgLy8gdXNlIHNldGVudigpIHdoZW4gbXVsdGlwbGUgdGhy
ZWFkcyBhcmUgcnVubmluZywgYXMgYW5vdGhlciB0aHJlYWQgY2FsbGluZworICAgIC8vIGdldGVu
digpIGNvdWxkIGNhdXNlIGEgY3Jhc2gsIGFuZCBtYW55IGZ1bmN0aW9ucyB1c2UgZ2V0ZW52KCkg
aW50ZXJuYWxseS4KKyAgICAvLyBUaGlzIHdvcmthcm91bmQgd2lsbCBzdG9wIHdvcmtpbmcgaWYg
Z2xpYi1uZXR3b3JraW5nIHN3aXRjaGVzIGF3YXkgZnJvbQorICAgIC8vIEdudVRMUyBvciBzaW1w
bHkgc3RvcHMgcGFyc2luZyB0aGlzIHZhcmlhYmxlLiBXZSBpbnRlbnRpb25hbGx5IGRvIG5vdAor
ICAgIC8vIG92ZXJ3cml0ZSB0aGlzIHByaW9yaXR5IHN0cmluZyBpZiBpdCdzIGFscmVhZHkgc2V0
IGJ5IHRoZSB1c2VyLgorICAgIC8vIEtlZXAgdGhpcyBpbiBzeW5jIHdpdGggV2ViUHJvY2Vzc01h
aW4uY3BwLgorICAgIC8vIGh0dHBzOi8vYnVnemlsbGEuZ25vbWUub3JnL3Nob3dfYnVnLmNnaT9p
ZD03Mzg2MzMKKyAgICBzZXRlbnYoIkdfVExTX0dOVVRMU19QUklPUklUWSIsICJOT1JNQUw6JUNP
TVBBVDohVkVSUy1TU0wzLjAiLCAwKTsKKwogICAgIHJldHVybiBOZXR3b3JrUHJvY2Vzc01haW5V
bml4KGFyZ2MsIGFyZ3YpOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz
cy9FbnRyeVBvaW50L3VuaXgvV2ViUHJvY2Vzc01haW4uY3BwIGIvU291cmNlL1dlYktpdDIvV2Vi
UHJvY2Vzcy9FbnRyeVBvaW50L3VuaXgvV2ViUHJvY2Vzc01haW4uY3BwCmluZGV4IDZjNjM3ZmQy
MzdjM2Q3NWE1MzMyZDFlMTkwY2JjOWU4MjI2Y2JjYWUuLjE0NDU1Nzc3YjlhZTM1MjQ4ZjgyNWNi
ZjU3NTEwNDNiZjAxNjVhODYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv
RW50cnlQb2ludC91bml4L1dlYlByb2Nlc3NNYWluLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9X
ZWJQcm9jZXNzL0VudHJ5UG9pbnQvdW5peC9XZWJQcm9jZXNzTWFpbi5jcHAKQEAgLTI5LDUgKzI5
LDE1IEBAIHVzaW5nIG5hbWVzcGFjZSBXZWJLaXQ7CiAKIGludCBtYWluKGludCBhcmdjLCBjaGFy
KiogYXJndikKIHsKKyAgICAvLyBEaXNhYmxlIFNTTHYzIHZlcnkgZWFybHkgYmVjYXVzZSBpdCBp
cyBwcmFjdGljYWxseSBpbXBvc3NpYmxlIHRvIHNhZmVseQorICAgIC8vIHVzZSBzZXRlbnYoKSB3
aGVuIG11bHRpcGxlIHRocmVhZHMgYXJlIHJ1bm5pbmcsIGFzIGFub3RoZXIgdGhyZWFkIGNhbGxp
bmcKKyAgICAvLyBnZXRlbnYoKSBjb3VsZCBjYXVzZSBhIGNyYXNoLCBhbmQgbWFueSBmdW5jdGlv
bnMgdXNlIGdldGVudigpIGludGVybmFsbHkuCisgICAgLy8gVGhpcyB3b3JrYXJvdW5kIHdpbGwg
c3RvcCB3b3JraW5nIGlmIGdsaWItbmV0d29ya2luZyBzd2l0Y2hlcyBhd2F5IGZyb20KKyAgICAv
LyBHbnVUTFMgb3Igc2ltcGx5IHN0b3BzIHBhcnNpbmcgdGhpcyB2YXJpYWJsZS4gV2UgaW50ZW50
aW9uYWxseSBkbyBub3QKKyAgICAvLyBvdmVyd3JpdGUgdGhpcyBwcmlvcml0eSBzdHJpbmcgaWYg
aXQncyBhbHJlYWR5IHNldCBieSB0aGUgdXNlci4KKyAgICAvLyBLZWVwIHRoaXMgaW4gc3luYyB3
aXRoIE5ldHdvcmtQcm9jZXNzTWFpbi5jcHAuCisgICAgLy8gaHR0cHM6Ly9idWd6aWxsYS5nbm9t
ZS5vcmcvc2hvd19idWcuY2dpP2lkPTczODYzMworICAgIHNldGVudigiR19UTFNfR05VVExTX1BS
SU9SSVRZIiwgIk5PUk1BTDolQ09NUEFUOiFWRVJTLVNTTDMuMCIsIDApOworCiAgICAgcmV0dXJu
IFdlYlByb2Nlc3NNYWluVW5peChhcmdjLCBhcmd2KTsKIH0K
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>240166</attachid>
            <date>2014-10-20 17:49:41 -0700</date>
            <delta_ts>2014-10-21 00:35:04 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-137859-20141020194947.patch</filename>
            <type>text/plain</type>
            <size>3258</size>
            <attacher name="Michael Catanzaro">mcatanzaro</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0ODY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggM2ZhMDllZjcxMWRiNzU2
NThhZGJlNjM1ZWM3YTcyOGE5OGQ4ZmRjMi4uNTUxYzkzODA1ZjllNGVjMTI2NmQxYzI3ZmFjNDIy
YjA4ZGNkMWEwMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE0LTEwLTIwICBNaWNo
YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBbU09VUF0g
RGlzYWJsZSBTU0x2MworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9MTM3ODU5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQ2FybG9zIEdhcmNpYSBDYW1wb3Mu
CisKKyAgICAgICAgU2V0IEdfVExTX0dOVVRMU19QUklPUklUWSBpZiB1bnNldC4KKworICAgICAg
ICAqIE5ldHdvcmtQcm9jZXNzL0VudHJ5UG9pbnQvdW5peC9OZXR3b3JrUHJvY2Vzc01haW4uY3Bw
OgorICAgICAgICAobWFpbik6CisgICAgICAgICogV2ViUHJvY2Vzcy9FbnRyeVBvaW50L3VuaXgv
V2ViUHJvY2Vzc01haW4uY3BwOgorICAgICAgICAobWFpbik6CisKIDIwMTQtMTAtMTkgIENhcmxv
cyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIE1v
dmUgR3RrRHJhZ0FuZERyb3BIZWxwZXIgZnJvbSBQbGF0Zm9ybSB0byBXZWJLaXQyCmRpZmYgLS1n
aXQgYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9FbnRyeVBvaW50L3VuaXgvTmV0d29y
a1Byb2Nlc3NNYWluLmNwcCBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL0VudHJ5UG9p
bnQvdW5peC9OZXR3b3JrUHJvY2Vzc01haW4uY3BwCmluZGV4IDhkNDI4N2IzNzEzZWU5M2MwZGI4
MGQxNzgwODkxMTJlMTU4OWU1M2IuLmM0MmJhYThlOTRlMTZkOGU4ZTk3YWUyNTZkOWEyNDk2ZjE0
NGY5NTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL0VudHJ5UG9p
bnQvdW5peC9OZXR3b3JrUHJvY2Vzc01haW4uY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL05ldHdv
cmtQcm9jZXNzL0VudHJ5UG9pbnQvdW5peC9OZXR3b3JrUHJvY2Vzc01haW4uY3BwCkBAIC0yNSw5
ICsyNSwyMSBAQAogCiAjaW5jbHVkZSAiTmV0d29ya1Byb2Nlc3NNYWluVW5peC5oIgogCisjaW5j
bHVkZSA8Y3N0ZGxpYj4KKwogdXNpbmcgbmFtZXNwYWNlIFdlYktpdDsKIAogaW50IG1haW4oaW50
IGFyZ2MsIGNoYXIqKiBhcmd2KQogeworICAgIC8vIERpc2FibGUgU1NMdjMgdmVyeSBlYXJseSBi
ZWNhdXNlIGl0IGlzIHByYWN0aWNhbGx5IGltcG9zc2libGUgdG8gc2FmZWx5CisgICAgLy8gdXNl
IHNldGVudigpIHdoZW4gbXVsdGlwbGUgdGhyZWFkcyBhcmUgcnVubmluZywgYXMgYW5vdGhlciB0
aHJlYWQgY2FsbGluZworICAgIC8vIGdldGVudigpIGNvdWxkIGNhdXNlIGEgY3Jhc2gsIGFuZCBt
YW55IGZ1bmN0aW9ucyB1c2UgZ2V0ZW52KCkgaW50ZXJuYWxseS4KKyAgICAvLyBUaGlzIHdvcmth
cm91bmQgd2lsbCBzdG9wIHdvcmtpbmcgaWYgZ2xpYi1uZXR3b3JraW5nIHN3aXRjaGVzIGF3YXkg
ZnJvbQorICAgIC8vIEdudVRMUyBvciBzaW1wbHkgc3RvcHMgcGFyc2luZyB0aGlzIHZhcmlhYmxl
LiBXZSBpbnRlbnRpb25hbGx5IGRvIG5vdAorICAgIC8vIG92ZXJ3cml0ZSB0aGlzIHByaW9yaXR5
IHN0cmluZyBpZiBpdCdzIGFscmVhZHkgc2V0IGJ5IHRoZSB1c2VyLgorICAgIC8vIEtlZXAgdGhp
cyBpbiBzeW5jIHdpdGggV2ViUHJvY2Vzc01haW4uY3BwLgorICAgIC8vIGh0dHBzOi8vYnVnemls
bGEuZ25vbWUub3JnL3Nob3dfYnVnLmNnaT9pZD03Mzg2MzMKKyAgICBzZXRlbnYoIkdfVExTX0dO
VVRMU19QUklPUklUWSIsICJOT1JNQUw6JUNPTVBBVDohVkVSUy1TU0wzLjAiLCAwKTsKKwogICAg
IHJldHVybiBOZXR3b3JrUHJvY2Vzc01haW5Vbml4KGFyZ2MsIGFyZ3YpOwogfQpkaWZmIC0tZ2l0
IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9FbnRyeVBvaW50L3VuaXgvV2ViUHJvY2Vzc01h
aW4uY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9FbnRyeVBvaW50L3VuaXgvV2ViUHJv
Y2Vzc01haW4uY3BwCmluZGV4IDZjNjM3ZmQyMzdjM2Q3NWE1MzMyZDFlMTkwY2JjOWU4MjI2Y2Jj
YWUuLjI2MDYyMGE3NjY5MTFhODE2MmNiYjEwNzE3YWExMzdjYmEzYTkyNzEgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvRW50cnlQb2ludC91bml4L1dlYlByb2Nlc3NNYWlu
LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0VudHJ5UG9pbnQvdW5peC9XZWJQ
cm9jZXNzTWFpbi5jcHAKQEAgLTI1LDkgKzI1LDIxIEBACiAKICNpbmNsdWRlICJXZWJQcm9jZXNz
TWFpblVuaXguaCIKIAorI2luY2x1ZGUgPGNzdGRsaWI+CisKIHVzaW5nIG5hbWVzcGFjZSBXZWJL
aXQ7CiAKIGludCBtYWluKGludCBhcmdjLCBjaGFyKiogYXJndikKIHsKKyAgICAvLyBEaXNhYmxl
IFNTTHYzIHZlcnkgZWFybHkgYmVjYXVzZSBpdCBpcyBwcmFjdGljYWxseSBpbXBvc3NpYmxlIHRv
IHNhZmVseQorICAgIC8vIHVzZSBzZXRlbnYoKSB3aGVuIG11bHRpcGxlIHRocmVhZHMgYXJlIHJ1
bm5pbmcsIGFzIGFub3RoZXIgdGhyZWFkIGNhbGxpbmcKKyAgICAvLyBnZXRlbnYoKSBjb3VsZCBj
YXVzZSBhIGNyYXNoLCBhbmQgbWFueSBmdW5jdGlvbnMgdXNlIGdldGVudigpIGludGVybmFsbHku
CisgICAgLy8gVGhpcyB3b3JrYXJvdW5kIHdpbGwgc3RvcCB3b3JraW5nIGlmIGdsaWItbmV0d29y
a2luZyBzd2l0Y2hlcyBhd2F5IGZyb20KKyAgICAvLyBHbnVUTFMgb3Igc2ltcGx5IHN0b3BzIHBh
cnNpbmcgdGhpcyB2YXJpYWJsZS4gV2UgaW50ZW50aW9uYWxseSBkbyBub3QKKyAgICAvLyBvdmVy
d3JpdGUgdGhpcyBwcmlvcml0eSBzdHJpbmcgaWYgaXQncyBhbHJlYWR5IHNldCBieSB0aGUgdXNl
ci4KKyAgICAvLyBLZWVwIHRoaXMgaW4gc3luYyB3aXRoIE5ldHdvcmtQcm9jZXNzTWFpbi5jcHAu
CisgICAgLy8gaHR0cHM6Ly9idWd6aWxsYS5nbm9tZS5vcmcvc2hvd19idWcuY2dpP2lkPTczODYz
MworICAgIHNldGVudigiR19UTFNfR05VVExTX1BSSU9SSVRZIiwgIk5PUk1BTDolQ09NUEFUOiFW
RVJTLVNTTDMuMCIsIDApOworCiAgICAgcmV0dXJuIFdlYlByb2Nlc3NNYWluVW5peChhcmdjLCBh
cmd2KTsKIH0K
</data>

          </attachment>
      

    </bug>

</bugzilla>