137853 2014-10-18 11:20:25 -0700 WorkQueue dispatches functions but isn’t a FunctionDispatcher 2014-10-18 12:04:52 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mitz mitz andersca benjamin cmarcelo commit-queue sam oldest_to_newest 1042618 0 mitz 2014-10-18 11:20:25 -0700 WorkQueue is a function dispatcher, but it doesn’t inherit from WTF::FunctionDispatcher. 1042619 1 240067 mitz 2014-10-18 11:22:06 -0700 Created attachment 240067 Make WorkQueue a FunctionDispatcher 1042620 2 commit-queue 2014-10-18 11:25:08 -0700 Attachment 240067 did not pass style-queue: ERROR: Source/WebKit2/Platform/WorkQueue.h:68: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1042621 3 240067 andersca 2014-10-18 11:32:12 -0700 Comment on attachment 240067 Make WorkQueue a FunctionDispatcher View in context: https://bugs.webkit.org/attachment.cgi?id=240067&action=review > Source/WebKit2/Platform/WorkQueue.h:68 > + virtual void dispatch(std::function<void ()>) override final; I'd just make WorkQueue itself final. 1042626 4 mitz 2014-10-18 12:04:52 -0700 Fixed in <http://trac.webkit.org/r174864>. 240067 2014-10-18 11:22:06 -0700 2014-10-18 11:32:12 -0700 Make WorkQueue a FunctionDispatcher bug-137853-20141018112210.patch text/plain 2811 mitz SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxNzQ4NjMpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE0LTEwLTE4ICBEYW4gQmVybnN0ZWluICA8bWl0 ekBhcHBsZS5jb20+CisKKyAgICAgICAgV29ya1F1ZXVlIGRpc3BhdGNoZXMgZnVuY3Rpb25zIGJ1 dCBpc27igJl0IGEgRnVuY3Rpb25EaXNwYXRjaGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzc4NTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9GdW5jdGlvbkRpc3BhdGNoZXIuaDogQWRkZWQg aGVhZGVyIGd1YXJkcy4KKwogMjAxNC0xMC0xNyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2Fy Y2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dMSUJdIEFkZCBBUEkgdG8gR01haW5Mb29wU291 cmNlIHRvIHNjaGVkdWxlIHNvdXJjZXMgYWZ0ZXIgYSBkZWxheSBpbiBtaWNyb3NlY29uZHMKSW5k ZXg6IFNvdXJjZS9XVEYvd3RmL0Z1bmN0aW9uRGlzcGF0Y2hlci5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XVEYvd3RmL0Z1bmN0aW9uRGlzcGF0Y2hlci5oCShyZXZpc2lvbiAxNzQ4NjIpCisrKyBT b3VyY2UvV1RGL3d0Zi9GdW5jdGlvbkRpc3BhdGNoZXIuaAkod29ya2luZyBjb3B5KQpAQCAtMjMs NiArMjMsOSBAQAogICogVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgogICovCiAKKyNp Zm5kZWYgRnVuY3Rpb25EaXNwYXRjaGVyX2gKKyNkZWZpbmUgRnVuY3Rpb25EaXNwYXRjaGVyX2gK KwogI2luY2x1ZGUgPGZ1bmN0aW9uYWw+CiAjaW5jbHVkZSA8d3RmL1RocmVhZFNhZmVSZWZDb3Vu dGVkLmg+CiAKQEAgLTQ0LDMgKzQ3LDUgQEAgcHJvdGVjdGVkOgogfSAvLyBuYW1lc3BhY2UgV1RG CiAKIHVzaW5nIFdURjo6RnVuY3Rpb25EaXNwYXRjaGVyOworCisjZW5kaWYgLy8gRnVuY3Rpb25E aXNwYXRjaGVyX2gKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NDg2MykKKysrIFNvdXJjZS9X ZWJLaXQyL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE0LTEw LTE4ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgV29ya1F1ZXVl IGRpc3BhdGNoZXMgZnVuY3Rpb25zIGJ1dCBpc27igJl0IGEgRnVuY3Rpb25EaXNwYXRjaGVyCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzc4NTMKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFBsYXRmb3Jt L1dvcmtRdWV1ZS5oOiBDaGFuZ2VkIHRvIGluaGVyaXQgZnJvbSBGdW5jdGlvbkRpc3BhdGNoZXIu CisKIDIwMTQtMTAtMTggIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29t PgogCiAgICAgICAgIFtHVEtdIEltcHJvdmUgZG9jdW1lbnRhdGlvbiBvZiB3ZWJraXRfd2ViX3Zp ZXdfZ2V0X3Rsc19pbmZvKCkKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL1dvcmtRdWV1 ZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL1dvcmtRdWV1ZS5oCShy ZXZpc2lvbiAxNzQ4NjIpCisrKyBTb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9Xb3JrUXVldWUuaAko d29ya2luZyBjb3B5KQpAQCAtMzQsNiArMzQsNyBAQAogI2luY2x1ZGUgPGNocm9ubz4KICNpbmNs dWRlIDxmdW5jdGlvbmFsPgogI2luY2x1ZGUgPHd0Zi9Gb3J3YXJkLmg+CisjaW5jbHVkZSA8d3Rm L0Z1bmN0aW9uRGlzcGF0Y2hlci5oPgogI2luY2x1ZGUgPHd0Zi9GdW5jdGlvbmFsLmg+CiAjaW5j bHVkZSA8d3RmL0hhc2hNYXAuaD4KICNpbmNsdWRlIDx3dGYvUmVmQ291bnRlZC5oPgpAQCAtNTEs NyArNTIsNyBAQAogI2luY2x1ZGUgPERpc3BhdGNoUXVldWVFZmwuaD4KICNlbmRpZgogCi1jbGFz cyBXb3JrUXVldWUgOiBwdWJsaWMgVGhyZWFkU2FmZVJlZkNvdW50ZWQ8V29ya1F1ZXVlPiB7Citj bGFzcyBXb3JrUXVldWUgOiBwdWJsaWMgRnVuY3Rpb25EaXNwYXRjaGVyIHsKIHB1YmxpYzoKICAg ICBlbnVtIGNsYXNzIFFPUyB7CiAgICAgICAgIFVzZXJJbnRlcmFjdGl2ZSwKQEAgLTYyLDkgKzYz LDkgQEAgcHVibGljOgogICAgIH07CiAgICAgCiAgICAgc3RhdGljIFBhc3NSZWZQdHI8V29ya1F1 ZXVlPiBjcmVhdGUoY29uc3QgY2hhciogbmFtZSwgUU9TID0gUU9TOjpEZWZhdWx0KTsKLSAgICB+ V29ya1F1ZXVlKCk7CisgICAgdmlydHVhbCB+V29ya1F1ZXVlKCk7CiAKLSAgICB2b2lkIGRpc3Bh dGNoKHN0ZDo6ZnVuY3Rpb248dm9pZCAoKT4pOworICAgIHZpcnR1YWwgdm9pZCBkaXNwYXRjaChz dGQ6OmZ1bmN0aW9uPHZvaWQgKCk+KSBvdmVycmlkZSBmaW5hbDsKICAgICB2b2lkIGRpc3BhdGNo QWZ0ZXIoc3RkOjpjaHJvbm86Om5hbm9zZWNvbmRzLCBzdGQ6OmZ1bmN0aW9uPHZvaWQgKCk+KTsK IAogI2lmIE9TKERBUldJTikK