137850 2014-10-18 06:16:46 -0700 [WinCairo] Repaint issues with accelerated compositing. 2014-10-18 14:48:40 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned alex.christensen bfulgham commit-queue oldest_to_newest 1042593 0 peavo 2014-10-18 06:16:46 -0700 There are some repaint issues in accelerated compositing mode, for example on www.ddg.gg. 1042594 1 240062 peavo 2014-10-18 06:32:48 -0700 Created attachment 240062 Patch 1042604 2 240062 bfulgham 2014-10-18 08:47:57 -0700 Comment on attachment 240062 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240062&action=review I think this looks fine, but I can't confirm isAcceleratedCompositing at the moment. can you confirm and then I can approve the patch? > Source/WebKit/win/WebView.cpp:6796 > + if (!isAcceleratedCompositing()) I don't have WebKit source in front of me. Can you confirm 'isAcceleratedCompositing' is identical to checking m_backingLayer for USE(CA)? 1042607 3 peavo 2014-10-18 09:12:23 -0700 (In reply to comment #2) > Comment on attachment 240062 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=240062&action=review > Thanks for reviewing :) > I think this looks fine, but I can't confirm isAcceleratedCompositing at the > moment. can you confirm and then I can approve the patch? > > > Source/WebKit/win/WebView.cpp:6796 > > + if (!isAcceleratedCompositing()) > > I don't have WebKit source in front of me. Can you confirm > 'isAcceleratedCompositing' is identical to checking m_backingLayer for > USE(CA)? Yes, when m_backingLayer is created, m_isAcceleratedCompositing is set to true, and when m_backingLayer is set to null, m_isAcceleratedCompositing is set to false. 1042628 4 240062 alex.christensen 2014-10-18 14:11:56 -0700 Comment on attachment 240062 Patch This also seems to fix a drawing issue that appeared sometimes during transitions in http://www.w3.org/Talks/2012/0416-CSS-WWW2012/Demos/transitions/demo-transitions-3-shadows.html 1042639 5 240062 commit-queue 2014-10-18 14:48:37 -0700 Comment on attachment 240062 Patch Clearing flags on attachment: 240062 Committed r174865: <http://trac.webkit.org/changeset/174865> 1042640 6 commit-queue 2014-10-18 14:48:40 -0700 All reviewed patches have been landed. Closing bug. 240062 2014-10-18 06:32:48 -0700 2014-10-18 14:48:37 -0700 Patch bug-137850-20141018153236.patch text/plain 4262 peavo SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NDg1OSkKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE0LTEwLTE4 ICBwZWF2b0BvdXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtXaW5D YWlyb10gUmVwYWludCBpc3N1ZXMgd2l0aCBhY2NlbGVyYXRlZCBjb21wb3NpdGluZy4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNzg1MAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZXJlIGlzIHNvbWV0 aW1lcyBtaXNzaW5nIGNvbnRlbnQgaW4gYWNjZWxlcmF0ZWQgY29tcG9zaXRpbmcgbW9kZS4KKyAg ICAgICAgVGhpcyBpcyBjYXVzZWQgYnkgbm90IGludmFsaWRhdGluZyB0aGUgbm9uIGNvbXBvc2l0 ZWQgbGF5ZXIsCisgICAgICAgIGFuZCBub3QgcmVuZGVyaW5nIHdoZW4gYSBmbHVzaCBkaWQgbm90 IGNvbXBsZXRlLgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvQWNjZWxlcmF0ZWRDb21wb3Np dGluZ0NvbnRleHQuY3BwOgorICAgICAgICAoQWNjZWxlcmF0ZWRDb21wb3NpdGluZ0NvbnRleHQ6 OmZsdXNoQW5kUmVuZGVyTGF5ZXJzKTogQWxzbyByZW5kZXIgd2hlbiBmbHVzaCBkaWQgbm90IGNv bXBsZXRlLgorICAgICAgICAoQWNjZWxlcmF0ZWRDb21wb3NpdGluZ0NvbnRleHQ6OnNldE5lZWRz RGlzcGxheUluUmVjdCk6IERlbGV0ZWQuCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvQWNjZWxl cmF0ZWRDb21wb3NpdGluZ0NvbnRleHQuaDogRGl0dG8uCisgICAgICAgICogV2ViVmlldy5jcHA6 CisgICAgICAgIChXZWJWaWV3OjphZGRUb0RpcnR5UmVnaW9uKTogSW52YWxpZGF0ZSBub24gY29t cG9zaXRlZCBsYXllci4KKyAgICAgICAgKFdlYlZpZXc6OmZsdXNoUGVuZGluZ0dyYXBoaWNzTGF5 ZXJDaGFuZ2VzKTogRmx1c2ggbGF5ZXJzLgorCiAyMDE0LTEwLTE3ICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgVXNlIGlzPD4oKSAvIGRvd25jYXN0PD4oKSBmb3Ig UmVuZGVyQm94CkluZGV4OiBTb3VyY2UvV2ViS2l0L3dpbi9XZWJWaWV3LmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViS2l0L3dpbi9XZWJWaWV3LmNwcAkocmV2aXNpb24gMTc0ODU5KQorKysg U291cmNlL1dlYktpdC93aW4vV2ViVmlldy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTg2OCw3ICs4 NjgsNyBAQCB2b2lkIFdlYlZpZXc6OmFkZFRvRGlydHlSZWdpb24oY29uc3QgSW50CiAjaWYgVVNF KENBKQogICAgICAgICBtX2JhY2tpbmdMYXllci0+c2V0TmVlZHNEaXNwbGF5SW5SZWN0KGRpcnR5 UmVjdCk7CiAjZWxpZiBVU0UoVEVYVFVSRV9NQVBQRVJfR0wpCi0gICAgICAgIG1fYWNjZWxlcmF0 ZWRDb21wb3NpdGluZ0NvbnRleHQtPnNldE5lZWRzRGlzcGxheUluUmVjdChkaXJ0eVJlY3QpOwor ICAgICAgICBtX2FjY2VsZXJhdGVkQ29tcG9zaXRpbmdDb250ZXh0LT5zZXROb25Db21wb3NpdGVk Q29udGVudHNOZWVkRGlzcGxheShkaXJ0eVJlY3QpOwogI2VuZGlmCiAgICAgICAgIHJldHVybjsK ICAgICB9CkBAIC02NzkyLDEwICs2NzkyLDkgQEAgdm9pZCBXZWJWaWV3OjpmbHVzaFBlbmRpbmdH cmFwaGljc0xheWVyQwogICAgIEZyYW1lVmlldyogdmlldyA9IGNvcmVGcmFtZS0+dmlldygpOwog ICAgIGlmICghdmlldykKICAgICAgICAgcmV0dXJuOwotI2lmIFVTRShDQSkKLSAgICBpZiAoIW1f YmFja2luZ0xheWVyKQorCisgICAgaWYgKCFpc0FjY2VsZXJhdGVkQ29tcG9zaXRpbmcoKSkKICAg ICAgICAgcmV0dXJuOwotI2VuZGlmCiAKICAgICB2aWV3LT51cGRhdGVMYXlvdXRBbmRTdHlsZUlm TmVlZGVkUmVjdXJzaXZlKCk7CiAKQEAgLTY4MDMsOSArNjgwMiwxMiBAQCB2b2lkIFdlYlZpZXc6 OmZsdXNoUGVuZGluZ0dyYXBoaWNzTGF5ZXJDCiAgICAgLy8gVXBkYXRpbmcgbGF5b3V0IG1pZ2h0 IGhhdmUgdGFrZW4gdXMgb3V0IG9mIGNvbXBvc2l0aW5nIG1vZGUuCiAgICAgaWYgKG1fYmFja2lu Z0xheWVyKQogICAgICAgICBtX2JhY2tpbmdMYXllci0+Zmx1c2hDb21wb3NpdGluZ1N0YXRlRm9y VGhpc0xheWVyT25seSgpOwotI2VuZGlmCiAKICAgICB2aWV3LT5mbHVzaENvbXBvc2l0aW5nU3Rh dGVJbmNsdWRpbmdTdWJmcmFtZXMoKTsKKyNlbGlmIFVTRShURVhUVVJFX01BUFBFUl9HTCkKKyAg ICBpZiAoaXNBY2NlbGVyYXRlZENvbXBvc2l0aW5nKCkpCisgICAgICAgIG1fYWNjZWxlcmF0ZWRD b21wb3NpdGluZ0NvbnRleHQtPmZsdXNoUGVuZGluZ0xheWVyQ2hhbmdlcygpOworI2VuZGlmCiB9 CiAKIGNsYXNzIEVudW1UZXh0TWF0Y2hlcyA6IHB1YmxpYyBJRW51bVRleHRNYXRjaGVzCkluZGV4 OiBTb3VyY2UvV2ViS2l0L3dpbi9XZWJDb3JlU3VwcG9ydC9BY2NlbGVyYXRlZENvbXBvc2l0aW5n Q29udGV4dC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC93aW4vV2ViQ29yZVN1cHBv cnQvQWNjZWxlcmF0ZWRDb21wb3NpdGluZ0NvbnRleHQuY3BwCShyZXZpc2lvbiAxNzQ4NTkpCisr KyBTb3VyY2UvV2ViS2l0L3dpbi9XZWJDb3JlU3VwcG9ydC9BY2NlbGVyYXRlZENvbXBvc2l0aW5n Q29udGV4dC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIxNiwxOCArMjE2LDYgQEAgdm9pZCBBY2Nl bGVyYXRlZENvbXBvc2l0aW5nQ29udGV4dDo6c2V0TgogICAgIHNjaGVkdWxlTGF5ZXJGbHVzaCgp OwogfQogCi12b2lkIEFjY2VsZXJhdGVkQ29tcG9zaXRpbmdDb250ZXh0OjpzZXROZWVkc0Rpc3Bs YXlJblJlY3QoY29uc3QgSW50UmVjdCYgcmVjdCkKLXsKLSAgICBpZiAoIW1fcm9vdExheWVyKQot ICAgICAgICByZXR1cm47Ci0gICAgaWYgKHJlY3QuaXNFbXB0eSgpKSB7Ci0gICAgICAgIG1fcm9v dExheWVyLT5zZXROZWVkc0Rpc3BsYXkoKTsKLSAgICAgICAgcmV0dXJuOwotICAgIH0KLSAgICBt X3Jvb3RMYXllci0+c2V0TmVlZHNEaXNwbGF5SW5SZWN0KHJlY3QpOwotICAgIHNjaGVkdWxlTGF5 ZXJGbHVzaCgpOwotfQotCiB2b2lkIEFjY2VsZXJhdGVkQ29tcG9zaXRpbmdDb250ZXh0OjpyZXNp emVSb290TGF5ZXIoY29uc3QgSW50U2l6ZSYgbmV3U2l6ZSkKIHsKICAgICBpZiAoIWVuYWJsZWQo KSkKQEAgLTMwMiw4ICsyOTAsNyBAQCB2b2lkIEFjY2VsZXJhdGVkQ29tcG9zaXRpbmdDb250ZXh0 OjpmbHVzCiAgICAgaWYgKG1fY29udGV4dCAmJiAhbV9jb250ZXh0LT5tYWtlQ29udGV4dEN1cnJl bnQoKSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgaWYgKCFmbHVzaFBlbmRpbmdMYXllckNoYW5n ZXMoKSkKLSAgICAgICAgcmV0dXJuOworICAgIGZsdXNoUGVuZGluZ0xheWVyQ2hhbmdlcygpOwog CiAgICAgY29tcG9zaXRlTGF5ZXJzVG9Db250ZXh0KCk7CiB9CkluZGV4OiBTb3VyY2UvV2ViS2l0 L3dpbi9XZWJDb3JlU3VwcG9ydC9BY2NlbGVyYXRlZENvbXBvc2l0aW5nQ29udGV4dC5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvd2luL1dlYkNvcmVTdXBwb3J0L0FjY2VsZXJhdGVkQ29t cG9zaXRpbmdDb250ZXh0LmgJKHJldmlzaW9uIDE3NDg1OSkKKysrIFNvdXJjZS9XZWJLaXQvd2lu L1dlYkNvcmVTdXBwb3J0L0FjY2VsZXJhdGVkQ29tcG9zaXRpbmdDb250ZXh0LmgJKHdvcmtpbmcg Y29weSkKQEAgLTQ4LDcgKzQ4LDYgQEAgcHVibGljOgogCiAgICAgdm9pZCBzZXRSb290Q29tcG9z aXRpbmdMYXllcihXZWJDb3JlOjpHcmFwaGljc0xheWVyKik7CiAgICAgdm9pZCBzZXROb25Db21w b3NpdGVkQ29udGVudHNOZWVkRGlzcGxheShjb25zdCBXZWJDb3JlOjpJbnRSZWN0Jik7Ci0gICAg dm9pZCBzZXROZWVkc0Rpc3BsYXlJblJlY3QoY29uc3QgV2ViQ29yZTo6SW50UmVjdCYpOwogICAg IHZvaWQgc2NoZWR1bGVMYXllckZsdXNoKCk7CiAgICAgdm9pZCByZXNpemVSb290TGF5ZXIoY29u c3QgV2ViQ29yZTo6SW50U2l6ZSYpOwogICAgIGJvb2wgZW5hYmxlZCgpOwo=