137849 2014-10-18 05:23:40 -0700 [GTK] [Stable] webkitgtk 2.6.1 fails to load flashplugin 2014-11-06 07:46:35 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 marcel.tiede webkit-unassigned berto cgarcia clopez oldest_to_newest 1042591 0 240061 marcel.tiede 2014-10-18 05:23:40 -0700 Created attachment 240061 Example program Hi, with a vala program that spawns a GTK-Window that only holds a webview (webkitgtk 2.6.1) there is an error loading the adobe flash website (https://www.adobe.com/software/flash/about/): Error scanning plugin /home/marcel/.mozilla/plugins/npwrapper.libflashplayer.so, /usr/lib/webkit2gtk-4.0/WebKitPluginProcess returned 256 exit status The flash version number itself is shown. I experienced a second problem. If I open the url https://deezer.com something is crashing very hard: [marcel@Obelix browsertest]$ ./browser Error scanning plugin /home/marcel/.mozilla/plugins/npwrapper.libflashplayer.so, /usr/lib/webkit2gtk-4.0/WebKitPluginProcess returned 256 exit status *** stack smashing detected ***: /usr/lib/webkit2gtk-4.0/WebKitPluginProcess2 terminated ======= Backtrace: ========= /usr/lib/libc.so.6(+0x7340e)[0x7fbd23ba940e] /usr/lib/libc.so.6(__fortify_fail+0x37)[0x7fbd23c2ea97] /usr/lib/libc.so.6(__fortify_fail+0x0)[0x7fbd23c2ea60] /usr/lib/webkit2gtk-4.0/WebKitPluginProcess2[0xac18d2] /usr/lib/webkit2gtk-4.0/WebKitPluginProcess2(_ZN6WebKit14NetscapePlugin10initializeERKNS_6Plugin10ParametersE+0x8db)[0xabd8ab] /usr/lib/webkit2gtk-4.0/WebKitPluginProcess2(_ZN6WebKit21PluginControllerProxy10initializeERKNS_24PluginCreationParametersE+0xe2)[0xa91fe2] /usr/lib/webkit2gtk-4.0/WebKitPluginProcess2(_ZN6WebKit20WebProcessConnection20createPluginInternalERKNS_24PluginCreationParametersERbS4_Rj+0x8e)[0xa965ce] /usr/lib/webkit2gtk-4.0/WebKitPluginProcess2(_ZN6WebKit20WebProcessConnection12createPluginERKNS_24PluginCreationParametersEN3WTF10PassRefPtrIN8Messages20WebProcessConnection12CreatePlugin12DelayedReplyEEE+0x200)[0xa96810] /usr/lib/webkit2gtk-4.0/WebKitPluginProcess2(_ZN3IPC20handleMessageDelayedIN8Messages20WebProcessConnection12CreatePluginEN6WebKit20WebProcessConnectionEMS5_FvRKNS4_24PluginCreationParametersEN3WTF10PassRefPtrINS3_12DelayedReplyEEEEEEvPNS_10ConnectionERNS_14MessageDecoderERSt10unique_ptrINS_14MessageEncoderESt14default_deleteISK_EEPT0_T1_+0x175)[0xac4e05] /usr/lib/webkit2gtk-4.0/WebKitPluginProcess2(_ZN6WebKit20WebProcessConnection41didReceiveSyncWebProcessConnectionMessageEPN3IPC10ConnectionERNS1_14MessageDecoderERSt10unique_ptrINS1_14MessageEncoderESt14default_deleteIS7_EE+0x9d)[0xac4bad] /usr/lib/webkit2gtk-4.0/WebKitPluginProcess2(_ZN6WebKit20WebProcessConnection21didReceiveSyncMessageEPN3IPC10ConnectionERNS1_14MessageDecoderERSt10unique_ptrINS1_14MessageEncoderESt14default_deleteIS7_EE+0x24d)[0xa95fdd] /usr/lib/webkit2gtk-4.0/WebKitPluginProcess2(_ZN3IPC10Connection19dispatchSyncMessageERNS_14MessageDecoderE+0x11c)[0xa8537c] /usr/lib/webkit2gtk-4.0/WebKitPluginProcess2(_ZN3IPC10Connection15dispatchMessageESt10unique_ptrINS_14MessageDecoderESt14default_deleteIS2_EE+0xcc)[0xa8545c] /usr/lib/webkit2gtk-4.0/WebKitPluginProcess2(_ZN3IPC10Connection16SyncMessageState16dispatchMessagesEPS0_+0x297)[0xa86c47] /usr/lib/webkit2gtk-4.0/WebKitPluginProcess2(_ZN3WTF7RunLoop11performWorkEv+0x1fc)[0x1da2e4c] /usr/lib/libjavascriptcoregtk-4.0.so.18(_ZN3WTF15GMainLoopSource12voidCallbackEv+0x2a5)[0x7fbd2bb896c5] /usr/lib/libjavascriptcoregtk-4.0.so.18(_ZN3WTF15GMainLoopSource18voidSourceCallbackEPS0_+0xa)[0x7fbd2bb8549a] /usr/lib/libglib-2.0.so.0(g_main_context_dispatch+0x15d)[0x7fbd2881692d] /usr/lib/libglib-2.0.so.0(+0x49d08)[0x7fbd28816d08] /usr/lib/libglib-2.0.so.0(g_main_loop_run+0xc2)[0x7fbd28817032] /usr/lib/webkit2gtk-4.0/WebKitPluginProcess2(PluginProcessMainUnix+0x29a)[0xa97aca] /usr/lib/libc.so.6(__libc_start_main+0xf0)[0x7fbd23b56040] /usr/lib/webkit2gtk-4.0/WebKitPluginProcess2[0xa82346] ======= Memory map: ======== ... With version 2.4.5 of webkitgtk there were no problems. In the attachments is a program to reproduce the errors. Command to compile the program: valac --pkg gtk+-3.0 --pkg webkit2gtk-4.0 browser.vala Marcel 1042611 1 clopez 2014-10-18 10:35:32 -0700 I was able to reproduce the problem with the attached example program (when loading https://deezer.com) and with webkit2gtk 2.6.1. But I was not able to reproduce it on trunk, so I guess it is already fixed on trunk. It would be great to know which commit fixes it in order to backport to stable. What I was able to reproduce is the '*** stack smashing detected ***' error. For me the flash plugin works. Also the browser seems to continues to work, but any time you click on a link on that page another stack smashing error happens. 1042612 2 marcel.tiede 2014-10-18 10:49:51 -0700 With the help of Carlos Alberto Lopez Perez I could find the problem for the error: Error scanning plugin /home/marcel/.mozilla/plugins/npwrapper.libflashplayer.so, /usr/lib/webkit2gtk-4.0/WebKitPluginProcess returned 256 exit status I just deleted the npwrapper.libflashplayer.so from my home directory. 1042624 3 clopez 2014-10-18 11:53:04 -0700 (In reply to comment #2) > With the help of Carlos Alberto Lopez Perez I could find the problem for > the error: > > Error scanning plugin > /home/marcel/.mozilla/plugins/npwrapper.libflashplayer.so, > /usr/lib/webkit2gtk-4.0/WebKitPluginProcess returned 256 exit status > > I just deleted the npwrapper.libflashplayer.so from my home directory. That was more a warning than an error. The real problem here seems to be a buffer overflow on webkit that causes that smashing stack error. Is reproducible with the example code attached and webkit 2.6.1 (I tried with the 2.6.1 packaged on Debian testing/sid). 1042673 4 cgarcia 2014-10-19 00:03:40 -0700 I can't reproduce this with 2.6.1, the bt looks like bug #137426 that was fixed and backported to 2.6 before the 2.6.1 release. 1044130 5 marcel.tiede 2014-10-25 02:43:57 -0700 WebkitGTK 2.6.2 is also not solving the problem. 1046107 6 berto 2014-11-04 10:35:31 -0800 It crashes for me as well (using 2.6.2): (gdb) bt #0 0x00007fbd3e90b107 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56 #1 0x00007fbd3e90c4e8 in __GI_abort () at abort.c:89 #2 0x00007fbd3e949044 in __libc_message (do_abort=do_abort@entry=2, fmt=fmt@entry=0x7fbd3ea3968b "*** %s ***: %s terminated\n") at ../sysdeps/posix/libc_fatal.c:175 #3 0x00007fbd3e9cc137 in __GI___fortify_fail (msg=msg@entry=0x7fbd3ea39673 "stack smashing detected") at fortify_fail.c:31 #4 0x00007fbd3e9cc100 in __stack_chk_fail () at stack_chk_fail.c:28 #5 0x0000000000afee12 in WebKit::NetscapePlugin::platformPostInitialize() () #6 0x0000000000afbabb in WebKit::NetscapePlugin::initialize(WebKit::Plugin::Parameters const&) () #7 0x0000000000ad6b32 in WebKit::PluginControllerProxy::initialize(WebKit::PluginCreationParameters const&) () #8 0x0000000000adb08c in WebKit::WebProcessConnection::createPluginInternal(WebKit::PluginCreationParameters const&, bool&, bool&, unsigned int&) () #9 0x0000000000adb2d0 in WebKit::WebProcessConnection::createPlugin(WebKit::PluginCreationParameters const&, WTF::PassRefPtr<Messages::WebProcessConnection::CreatePlugin::DelayedReply>) () #10 0x0000000000b01e50 in void IPC::handleMessageDelayed<Messages::WebProcessConnection::CreatePlugin, WebKit::WebProcessConnection, void (WebKit::WebProcessConnection::*)(WebKit::PluginCreationParameters const&, WTF::PassRefPtr<Messages::WebProcessConnection::CreatePlugin::DelayedReply>)>(IPC::Connection*, IPC::MessageDecoder&, std::unique_ptr<IPC::MessageEncoder, std::default_delete<IPC::MessageEncoder> >&, WebKit::WebProcessConnection*, void (WebKit::WebProcessConnection::*)(WebKit::PluginCreationParameters const&, WTF::PassRefPtr<Messages::WebProcessConnection::CreatePlugin::DelayedReply>)) () 1046444 7 berto 2014-11-05 03:59:37 -0800 With debugging symbols: (gdb) bt #0 0x00007f11ec156407 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56 #1 0x00007f11ec1577e8 in __GI_abort () at abort.c:89 #2 0x00007f11ec194344 in __libc_message (do_abort=do_abort@entry=2, fmt=fmt@entry=0x7f11ec2849f5 "*** %s ***: %s terminated\n") at ../sysdeps/posix/libc_fatal.c:175 #3 0x00007f11ec217437 in __GI___fortify_fail (msg=msg@entry=0x7f11ec2849dd "stack smashing detected") at fortify_fail.c:31 #4 0x00007f11ec217400 in __stack_chk_fail () at stack_chk_fail.c:28 #5 0x0000000000afee12 in WebKit::NetscapePlugin::platformPostInitialize (this=this@entry=0x7f11f4182dc0) at /tmp/buildd/webkit2gtk-2.6.2+dfsg1/Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:229 #6 0x0000000000afbabb in WebKit::NetscapePlugin::initialize (this=0x7f11f4182dc0, parameters=...) at /tmp/buildd/webkit2gtk-2.6.2+dfsg1/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp:668 #7 0x0000000000ad6b32 in WebKit::PluginControllerProxy::initialize (this=this@entry=0x2afc360, creationParameters=...) at /tmp/buildd/webkit2gtk-2.6.2+dfsg1/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp:120 #8 0x0000000000adb08c in WebKit::WebProcessConnection::createPluginInternal (this=this@entry=0x7f11f416e9b0, creationParameters=..., result=result@entry=@0x7fff8e0063ce: false, wantsWheelEvents=wantsWheelEvents@entry=@0x7fff8e0063cf: false, remoteLayerClientID=remoteLayerClientID@entry=@0x7fff8e0063e0: 0) at /tmp/buildd/webkit2gtk-2.6.2+dfsg1/Source/WebKit2/PluginProcess/WebProcessConnection.cpp:219 #9 0x0000000000adb2d0 in WebKit::WebProcessConnection::createPlugin (this=0x7f11f416e9b0, creationParameters=..., reply=...) at /tmp/buildd/webkit2gtk-2.6.2+dfsg1/Source/WebKit2/PluginProcess/WebProcessConnection.cpp:264 #10 0x0000000000b01e50 in callMemberFunctionImpl<WebKit::WebProcessConnection, void (WebKit::WebProcessConnection::*)(WebKit::PluginCreationParameters const&, WTF::PassRefPtr<Messages::WebProcessConnection::CreatePlugin::DelayedReply>), Messages::WebProcessConnection::CreatePlugin::DelayedReply, std::tuple<WebKit::PluginCreationParameters>, 0ul> ( args=<unknown type in /usr/lib/debug/usr/lib/x86_64-linux-gnu/webkit2gtk-4.0/WebKitPluginProcess2, CU 0x793474, DIE 0x7b3b95>, delayedReply=..., function=<optimized out>, object=0x7f11f416e9b0) at /tmp/buildd/webkit2gtk-2.6.2+dfsg1/Source/WebKit2/Platform/IPC/HandleMessage.h:44 #11 callMemberFunction<WebKit::WebProcessConnection, void (WebKit::WebProcessConnection::*)(WebKit::PluginCreationParameters const&, WTF::PassRefPtr<Messages::WebProcessConnection::CreatePlugin::DelayedReply>), Messages::WebProcessConnection::CreatePlugin::DelayedReply, std::tuple<WebKit::PluginCreationParameters>, std::make_index_sequence<1ul> > (function=<optimized out>, object=0x7f11f416e9b0, delayedReply=..., args=<unknown type in /usr/lib/debug/usr/lib/x86_64-linux-gnu/webkit2gtk-4.0/WebKitPluginProcess2, CU 0x793474, DIE 0x7b3b1d>) at /tmp/buildd/webkit2gtk-2.6.2+dfsg1/Source/WebKit2/Platform/IPC/HandleMessage.h:50 1046447 8 berto 2014-11-05 04:53:55 -0800 I can't seem to reproduce this crash if I rebuild webkit 2.6.2, so this might have to do with the version of the compiler or some library. 1046456 9 clopez 2014-11-05 06:19:16 -0800 (In reply to comment #8) > I can't seem to reproduce this crash if I rebuild webkit 2.6.2, so > this might have to do with the version of the compiler or some library. I think it may have to be with the hardening flags that the debian package uses. $ grep ^CPPFLAGS webkit2gtk-2.6.2+dfsg1/debian/rules CPPFLAGS = $(shell dpkg-buildflags --get CPPFLAGS) -Wall $ dpkg-buildflags --get CPPFLAGS -D_FORTIFY_SOURCE=2 You can try rebuilding it with those flags to check if then is reproducible or not. 1046459 10 berto 2014-11-05 06:37:44 -0800 I actually rebuilt it with exactly the same flags and it no longer crashes. I'm still looking into it. On a related note I just fixed bug 138418, although I don't see how that could cause this problem. 1046777 11 241098 berto 2014-11-06 02:32:31 -0800 Created attachment 241098 Workaround I believe that this is a bug in GCC, I can reproduce it reliably with the following conditions: * GCC 4.9.1 (reproduced with 4.9.1-4 and 4.9.1-19 from Debian) * -O1 or -O2 * -fstack-protector-strong The affected function is NetscapePlugin::platformPostInitialize() from NetscapePluginX11.cpp. As a workaround it is possible to disable the compiler optimizations in that function (and still keep the stack protection enabled) with the following patch. 1046780 12 berto 2014-11-06 02:58:28 -0800 Interestingly enough webkitgtk 2.4.7 does not seem to crash 1046803 13 241106 berto 2014-11-06 07:38:32 -0800 Created attachment 241106 Patch I'm stupid, forget my previous comments. We are actually having the stack corrupted. The reason is that although NPPVpluginNeedsXEmbed is a boolean value we cannot use bool/NPBool there (1 byte) because the Flash player plugin (and possibly others) are using an int instead. My confusion came from the fact that it doesn't happen when we disable optimizations. The reason for that might be that in that case we would be overwriting the windowID variable instead, which is not a problem because we would not be changing its current value (0). 1046804 14 241106 cgarcia 2014-11-06 07:41:35 -0800 Comment on attachment 241106 Patch How I hate flash :-/ 1046806 15 berto 2014-11-06 07:46:35 -0800 Committed r175696: <http://trac.webkit.org/changeset/175696> 240061 2014-10-18 05:23:40 -0700 2014-10-18 05:23:40 -0700 Example program browser.vala text/x-vala 744 marcel.tiede dXNpbmcgR0xpYjsKdXNpbmcgR3RrOwp1c2luZyBXZWJLaXQ7CiAKcHVibGljIGNsYXNzIEJyb3dz ZXIgOiBXaW5kb3cgewogICAgLy9wcml2YXRlIGNvbnN0IHN0cmluZyBVUkwgPSAiaHR0cHM6Ly93 d3cuYWRvYmUuY29tL3NvZnR3YXJlL2ZsYXNoL2Fib3V0LyI7CiAgICBwcml2YXRlIGNvbnN0IHN0 cmluZyBVUkwgPSJodHRwczovL2RlZXplci5jb20iOwogICAgIAogICAgcHVibGljIEJyb3dzZXIo KSB7CiAgICAgICAgdGhpcy5hZGQodGhpcy5jcmVhdGVfd2ViX3dpbmRvdygpKTsKICAgICAgICAg CiAgICAgICAgdGhpcy5kZXN0cm95LmNvbm5lY3QoKCkgPT4gewogICAgICAgICAgICBHdGsubWFp bl9xdWl0KCk7CiAgICAgICAgfSk7CiAgICB9CiAgICAgCiAgICBwcml2YXRlIFdlYlZpZXcgY3Jl YXRlX3dlYl93aW5kb3coKSB7CiAgICAgICAgdmFyIHZpZXcgPSBuZXcgV2ViVmlldygpOwogICAg ICAgIHZpZXcubG9hZF91cmkoQnJvd3Nlci5VUkwpOwogICAgICAgICAKICAgICAgICByZXR1cm4g dmlldzsKICAgIH0KICAgICAKICAgIHB1YmxpYyBzdGF0aWMgaW50IG1haW4oc3RyaW5nW10gYXJn cykgewogICAgICAgIEd0ay5pbml0KHJlZiBhcmdzKTsKICAgICAgICAgCiAgICAgICAgdmFyIGJy b3dzZXIgPSBuZXcgQnJvd3NlcigpOwogICAgICAgIGJyb3dzZXIuc2hvd19hbGwoKTsKICAgICAg ICAgCiAgICAgICAgR3RrLm1haW4oKTsKICAgICAgICAgCiAgICAgICAgcmV0dXJuIDA7CiAgICB9 Cn0K 241098 2014-11-06 02:32:31 -0800 2014-11-06 07:38:32 -0800 Workaround 137849.diff text/plain 728 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS94 MTEvTmV0c2NhcGVQbHVnaW5YMTEuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVn aW5zL05ldHNjYXBlL3gxMS9OZXRzY2FwZVBsdWdpblgxMS5jcHAKaW5kZXggNjY0ZWQ3NC4uY2Iz NDE3NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNj YXBlL3gxMS9OZXRzY2FwZVBsdWdpblgxMS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9QbHVnaW5zL05ldHNjYXBlL3gxMS9OZXRzY2FwZVBsdWdpblgxMS5jcHAKQEAgLTE5OSw2 ICsxOTksOCBAQCB2b2lkIE5ldHNjYXBlUGx1Z2luOjpwbGF0Zm9ybVByZUluaXRpYWxpemUoKQog ewogfQogCisjcHJhZ21hIEdDQyBwdXNoX29wdGlvbnMKKyNwcmFnbWEgR0NDIG9wdGltaXplICgi TzAiKQogYm9vbCBOZXRzY2FwZVBsdWdpbjo6cGxhdGZvcm1Qb3N0SW5pdGlhbGl6ZSgpCiB7CiAg ICAgdWludDY0X3Qgd2luZG93SUQgPSAwOwpAQCAtMjI3LDYgKzIyOSw3IEBAIGJvb2wgTmV0c2Nh cGVQbHVnaW46OnBsYXRmb3JtUG9zdEluaXRpYWxpemUoKQogCiAgICAgcmV0dXJuIHBsYXRmb3Jt UG9zdEluaXRpYWxpemVXaW5kb3dsZXNzKCk7CiB9CisjcHJhZ21hIEdDQyBwb3Bfb3B0aW9ucwog CiB2b2lkIE5ldHNjYXBlUGx1Z2luOjpwbGF0Zm9ybURlc3Ryb3koKQogewo= 241106 2014-11-06 07:38:32 -0800 2014-11-06 07:41:35 -0800 Patch 137849.diff text/plain 1678 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAwZTY2YzE3Li4xMjNlMWFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTQtMTEtMDYgIEFsYmVydG8gR2FyY2lhICA8YmVydG9AaWdhbGlhLmNvbT4KKworICAg ICAgICBbR1RLXSBbU3RhYmxlXSB3ZWJraXRndGsgMi42LjEgZmFpbHMgdG8gbG9hZCBmbGFzaHBs dWdpbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM3 ODQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTlBQ VnBsdWdpbk5lZWRzWEVtYmVkIGlzIGEgYm9vbGVhbiB2YWx1ZSwgc28gaXQgc2hvdWxkIG5vcm1h bGx5CisgICAgICAgIHVzZSBhbiBOUEJvb2wgKDEgYnl0ZSkuIEhvd2V2ZXIgc29tZSBwbHVnaW5z ICh0aGUgRmxhc2ggcGxheWVyIGluCisgICAgICAgIHBhcnRpY3VsYXIpIGFyZSB1c2luZyBhbiBp bnQgaW5zdGVhZCwgc28gd2UgaGF2ZSB0byBkbyBpdCBhcyB3ZWxsCisgICAgICAgIGVsc2Ugd2Un bGwgZW5kIHVwIGNvcnJ1cHRpbmcgdGhlIHN0YWNrLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9Q bHVnaW5zL05ldHNjYXBlL3gxMS9OZXRzY2FwZVBsdWdpblgxMS5jcHA6CisgICAgICAgIChXZWJL aXQ6Ok5ldHNjYXBlUGx1Z2luOjpwbGF0Zm9ybVBvc3RJbml0aWFsaXplKToKKwogMjAxNC0xMS0w NiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAg W0dUS10gQWRkIGNvbnRleHQgbWVudSBBUEkgdG8gV2ViIFByb2Nlc3MgRXh0ZW5zaW9ucwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL3gxMS9O ZXRzY2FwZVBsdWdpblgxMS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMv TmV0c2NhcGUveDExL05ldHNjYXBlUGx1Z2luWDExLmNwcAppbmRleCA2NjRlZDc0Li5kMTMwOTA2 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUv eDExL05ldHNjYXBlUGx1Z2luWDExLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L1BsdWdpbnMvTmV0c2NhcGUveDExL05ldHNjYXBlUGx1Z2luWDExLmNwcApAQCAtMjAyLDcgKzIw Miw5IEBAIHZvaWQgTmV0c2NhcGVQbHVnaW46OnBsYXRmb3JtUHJlSW5pdGlhbGl6ZSgpCiBib29s IE5ldHNjYXBlUGx1Z2luOjpwbGF0Zm9ybVBvc3RJbml0aWFsaXplKCkKIHsKICAgICB1aW50NjRf dCB3aW5kb3dJRCA9IDA7Ci0gICAgTlBCb29sIG5lZWRzWEVtYmVkID0gZmFsc2U7CisgICAgLy8g TlBQVnBsdWdpbk5lZWRzWEVtYmVkIGlzIGEgYm9vbGVhbiB2YWx1ZSwgYnV0IGF0IGxlYXN0IHRo ZQorICAgIC8vIEZsYXNoIHBsYXllciBwbHVnaW4gaXMgdXNpbmcgYW4gJ2ludCcgaW5zdGVhZC4K KyAgICBpbnQgbmVlZHNYRW1iZWQgPSAwOwogICAgIGlmIChtX2lzV2luZG93ZWQpIHsKICAgICAg ICAgTlBQX0dldFZhbHVlKE5QUFZwbHVnaW5OZWVkc1hFbWJlZCwgJm5lZWRzWEVtYmVkKTsKICAg ICAgICAgaWYgKG5lZWRzWEVtYmVkKSB7Cg==