137844 2014-10-17 20:03:57 -0700 [EFL] build break occurs on webkit efl build. 2014-10-18 20:17:44 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Minor --- 137802 1 hyuki.kim webkit-unassigned benjamin cdumez commit-queue gyuyoung.kim lucas.de.marchi oldest_to_newest 1042549 0 hyuki.kim 2014-10-17 20:03:57 -0700 build break occurs on webkit efl build. /home/hyuki/git/open/webkit/Source/WebCore/cssjit/SelectorCompiler.cpp: In member function ‘void WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatchesSelectorList(JSC::AbstractMacroAssembler<JSC::X86Assembler>::JumpList&, JSC::AbstractMacroAssembler<JSC::X86Assembler>::RegisterID, const WebCore::SelectorCompiler::SelectorList&)’: /home/hyuki/git/open/webkit/Source/WebCore/cssjit/SelectorCompiler.cpp:1700:14: error: variable ‘elementAddressRegisterIndex’ set but not used [-Werror=unused-but-set-variable] unsigned elementAddressRegisterIndex = std::numeric_limits<unsigned>::max(); ^ cc1plus: all warnings being treated as errors make[2]: *** [Source/WebCore/CMakeFiles/WebCore.dir/cssjit/SelectorCompiler.cpp.o] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [Source/WebCore/CMakeFiles/WebCore.dir/all] Error 2 make: *** [all] Error 2 1042550 1 240056 hyuki.kim 2014-10-17 20:11:25 -0700 Created attachment 240056 Patch 1042560 2 240056 cdumez 2014-10-17 21:42:22 -0700 Comment on attachment 240056 Patch I believe this was fixed already? 1042580 3 hyuki.kim 2014-10-18 01:59:34 -0700 (In reply to comment #2) > Comment on attachment 240056 [details] > Patch > > I believe this was fixed already? (In reply to comment #2) > Comment on attachment 240056 [details] > Patch > > I believe this was fixed already? Unfortunately, Nobody touch it yet. unused-but-set-variable. :) Could you see the code below ? unsigned elementAddressRegisterIndex = std::numeric_limits<unsigned>::max(); unsigned elementToTestIndex = std::numeric_limits<unsigned>::max(); bool isElementToMatchOnStack = false; if (selectorList.clobberElementAddressRegister) { if (elementToMatch != elementAddressRegister) { registersToSave.append(elementAddressRegister); registersToSave.append(elementToMatch); elementAddressRegisterIndex = 0; elementToTestIndex = 1; isElementToMatchOnStack = true; } else { registersToSave.append(elementAddressRegister); elementAddressRegisterIndex = 0; elementToTestIndex = 0; } } else if (elementToMatch != elementAddressRegister) { registersToSave.append(elementAddressRegister); elementAddressRegisterIndex = 0; } 1042582 4 240056 gyuyoung.kim 2014-10-18 02:16:17 -0700 Comment on attachment 240056 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240056&action=review > Source/WebCore/cssjit/SelectorCompiler.cpp:1701 > + unsigned elementToTestIndex = elementAddressRegisterIndex; I'm not sure whether this is correct fix. I think Benjamin needs to take a look this. 1042584 5 gyuyoung.kim 2014-10-18 02:17:18 -0700 *** Bug 137847 has been marked as a duplicate of this bug. *** 1042585 6 hyuki.kim 2014-10-18 02:20:45 -0700 (In reply to comment #5) > *** Bug 137847 has been marked as a duplicate of this bug. *** This is just for keeping code that any author of this code wrote before without any side-effect. :) I just want to fix build break for my webkit efl build. 1042587 7 240056 gyuyoung.kim 2014-10-18 02:39:06 -0700 Comment on attachment 240056 Patch I believe that this fix doesn't change behavior. rs=me to fix EFL build break for now. 1042589 8 240056 commit-queue 2014-10-18 03:16:33 -0700 Comment on attachment 240056 Patch Clearing flags on attachment: 240056 Committed r174859: <http://trac.webkit.org/changeset/174859> 1042590 9 commit-queue 2014-10-18 03:16:38 -0700 All reviewed patches have been landed. Closing bug. 1042662 10 benjamin 2014-10-18 20:17:44 -0700 I am sorry I broke EFL, I thought the bot was red because of the StackAllocator changes. Thanks for fixing. I'll clean up that code. 240056 2014-10-17 20:11:25 -0700 2014-10-18 03:16:33 -0700 Patch fix_buildbreak_001.patch text/plain 1741 hyuki.kim ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5N2QxOGE3Li4wYmFiMzYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTQtMTAtMTcgIEt3YW5nSHl1ayBLaW0gIDxoeXVraS5raW1Ac2Ftc3VuZy5jb20+CisK KyAgICAgICAgW0VGTF0gYnVpbGQgYnJlYWsgb2NjdXJzIG9uIHdlYmtpdCBlZmwgYnVpbGQuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzc4NDQKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBcyBsb2NhbCB2 YXJpYWJsZSBlbGVtZW50QWRkcmVzc1JlZ2lzdGVySW5kZXggaXMgYXNzaWduZWQgYnV0IG5vdCB1 c2VkLCB0aGVyZSBpcyBidWlsZCBicmVhayBmb3IgdGhlIHdlYmtpdCBlZmwuCisKKyAgICAgICAg Tm8gbmV3IHRlc3RzIGJlY2F1c2UgaXQncyBqdXN0IHRvIGZpeCBidWlsZCBicmVhay4KKworICAg ICAgICAqIGNzc2ppdC9TZWxlY3RvckNvbXBpbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNl bGVjdG9yQ29tcGlsZXI6OlNlbGVjdG9yQ29kZUdlbmVyYXRvcjo6Z2VuZXJhdGVFbGVtZW50TWF0 Y2hlc1NlbGVjdG9yTGlzdCk6CisKIDIwMTQtMTAtMTYgIFJvZ2VyIEZvbmcgIDxyb2dlcl9mb25n QGFwcGxlLmNvbT4KIAogICAgICAgICBDYWxsaW5nIGdsUmVhZFBpeGVscyB3aXRoIEJHUkEgZm9y bWF0IG9uIGFuIE5WSURJQSBtYWNoaW5lIHdpdGggYW4gb3BhcXVlIGNvbnRleHQgcmV0dXJucyB0 aGUgd3JvbmcgYWxwaGEgdmFsdWVzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3Nzaml0 L1NlbGVjdG9yQ29tcGlsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvY3Nzaml0L1NlbGVjdG9yQ29t cGlsZXIuY3BwCm9sZCBtb2RlIDEwMDY0NApuZXcgbW9kZSAxMDA3NTUKaW5kZXggNTQ4ZTc0Ny4u YWVlMzcyMwotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3NqaXQvU2VsZWN0b3JDb21waWxlci5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvY3Nzaml0L1NlbGVjdG9yQ29tcGlsZXIuY3BwCkBAIC0xNjk4 LDcgKzE2OTgsNyBAQCB2b2lkIFNlbGVjdG9yQ29kZUdlbmVyYXRvcjo6Z2VuZXJhdGVFbGVtZW50 TWF0Y2hlc1NlbGVjdG9yTGlzdChBc3NlbWJsZXI6Okp1bXBMaQogICAgIC8vIGJlY2F1c2UgdGhl eSBhcmUgdXNlZCBieSB0aGUgbWF0Y2hlciBpdHNlbGYuCiAgICAgLy8gVG8gc2ltcGxpZnkgdGhp bmdzIGZvciBub3csIHdlIGp1c3QgYWx3YXlzIHByZXNlcnZlIHRoZW0gb24gdGhlIHN0YWNrLgog ICAgIHVuc2lnbmVkIGVsZW1lbnRBZGRyZXNzUmVnaXN0ZXJJbmRleCA9IHN0ZDo6bnVtZXJpY19s aW1pdHM8dW5zaWduZWQ+OjptYXgoKTsKLSAgICB1bnNpZ25lZCBlbGVtZW50VG9UZXN0SW5kZXgg PSBzdGQ6Om51bWVyaWNfbGltaXRzPHVuc2lnbmVkPjo6bWF4KCk7CisgICAgdW5zaWduZWQgZWxl bWVudFRvVGVzdEluZGV4ID0gZWxlbWVudEFkZHJlc3NSZWdpc3RlckluZGV4OwogICAgIGJvb2wg aXNFbGVtZW50VG9NYXRjaE9uU3RhY2sgPSBmYWxzZTsKICAgICBpZiAoc2VsZWN0b3JMaXN0LmNs b2JiZXJFbGVtZW50QWRkcmVzc1JlZ2lzdGVyKSB7CiAgICAgICAgIGlmIChlbGVtZW50VG9NYXRj aCAhPSBlbGVtZW50QWRkcmVzc1JlZ2lzdGVyKSB7Cg==