137836 2014-10-17 14:10:15 -0700 Avoid unnecessary isSVGFont() check in SimpleFontData::applyTransforms() 2014-10-17 16:59:17 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Enhancement --- 1 cdumez cdumez commit-queue d-r fmalita gyuyoung.kim kling mmaxfield pdr rniwa schenney sergio oldest_to_newest 1042461 0 cdumez 2014-10-17 14:10:15 -0700 Avoid unnecessary isSVGFont() check in SimpleFontData::applyTransforms(). This function is never called for SVG fonts so replace the if check by an assertion. 1042467 1 240038 cdumez 2014-10-17 14:13:22 -0700 Created attachment 240038 Patch 1042472 2 240038 kling 2014-10-17 14:21:46 -0700 Comment on attachment 240038 Patch r=me You could also mark applyTransforms() as deleted in SVGFontData. That way you'll get a compile error if you try to call it on an SVGFontData object. 1042475 3 cdumez 2014-10-17 14:23:20 -0700 (In reply to comment #2) > Comment on attachment 240038 [details] > Patch > > r=me > > You could also mark applyTransforms() as deleted in SVGFontData. That way > you'll get a compile error if you try to call it on an SVGFontData object. Yes, love it 1042481 4 240040 cdumez 2014-10-17 14:42:37 -0700 Created attachment 240040 Patch 1042531 5 240040 commit-queue 2014-10-17 16:59:11 -0700 Comment on attachment 240040 Patch Clearing flags on attachment: 240040 Committed r174853: <http://trac.webkit.org/changeset/174853> 1042532 6 commit-queue 2014-10-17 16:59:17 -0700 All reviewed patches have been landed. Closing bug. 240038 2014-10-17 14:13:22 -0700 2014-10-17 14:42:31 -0700 Patch bug-137836-20141017141327.patch text/plain 2115 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0ODIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWMwMjIyNGVkZjY3MDlm MGY3NjQyMWQ1ZDIzYjhkNGFmMTIyZWVmNS4uYWNiNWM3MmJlNWM3MGVjOWY5MzdhOWZhZjA2Zjgw NzYzMmE1MGMwMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE0LTEwLTE3ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQXZvaWQgdW5uZWNlc3Nhcnkg aXNTVkdGb250KCkgY2hlY2sgaW4gU2ltcGxlRm9udERhdGE6OmFwcGx5VHJhbnNmb3JtcygpCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzc4MzYKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBdm9pZCB1bm5l Y2Vzc2FyeSBpc1NWR0ZvbnQoKSBjaGVjayBpbiBTaW1wbGVGb250RGF0YTo6YXBwbHlUcmFuc2Zv cm1zKCkuCisgICAgICAgIFRoaXMgZnVuY3Rpb24gaXMgb25seSBjYWxsZWQgZnJvbSBXaWR0aEl0 ZXJhdG9yOjphcHBseUZvbnRUcmFuc2Zvcm1zKCksCisgICAgICAgIHdoaWNoIGFscmVhZHkgbWFr ZXMgc3VyZSB0byBjYWxsIGFwcGx5VHJhbnNmb3JtcygpIGlmIGlzU1ZHRm9udCgpCisgICAgICAg IHJldHVybnMgZmFsc2UuIFRoaXMgcGF0Y2ggcmVwbGFjZXMgdGhlIGNoZWNrIHdpdGggYSBzaW1w bGUgYXNzZXJ0aW9uLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8gYmVoYXZpb3IgY2hhbmdl LgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvU2ltcGxlRm9udERhdGEuaDoKKwogMjAx NC0xMC0xNiAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBbTWFj XSBSZXByZXNlbnQgQVZNZWRpYVNlbGVjdGlvbk9wdGlvbnMgYXMgQXVkaW9UcmFja3MKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1NpbXBsZUZvbnREYXRhLmgg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9TaW1wbGVGb250RGF0YS5oCmluZGV4 IGU0ZmQxOTU5NTgyY2I5ZDg4ZWMzYjZlZTI2YmRmODhmZDEyYTZiNjIuLjZiNDlkNGNhZDBmMjAy MDc3ODQzN2I3NzhlMjhhMmNlNjljMDc1N2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL1NpbXBsZUZvbnREYXRhLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvU2ltcGxlRm9udERhdGEuaApAQCAtMjE5LDggKzIxOSw4IEBAIHB1Ymxp YzoKIAogICAgIGJvb2wgYXBwbHlUcmFuc2Zvcm1zKEdseXBoQnVmZmVyR2x5cGgqIGdseXBocywg R2x5cGhCdWZmZXJBZHZhbmNlKiBhZHZhbmNlcywgc2l6ZV90IGdseXBoQ291bnQsIFR5cGVzZXR0 aW5nRmVhdHVyZXMgdHlwZXNldHRpbmdGZWF0dXJlcykgY29uc3QKICAgICB7Ci0gICAgICAgIGlm IChpc1NWR0ZvbnQoKSkKLSAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAgICAgLy8gV2Ug bmVlZCB0byBoYW5kbGUgdHJhbnNmb3JtcyBvbiBTVkcgZm9udHMgaW50ZXJuYWxseSwgc2luY2Ug dGhleSBhcmUgcmVuZGVyZWQgaW50ZXJuYWxseS4KKyAgICAgICAgQVNTRVJUKCFpc1NWR0ZvbnQo KSk7CiAjaWYgUExBVEZPUk0oSU9TKSB8fCAoUExBVEZPUk0oTUFDKSAmJiBfX01BQ19PU19YX1ZF UlNJT05fTUlOX1JFUVVJUkVEID4gMTA4MCkKICAgICAgICAgd2tDVEZvbnRUcmFuc2Zvcm1PcHRp b25zIG9wdGlvbnMgPSAodHlwZXNldHRpbmdGZWF0dXJlcyAmIEtlcm5pbmcgPyB3a0NURm9udFRy YW5zZm9ybUFwcGx5UG9zaXRpb25pbmcgOiAwKSB8ICh0eXBlc2V0dGluZ0ZlYXR1cmVzICYgTGln YXR1cmVzID8gd2tDVEZvbnRUcmFuc2Zvcm1BcHBseVNoYXBpbmcgOiAwKTsKICAgICAgICAgcmV0 dXJuIHdrQ1RGb250VHJhbnNmb3JtR2x5cGhzKG1fcGxhdGZvcm1EYXRhLmN0Rm9udCgpLCBnbHlw aHMsIHJlaW50ZXJwcmV0X2Nhc3Q8Q0dTaXplKj4oYWR2YW5jZXMpLCBnbHlwaENvdW50LCBvcHRp b25zKTsK 240040 2014-10-17 14:42:37 -0700 2014-10-17 16:59:11 -0700 Patch bug-137836-20141017144243.patch text/plain 3053 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0ODM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2NjZDNmY2Q4MzgzYmFj NDkxMjNhN2M5YzkwOWM1NmRiN2JmZTBmOS4uY2JkYjU0ODhlMGNkNmIwZDdiMzA0YjM4NjQ5ODI1 MmRkMWRjYzIwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDE0LTEwLTE3ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgQXZvaWQgdW5uZWNlc3Nhcnkg aXNTVkdGb250KCkgY2hlY2sgaW4gU2ltcGxlRm9udERhdGE6OmFwcGx5VHJhbnNmb3JtcygpCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzc4MzYKKwor ICAgICAgICBSZXZpZXdlZCBieSBBbmRyZWFzIEtsaW5nLgorCisgICAgICAgIEF2b2lkIHVubmVj ZXNzYXJ5IGlzU1ZHRm9udCgpIGNoZWNrIGluIFNpbXBsZUZvbnREYXRhOjphcHBseVRyYW5zZm9y bXMoKS4KKyAgICAgICAgVGhpcyBmdW5jdGlvbiBpcyBvbmx5IGNhbGxlZCBmcm9tIFdpZHRoSXRl cmF0b3I6OmFwcGx5Rm9udFRyYW5zZm9ybXMoKSwKKyAgICAgICAgd2hpY2ggYWxyZWFkeSBtYWtl cyBzdXJlIHRvIGNhbGwgYXBwbHlUcmFuc2Zvcm1zKCkgaWYgaXNTVkdGb250KCkKKyAgICAgICAg cmV0dXJucyBmYWxzZS4gVGhpcyBwYXRjaCByZXBsYWNlcyB0aGUgY2hlY2sgd2l0aCBhIHNpbXBs ZSBhc3NlcnRpb24uCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBiZWhhdmlvciBjaGFuZ2Uu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9TaW1wbGVGb250RGF0YS5oOgorICAgICAg ICAqIHN2Zy9TVkdGb250RGF0YS5oOgorCisyMDE0LTEwLTE3ICBDaHJpcyBEdW1leiAgPGNkdW1l ekBhcHBsZS5jb20+CisKICAgICAgICAgVXNlIGlzPD4oKSAvIGRvd25jYXN0PD4oKSBmb3IgU3R5 bGVJbWFnZQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTM3ODI0CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1Np bXBsZUZvbnREYXRhLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9TaW1wbGVG b250RGF0YS5oCmluZGV4IGU0ZmQxOTU5NTgyY2I5ZDg4ZWMzYjZlZTI2YmRmODhmZDEyYTZiNjIu LjZiNDlkNGNhZDBmMjAyMDc3ODQzN2I3NzhlMjhhMmNlNjljMDc1N2UgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1NpbXBsZUZvbnREYXRhLmgKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvU2ltcGxlRm9udERhdGEuaApAQCAtMjE5LDgg KzIxOSw4IEBAIHB1YmxpYzoKIAogICAgIGJvb2wgYXBwbHlUcmFuc2Zvcm1zKEdseXBoQnVmZmVy R2x5cGgqIGdseXBocywgR2x5cGhCdWZmZXJBZHZhbmNlKiBhZHZhbmNlcywgc2l6ZV90IGdseXBo Q291bnQsIFR5cGVzZXR0aW5nRmVhdHVyZXMgdHlwZXNldHRpbmdGZWF0dXJlcykgY29uc3QKICAg ICB7Ci0gICAgICAgIGlmIChpc1NWR0ZvbnQoKSkKLSAgICAgICAgICAgIHJldHVybiBmYWxzZTsK KyAgICAgICAgLy8gV2UgbmVlZCB0byBoYW5kbGUgdHJhbnNmb3JtcyBvbiBTVkcgZm9udHMgaW50 ZXJuYWxseSwgc2luY2UgdGhleSBhcmUgcmVuZGVyZWQgaW50ZXJuYWxseS4KKyAgICAgICAgQVNT RVJUKCFpc1NWR0ZvbnQoKSk7CiAjaWYgUExBVEZPUk0oSU9TKSB8fCAoUExBVEZPUk0oTUFDKSAm JiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID4gMTA4MCkKICAgICAgICAgd2tDVEZv bnRUcmFuc2Zvcm1PcHRpb25zIG9wdGlvbnMgPSAodHlwZXNldHRpbmdGZWF0dXJlcyAmIEtlcm5p bmcgPyB3a0NURm9udFRyYW5zZm9ybUFwcGx5UG9zaXRpb25pbmcgOiAwKSB8ICh0eXBlc2V0dGlu Z0ZlYXR1cmVzICYgTGlnYXR1cmVzID8gd2tDVEZvbnRUcmFuc2Zvcm1BcHBseVNoYXBpbmcgOiAw KTsKICAgICAgICAgcmV0dXJuIHdrQ1RGb250VHJhbnNmb3JtR2x5cGhzKG1fcGxhdGZvcm1EYXRh LmN0Rm9udCgpLCBnbHlwaHMsIHJlaW50ZXJwcmV0X2Nhc3Q8Q0dTaXplKj4oYWR2YW5jZXMpLCBn bHlwaENvdW50LCBvcHRpb25zKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdG b250RGF0YS5oIGIvU291cmNlL1dlYkNvcmUvc3ZnL1NWR0ZvbnREYXRhLmgKaW5kZXggMDI3YmFh YTQzODcyNTAxNWNkZGZjNmY5YmY2Y2EyMmIxZDM3MjM2Ny4uMmUyZTgwNDRmOTFjMWMyMzA3MzBh ZjRhY2RjNzJiZWNiMjQwODAzOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvc3ZnL1NWR0Zv bnREYXRhLmgKKysrIGIvU291cmNlL1dlYkNvcmUvc3ZnL1NWR0ZvbnREYXRhLmgKQEAgLTUyLDYg KzUyLDggQEAgcHJpdmF0ZToKICAgICBib29sIGZpbGxCTVBHbHlwaHMoU1ZHRm9udEVsZW1lbnQq LCBHbHlwaFBhZ2UqICwgdW5zaWduZWQgb2Zmc2V0LCB1bnNpZ25lZCBsZW5ndGgsIFVDaGFyKiBi dWZmZXIsIGNvbnN0IFNpbXBsZUZvbnREYXRhKikgY29uc3Q7CiAgICAgYm9vbCBmaWxsTm9uQk1Q R2x5cGhzKFNWR0ZvbnRFbGVtZW50KiwgR2x5cGhQYWdlKiAsIHVuc2lnbmVkIG9mZnNldCwgdW5z aWduZWQgbGVuZ3RoLCBVQ2hhciogYnVmZmVyLCBjb25zdCBTaW1wbGVGb250RGF0YSopIGNvbnN0 OwogCisgICAgYm9vbCBhcHBseVRyYW5zZm9ybXMoR2x5cGhCdWZmZXJHbHlwaCosIEdseXBoQnVm ZmVyQWR2YW5jZSosIHNpemVfdCwgVHlwZXNldHRpbmdGZWF0dXJlcykgY29uc3QgPSBkZWxldGU7 CisKICAgICAvLyBUaHMgU1ZHRm9udEZhY2VFbGVtZW50IGlzIGtlcHQgYWxpdmUgLS0KICAgICAv LyAxKSBpbiB0aGUgZXh0ZXJuYWwgZm9udCBjYXNlOiBieSB0aGUgQ1NTRm9udEZhY2VTb3VyY2Us IHdoaWNoIGhvbGRzIGEgcmVmZXJlbmNlIHRvIHRoZSBleHRlcm5hbCBTVkcgZG9jdW1lbnQKICAg ICAvLyAgICBjb250YWluaW5nIHRoZSBlbGVtZW50Owo=