137816 2014-10-17 06:03:03 -0700 [ninja] Don't remove response files for verbose builds 2014-11-03 03:46:03 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ossy evab.u-szeged cgarcia commit-queue dbates evab.u-szeged gyuyoung.kim mrobinson oldest_to_newest 1042367 0 ossy 2014-10-17 06:03:03 -0700 In bug137606 I suggested to disable using response files if we use VERBOSE build to be able copy/paste the command and be able run manually. Unfortunately the linking fails in this case with "Argument list too long". The another problem is that ninja automatically removes response files. But we can use "-d keeprsp" not to remove rsp files if we have ninja 1.5.1 or newer. 1042374 1 mrobinson 2014-10-17 07:42:35 -0700 Response file are necessary because CMake + Ninja does not know how to add files to ar archives in chunks. Instead it will try to add them using one command invocation. 1044750 2 240601 evab.u-szeged 2014-10-29 07:58:40 -0700 Created attachment 240601 Patch "-d keeprsp" is available since ninja version 1.4.0, so created the feature according to this. 1044751 3 240602 evab.u-szeged 2014-10-29 08:05:03 -0700 Created attachment 240602 Patch 1044757 4 240603 evab.u-szeged 2014-10-29 08:43:57 -0700 Created attachment 240603 Patch 1045663 5 evab.u-szeged 2014-11-02 23:25:06 -0800 Ping? 1045679 6 240603 ossy 2014-11-03 00:31:05 -0800 Comment on attachment 240603 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240603&action=review The idea is good, but I suggest some minor style changes. > Tools/Scripts/webkitdirs.pm:170 > + my $ninjaVersion = `ninja --version`; > + $ninjaVersion =~ s/\R//g; I think chomp is better choice here: chomp(my $ninjaVersion = `ninja --version`); > Tools/Scripts/webkitdirs.pm:1841 > + > + if (version->parse(determineNinjaVersion()) >= version->parse("1.4.0")) { > + push @args, "-d keeprsp"; > + } We can do it in one line: push @args, "-d keeprsp" if (version->parse(determineNinjaVersion()) >= version->parse("1.4.0")); 1045684 7 240834 evab.u-szeged 2014-11-03 01:07:03 -0800 Created attachment 240834 Patch for landing 1045703 8 240834 commit-queue 2014-11-03 03:45:59 -0800 Comment on attachment 240834 Patch for landing Clearing flags on attachment: 240834 Committed r175469: <http://trac.webkit.org/changeset/175469> 1045704 9 commit-queue 2014-11-03 03:46:03 -0800 All reviewed patches have been landed. Closing bug. 240601 2014-10-29 07:58:40 -0700 2014-10-29 08:03:39 -0700 Patch patch.diff text/plain 1321 evab.u-szeged ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA3ZjVk YjQyLi43NGY2ZjFlIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTQtMTAtMjkgIEV2YSBCYWxhenNmYWx2aSAgPGV2 YWIudS1zemVnZWRAcGFydG5lci5zYW1zdW5nLmNvbT4KKworICAgICAgICBbbmluamFdIERvbid0 IHJlbW92ZSByZXNwb25zZSBmaWxlcyBmb3IgdmVyYm9zZSBidWlsZHMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNzgxNgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBt OgorICAgICAgICAoYnVpbGRDTWFrZUdlbmVyYXRlZFByb2plY3QpOgorCiAyMDE0LTEwLTI5ICBD c2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAKICAgICAgICAgW0VGTF0gYnVp bGQtd2Via2l0IHNob3VsZCB0cnkgaGFyZGVyIHRvIGF2b2lkIHJlLXJ1bm5pbmcgY21ha2UKZGlm ZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbSBiL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0ZGlycy5wbQppbmRleCA3ODA5YTllLi5jY2NkN2IyIDEwMDc1NQotLS0gYS9Ub29scy9TY3Jp cHRzL3dlYmtpdGRpcnMucG0KKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCkBAIC0x ODI1LDcgKzE4MjUsMTMgQEAgc3ViIGJ1aWxkQ01ha2VHZW5lcmF0ZWRQcm9qZWN0KCQpCiAgICAg ICAgICRjb21tYW5kID0gIiRidWlsZFBhdGgvYnVpbGQuc2giOwogICAgICAgICBAYXJncyA9ICgk bWFrZUFyZ3MpOwogICAgIH0KLSAgICBwdXNoIEBhcmdzLCAiLXYiIGlmICgkRU5We1ZFUkJPU0V9 ICYmIGNhblVzZU5pbmphKCkpOworCisgICAgaWYgKCRFTlZ7VkVSQk9TRX0gJiYgY2FuVXNlTmlu amEoKSkgeworICAgICAgICBwdXNoIEBhcmdzLCAiLXYiOworCisgICAgICAgIGlmICh2ZXJzaW9u LT5wYXJzZShkZXRlcm1pbmVOaW5qYVZlcnNpb24oKSkgPj0gdmVyc2lvbi0+cGFyc2UoIjEuNC4w IikpCisgICAgICAgICAgICBwdXNoIEBhcmdzLCAiLWQga2VlcHJzcCI7CisgICAgfQogCiAgICAg IyBXZSBjYWxsIHN5c3RlbSgiY21ha2UgQGFyZ3MiKSBpbnN0ZWFkIG9mIHN5c3RlbSgiY21ha2Ui LCBAYXJncykgc28gdGhhdCBAYXJncyBpcwogICAgICMgcGFyc2VkIGZvciBzaGVsbCBtZXRhY2hh cmFjdGVycy4gSW4gcGFydGljdWxhciwgJG1ha2VBcmdzIG1heSBjb250YWluIHN1Y2ggbWV0YWNo YXJhY3RlcnMuCg== 240602 2014-10-29 08:05:03 -0700 2014-10-29 08:06:20 -0700 Patch bug-137816-20141029160508.patch text/plain 1494 evab.u-szeged U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1MzI3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggN2Y1ZGI0MjMwNTBiOGFkOGJlOWNkNzYyYjIzODM1YTIx MjYxNjlmNC4uNzRmNmYxZWM1OTM2OTU2YWQzMjcyNTk1ZGJkOTE5ZDZlMjBhMmY4YyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE0LTEwLTI5ICBFdmEgQmFsYXpzZmFsdmkgIDxldmFiLnUtc3plZ2VkQHBhcnRuZXIu c2Ftc3VuZy5jb20+CisKKyAgICAgICAgW25pbmphXSBEb24ndCByZW1vdmUgcmVzcG9uc2UgZmls ZXMgZm9yIHZlcmJvc2UgYnVpbGRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMzc4MTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKyAgICAgICAgKGJ1aWxkQ01h a2VHZW5lcmF0ZWRQcm9qZWN0KToKKwogMjAxNC0xMC0yOSAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8 b3NzeUB3ZWJraXQub3JnPgogCiAgICAgICAgIFtFRkxdIGJ1aWxkLXdlYmtpdCBzaG91bGQgdHJ5 IGhhcmRlciB0byBhdm9pZCByZS1ydW5uaW5nIGNtYWtlCmRpZmYgLS1naXQgYS9Ub29scy9TY3Jp cHRzL3dlYmtpdGRpcnMucG0gYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KaW5kZXggNzgw OWE5ZWZiYzBkZDNiNDkzYmNkNjJjMjMwNDEzMjg0NmYzOGRlNi4uZjE3ODhjNzhmZDNlNjczYWVm ODFjMDQ1MWFjMTE2YjFkMGM4NzcxMCAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRk aXJzLnBtCisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQpAQCAtMTgyNSw3ICsxODI1 LDE0IEBAIHN1YiBidWlsZENNYWtlR2VuZXJhdGVkUHJvamVjdCgkKQogICAgICAgICAkY29tbWFu ZCA9ICIkYnVpbGRQYXRoL2J1aWxkLnNoIjsKICAgICAgICAgQGFyZ3MgPSAoJG1ha2VBcmdzKTsK ICAgICB9Ci0gICAgcHVzaCBAYXJncywgIi12IiBpZiAoJEVOVntWRVJCT1NFfSAmJiBjYW5Vc2VO aW5qYSgpKTsKKworICAgIGlmICgkRU5We1ZFUkJPU0V9ICYmIGNhblVzZU5pbmphKCkpIHsKKyAg ICAgICAgcHVzaCBAYXJncywgIi12IjsKKworICAgICAgICBpZiAodmVyc2lvbi0+cGFyc2UoZGV0 ZXJtaW5lTmluamFWZXJzaW9uKCkpID49IHZlcnNpb24tPnBhcnNlKCIxLjQuMCIpKSB7CisgICAg ICAgICAgICBwdXNoIEBhcmdzLCAiLWQga2VlcHJzcCI7CisgICAgICAgIH0KKyAgICB9CiAKICAg ICAjIFdlIGNhbGwgc3lzdGVtKCJjbWFrZSBAYXJncyIpIGluc3RlYWQgb2Ygc3lzdGVtKCJjbWFr ZSIsIEBhcmdzKSBzbyB0aGF0IEBhcmdzIGlzCiAgICAgIyBwYXJzZWQgZm9yIHNoZWxsIG1ldGFj aGFyYWN0ZXJzLiBJbiBwYXJ0aWN1bGFyLCAkbWFrZUFyZ3MgbWF5IGNvbnRhaW4gc3VjaCBtZXRh Y2hhcmFjdGVycy4K 240603 2014-10-29 08:43:57 -0700 2014-11-03 01:06:57 -0800 Patch bug-137816-20141029164401.patch text/plain 1802 evab.u-szeged U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1MzI3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggN2Y1ZGI0MjMwNTBiOGFkOGJlOWNkNzYyYjIzODM1YTIx MjYxNjlmNC4uNmE3ZTE1NDIyZGE5YTA4Y2ZiYjA0NzEyODcyZGRmMjgyZmQzY2YzMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE0LTEwLTI5ICBFdmEgQmFsYXpzZmFsdmkgIDxldmFiLnUtc3plZ2VkQHBhcnRuZXIu c2Ftc3VuZy5jb20+CisKKyAgICAgICAgW25pbmphXSBEb24ndCByZW1vdmUgcmVzcG9uc2UgZmls ZXMgZm9yIHZlcmJvc2UgYnVpbGRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMzc4MTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKyAgICAgICAgKGRldGVybWlu ZU5pbmphVmVyc2lvbik6CisgICAgICAgIChidWlsZENNYWtlR2VuZXJhdGVkUHJvamVjdCk6CisK IDIwMTQtMTAtMjkgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KIAogICAg ICAgICBbRUZMXSBidWlsZC13ZWJraXQgc2hvdWxkIHRyeSBoYXJkZXIgdG8gYXZvaWQgcmUtcnVu bmluZyBjbWFrZQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtIGIvVG9v bHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCmluZGV4IDc4MDlhOWVmYmMwZGQzYjQ5M2JjZDYyYzIz MDQxMzI4NDZmMzhkZTYuLmUyMzBmMTg1OTgxODI0NWFjZGU4NGM2MzFkMWQ0NjI4ZDNlODg3ZDgg MTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQorKysgYi9Ub29scy9TY3Jp cHRzL3dlYmtpdGRpcnMucG0KQEAgLTE2NCw2ICsxNjQsMTMgQEAgc3ViIHNldFNvdXJjZURpcigk KQogICAgICgkc291cmNlRGlyKSA9IEBfOwogfQogCitzdWIgZGV0ZXJtaW5lTmluamFWZXJzaW9u Cit7CisgICAgbXkgJG5pbmphVmVyc2lvbiA9IGBuaW5qYSAtLXZlcnNpb25gOworICAgICRuaW5q YVZlcnNpb24gPX4gcy9cUi8vZzsKKyAgICByZXR1cm4gJG5pbmphVmVyc2lvbjsKK30KKwogc3Vi IGRldGVybWluZVhjb2RlVmVyc2lvbgogewogICAgIHJldHVybiBpZiBkZWZpbmVkICR4Y29kZVZl cnNpb247CkBAIC0xODI1LDcgKzE4MzIsMTQgQEAgc3ViIGJ1aWxkQ01ha2VHZW5lcmF0ZWRQcm9q ZWN0KCQpCiAgICAgICAgICRjb21tYW5kID0gIiRidWlsZFBhdGgvYnVpbGQuc2giOwogICAgICAg ICBAYXJncyA9ICgkbWFrZUFyZ3MpOwogICAgIH0KLSAgICBwdXNoIEBhcmdzLCAiLXYiIGlmICgk RU5We1ZFUkJPU0V9ICYmIGNhblVzZU5pbmphKCkpOworCisgICAgaWYgKCRFTlZ7VkVSQk9TRX0g JiYgY2FuVXNlTmluamEoKSkgeworICAgICAgICBwdXNoIEBhcmdzLCAiLXYiOworCisgICAgICAg IGlmICh2ZXJzaW9uLT5wYXJzZShkZXRlcm1pbmVOaW5qYVZlcnNpb24oKSkgPj0gdmVyc2lvbi0+ cGFyc2UoIjEuNC4wIikpIHsKKyAgICAgICAgICAgIHB1c2ggQGFyZ3MsICItZCBrZWVwcnNwIjsK KyAgICAgICAgfQorICAgIH0KIAogICAgICMgV2UgY2FsbCBzeXN0ZW0oImNtYWtlIEBhcmdzIikg aW5zdGVhZCBvZiBzeXN0ZW0oImNtYWtlIiwgQGFyZ3MpIHNvIHRoYXQgQGFyZ3MgaXMKICAgICAj IHBhcnNlZCBmb3Igc2hlbGwgbWV0YWNoYXJhY3RlcnMuIEluIHBhcnRpY3VsYXIsICRtYWtlQXJn cyBtYXkgY29udGFpbiBzdWNoIG1ldGFjaGFyYWN0ZXJzLgo= 240834 2014-11-03 01:07:03 -0800 2014-11-03 03:45:59 -0800 Patch for landing bug-137816-20141103100710.patch text/plain 1719 evab.u-szeged U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1NDY2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNmRhNGIxMTZiMzZkNWFlZGJlYmQzOWNmZDY0NzNkZDRh Zjk0ODFkNi4uMmU1N2NkMjZlMTRmNGYyZDU0MDY1MjAyMWQ5MzlkNjY2YzEyMWVhNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE0LTExLTAzICBFdmEgQmFsYXpzZmFsdmkgIDxldmFiLnUtc3plZ2VkQHBhcnRuZXIu c2Ftc3VuZy5jb20+CisKKyAgICAgICAgW25pbmphXSBEb24ndCByZW1vdmUgcmVzcG9uc2UgZmls ZXMgZm9yIHZlcmJvc2UgYnVpbGRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMzc4MTYKKworICAgICAgICBSZXZpZXdlZCBieSBDc2FiYSBPc3p0cm9n b27DoWMuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdGRpcnMucG06CisgICAgICAgIChkZXRl cm1pbmVOaW5qYVZlcnNpb24pOgorICAgICAgICAoYnVpbGRDTWFrZUdlbmVyYXRlZFByb2plY3Qp OgorCiAyMDE0LTExLTAyICBBa29zIEtpc3MgIDxha2lzc0BpbmYudS1zemVnZWQuaHU+CiAKICAg ICAgICAgW0dUS10gRml4IHRoZSBidWlsZCBvZiBGVEwgSklUCmRpZmYgLS1naXQgYS9Ub29scy9T Y3JpcHRzL3dlYmtpdGRpcnMucG0gYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KaW5kZXgg NzgwOWE5ZWZiYzBkZDNiNDkzYmNkNjJjMjMwNDEzMjg0NmYzOGRlNi4uOGIwNmIxMmYyZDc2NDVj YWM1YTZjNjU5NTg0NTZlYzM4NjUzYjAyNyAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJr aXRkaXJzLnBtCisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQpAQCAtMTY0LDYgKzE2 NCwxMiBAQCBzdWIgc2V0U291cmNlRGlyKCQpCiAgICAgKCRzb3VyY2VEaXIpID0gQF87CiB9CiAK K3N1YiBkZXRlcm1pbmVOaW5qYVZlcnNpb24KK3sKKyAgICBjaG9tcChteSAkbmluamFWZXJzaW9u ID0gYG5pbmphIC0tdmVyc2lvbmApOworICAgIHJldHVybiAkbmluamFWZXJzaW9uOworfQorCiBz dWIgZGV0ZXJtaW5lWGNvZGVWZXJzaW9uCiB7CiAgICAgcmV0dXJuIGlmIGRlZmluZWQgJHhjb2Rl VmVyc2lvbjsKQEAgLTE4MjUsNyArMTgzMSwxMSBAQCBzdWIgYnVpbGRDTWFrZUdlbmVyYXRlZFBy b2plY3QoJCkKICAgICAgICAgJGNvbW1hbmQgPSAiJGJ1aWxkUGF0aC9idWlsZC5zaCI7CiAgICAg ICAgIEBhcmdzID0gKCRtYWtlQXJncyk7CiAgICAgfQotICAgIHB1c2ggQGFyZ3MsICItdiIgaWYg KCRFTlZ7VkVSQk9TRX0gJiYgY2FuVXNlTmluamEoKSk7CisKKyAgICBpZiAoJEVOVntWRVJCT1NF fSAmJiBjYW5Vc2VOaW5qYSgpKSB7CisgICAgICAgIHB1c2ggQGFyZ3MsICItdiI7CisgICAgICAg IHB1c2ggQGFyZ3MsICItZCBrZWVwcnNwIiBpZiAodmVyc2lvbi0+cGFyc2UoZGV0ZXJtaW5lTmlu amFWZXJzaW9uKCkpID49IHZlcnNpb24tPnBhcnNlKCIxLjQuMCIpKTsKKyAgICB9CiAKICAgICAj IFdlIGNhbGwgc3lzdGVtKCJjbWFrZSBAYXJncyIpIGluc3RlYWQgb2Ygc3lzdGVtKCJjbWFrZSIs IEBhcmdzKSBzbyB0aGF0IEBhcmdzIGlzCiAgICAgIyBwYXJzZWQgZm9yIHNoZWxsIG1ldGFjaGFy YWN0ZXJzLiBJbiBwYXJ0aWN1bGFyLCAkbWFrZUFyZ3MgbWF5IGNvbnRhaW4gc3VjaCBtZXRhY2hh cmFjdGVycy4K