137798 2014-10-16 17:13:34 -0700 OSObjectPtr is missing leakRef() 2014-10-16 22:14:42 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mitz mitz benjamin cmarcelo commit-queue sam oldest_to_newest 1042246 0 mitz 2014-10-16 17:13:34 -0700 OSObjectPtr is missing leakRef() 1042247 1 239985 mitz 2014-10-16 17:14:48 -0700 Created attachment 239985 Add OSObjectPtr::leakRef 1042248 2 commit-queue 2014-10-16 17:16:28 -0700 Attachment 239985 did not pass style-queue: ERROR: Source/WTF/wtf/OSObjectPtr.h:145: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1042297 3 mitz 2014-10-16 22:14:42 -0700 Committed <http://trac.webkit.org/r174809>. 239985 2014-10-16 17:14:48 -0700 2014-10-16 21:45:59 -0700 Add OSObjectPtr::leakRef bug-137798-20141016171453.patch text/plain 2358 mitz SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxNzQ4MDApCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE0LTEwLTE2ICBEYW4gQmVybnN0ZWluICA8bWl0 ekBhcHBsZS5jb20+CisKKyAgICAgICAgT1NPYmplY3RQdHIgaXMgbWlzc2luZyBsZWFrUmVmKCkK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNzc5OAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL09T T2JqZWN0UHRyLmg6CisKIDIwMTQtMTAtMTQgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBhcHBs ZS5jb20+CiAKICAgICAgICAgW1dpbl0gVW5yZXZpZXdlZCBnYXJkZW5pbmcuIElnbm9yZSBWaXN1 YWwgU3R1ZGlvICouc2RmIGZpbGVzLgpJbmRleDogU291cmNlL1dURi93dGYvT1NPYmplY3RQdHIu aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9PU09iamVjdFB0ci5oCShyZXZpc2lvbiAx NzQ3OTgpCisrKyBTb3VyY2UvV1RGL3d0Zi9PU09iamVjdFB0ci5oCSh3b3JraW5nIGNvcHkpCkBA IC0xNDEsNiArMTQxLDEzIEBAIHB1YmxpYzoKICAgICAgICAgc3RkOjpzd2FwKG1fcHRyLCBvdGhl ci5tX3B0cik7CiAgICAgfQogCisgICAgVCBsZWFrUmVmKCkgV0FSTl9VTlVTRURfUkVUVVJOCisg ICAgeworICAgICAgICBUIHB0ciA9IG1fcHRyOworICAgICAgICBtX3B0ciA9IG51bGxwdHI7Cisg ICAgICAgIHJldHVybiBwdHI7CisgICAgfQorCiAgICAgZnJpZW5kIE9TT2JqZWN0UHRyIGFkb3B0 T1NPYmplY3Q8VD4oVCk7CiAKIHByaXZhdGU6CkluZGV4OiBUb29scy9DaGFuZ2VMb2cKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gVG9vbHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNzQ4MDApCisrKyBUb29scy9DaGFu Z2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxNC0xMC0xNiAgRGFuIEJl cm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgorCisgICAgICAgIE9TT2JqZWN0UHRyIGlzIG1pc3Np bmcgbGVha1JlZigpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMzc3OTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL2Rhcndpbi9PU09iamVjdFB0ci5jcHA6Cisg ICAgICAgIChUZXN0V2ViS2l0QVBJOjpURVNUKE9TT2JqZWN0UHRyLCBMZWFrUmVmKSk6IEFkZGVk LgorCiAyMDE0LTEwLTE2ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CiAKICAg ICAgICAgY29tbWl0LXF1ZXVlOiBmYWlscyB0byByZXBsYWNlIE9PLVBTISB3aXRoIHJldmlld2Vy IG5hbWUKSW5kZXg6IFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL2Rhcndpbi9PU09iamVj dFB0ci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvZGFy d2luL09TT2JqZWN0UHRyLmNwcAkocmV2aXNpb24gMTc0Nzk4KQorKysgVG9vbHMvVGVzdFdlYktp dEFQSS9UZXN0cy9XVEYvZGFyd2luL09TT2JqZWN0UHRyLmNwcAkod29ya2luZyBjb3B5KQpAQCAt NTEsNCArNTEsMTYgQEAgVEVTVChPU09iamVjdFB0ciwgUmV0YWluUmVsZWFzZSkKICAgICBFWFBF Q1RfRVEoMSwgQ0ZHZXRSZXRhaW5Db3VudChmb28pKTsKIH0KIAorVEVTVChPU09iamVjdFB0ciwg TGVha1JlZikKK3sKKyAgICBPU09iamVjdFB0cjxkaXNwYXRjaF9xdWV1ZV90PiBmb28gPSBhZG9w dE9TT2JqZWN0KGRpc3BhdGNoX3F1ZXVlX2NyZWF0ZSgwLCBESVNQQVRDSF9RVUVVRV9TRVJJQUwp KTsKKyAgICBFWFBFQ1RfRVEoMSwgQ0ZHZXRSZXRhaW5Db3VudChmb28uZ2V0KCkpKTsKKworICAg IGRpc3BhdGNoX3F1ZXVlX3QgcXVldWUgPSBmb28ubGVha1JlZigpOworICAgIEVYUEVDVF9FUShu dWxscHRyLCBmb28uZ2V0KCkpOworICAgIEVYUEVDVF9FUSgxLCBDRkdldFJldGFpbkNvdW50KHF1 ZXVlKSk7CisKKyAgICBXVEY6OnJlbGVhc2VPU09iamVjdChxdWV1ZSk7Cit9CisKIH0gLy8gbmFt ZXNwYWNlIFRlc3RXZWJLaXRBUEkK