137795 2014-10-16 15:51:49 -0700 commit-queue: fails to replace OO-PS! with reviewer name 2014-10-16 16:57:08 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ddkilzer ddkilzer ap cdumez commit-queue ddkilzer glenn oliver ossy rniwa oldest_to_newest 1042226 0 ddkilzer 2014-10-16 15:51:49 -0700 After the Bugzilla 4.2.11 update, the commit-queue sometimes fails to replace the OO-PS! text with the reviewer name. For example: <https://webkit-queues.appspot.com/patch/239923> <https://webkit-queues.appspot.com/results/5777270190899200> Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 239923, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. 1042234 1 ddkilzer 2014-10-16 16:16:01 -0700 Oliver thinks this may be the same issue: $ ./Tools/Scripts/webkit-patch land 137766 Fetching: https://bugs.webkit.org/show_bug.cgi?id=137766&ctype=xml&excludefield=attachmentdata Warning, attachment 239923 on bug 137766 has invalid reviewer (akling) No reviewed patches on bug 137766, cannot infer reviewer. Failed to guess reviewer from bug 137766 and --reviewer= not provided. Not updating ChangeLogs with reviewer. Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html Looks like webkit-patch isn't able to fetch the reviewer list? 1042237 2 ddkilzer 2014-10-16 16:38:41 -0700 (In reply to comment #1) > Looks like webkit-patch isn't able to fetch the reviewer list? Bugzilla changed to not expose email addresses when no one is logged in, so webkit-patch is loading this URL without logging in first: https://bugs.webkit.org/show_bug.cgi?id=137766&ctype=xml&excludefield=attachmentdata And getting <flag> elements like this: <flag name="review" id="264671" type_id="1" status="+" setter="akling"/> <flag name="commit-queue" id="264709" type_id="3" status="+" setter="cdumez"/> Instead of like this (after logging in): <flag name="review" id="264671" type_id="1" status="+" setter="akling@apple.com"/> <flag name="commit-queue" id="264709" type_id="3" status="+" setter="cdumez@apple.com"/> The fix is to make sure webkit-patch logs in before fetching attachment data. 1042240 3 239983 ddkilzer 2014-10-16 16:50:52 -0700 Created attachment 239983 Patch v1 1042243 4 ddkilzer 2014-10-16 16:56:34 -0700 Committed r174800: <http://trac.webkit.org/changeset/174800> 1042244 5 ddkilzer 2014-10-16 16:57:08 -0700 (In reply to comment #4) > Committed r174800: <http://trac.webkit.org/changeset/174800> NOTE: I haven't been able to verify if this is the only fix needed, but this is needed before we determine what the next issue is. 239983 2014-10-16 16:50:52 -0700 2014-10-16 16:52:30 -0700 Patch v1 bug-137795-20141016164945.patch text/plain 1733 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0Nzk4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzhmZmJkNTUyM2EyNjYzMjRjYTBjNjA3ZGI5Yjg3NTNi YjNmNzUxOS4uZWI1ZDRhZGViMGM1MmRkN2Q5YTliYjc0MjljNmM2M2VjNDU1NGRlZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4 IEBACiAyMDE0LTEwLTE2ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CiAKKyAg ICAgICAgY29tbWl0LXF1ZXVlOiBmYWlscyB0byByZXBsYWNlIE9PLVBTISB3aXRoIHJldmlld2Vy IG5hbWUKKyAgICAgICAgPGh0dHA6Ly93ZWJraXQub3JnL2IvMTM3Nzk1PgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9j b21tb24vbmV0L2J1Z3ppbGxhL2J1Z3ppbGxhLnB5OgorICAgICAgICAoQnVnemlsbGEuZmV0Y2hf YnVnX2RpY3Rpb25hcnkpOiBCdWd6aWxsYSA0LjIueCBuZXZlciBnaXZlcyBvdXQKKyAgICAgICAg ZW1haWwgYWRkcmVzc2VzIHRvIHVuYXV0aGVudGljYXRlZCBwYWdlIGxvYWRzLCBzbyB3ZSBtdXN0 IGFsd2F5cworICAgICAgICBhdXRoZW50aWNhdGUgYmVmb3JlIGdldHRpbmcgYnVnIGRhdGEgc28g d2UgZ2V0IGZ1bGwgZW1haWwKKyAgICAgICAgYWRkcmVzc2VzLgorCisyMDE0LTEwLTE2ICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKICAgICAgICAgY29tbWl0LXF1ZXVlOiBm YWlscyB0byBjbG9zZSBidWdzIGFmdGVyIHN1Y2Nlc3NmdWxseSBsYW5kaW5nIHBhdGNoZXMKICAg ICAgICAgPGh0dHA6Ly93ZWJraXQub3JnL2IvMTM3Nzk0PgogCmRpZmYgLS1naXQgYS9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVnemlsbGEvYnVnemlsbGEucHkgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVnemlsbGEvYnVnemlsbGEucHkKaW5kZXggM2Zk ZGE3YjgxNzRjNzBlZjdkNWMyMTFlZTIwZDQ4NDhkYjU4YWQwZC4uNDE0MTBjZWMyZmFlN2JlYzVm MDE0ZTViMDUwOGZlZjI4MDcyMzVjYiAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9jb21tb24vbmV0L2J1Z3ppbGxhL2J1Z3ppbGxhLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvY29tbW9uL25ldC9idWd6aWxsYS9idWd6aWxsYS5weQpAQCAtNDY4LDEyICs0NjgsMTAg QEAgY2xhc3MgQnVnemlsbGEob2JqZWN0KToKIAogICAgIGRlZiBmZXRjaF9idWdfZGljdGlvbmFy eShzZWxmLCBidWdfaWQpOgogICAgICAgICB0cnk6CisgICAgICAgICAgICBzZWxmLmF1dGhlbnRp Y2F0ZSgpCiAgICAgICAgICAgICByZXR1cm4gc2VsZi5fcGFyc2VfYnVnX2RpY3Rpb25hcnlfZnJv bV94bWwoc2VsZi5fZmV0Y2hfYnVnX3BhZ2UoYnVnX2lkKSkKICAgICAgICAgZXhjZXB0IEtleWJv YXJkSW50ZXJydXB0OgogICAgICAgICAgICAgcmFpc2UKLSAgICAgICAgZXhjZXB0OgotICAgICAg ICAgICAgc2VsZi5hdXRoZW50aWNhdGUoKQotICAgICAgICAgICAgcmV0dXJuIHNlbGYuX3BhcnNl X2J1Z19kaWN0aW9uYXJ5X2Zyb21feG1sKHNlbGYuX2ZldGNoX2J1Z19wYWdlKGJ1Z19pZCkpCiAK ICAgICAjIEZJWE1FOiBBIEJ1Z3ppbGxhQ2FjaGUgb2JqZWN0IHNob3VsZCBwcm92aWRlIGFsbCB0 aGVzZSBmZXRjaF8gbWV0aG9kcy4KIAo=