137794 2014-10-16 15:29:21 -0700 commit-queue: fails to close bugs after successfully landing patches 2014-10-16 15:43:59 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ddkilzer ddkilzer ap commit-queue glenn ossy rniwa oldest_to_newest 1042220 0 ddkilzer 2014-10-16 15:29:21 -0700 See: <https://webkit-queues.appspot.com/results/5533208674304000> Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 239956, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Fetching: https://bugs.webkit.org/attachment.cgi?id=239956&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=137596&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Updating working directory Processing patch 239956 from bug 137596. Committed r174789: <http://trac.webkit.org/changeset/174789> Logging in as commit-queue@webkit.org... Clearing flags on attachment: 239956 Committed r174789: <http://trac.webkit.org/changeset/174789> Updating OpenSource From git://git.webkit.org/WebKit 4fe827b..628d098 master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 174785 = 4fe827b6bb38580831ecab29dfbc8e7d34c6726e r174786 = 8bcf22ac234e7deecdb35407e3d2a1c83d737ec9 r174787 = a5d9cf509e7f2d0101af9cd1ae889cf9ad9951f0 r174788 = 628d0989d0fd2bcea2b7917e9e18ccb6bbd4922e Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Traceback (most recent call last): File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch", line 84, in <module> main() File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch", line 79, in main WebKitPatch(os.path.abspath(__file__)).main() File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main result = command.check_arguments_and_execute(options, args, self) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/download.py", line 177, in execute self._process_patch(patch, options, args, tool) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/download.py", line 203, in _process_patch self._main_sequence.run_and_handle_errors(tool, options, state) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors self._run(tool, options, state) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run step(tool, options).run(state) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/steps/closepatch.py", line 36, in run self._tool.bugs.clear_attachment_flags(state["patch"].id(), comment_text) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py", line 757, in clear_attachment_flags self.browser.set_value(comment_text, name='comment', nr=0) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_form.py", line 2833, in set_value c.value = value File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_form.py", line 1221, in __setattr__ raise AttributeError("control '%s' is disabled" % self.name) AttributeError: control 'comment' is disabled 1042221 1 ddkilzer 2014-10-16 15:31:45 -0700 Using Web Inspector, it looks like there are two <textarea> elements with the name "comment", and Mechanize is choosing the first one: Load: <https://bugs.webkit.org/attachment.cgi?id=239956&action=edit> #1: <textarea name="comment" id="editFrame" class="bz_default_hidden" wrap="soft" disabled="disabled" rows="10" cols="80"> #2: <textarea name="comment" id="comment" wrap="soft" rows="10" cols="80"> I think changing line 757 in bugzilla.py will fix this: - self.browser.set_value(comment_text, name='comment', nr=0) + self.browser.set_value(comment_text, name='comment', nr=1) 1042222 2 239979 ddkilzer 2014-10-16 15:38:20 -0700 Created attachment 239979 Patch v1 1042225 3 ddkilzer 2014-10-16 15:43:59 -0700 Committed r174797: <http://trac.webkit.org/changeset/174797> 239979 2014-10-16 15:38:20 -0700 2014-10-16 15:40:10 -0700 Patch v1 bug-137794-20141016153714.patch text/plain 1607 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0NzkxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTRkMmVlYzk5Mjk3YmRlNTAyYTYyNzc4ZjViMmU1YzY2 MWM0MGZjMi4uZjcyMzg2MDRjZmY5NzVjZTUxOTI2YzQ2NDgyMzViMDM3MjI5MzllZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE0LTEwLTE2ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAg ICAgICAgY29tbWl0LXF1ZXVlOiBmYWlscyB0byBjbG9zZSBidWdzIGFmdGVyIHN1Y2Nlc3NmdWxs eSBsYW5kaW5nIHBhdGNoZXMKKyAgICAgICAgPGh0dHA6Ly93ZWJraXQub3JnL2IvMTM3Nzk0Pgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0 cy93ZWJraXRweS9jb21tb24vbmV0L2J1Z3ppbGxhL2J1Z3ppbGxhLnB5OgorICAgICAgICAoQnVn emlsbGEuY2xlYXJfYXR0YWNobWVudF9mbGFncyk6IENoYW5nZSAnbnI9MCcgdG8gJ25yPTEnIHRv CisgICAgICAgIHRlbGwgTWVjaGFuaXplIHRvIHVzZSB0aGUgc2Vjb25kIDx0ZXh0YXJlYT4gb24g dGhlIHBhZ2Ugd2l0aAorICAgICAgICBuYW1lPSJjb21tZW50Ii4KKwogMjAxNC0xMC0xNSAgR3l1 eW91bmcgS2ltICA8Z3l1eW91bmcua2ltQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFVucmV2aWV3 ZWQsIGFkZCBteXNlbGYgdG8gQ29vcmRpbmF0ZWRHcmFwaGljcyB3YXRjaGVycy4KZGlmZiAtLWdp dCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9idWd6aWxsYS9idWd6aWxsYS5w eSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9idWd6aWxsYS9idWd6aWxsYS5w eQppbmRleCAwNDY4MzIxMDM2OTIyNDkyOTFmOTk2ZTcwY2Q1MDcyZDQzZDQ1OGY5Li4zZmRkYTdi ODE3NGM3MGVmN2Q1YzIxMWVlMjBkNDg0OGRiNThhZDBkIDEwMDY0NAotLS0gYS9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVnemlsbGEvYnVnemlsbGEucHkKKysrIGIvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L2J1Z3ppbGxhL2J1Z3ppbGxhLnB5CkBAIC03NTQs NyArNzU0LDcgQEAgY2xhc3MgQnVnemlsbGEob2JqZWN0KToKIAogICAgICAgICBzZWxmLmJyb3dz ZXIub3BlbihzZWxmLmF0dGFjaG1lbnRfdXJsX2Zvcl9pZChhdHRhY2htZW50X2lkLCAnZWRpdCcp KQogICAgICAgICBzZWxmLmJyb3dzZXIuc2VsZWN0X2Zvcm0obnI9MSkKLSAgICAgICAgc2VsZi5i cm93c2VyLnNldF92YWx1ZShjb21tZW50X3RleHQsIG5hbWU9J2NvbW1lbnQnLCBucj0wKQorICAg ICAgICBzZWxmLmJyb3dzZXIuc2V0X3ZhbHVlKGNvbW1lbnRfdGV4dCwgbmFtZT0nY29tbWVudCcs IG5yPTEpCiAgICAgICAgIHNlbGYuX2ZpbmRfc2VsZWN0X2VsZW1lbnRfZm9yX2ZsYWcoJ3Jldmll dycpLnZhbHVlID0gKCJYIiwpCiAgICAgICAgIHNlbGYuX2ZpbmRfc2VsZWN0X2VsZW1lbnRfZm9y X2ZsYWcoJ2NvbW1pdC1xdWV1ZScpLnZhbHVlID0gKCJYIiwpCiAgICAgICAgIHNlbGYuYnJvd3Nl ci5zdWJtaXQoKQo=