<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>137791</bug_id>
          
          <creation_ts>2014-10-16 14:50:03 -0700</creation_ts>
          <short_desc>[Mac] Use Fast enumeration consistently in WebFontCache.mm</short_desc>
          <delta_ts>2014-10-18 10:05:38 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Platform</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>OS X 10.9</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Enhancement</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Chris Dumez">cdumez</reporter>
          <assigned_to name="Chris Dumez">cdumez</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>darin</cc>
    
    <cc>enrica</cc>
    
    <cc>simon.fraser</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1042202</commentid>
    <comment_count>0</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2014-10-16 14:50:03 -0700</bug_when>
    <thetext>Use Fast enumeration consistently in WebFontCache.mm. Currently, some code is using fast enumeration while the rest isn&apos;t.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1042209</commentid>
    <comment_count>1</comment_count>
      <attachid>239976</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2014-10-16 14:56:22 -0700</bug_when>
    <thetext>Created attachment 239976
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1042608</commentid>
    <comment_count>2</comment_count>
      <attachid>239976</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-10-18 10:05:29 -0700</bug_when>
    <thetext>Comment on attachment 239976
Patch

Clearing flags on attachment: 239976

Committed r174862: &lt;http://trac.webkit.org/changeset/174862&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1042609</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-10-18 10:05:38 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>239976</attachid>
            <date>2014-10-16 14:56:22 -0700</date>
            <delta_ts>2014-10-18 10:05:29 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-137791-20141016145627.patch</filename>
            <type>text/plain</type>
            <size>4107</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0NzkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWViMzlhZDFmZTY5NmZl
ODRiMWQzNDJhYzM4YmYxZThiYjkxYzZiOS4uNjQzZDBmNjdmOTY1ZjJlYzI5ODg4YTg1ZTgxZjQy
NDc5OGNhMTUyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE0LTEwLTE2ICBDaHJp
cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW01hY10gVXNlIEZhc3QgZW51
bWVyYXRpb24gY29uc2lzdGVudGx5IGluIFdlYkZvbnRDYWNoZS5tbQorICAgICAgICBodHRwczov
L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM3NzkxCisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIGZhc3QgZW51bWVyYXRpb24gY29u
c2lzdGVudGx5IGluIFdlYkZvbnRDYWNoZS5tbSBhcyB0aGlzIHJlc3VsdHMgaW4KKyAgICAgICAg
bW9yZSBlZmZpY2llbnQsIGNvbmNpc2UgYW5kIHNhZmVyIGNvZGUuCisKKyAgICAgICAgTm8gbmV3
IHRlc3RzLCBubyBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvV2Vi
Rm9udENhY2hlLm1tOgorICAgICAgICAoK1tXZWJGb250Q2FjaGUgZ2V0VHJhaXRzOmluRmFtaWx5
Ol0pOgorICAgICAgICBSZXNlcnZlIFZlY3RvciBjYXBhY2l0eSBiZWZvcmUgdGhlIGxvb3AgYXMg
d2Uga25vdyBob3cgbWFueSB0cmFpdHMgd2UKKyAgICAgICAgYXJlIGdvaW5nIHRvIGFwcGVuZC4g
QWxzbyB1c2UgdW5jaGVja2VkQXBwZW5kKCkgZm9yIHBlcmZvcm1hbmNlLgorCisgICAgICAgICgr
W1dlYkZvbnRDYWNoZSBpbnRlcm5hbEZvbnRXaXRoRmFtaWx5OnRyYWl0czp3ZWlnaHQ6c2l6ZTpd
KToKKwogMjAxNC0xMC0xNiAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4K
IAogICAgICAgICBJbXBsZW1lbnQgc2VsZWN0aW9uIHNlcnZpY2VzIG1lbnUgZm9yIExlZ2FjeSBX
ZWJLaXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9XZWJGb250Q2Fj
aGUubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvV2ViRm9udENhY2hlLm1tCmluZGV4
IGFjYTk5ZTRmOGVhYzEyMmUzMGJiOGRjYjJhMjY0ZDZhNGE4ODdkZjQuLjhmNjc3NDU0NDdhZmNl
OGJlOGYxNDdlNmJiZDFjZDU4MTEwOGM2ZDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs
YXRmb3JtL21hYy9XZWJGb250Q2FjaGUubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v
bWFjL1dlYkZvbnRDYWNoZS5tbQpAQCAtMTQ2LDE4ICsxNDYsMTUgQEAgc3RhdGljIGlubGluZSB2
b2lkIHJlbWVtYmVyRGVzaXJlZEZhbWlseVRvQXZhaWxhYmxlRmFtaWx5TWFwcGluZyhOU1N0cmlu
ZyogZGVzaXIKIHsKICAgICBOU0ZvbnRNYW5hZ2VyICpmb250TWFuYWdlciA9IFtOU0ZvbnRNYW5h
Z2VyIHNoYXJlZEZvbnRNYW5hZ2VyXTsKIAotICAgIE5TRW51bWVyYXRvciAqZSA9IFtbZm9udE1h
bmFnZXIgYXZhaWxhYmxlRm9udEZhbWlsaWVzXSBvYmplY3RFbnVtZXJhdG9yXTsKICAgICBOU1N0
cmluZyAqYXZhaWxhYmxlRmFtaWx5OwotICAgIHdoaWxlICgoYXZhaWxhYmxlRmFtaWx5ID0gW2Ug
bmV4dE9iamVjdF0pKSB7CisgICAgZm9yIChhdmFpbGFibGVGYW1pbHkgaW4gW2ZvbnRNYW5hZ2Vy
IGF2YWlsYWJsZUZvbnRGYW1pbGllc10pIHsKICAgICAgICAgaWYgKFtkZXNpcmVkRmFtaWx5IGNh
c2VJbnNlbnNpdGl2ZUNvbXBhcmU6YXZhaWxhYmxlRmFtaWx5XSA9PSBOU09yZGVyZWRTYW1lKQog
ICAgICAgICAgICAgYnJlYWs7CiAgICAgfQogCiAgICAgaWYgKCFhdmFpbGFibGVGYW1pbHkpIHsK
ICAgICAgICAgLy8gTWF0Y2ggYnkgUG9zdFNjcmlwdCBuYW1lLgotICAgICAgICBOU0VudW1lcmF0
b3IgKmF2YWlsYWJsZUZvbnRzID0gW1tmb250TWFuYWdlciBhdmFpbGFibGVGb250c10gb2JqZWN0
RW51bWVyYXRvcl07Ci0gICAgICAgIE5TU3RyaW5nICphdmFpbGFibGVGb250OwotICAgICAgICB3
aGlsZSAoKGF2YWlsYWJsZUZvbnQgPSBbYXZhaWxhYmxlRm9udHMgbmV4dE9iamVjdF0pKSB7Cisg
ICAgICAgIGZvciAoTlNTdHJpbmcgKmF2YWlsYWJsZUZvbnQgaW4gW2ZvbnRNYW5hZ2VyIGF2YWls
YWJsZUZvbnRzXSkgewogICAgICAgICAgICAgaWYgKFtkZXNpcmVkRmFtaWx5IGNhc2VJbnNlbnNp
dGl2ZUNvbXBhcmU6YXZhaWxhYmxlRm9udF0gPT0gTlNPcmRlcmVkU2FtZSkgewogICAgICAgICAg
ICAgICAgIE5TRm9udCAqZm9udCA9IFtOU0ZvbnQgZm9udFdpdGhOYW1lOmF2YWlsYWJsZUZvbnQg
c2l6ZToxMF07CiAgICAgICAgICAgICAgICAgTlNJbnRlZ2VyIHdlaWdodCA9IFtmb250TWFuYWdl
ciB3ZWlnaHRPZkZvbnQ6Zm9udF07CkBAIC0xNjgsMTUgKzE2NSwxMyBAQCBzdGF0aWMgaW5saW5l
IHZvaWQgcmVtZW1iZXJEZXNpcmVkRmFtaWx5VG9BdmFpbGFibGVGYW1pbHlNYXBwaW5nKE5TU3Ry
aW5nKiBkZXNpcgogICAgICAgICByZXR1cm47CiAgICAgfQogCi0gICAgTlNBcnJheSAqZm9udHMg
PSBbZm9udE1hbmFnZXIgYXZhaWxhYmxlTWVtYmVyc09mRm9udEZhbWlseTphdmFpbGFibGVGYW1p
bHldOyAgICAKLSAgICB1bnNpZ25lZCBuID0gW2ZvbnRzIGNvdW50XTsKLSAgICB1bnNpZ25lZCBp
OwotICAgIGZvciAoaSA9IDA7IGkgPCBuOyBpKyspIHsKLSAgICAgICAgTlNBcnJheSAqZm9udElu
Zm8gPSBbZm9udHMgb2JqZWN0QXRJbmRleDppXTsKKyAgICBOU0FycmF5ICpmb250cyA9IFtmb250
TWFuYWdlciBhdmFpbGFibGVNZW1iZXJzT2ZGb250RmFtaWx5OmF2YWlsYWJsZUZhbWlseV07Cisg
ICAgdHJhaXRzTWFza3MucmVzZXJ2ZUNhcGFjaXR5KFtmb250cyBjb3VudF0pOworICAgIGZvciAo
TlNBcnJheSAqZm9udEluZm8gaW4gZm9udHMpIHsKICAgICAgICAgLy8gQXJyYXkgaW5kaWNlcyBt
dXN0IGJlIGhhcmQgY29kZWQgYmVjYXVzZSBvZiBsYW1lIEFwcEtpdCBBUEkuCiAgICAgICAgIE5T
SW50ZWdlciBmb250V2VpZ2h0ID0gW1tmb250SW5mbyBvYmplY3RBdEluZGV4OjJdIGludFZhbHVl
XTsKICAgICAgICAgTlNGb250VHJhaXRNYXNrIGZvbnRUcmFpdHMgPSBbW2ZvbnRJbmZvIG9iamVj
dEF0SW5kZXg6M10gdW5zaWduZWRJbnRWYWx1ZV07Ci0gICAgICAgIHRyYWl0c01hc2tzLmFwcGVu
ZCh0b1RyYWl0c01hc2soZm9udFRyYWl0cywgZm9udFdlaWdodCkpOworICAgICAgICB0cmFpdHNN
YXNrcy51bmNoZWNrZWRBcHBlbmQodG9UcmFpdHNNYXNrKGZvbnRUcmFpdHMsIGZvbnRXZWlnaHQp
KTsKICAgICB9CiB9CiAKQEAgLTI0MiwxMiArMjM3LDggQEAgc3RhdGljIGlubGluZSB2b2lkIHJl
bWVtYmVyRGVzaXJlZEZhbWlseVRvQXZhaWxhYmxlRmFtaWx5TWFwcGluZyhOU1N0cmluZyogZGVz
aXIKICAgICBOU0ZvbnRUcmFpdE1hc2sgY2hvc2VuVHJhaXRzID0gMDsKICAgICBOU1N0cmluZyAq
Y2hvc2VuRnVsbE5hbWUgPSAwOwogCi0gICAgTlNBcnJheSAqZm9udHMgPSBbZm9udE1hbmFnZXIg
YXZhaWxhYmxlTWVtYmVyc09mRm9udEZhbWlseTphdmFpbGFibGVGYW1pbHldOyAgICAKLSAgICB1
bnNpZ25lZCBuID0gW2ZvbnRzIGNvdW50XTsKLSAgICB1bnNpZ25lZCBpOwotICAgIGZvciAoaSA9
IDA7IGkgPCBuOyBpKyspIHsKLSAgICAgICAgTlNBcnJheSAqZm9udEluZm8gPSBbZm9udHMgb2Jq
ZWN0QXRJbmRleDppXTsKLQorICAgIE5TQXJyYXkgKmZvbnRzID0gW2ZvbnRNYW5hZ2VyIGF2YWls
YWJsZU1lbWJlcnNPZkZvbnRGYW1pbHk6YXZhaWxhYmxlRmFtaWx5XTsKKyAgICBmb3IgKE5TQXJy
YXkgKmZvbnRJbmZvIGluIGZvbnRzKSB7CiAgICAgICAgIC8vIEFycmF5IGluZGljZXMgbXVzdCBi
ZSBoYXJkIGNvZGVkIGJlY2F1c2Ugb2YgbGFtZSBBcHBLaXQgQVBJLgogICAgICAgICBOU1N0cmlu
ZyAqZm9udEZ1bGxOYW1lID0gW2ZvbnRJbmZvIG9iamVjdEF0SW5kZXg6MF07CiAgICAgICAgIE5T
SW50ZWdlciBmb250V2VpZ2h0ID0gW1tmb250SW5mbyBvYmplY3RBdEluZGV4OjJdIGludFZhbHVl
XTsK
</data>

          </attachment>
      

    </bug>

</bugzilla>