137778 2014-10-16 07:56:32 -0700 [EFL] window.screen.width returns wrong value if more displays are available 2014-10-17 03:44:04 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 g.czajkowski g.czajkowski commit-queue gyuyoung.kim jinwoo7.song lucas.de.marchi ryuan.choi oldest_to_newest 1042119 0 g.czajkowski 2014-10-16 07:56:32 -0700 ecore_x_screen_size_get() retrieves the size of Ecore_X_Screen, for example, having two displays of 1680x1050, it will return 33600x1050. Unlike EFL's MiniBrowser, Firefox and Chrome return screen of the current display. 1042120 1 239948 g.czajkowski 2014-10-16 08:02:17 -0700 Created attachment 239948 Patch 1042318 2 jinwoo7.song 2014-10-17 00:23:27 -0700 Looks good to me. 1042319 3 239948 gyuyoung.kim 2014-10-17 00:29:20 -0700 Comment on attachment 239948 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239948&action=review > Source/WebCore/platform/efl/PlatformScreenEfl.cpp:94 > + if (ecore_x_randr_query() && ecore_x_window_focus_get()) ecore_x_window_focus_get() is called twice. How about using a variable to handle it ? Ecore_X_Window focusedWindow = ecore_x_window_focus_get(); 1042341 4 240008 g.czajkowski 2014-10-17 02:32:29 -0700 Created attachment 240008 Patch for landing 1042342 5 g.czajkowski 2014-10-17 02:34:46 -0700 (In reply to comment #3) > Comment on attachment 239948 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=239948&action=review > > > Source/WebCore/platform/efl/PlatformScreenEfl.cpp:94 > > + if (ecore_x_randr_query() && ecore_x_window_focus_get()) > > ecore_x_window_focus_get() is called twice. How about using a variable to > handle it ? > > Ecore_X_Window focusedWindow = ecore_x_window_focus_get(); Nice catch! Fixed. 1042357 6 240008 commit-queue 2014-10-17 03:43:59 -0700 Comment on attachment 240008 Patch for landing Clearing flags on attachment: 240008 Committed r174819: <http://trac.webkit.org/changeset/174819> 1042358 7 commit-queue 2014-10-17 03:44:04 -0700 All reviewed patches have been landed. Closing bug. 239948 2014-10-16 08:02:17 -0700 2014-10-17 02:32:18 -0700 Patch bug-137778-20141016170221.patch text/plain 2077 g.czajkowski U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0MjI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTdkYzYwMGU1OWRmMzA2 YjVkZTViZTBkZjYyOGIzZTk0Mzk4YmVkNS4uNGZhODI4MGM3YmJlNzU2NWYzODY5MWNjYzg0M2E2 YzM0NDg5MTczNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE0LTEwLTE2ICBHcnpl Z29yeiBDemFqa293c2tpICA8Zy5jemFqa293c2tpQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtF RkxdIHdpbmRvdy5zY3JlZW4ud2lkdGggcmV0dXJucyB3cm9uZyB2YWx1ZSBpZiBtb3JlIGRpc3Bs YXlzIGFyZSBhdmFpbGFibGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEzNzc3OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIGVjb3JlX3hfc2NyZWVuX3NpemVfZ2V0KCkgcmV0cmlldmVzIHRoZSBzaXplIG9m IEVjb3JlX1hfU2NyZWVuLCBmb3IgZXhhbXBsZSwKKyAgICAgICAgaGF2aW5nIHR3byBkaXNwbGF5 cyBvZiAxNjgweDEwNTAsIGl0IHdpbGwgcmV0dXJuIDMzNjB4MTA1MC4KKworICAgICAgICBVbmxp a2UgRUZMJ3MgTWluaUJyb3dzZXIsIEZpcmVmb3ggYW5kIENocm9tZSByZXR1cm4gc2NyZWVuIG9m IHRoZSBjdXJyZW50IGRpc3BsYXkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBIYXJkd2FyZSBz cGVjaWZpYyBidWcgaW5jbHVkaW5nIG11bHRpcGxlIGRpc3BsYXlzLgorCisgICAgICAgICogcGxh dGZvcm0vZWZsL1BsYXRmb3JtU2NyZWVuRWZsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnNjcmVl blJlY3QpOgorICAgICAgICBVc2UgZWNvcmUncyB4cmFuZHIgdG8gZGV0ZXJtaW5lIHRoZSBzY3Jl ZW4gb24gd2hpY2ggYnJvd3NlciB3aW5kb3cgaXMgZGlzcGxheWVkLgorCiAyMDE0LTEwLTAxICBD aHJpc3RvcGhlIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBIYXZlIGlzPD4o VCopIGZ1bmN0aW9uIGRvIGEgbnVsbCBjaGVjayBvbiB0aGUgcG9pbnRlciBhcmd1bWVudApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1BsYXRmb3JtU2NyZWVuRWZsLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9QbGF0Zm9ybVNjcmVlbkVmbC5jcHAKaW5k ZXggN2E1YTQzMmNhYTVhZGI1NTQ3NjI5YWFiNTE1Yjc1YjZhYTk1Y2NlZC4uMzViNzlmNGJiY2Zk NjQ5NTZkMjYxZWVlNTZmODc3NTY4N2Q0ZGE0NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZWZsL1BsYXRmb3JtU2NyZWVuRWZsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9lZmwvUGxhdGZvcm1TY3JlZW5FZmwuY3BwCkBAIC05MSw3ICs5MSwxMCBAQCBGbG9h dFJlY3Qgc2NyZWVuUmVjdChXaWRnZXQqIHdpZGdldCkKICAgICAvLyBhbmQgd2UgY2Fubm90IGFj Y3VyYXRlbHkgZGV0ZWN0IHRoZSBzY3JlZW4gc2l6ZS4KICAgICBpbnQgd2lkdGggPSA4MDA7CiAg ICAgaW50IGhlaWdodCA9IDYwMDsKLSAgICBlY29yZV94X3NjcmVlbl9zaXplX2dldChlY29yZV94 X2RlZmF1bHRfc2NyZWVuX2dldCgpLCAmd2lkdGgsICZoZWlnaHQpOworICAgIGlmIChlY29yZV94 X3JhbmRyX3F1ZXJ5KCkgJiYgZWNvcmVfeF93aW5kb3dfZm9jdXNfZ2V0KCkpCisgICAgICAgIGVj b3JlX3hfcmFuZHJfc2NyZWVuX3ByaW1hcnlfb3V0cHV0X2N1cnJlbnRfc2l6ZV9nZXQoZWNvcmVf eF93aW5kb3dfcm9vdF9nZXQoZWNvcmVfeF93aW5kb3dfZm9jdXNfZ2V0KCkpLCAmd2lkdGgsICZo ZWlnaHQsIDAsIDAsIDApOworICAgIGVsc2UKKyAgICAgICAgZWNvcmVfeF9zY3JlZW5fc2l6ZV9n ZXQoZWNvcmVfeF9kZWZhdWx0X3NjcmVlbl9nZXQoKSwgJndpZHRoLCAmaGVpZ2h0KTsKICAgICBy ZXR1cm4gRmxvYXRSZWN0KDAsIDAsIHdpZHRoLCBoZWlnaHQpOwogI2Vsc2UKICAgICBpZiAoIXdp ZGdldCB8fCAhd2lkZ2V0LT5ldmFzKCkpCg== 240008 2014-10-17 02:32:29 -0700 2014-10-17 03:43:59 -0700 Patch for landing bug-137778-20141017113233.patch text/plain 2113 g.czajkowski U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0MjI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTdkYzYwMGU1OWRmMzA2 YjVkZTViZTBkZjYyOGIzZTk0Mzk4YmVkNS4uYjFlYmYzOTY3ODQ4OGNiMzZhNzc2NGY2ZTEyZGQ5 YTI4NWNkNzg5MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE0LTEwLTE2ICBHcnpl Z29yeiBDemFqa293c2tpICA8Zy5jemFqa293c2tpQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtF RkxdIHdpbmRvdy5zY3JlZW4ud2lkdGggcmV0dXJucyB3cm9uZyB2YWx1ZSBpZiBtb3JlIGRpc3Bs YXlzIGFyZSBhdmFpbGFibGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEzNzc3OAorCisgICAgICAgIFJldmlld2VkIGJ5IEd5dXlvdW5nIEtpbS4KKwor ICAgICAgICBlY29yZV94X3NjcmVlbl9zaXplX2dldCgpIHJldHJpZXZlcyB0aGUgc2l6ZSBvZiBF Y29yZV9YX1NjcmVlbiwgZm9yIGV4YW1wbGUsCisgICAgICAgIGhhdmluZyB0d28gZGlzcGxheXMg b2YgMTY4MHgxMDUwLCBpdCB3aWxsIHJldHVybiAzMzYweDEwNTAuCisKKyAgICAgICAgVW5saWtl IEVGTCdzIE1pbmlCcm93c2VyLCBGaXJlZm94IGFuZCBDaHJvbWUgcmV0dXJuIHNjcmVlbiBvZiB0 aGUgY3VycmVudCBkaXNwbGF5LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gSGFyZHdhcmUgc3Bl Y2lmaWMgYnVnIGluY2x1ZGluZyBtdWx0aXBsZSBkaXNwbGF5cy4KKworICAgICAgICAqIHBsYXRm b3JtL2VmbC9QbGF0Zm9ybVNjcmVlbkVmbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpzY3JlZW5S ZWN0KToKKyAgICAgICAgVXNlIGVjb3JlJ3MgeHJhbmRyIHRvIGRldGVybWluZSB0aGUgc2NyZWVu IG9uIHdoaWNoIGJyb3dzZXIgd2luZG93IGlzIGRpc3BsYXllZC4KKwogMjAxNC0xMC0wMSAgQ2hy aXN0b3BoZSBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgSGF2ZSBpczw+KFQq KSBmdW5jdGlvbiBkbyBhIG51bGwgY2hlY2sgb24gdGhlIHBvaW50ZXIgYXJndW1lbnQKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9QbGF0Zm9ybVNjcmVlbkVmbC5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvUGxhdGZvcm1TY3JlZW5FZmwuY3BwCmluZGV4 IDdhNWE0MzJjYWE1YWRiNTU0NzYyOWFhYjUxNWI3NWI2YWE5NWNjZWQuLmZkYzIzYjhmZjE3NDkz OTllNGRlMmYwOGRmOTA0OTE5M2Q3OTgwNTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2VmbC9QbGF0Zm9ybVNjcmVlbkVmbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZWZsL1BsYXRmb3JtU2NyZWVuRWZsLmNwcApAQCAtOTEsNyArOTEsMTEgQEAgRmxvYXRS ZWN0IHNjcmVlblJlY3QoV2lkZ2V0KiB3aWRnZXQpCiAgICAgLy8gYW5kIHdlIGNhbm5vdCBhY2N1 cmF0ZWx5IGRldGVjdCB0aGUgc2NyZWVuIHNpemUuCiAgICAgaW50IHdpZHRoID0gODAwOwogICAg IGludCBoZWlnaHQgPSA2MDA7Ci0gICAgZWNvcmVfeF9zY3JlZW5fc2l6ZV9nZXQoZWNvcmVfeF9k ZWZhdWx0X3NjcmVlbl9nZXQoKSwgJndpZHRoLCAmaGVpZ2h0KTsKKyAgICBFY29yZV9YX1dpbmRv dyBmb2N1c2VkV2luZG93ID0gZWNvcmVfeF93aW5kb3dfZm9jdXNfZ2V0KCk7CisgICAgaWYgKGVj b3JlX3hfcmFuZHJfcXVlcnkoKSAmJiBmb2N1c2VkV2luZG93KQorICAgICAgICBlY29yZV94X3Jh bmRyX3NjcmVlbl9wcmltYXJ5X291dHB1dF9jdXJyZW50X3NpemVfZ2V0KGVjb3JlX3hfd2luZG93 X3Jvb3RfZ2V0KGZvY3VzZWRXaW5kb3cpLCAmd2lkdGgsICZoZWlnaHQsIDAsIDAsIDApOworICAg IGVsc2UKKyAgICAgICAgZWNvcmVfeF9zY3JlZW5fc2l6ZV9nZXQoZWNvcmVfeF9kZWZhdWx0X3Nj cmVlbl9nZXQoKSwgJndpZHRoLCAmaGVpZ2h0KTsKICAgICByZXR1cm4gRmxvYXRSZWN0KDAsIDAs IHdpZHRoLCBoZWlnaHQpOwogI2Vsc2UKICAgICBpZiAoIXdpZGdldCB8fCAhd2lkZ2V0LT5ldmFz KCkpCg==