137776 2014-10-16 05:57:17 -0700 Allow reuse of BitmapTextureImageBuffer instances 2016-09-17 07:04:50 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 1 pulkomandy webkit-unassigned cdumez cmarcelo commit-queue kondapallykalyan luiz noam rniwa simon.fraser oldest_to_newest 1042110 0 pulkomandy 2014-10-16 05:57:17 -0700 Allow reuse of BitmapTextureImageBuffer instances 1042111 1 239945 pulkomandy 2014-10-16 06:02:01 -0700 Created attachment 239945 Patch 1042168 2 239945 cdumez 2014-10-16 13:31:32 -0700 Comment on attachment 239945 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239945&action=review > Source/WebCore/platform/graphics/texmap/TextureMapperImageBuffer.h:36 > + bool canReuseWith(const IntSize& /* contentsSize */, Flags = 0) { return true; } Isn't this function virtual? if so, please mark it explicitly as virtual. You will also want to use override (and likely final). 1042173 3 239945 cdumez 2014-10-16 13:41:50 -0700 Comment on attachment 239945 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239945&action=review Someone else should comment on the general approach. >> Source/WebCore/platform/graphics/texmap/TextureMapperImageBuffer.h:36 >> + bool canReuseWith(const IntSize& /* contentsSize */, Flags = 0) { return true; } > > Isn't this function virtual? if so, please mark it explicitly as virtual. You will also want to use override (and likely final). Yes, it is virtual, please use: virtual bool canReuseWith(const IntSize& /* contentsSize */, Flags = 0) override { return true; } Also, please mark the class as final (I don't think anyone subclasses it). 1042175 4 239962 pulkomandy 2014-10-16 13:52:33 -0700 Created attachment 239962 Patch 1042176 5 239962 cdumez 2014-10-16 13:54:08 -0700 Comment on attachment 239962 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239962&action=review > Source/WebCore/platform/graphics/texmap/TextureMapperImageBuffer.h:36 > + virtual bool canReuseWith(const IntSize& /* contentsSize */, Flags = 0) override final { return true; } Cannot the class be final instead? 1042180 6 239964 pulkomandy 2014-10-16 13:58:57 -0700 Created attachment 239964 Patch 1045301 7 239964 bfulgham 2014-10-31 10:56:29 -0700 Comment on attachment 239964 Patch This seems fine, but the gtk bot seems to fail with this change, and that's one of the builds that would make use of this change. 1230802 8 239964 mcatanzaro 2016-09-17 07:04:50 -0700 Comment on attachment 239964 Patch Hi, Apologies that your patch was not reviewed in a timely manner. Since it's now quite old, I am removing it from the review request queue. Please consider rebasing it on trunk and resubmitting. To increase the chances of getting a review, consider using 'Tools/Scripts/webkit-patch upload --suggest-reviewers' to CC reviewers who might be interested in this bug. 239945 2014-10-16 06:02:01 -0700 2014-10-16 13:52:17 -0700 Patch bug-137776-20141016150309.patch text/plain 2243 pulkomandy U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0NTgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDhkYmNhZTQ1YzJmNWJk MTg3NzJjZjRlMTRjZDZlMDE2MTQ3M2QxMi4uNzExNDI5OTg0MGUxNzIwZjEzMWEyZDYyNDcwN2I4 ZmQ4ZmI5OTJmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE0LTEwLTE2ICBBZHJp ZW4gRGVzdHVndWVzICA8cHVsa29tYW5keUBnbWFpbC5jb20+CisKKyAgICAgICAgQWxsb3cgcmV1 c2Ugb2YgQml0bWFwVGV4dHVyZUltYWdlQnVmZmVyIGluc3RhbmNlcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM3Nzc2CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzOiBObyBmdW5jdGlv bmFsIGNoYW5nZSwgZGVjcmVhc2VzIG1lbW9yeSB1c2UKKworICAgICAgICBJdCBpcyBzYWZlIHRv IHJldXNlIEJpdG1hcFRleHR1cmVJbWFnZUJ1ZmZlciBvYmplY3RzIGFzIHRoZSByZXNldAorICAg ICAgICBtZXRob2Qgd2lsbCByZXNldCB0aGVtIHRvIGEgY2xlYW4gc3RhdGUsIG5vIG1hdHRlciB0 aGUgZmxhZ3MgYW5kIHNpemUuCisgICAgICAgIFRoZXkgd2VyZSBuZXZlciByZXVzZWQgYmVmb3Jl LCBidXQga2VwdCBpbiB0aGUgdGV4dHVyZSBwb29sIGFueXdheS4KKworICAgICAgICBPbiBIYWlr dSB3ZSBjYW4gb25seSBhbGxvY2F0ZSBhIGxpbWl0ZWQgbnVtYmVyIG9mIGltYWdlIGJ1ZmZlcnMg KGFib3V0CisgICAgICAgIDIwMDApIGFuZCBEdW1wUmVuZGVyVHJlZSB3YXMgbm90IGRlbGV0aW5n IG9sZCBidWZmZXJzIGZhc3QgZW5vdWdoLAorICAgICAgICBsZWFkaW5nIHRvIGFuIGFwcF9zZXJ2 ZXIgY3Jhc2ggYW5kIGludGVycnVwdGVkIHRlc3RzdWl0ZS4KKworICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVySW1hZ2VCdWZmZXIuaDoKKyAgICAgICAgKFdl YkNvcmU6OkJpdG1hcFRleHR1cmVJbWFnZUJ1ZmZlcjo6Y2FuUmV1c2VXaXRoKToKKwogMjAxNC0x MC0xMCAgWmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5jb20+CiAKICAgICAgICAgQXZv aWQgZGVmYXVsdGluZyB0byBjYXB0dXJlLWJ5LXZhbHVlIGZvciBDKysxMSBsYW1iZGFzIGluIFdl YkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1h cC9UZXh0dXJlTWFwcGVySW1hZ2VCdWZmZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVySW1hZ2VCdWZmZXIuaAppbmRleCAwMTc3ZGRiN2Ux NzA1MjBiZTg0YjE4NDMxNjI0YWM0OWIwZGVlZTYwLi5iYTVkNzAwMDA4MmY3MDgyYzk4MTY3MzFl N2U5OTFmZTk4ODZhOTQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckltYWdlQnVmZmVyLmgKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJJbWFnZUJ1ZmZlci5oCkBA IC0zMyw2ICszMyw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIEludFNpemUgc2l6ZSgpIGNvbnN0 IHsgcmV0dXJuIG1faW1hZ2UtPmludGVybmFsU2l6ZSgpOyB9CiAgICAgdmlydHVhbCB2b2lkIGRp ZFJlc2V0KCk7CiAgICAgdmlydHVhbCBib29sIGlzVmFsaWQoKSBjb25zdCB7IHJldHVybiBtX2lt YWdlLmdldCgpOyB9CisgICAgYm9vbCBjYW5SZXVzZVdpdGgoY29uc3QgSW50U2l6ZSYgLyogY29u dGVudHNTaXplICovLCBGbGFncyA9IDApIHsgcmV0dXJuIHRydWU7IH0KICAgICBpbmxpbmUgR3Jh cGhpY3NDb250ZXh0KiBncmFwaGljc0NvbnRleHQoKSB7IHJldHVybiBtX2ltYWdlID8gbV9pbWFn ZS0+Y29udGV4dCgpIDogMDsgfQogICAgIHZpcnR1YWwgdm9pZCB1cGRhdGVDb250ZW50cyhJbWFn ZSosIGNvbnN0IEludFJlY3QmLCBjb25zdCBJbnRQb2ludCYsIFVwZGF0ZUNvbnRlbnRzRmxhZyk7 CiAgICAgdmlydHVhbCB2b2lkIHVwZGF0ZUNvbnRlbnRzKFRleHR1cmVNYXBwZXIqLCBHcmFwaGlj c0xheWVyKiwgY29uc3QgSW50UmVjdCYgdGFyZ2V0LCBjb25zdCBJbnRQb2ludCYgb2Zmc2V0LCBV cGRhdGVDb250ZW50c0ZsYWcpOwo= 239962 2014-10-16 13:52:33 -0700 2014-10-16 13:58:41 -0700 Patch bug-137776-20141016225231.patch text/plain 2226 pulkomandy U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0NTgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDhkYmNhZTQ1YzJmNWJk MTg3NzJjZjRlMTRjZDZlMDE2MTQ3M2QxMi4uNjY2NjIyZDMxMzg3ZTgwYjAyNDQxNGE1ZjE3MmM1 YjAyODFhZTRkNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE0LTEwLTE2ICBBZHJp ZW4gRGVzdHVndWVzICA8cHVsa29tYW5keUBnbWFpbC5jb20+CisKKyAgICAgICAgQWxsb3cgcmV1 c2Ugb2YgQml0bWFwVGV4dHVyZUltYWdlQnVmZmVyIGluc3RhbmNlcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM3Nzc2CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzOiBObyBmdW5jdGlv bmFsIGNoYW5nZSwgZGVjcmVhc2VzIG1lbW9yeSB1c2UKKworICAgICAgICBJdCBpcyBzYWZlIHRv IHJldXNlIEJpdG1hcFRleHR1cmVJbWFnZUJ1ZmZlciBvYmplY3RzIGFzIHRoZSByZXNldAorICAg ICAgICBtZXRob2Qgd2lsbCByZXNldCB0aGVtIHRvIGEgY2xlYW4gc3RhdGUsIG5vIG1hdHRlciB0 aGUgZmxhZ3MKKyAgICAgICAgYW5kIHNpemUuCisKKyAgICAgICAgVGhleSB3ZXJlIG5ldmVyIHJl dXNlZCBiZWZvcmUsIGJ1dCBrZXB0IGluIHRoZSB0ZXh0dXJlIHBvb2wKKyAgICAgICAgYW55d2F5 LgorCisgICAgICAgIE9uIEhhaWt1IHdlIGNhbiBvbmx5IGFsbG9jYXRlIGEgbGltaXRlZCBudW1i ZXIgb2YgaW1hZ2UgYnVmZmVycyAoYWJvdXQKKyAgICAgICAgMjAwMCkgYW5kIER1bXBSZW5kZXJU cmVlIHdhcyBub3QgZGVsZXRpbmcgb2xkIGJ1ZmZlcnMgZmFzdCBlbm91Z2gsCisgICAgICAgIGxl YWRpbmcgdG8gYW4gYXBwX3NlcnZlciBjcmFzaCBhbmQgaW50ZXJydXB0ZWQgdGVzdHN1aXRlLgor CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJJbWFnZUJ1 ZmZlci5oOgorCiAyMDE0LTEwLTEwICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNv bT4KIAogICAgICAgICBBdm9pZCBkZWZhdWx0aW5nIHRvIGNhcHR1cmUtYnktdmFsdWUgZm9yIEMr KzExIGxhbWJkYXMgaW4gV2ViQ29yZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJJbWFnZUJ1ZmZlci5oIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJJbWFnZUJ1ZmZlci5o CmluZGV4IDAxNzdkZGI3ZTE3MDUyMGJlODRiMTg0MzE2MjRhYzQ5YjBkZWVlNjAuLmZiMTQ3OWVh NWZjNWMwODI0ODEzODVmZTFkZDBmN2EzMWNlOTI3NjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVySW1hZ2VCdWZmZXIuaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBl ckltYWdlQnVmZmVyLmgKQEAgLTMzLDYgKzMzLDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgSW50 U2l6ZSBzaXplKCkgY29uc3QgeyByZXR1cm4gbV9pbWFnZS0+aW50ZXJuYWxTaXplKCk7IH0KICAg ICB2aXJ0dWFsIHZvaWQgZGlkUmVzZXQoKTsKICAgICB2aXJ0dWFsIGJvb2wgaXNWYWxpZCgpIGNv bnN0IHsgcmV0dXJuIG1faW1hZ2UuZ2V0KCk7IH0KKyAgICB2aXJ0dWFsIGJvb2wgY2FuUmV1c2VX aXRoKGNvbnN0IEludFNpemUmIC8qIGNvbnRlbnRzU2l6ZSAqLywgRmxhZ3MgPSAwKSBvdmVycmlk ZSBmaW5hbCB7IHJldHVybiB0cnVlOyB9CiAgICAgaW5saW5lIEdyYXBoaWNzQ29udGV4dCogZ3Jh cGhpY3NDb250ZXh0KCkgeyByZXR1cm4gbV9pbWFnZSA/IG1faW1hZ2UtPmNvbnRleHQoKSA6IDA7 IH0KICAgICB2aXJ0dWFsIHZvaWQgdXBkYXRlQ29udGVudHMoSW1hZ2UqLCBjb25zdCBJbnRSZWN0 JiwgY29uc3QgSW50UG9pbnQmLCBVcGRhdGVDb250ZW50c0ZsYWcpOwogICAgIHZpcnR1YWwgdm9p ZCB1cGRhdGVDb250ZW50cyhUZXh0dXJlTWFwcGVyKiwgR3JhcGhpY3NMYXllciosIGNvbnN0IElu dFJlY3QmIHRhcmdldCwgY29uc3QgSW50UG9pbnQmIG9mZnNldCwgVXBkYXRlQ29udGVudHNGbGFn KTsK 239964 2014-10-16 13:58:57 -0700 2016-09-17 07:04:50 -0700 Patch bug-137776-20141016225900.patch text/plain 2533 pulkomandy U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0NTgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDhkYmNhZTQ1YzJmNWJk MTg3NzJjZjRlMTRjZDZlMDE2MTQ3M2QxMi4uNjY2NjIyZDMxMzg3ZTgwYjAyNDQxNGE1ZjE3MmM1 YjAyODFhZTRkNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE0LTEwLTE2ICBBZHJp ZW4gRGVzdHVndWVzICA8cHVsa29tYW5keUBnbWFpbC5jb20+CisKKyAgICAgICAgQWxsb3cgcmV1 c2Ugb2YgQml0bWFwVGV4dHVyZUltYWdlQnVmZmVyIGluc3RhbmNlcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM3Nzc2CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzOiBObyBmdW5jdGlv bmFsIGNoYW5nZSwgZGVjcmVhc2VzIG1lbW9yeSB1c2UKKworICAgICAgICBJdCBpcyBzYWZlIHRv IHJldXNlIEJpdG1hcFRleHR1cmVJbWFnZUJ1ZmZlciBvYmplY3RzIGFzIHRoZSByZXNldAorICAg ICAgICBtZXRob2Qgd2lsbCByZXNldCB0aGVtIHRvIGEgY2xlYW4gc3RhdGUsIG5vIG1hdHRlciB0 aGUgZmxhZ3MKKyAgICAgICAgYW5kIHNpemUuCisKKyAgICAgICAgVGhleSB3ZXJlIG5ldmVyIHJl dXNlZCBiZWZvcmUsIGJ1dCBrZXB0IGluIHRoZSB0ZXh0dXJlIHBvb2wKKyAgICAgICAgYW55d2F5 LgorCisgICAgICAgIE9uIEhhaWt1IHdlIGNhbiBvbmx5IGFsbG9jYXRlIGEgbGltaXRlZCBudW1i ZXIgb2YgaW1hZ2UgYnVmZmVycyAoYWJvdXQKKyAgICAgICAgMjAwMCkgYW5kIER1bXBSZW5kZXJU cmVlIHdhcyBub3QgZGVsZXRpbmcgb2xkIGJ1ZmZlcnMgZmFzdCBlbm91Z2gsCisgICAgICAgIGxl YWRpbmcgdG8gYW4gYXBwX3NlcnZlciBjcmFzaCBhbmQgaW50ZXJydXB0ZWQgdGVzdHN1aXRlLgor CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJJbWFnZUJ1 ZmZlci5oOgorCiAyMDE0LTEwLTEwICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNv bT4KIAogICAgICAgICBBdm9pZCBkZWZhdWx0aW5nIHRvIGNhcHR1cmUtYnktdmFsdWUgZm9yIEMr KzExIGxhbWJkYXMgaW4gV2ViQ29yZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJJbWFnZUJ1ZmZlci5oIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJJbWFnZUJ1ZmZlci5o CmluZGV4IDAxNzdkZGI3ZTE3MDUyMGJlODRiMTg0MzE2MjRhYzQ5YjBkZWVlNjAuLmMwNWI4ODMx YThjYzFjNDg5MTQ4ZmI2YWEzOGNkNmM2MGEyN2FmNTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVySW1hZ2VCdWZmZXIuaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBl ckltYWdlQnVmZmVyLmgKQEAgLTI2LDEzICsyNiwxNCBAQAogI2lmIFVTRShURVhUVVJFX01BUFBF UikKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotY2xhc3MgQml0bWFwVGV4dHVyZUltYWdlQnVmZmVy IDogcHVibGljIEJpdG1hcFRleHR1cmUgeworY2xhc3MgQml0bWFwVGV4dHVyZUltYWdlQnVmZmVy IGZpbmFsIDogcHVibGljIEJpdG1hcFRleHR1cmUgewogICAgIGZyaWVuZCBjbGFzcyBUZXh0dXJl TWFwcGVySW1hZ2VCdWZmZXI7CiBwdWJsaWM6CiAgICAgc3RhdGljIFBhc3NSZWZQdHI8Qml0bWFw VGV4dHVyZT4gY3JlYXRlKCkgeyByZXR1cm4gYWRvcHRSZWYobmV3IEJpdG1hcFRleHR1cmVJbWFn ZUJ1ZmZlcik7IH0KICAgICB2aXJ0dWFsIEludFNpemUgc2l6ZSgpIGNvbnN0IHsgcmV0dXJuIG1f aW1hZ2UtPmludGVybmFsU2l6ZSgpOyB9CiAgICAgdmlydHVhbCB2b2lkIGRpZFJlc2V0KCk7CiAg ICAgdmlydHVhbCBib29sIGlzVmFsaWQoKSBjb25zdCB7IHJldHVybiBtX2ltYWdlLmdldCgpOyB9 CisgICAgdmlydHVhbCBib29sIGNhblJldXNlV2l0aChjb25zdCBJbnRTaXplJiAvKiBjb250ZW50 c1NpemUgKi8sIEZsYWdzID0gMCkgb3ZlcnJpZGUgeyByZXR1cm4gdHJ1ZTsgfQogICAgIGlubGlu ZSBHcmFwaGljc0NvbnRleHQqIGdyYXBoaWNzQ29udGV4dCgpIHsgcmV0dXJuIG1faW1hZ2UgPyBt X2ltYWdlLT5jb250ZXh0KCkgOiAwOyB9CiAgICAgdmlydHVhbCB2b2lkIHVwZGF0ZUNvbnRlbnRz KEltYWdlKiwgY29uc3QgSW50UmVjdCYsIGNvbnN0IEludFBvaW50JiwgVXBkYXRlQ29udGVudHNG bGFnKTsKICAgICB2aXJ0dWFsIHZvaWQgdXBkYXRlQ29udGVudHMoVGV4dHVyZU1hcHBlciosIEdy YXBoaWNzTGF5ZXIqLCBjb25zdCBJbnRSZWN0JiB0YXJnZXQsIGNvbnN0IEludFBvaW50JiBvZmZz ZXQsIFVwZGF0ZUNvbnRlbnRzRmxhZyk7Cg==