137775 2014-10-16 02:52:35 -0700 [GTK] Minibrowser : Add window fullscreen support for Minibrowser 2014-10-30 06:45:08 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kumar.rohit webkit-unassigned cgarcia commit-queue gustavo mrobinson pnormand oldest_to_newest 1042103 0 kumar.rohit 2014-10-16 02:52:35 -0700 Add support for window fullscreen toggling in Minibrowser using keyboard F11 key. 1042104 1 239941 kumar.rohit 2014-10-16 03:00:18 -0700 Created attachment 239941 Patch 1043379 2 239941 cgarcia 2014-10-22 00:26:30 -0700 Comment on attachment 239941 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239941&action=review > Tools/MiniBrowser/gtk/BrowserWindow.c:575 > + if (!window->fullScreenIsEnabled) { > + gtk_window_fullscreen(GTK_WINDOW(window)); > + gtk_widget_hide(window->toolbar); > + window->fullScreenIsEnabled = TRUE; > + } else { > + gtk_window_unfullscreen(GTK_WINDOW(window)); > + gtk_widget_show(window->toolbar); > + window->fullScreenIsEnabled = FALSE; > + } We already have code to enter/leave fullscreen when requested by wk, maybe we can reuse that code to make it work also when requested by the user, because there are some inconsistencies. The other code shows a message explaining the user how to leave fullscreen mode, and the keybindings are f or ESC, not F11. Also the other code takes care of showing/hide the findbar. 1043387 3 kumar.rohit 2014-10-22 02:07:15 -0700 (In reply to comment #2) > Comment on attachment 239941 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=239941&action=review > > > Tools/MiniBrowser/gtk/BrowserWindow.c:575 > > + if (!window->fullScreenIsEnabled) { > > + gtk_window_fullscreen(GTK_WINDOW(window)); > > + gtk_widget_hide(window->toolbar); > > + window->fullScreenIsEnabled = TRUE; > > + } else { > > + gtk_window_unfullscreen(GTK_WINDOW(window)); > > + gtk_widget_show(window->toolbar); > > + window->fullScreenIsEnabled = FALSE; > > + } > > We already have code to enter/leave fullscreen when requested by wk, maybe > we can reuse that code to make it work also when requested by the user, > because there are some inconsistencies. The other code shows a message > explaining the user how to leave fullscreen mode, and the keybindings are f > or ESC, not F11. Also the other code takes care of showing/hide the findbar. I think the code to enter/leave fullscreen is for HTML element/webview fullscreen and not for the minibrowser window itself. We don't need message and title for window to be displayed on fullscreen in this case. Most of the browsers (Chrome, Firefox, IE) uses F11 key to toggle browser window fullscreen and f or ESC for HTML elements. Please correct me if I am wrong. 1043393 4 cgarcia 2014-10-22 02:32:06 -0700 (In reply to comment #3) > (In reply to comment #2) > > Comment on attachment 239941 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=239941&action=review > > > > > Tools/MiniBrowser/gtk/BrowserWindow.c:575 > > > + if (!window->fullScreenIsEnabled) { > > > + gtk_window_fullscreen(GTK_WINDOW(window)); > > > + gtk_widget_hide(window->toolbar); > > > + window->fullScreenIsEnabled = TRUE; > > > + } else { > > > + gtk_window_unfullscreen(GTK_WINDOW(window)); > > > + gtk_widget_show(window->toolbar); > > > + window->fullScreenIsEnabled = FALSE; > > > + } > > > > We already have code to enter/leave fullscreen when requested by wk, maybe > > we can reuse that code to make it work also when requested by the user, > > because there are some inconsistencies. The other code shows a message > > explaining the user how to leave fullscreen mode, and the keybindings are f > > or ESC, not F11. Also the other code takes care of showing/hide the findbar. > > I think the code to enter/leave fullscreen is for HTML element/webview > fullscreen and not for the minibrowser window itself. Right. > We don't need message > and title for window to be displayed on fullscreen in this case. Most of the > browsers (Chrome, Firefox, IE) uses F11 key to toggle browser window > fullscreen and f or ESC for HTML elements. Please correct me if I am wrong. Yes, Epiphany also uses F11, but also shows a message. In any case, my point is that the code that enters/leaves fullscreen could be common in both cases. Move the common logic to a function, and call it from both places. 1043732 5 kumar.rohit 2014-10-23 03:06:56 -0700 (In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > Comment on attachment 239941 [details] > > > Patch > > > > > > View in context: > > > https://bugs.webkit.org/attachment.cgi?id=239941&action=review > > > > > > > Tools/MiniBrowser/gtk/BrowserWindow.c:575 > > > > + if (!window->fullScreenIsEnabled) { > > > > + gtk_window_fullscreen(GTK_WINDOW(window)); > > > > + gtk_widget_hide(window->toolbar); > > > > + window->fullScreenIsEnabled = TRUE; > > > > + } else { > > > > + gtk_window_unfullscreen(GTK_WINDOW(window)); > > > > + gtk_widget_show(window->toolbar); > > > > + window->fullScreenIsEnabled = FALSE; > > > > + } > > > > > > We already have code to enter/leave fullscreen when requested by wk, maybe > > > we can reuse that code to make it work also when requested by the user, > > > because there are some inconsistencies. The other code shows a message > > > explaining the user how to leave fullscreen mode, and the keybindings are f > > > or ESC, not F11. Also the other code takes care of showing/hide the findbar. > > > > I think the code to enter/leave fullscreen is for HTML element/webview > > fullscreen and not for the minibrowser window itself. > > Right. > > > We don't need message > > and title for window to be displayed on fullscreen in this case. Most of the > > browsers (Chrome, Firefox, IE) uses F11 key to toggle browser window > > fullscreen and f or ESC for HTML elements. Please correct me if I am wrong. > > Yes, Epiphany also uses F11, but also shows a message. In any case, my point > is that the code that enters/leaves fullscreen could be common in both > cases. Move the common logic to a function, and call it from both places. There is no common code in BrowserWindow.c file for webkitView and window fullscreen except findbar hide. Are you suggesting to implement it in WebKitWebViewBase.cpp file to handle the F11 keypress event similar to ESC and F key handle? 1043736 6 cgarcia 2014-10-23 03:53:11 -0700 (In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #3) > > > (In reply to comment #2) > > > > Comment on attachment 239941 [details] > > > > Patch > > > > > > > > View in context: > > > > https://bugs.webkit.org/attachment.cgi?id=239941&action=review > > > > > > > > > Tools/MiniBrowser/gtk/BrowserWindow.c:575 > > > > > + if (!window->fullScreenIsEnabled) { > > > > > + gtk_window_fullscreen(GTK_WINDOW(window)); > > > > > + gtk_widget_hide(window->toolbar); > > > > > + window->fullScreenIsEnabled = TRUE; > > > > > + } else { > > > > > + gtk_window_unfullscreen(GTK_WINDOW(window)); > > > > > + gtk_widget_show(window->toolbar); > > > > > + window->fullScreenIsEnabled = FALSE; > > > > > + } > > > > > > > > We already have code to enter/leave fullscreen when requested by wk, maybe > > > > we can reuse that code to make it work also when requested by the user, > > > > because there are some inconsistencies. The other code shows a message > > > > explaining the user how to leave fullscreen mode, and the keybindings are f > > > > or ESC, not F11. Also the other code takes care of showing/hide the findbar. > > > > > > I think the code to enter/leave fullscreen is for HTML element/webview > > > fullscreen and not for the minibrowser window itself. > > > > Right. > > > > > We don't need message > > > and title for window to be displayed on fullscreen in this case. Most of the > > > browsers (Chrome, Firefox, IE) uses F11 key to toggle browser window > > > fullscreen and f or ESC for HTML elements. Please correct me if I am wrong. > > > > Yes, Epiphany also uses F11, but also shows a message. In any case, my point > > is that the code that enters/leaves fullscreen could be common in both > > cases. Move the common logic to a function, and call it from both places. > > There is no common code in BrowserWindow.c file for webkitView and window > fullscreen except findbar hide. Are you suggesting to implement it in > WebKitWebViewBase.cpp file to handle the F11 keypress event similar to ESC > and F key handle? Oh, you are right, sorry, I thought we were also doing the fullscreen/unfullscreen in MB when entering/leaving fs, but that's done by the web view. So, yes, it's enough to move the searchbar visibility code to their own functions and call those from both places. Something like browserWindowHideSearchBarForFullscreen() and browserWindowShowSearchBarAfterFullscreen(), for example 1043740 7 kumar.rohit 2014-10-23 04:11:06 -0700 (In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #4) > > > (In reply to comment #3) > > > > (In reply to comment #2) > > > > > Comment on attachment 239941 [details] > > > > > Patch > > > > > > > > > > View in context: > > > > > https://bugs.webkit.org/attachment.cgi?id=239941&action=review > > > > > > > > > > > Tools/MiniBrowser/gtk/BrowserWindow.c:575 > > > > > > + if (!window->fullScreenIsEnabled) { > > > > > > + gtk_window_fullscreen(GTK_WINDOW(window)); > > > > > > + gtk_widget_hide(window->toolbar); > > > > > > + window->fullScreenIsEnabled = TRUE; > > > > > > + } else { > > > > > > + gtk_window_unfullscreen(GTK_WINDOW(window)); > > > > > > + gtk_widget_show(window->toolbar); > > > > > > + window->fullScreenIsEnabled = FALSE; > > > > > > + } > > > > > > > > > > We already have code to enter/leave fullscreen when requested by wk, maybe > > > > > we can reuse that code to make it work also when requested by the user, > > > > > because there are some inconsistencies. The other code shows a message > > > > > explaining the user how to leave fullscreen mode, and the keybindings are f > > > > > or ESC, not F11. Also the other code takes care of showing/hide the findbar. > > > > > > > > I think the code to enter/leave fullscreen is for HTML element/webview > > > > fullscreen and not for the minibrowser window itself. > > > > > > Right. > > > > > > > We don't need message > > > > and title for window to be displayed on fullscreen in this case. Most of the > > > > browsers (Chrome, Firefox, IE) uses F11 key to toggle browser window > > > > fullscreen and f or ESC for HTML elements. Please correct me if I am wrong. > > > > > > Yes, Epiphany also uses F11, but also shows a message. In any case, my point > > > is that the code that enters/leaves fullscreen could be common in both > > > cases. Move the common logic to a function, and call it from both places. > > > > There is no common code in BrowserWindow.c file for webkitView and window > > fullscreen except findbar hide. Are you suggesting to implement it in > > WebKitWebViewBase.cpp file to handle the F11 keypress event similar to ESC > > and F key handle? > > Oh, you are right, sorry, I thought we were also doing the > fullscreen/unfullscreen in MB when entering/leaving fs, but that's done by > the web view. So, yes, it's enough to move the searchbar visibility code to > their own functions and call those from both places. Something like > browserWindowHideSearchBarForFullscreen() and > browserWindowShowSearchBarAfterFullscreen(), for example Do you mean to say hide 'toolbar' in place of searchbar? We dont need to hide 'searchbar' as this beahviour is not needed in case of window fullscreen and needed in case of webview fullscreen.(checked in firefox and chrome). 1043741 8 cgarcia 2014-10-23 04:16:03 -0700 (In reply to comment #7) > (In reply to comment #6) > > (In reply to comment #5) > > > (In reply to comment #4) > > > > (In reply to comment #3) > > > > > (In reply to comment #2) > > > > > > Comment on attachment 239941 [details] > > > > > > Patch > > > > > > > > > > > > View in context: > > > > > > https://bugs.webkit.org/attachment.cgi?id=239941&action=review > > > > > > > > > > > > > Tools/MiniBrowser/gtk/BrowserWindow.c:575 > > > > > > > + if (!window->fullScreenIsEnabled) { > > > > > > > + gtk_window_fullscreen(GTK_WINDOW(window)); > > > > > > > + gtk_widget_hide(window->toolbar); > > > > > > > + window->fullScreenIsEnabled = TRUE; > > > > > > > + } else { > > > > > > > + gtk_window_unfullscreen(GTK_WINDOW(window)); > > > > > > > + gtk_widget_show(window->toolbar); > > > > > > > + window->fullScreenIsEnabled = FALSE; > > > > > > > + } > > > > > > > > > > > > We already have code to enter/leave fullscreen when requested by wk, maybe > > > > > > we can reuse that code to make it work also when requested by the user, > > > > > > because there are some inconsistencies. The other code shows a message > > > > > > explaining the user how to leave fullscreen mode, and the keybindings are f > > > > > > or ESC, not F11. Also the other code takes care of showing/hide the findbar. > > > > > > > > > > I think the code to enter/leave fullscreen is for HTML element/webview > > > > > fullscreen and not for the minibrowser window itself. > > > > > > > > Right. > > > > > > > > > We don't need message > > > > > and title for window to be displayed on fullscreen in this case. Most of the > > > > > browsers (Chrome, Firefox, IE) uses F11 key to toggle browser window > > > > > fullscreen and f or ESC for HTML elements. Please correct me if I am wrong. > > > > > > > > Yes, Epiphany also uses F11, but also shows a message. In any case, my point > > > > is that the code that enters/leaves fullscreen could be common in both > > > > cases. Move the common logic to a function, and call it from both places. > > > > > > There is no common code in BrowserWindow.c file for webkitView and window > > > fullscreen except findbar hide. Are you suggesting to implement it in > > > WebKitWebViewBase.cpp file to handle the F11 keypress event similar to ESC > > > and F key handle? > > > > Oh, you are right, sorry, I thought we were also doing the > > fullscreen/unfullscreen in MB when entering/leaving fs, but that's done by > > the web view. So, yes, it's enough to move the searchbar visibility code to > > their own functions and call those from both places. Something like > > browserWindowHideSearchBarForFullscreen() and > > browserWindowShowSearchBarAfterFullscreen(), for example > > Do you mean to say hide 'toolbar' in place of searchbar? We dont need to > hide 'searchbar' as this beahviour is not needed in case of window > fullscreen and needed in case of webview fullscreen.(checked in firefox and > chrome). I don't know why we hide the searchbar when entering fs TBH, I proposed it for consistency. 1044217 9 kumar.rohit 2014-10-27 00:14:06 -0700 (In reply to comment #8) > (In reply to comment #7) > > (In reply to comment #6) > > > (In reply to comment #5) > > > > (In reply to comment #4) > > > > > (In reply to comment #3) > > > > > > (In reply to comment #2) > > > > > > > Comment on attachment 239941 [details] > > > > > > > Patch > > > > > > > > > > > > > > View in context: > > > > > > > https://bugs.webkit.org/attachment.cgi?id=239941&action=review > > > > > > > > > > > > > > > Tools/MiniBrowser/gtk/BrowserWindow.c:575 > > > > > > > > + if (!window->fullScreenIsEnabled) { > > > > > > > > + gtk_window_fullscreen(GTK_WINDOW(window)); > > > > > > > > + gtk_widget_hide(window->toolbar); > > > > > > > > + window->fullScreenIsEnabled = TRUE; > > > > > > > > + } else { > > > > > > > > + gtk_window_unfullscreen(GTK_WINDOW(window)); > > > > > > > > + gtk_widget_show(window->toolbar); > > > > > > > > + window->fullScreenIsEnabled = FALSE; > > > > > > > > + } > > > > > > > > > > > > > > We already have code to enter/leave fullscreen when requested by wk, maybe > > > > > > > we can reuse that code to make it work also when requested by the user, > > > > > > > because there are some inconsistencies. The other code shows a message > > > > > > > explaining the user how to leave fullscreen mode, and the keybindings are f > > > > > > > or ESC, not F11. Also the other code takes care of showing/hide the findbar. > > > > > > > > > > > > I think the code to enter/leave fullscreen is for HTML element/webview > > > > > > fullscreen and not for the minibrowser window itself. > > > > > > > > > > Right. > > > > > > > > > > > We don't need message > > > > > > and title for window to be displayed on fullscreen in this case. Most of the > > > > > > browsers (Chrome, Firefox, IE) uses F11 key to toggle browser window > > > > > > fullscreen and f or ESC for HTML elements. Please correct me if I am wrong. > > > > > > > > > > Yes, Epiphany also uses F11, but also shows a message. In any case, my point > > > > > is that the code that enters/leaves fullscreen could be common in both > > > > > cases. Move the common logic to a function, and call it from both places. > > > > > > > > There is no common code in BrowserWindow.c file for webkitView and window > > > > fullscreen except findbar hide. Are you suggesting to implement it in > > > > WebKitWebViewBase.cpp file to handle the F11 keypress event similar to ESC > > > > and F key handle? > > > > > > Oh, you are right, sorry, I thought we were also doing the > > > fullscreen/unfullscreen in MB when entering/leaving fs, but that's done by > > > the web view. So, yes, it's enough to move the searchbar visibility code to > > > their own functions and call those from both places. Something like > > > browserWindowHideSearchBarForFullscreen() and > > > browserWindowShowSearchBarAfterFullscreen(), for example > > > > Do you mean to say hide 'toolbar' in place of searchbar? We dont need to > > hide 'searchbar' as this beahviour is not needed in case of window > > fullscreen and needed in case of webview fullscreen.(checked in firefox and > > chrome). > > I don't know why we hide the searchbar when entering fs TBH, I proposed it > for consistency. I think we need to hide searchbar while entering fs because otherwise searchbar would be visible on top of fullscreen element. 1045027 10 239941 commit-queue 2014-10-30 06:45:05 -0700 Comment on attachment 239941 Patch Clearing flags on attachment: 239941 Committed r175371: <http://trac.webkit.org/changeset/175371> 1045028 11 commit-queue 2014-10-30 06:45:08 -0700 All reviewed patches have been landed. Closing bug. 239941 2014-10-16 03:00:18 -0700 2014-10-30 06:45:05 -0700 Patch bug-137775-20141016153138.patch text/plain 2638 kumar.rohit U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0NzYxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTRkMmVlYzk5Mjk3YmRlNTAyYTYyNzc4ZjViMmU1YzY2 MWM0MGZjMi4uN2JjMTMwZmU0NjRjYmFlOGU0NmFkMzBmOGM0NTM4Y2M4NTZlMDRlNSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE0LTEwLTE2ICBSb2hpdCBLdW1hciAgPGt1bWFyLnJvaGl0QHNhbXN1bmcuY29tPgor CisgICAgICAgIFtHVEtdIE1pbmlicm93c2VyIDogQWRkIHdpbmRvdyBmdWxsc2NyZWVuIHN1cHBv cnQgZm9yIE1pbmlicm93c2VyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMzc3NzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIE1pbmlCcm93c2VyL2d0ay9Ccm93c2VyV2luZG93LmM6CisgICAgICAgICh0 b2dnbGVGdWxsU2NyZWVuKTogQ2FsbGJhY2sgdG8gdG9nZ2xlIHdpbmRvdyBmdWxsc2NyZWVuIG9u IHByZXNzaW5nIEYxMSBrZXkuCisgICAgICAgIChicm93c2VyX3dpbmRvd19pbml0KToKKwogMjAx NC0xMC0xNSAgR3l1eW91bmcgS2ltICA8Z3l1eW91bmcua2ltQHNhbXN1bmcuY29tPgogCiAgICAg ICAgIFVucmV2aWV3ZWQsIGFkZCBteXNlbGYgdG8gQ29vcmRpbmF0ZWRHcmFwaGljcyB3YXRjaGVy cy4KZGlmZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9Ccm93c2VyV2luZG93LmMgYi9U b29scy9NaW5pQnJvd3Nlci9ndGsvQnJvd3NlcldpbmRvdy5jCmluZGV4IDMwMjZmYjZlZWFiZThl YjViYmE2MjkxNWRmMjhjMDM1ZTk2MmI1NGIuLjlkMjU5YWM1M2EyMDFlYTA4NzFkMTY4ZTRmYjIz MmY4OWU4ZTgwNjQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9Ccm93c2VyV2lu ZG93LmMKKysrIGIvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJXaW5kb3cuYwpAQCAtNjAs NiArNjAsNyBAQCBzdHJ1Y3QgX0Jyb3dzZXJXaW5kb3cgewogICAgIEJyb3dzZXJTZWFyY2hCYXIg KnNlYXJjaEJhcjsKICAgICBnYm9vbGVhbiBzZWFyY2hCYXJWaXNpYmxlOwogICAgIGdib29sZWFu IGluc3BlY3RvcldpbmRvd0lzVmlzaWJsZTsKKyAgICBnYm9vbGVhbiBmdWxsU2NyZWVuSXNFbmFi bGVkOwogICAgIEdka1BpeGJ1ZiAqZmF2aWNvbjsKICAgICBHdGtXaWRnZXQgKnJlbG9hZE9yU3Rv cEJ1dHRvbjsKICAgICBHdGtXaWRnZXQgKmZ1bGxTY3JlZW5NZXNzYWdlTGFiZWw7CkBAIC01NjEs NiArNTYyLDIwIEBAIHN0YXRpYyB2b2lkIGxvYWRIb21lUGFnZShCcm93c2VyV2luZG93ICp3aW5k b3csIGdwb2ludGVyIHVzZXJfZGF0YSkKICAgICB3ZWJraXRfd2ViX3ZpZXdfbG9hZF91cmkod2lu ZG93LT53ZWJWaWV3LCBCUk9XU0VSX0RFRkFVTFRfVVJMKTsKIH0KIAorc3RhdGljIGdib29sZWFu IHRvZ2dsZUZ1bGxTY3JlZW4oQnJvd3NlcldpbmRvdyAqd2luZG93LCBncG9pbnRlciB1c2VyX2Rh dGEpCit7CisgICAgaWYgKCF3aW5kb3ctPmZ1bGxTY3JlZW5Jc0VuYWJsZWQpIHsKKyAgICAgICAg Z3RrX3dpbmRvd19mdWxsc2NyZWVuKEdUS19XSU5ET1cod2luZG93KSk7CisgICAgICAgIGd0a193 aWRnZXRfaGlkZSh3aW5kb3ctPnRvb2xiYXIpOworICAgICAgICB3aW5kb3ctPmZ1bGxTY3JlZW5J c0VuYWJsZWQgPSBUUlVFOworICAgIH0gZWxzZSB7CisgICAgICAgIGd0a193aW5kb3dfdW5mdWxs c2NyZWVuKEdUS19XSU5ET1cod2luZG93KSk7CisgICAgICAgIGd0a193aWRnZXRfc2hvdyh3aW5k b3ctPnRvb2xiYXIpOworICAgICAgICB3aW5kb3ctPmZ1bGxTY3JlZW5Jc0VuYWJsZWQgPSBGQUxT RTsKKyAgICB9CisgICAgcmV0dXJuIFRSVUU7Cit9CisKIHN0YXRpYyB2b2lkIGJyb3dzZXJXaW5k b3dGaW5hbGl6ZShHT2JqZWN0ICpnT2JqZWN0KQogewogICAgIEJyb3dzZXJXaW5kb3cgKndpbmRv dyA9IEJST1dTRVJfV0lORE9XKGdPYmplY3QpOwpAQCAtNjcwLDYgKzY4NSwxMCBAQCBzdGF0aWMg dm9pZCBicm93c2VyX3dpbmRvd19pbml0KEJyb3dzZXJXaW5kb3cgKndpbmRvdykKICAgICBndGtf YWNjZWxfZ3JvdXBfY29ubmVjdCh3aW5kb3ctPmFjY2VsR3JvdXAsIEdES19LRVlfS1BfMCwgR0RL X0NPTlRST0xfTUFTSywgR1RLX0FDQ0VMX1ZJU0lCTEUsCiAgICAgICAgIGdfY2Nsb3N1cmVfbmV3 X3N3YXAoR19DQUxMQkFDSyhkZWZhdWx0Wm9vbUNhbGxiYWNrKSwgd2luZG93LCBOVUxMKSk7CiAK KyAgICAvKiBUb2dnbGUgZnVsbHNjcmVlbiAqLyAKKyAgICBndGtfYWNjZWxfZ3JvdXBfY29ubmVj dCh3aW5kb3ctPmFjY2VsR3JvdXAsIEdES19LRVlfRjExLCAwLCBHVEtfQUNDRUxfVklTSUJMRSwK KyAgICAgICAgZ19jY2xvc3VyZV9uZXdfc3dhcChHX0NBTExCQUNLKHRvZ2dsZUZ1bGxTY3JlZW4p LCB3aW5kb3csIE5VTEwpKTsKKwogICAgIEd0a1dpZGdldCAqdG9vbGJhciA9IGd0a190b29sYmFy X25ldygpOwogICAgIHdpbmRvdy0+dG9vbGJhciA9IHRvb2xiYXI7CiAgICAgZ3RrX29yaWVudGFi bGVfc2V0X29yaWVudGF0aW9uKEdUS19PUklFTlRBQkxFKHRvb2xiYXIpLCBHVEtfT1JJRU5UQVRJ T05fSE9SSVpPTlRBTCk7Cg==