137763 2014-10-15 19:15:06 -0700 [Media] Reduce style updates (painting) in controls 2014-10-15 19:38:33 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dino dino calvaris commit-queue eric.carlson glenn jer.noble philipj sergio oldest_to_newest 1042036 0 dino 2014-10-15 19:15:06 -0700 [Media] Reduce style updates (painting) in controls 1042038 1 239916 dino 2014-10-15 19:19:48 -0700 Created attachment 239916 Patch 1042041 2 dino 2014-10-15 19:25:56 -0700 <rdar://problem/17833045> 1042042 3 dino 2014-10-15 19:26:06 -0700 Committed r174756: <http://trac.webkit.org/changeset/174756> 1042045 4 jer.noble 2014-10-15 19:38:33 -0700 Surely you need to call updateTime() and updateProgress() from showControls(), in case the currentTime or progress changed while the controls were hidden. 239916 2014-10-15 19:19:48 -0700 2014-10-15 19:22:34 -0700 Patch bug-137763-20141016131951.patch text/plain 4472 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0NzAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTYwNWRhNDdmN2M5NWIx YTMzZGY4NGZmOTVjMzMxYjBkMDMxZDA0Zi4uODU5ODFhYWJiZjMzNWFiZmNlYjA1ZDdiZDQ5NWU3 ZWUwMjRmN2IzMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE0LTEwLTE1ICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBbTWVkaWFdIFJlZHVjZSBzdHls ZSB1cGRhdGVzIChwYWludGluZykgaW4gY29udHJvbHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNzc2MworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIE1lZGlhIGNvbnRyb2xzIHdlcmUgY2F1c2luZyBhIGxv dCBvZiByZXBhaW50cyB0aGV5IHdlcmUKKyAgICAgICAgY29uc3RhbnRseSB1cGRhdGluZyB0aGUg c3R5bGUgb2YgdGhlIHdpZGdldHMsIHRoZSB2YWx1ZQorICAgICAgICBvZiB0aGUgZm9ybXMsIG9y IHRoZSB0ZXh0IGluIHRoZSBkaXNwbGF5LgorCisgICAgICAgIFRoaXMgaXMgbmVjZXNzYXJ5IHdo ZW4gdGhlIGNvbnRyb2xzIGFyZSB2aXNpYmxlLCBidXQgbm90CisgICAgICAgIG5lY2Vzc2FyeSB3 aGVuIHRoZXkgYXJlIGhpZGRlbi4gUmV0dXJuIGltbWVkaWF0ZWx5IGluIHRoYXQgY2FzZS4KKwor ICAgICAgICAqIE1vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzQXBwbGUuanM6Cisg ICAgICAgIChDb250cm9sbGVyLnByb3RvdHlwZS5jcmVhdGVDb250cm9scyk6IEluaXRpYWxpc2Ug dGhlIHNsaWRlciB0byBhIHplcm8gdmFsdWUuCisgICAgICAgIChDb250cm9sbGVyLnByb3RvdHlw ZS5oYW5kbGVEdXJhdGlvbkNoYW5nZSk6IEZvcmNlIGFuIHVwZGF0ZSBldmVuIHRob3VnaCB3ZSBt aWdodCBiZSBoaWRkZW4uCisgICAgICAgIChDb250cm9sbGVyLnByb3RvdHlwZS51cGRhdGVQcm9n cmVzcyk6IERvbid0IHVwZGF0ZSBpZiB3ZSdyZSBoaWRkZW4uCisgICAgICAgIChDb250cm9sbGVy LnByb3RvdHlwZS51cGRhdGVUaW1lKTogRGl0dG8uCisgICAgICAgICogTW9kdWxlcy9tZWRpYWNv bnRyb2xzL21lZGlhQ29udHJvbHNpT1MuanM6CisgICAgICAgIChDb250cm9sbGVySU9TLnByb3Rv dHlwZS51cGRhdGVQcm9ncmVzcyk6IERpdHRvLgorCiAyMDE0LTEwLTE0ICBEZWFuIEphY2tzb24g IDxkaW5vQGFwcGxlLmNvbT4KIAogICAgICAgICBDcmFzaCBpbiBXZWJDb3JlOjpVc2VyR2VzdHVy ZUluZGljYXRvcjo6cHJvY2Vzc2luZ1VzZXJHZXN0dXJlIHdpdGggV2ViV29ya2VycwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNB cHBsZS5qcyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRy b2xzQXBwbGUuanMKaW5kZXggZTg2NGFiMDc3MGE1ZGRkZWI2ZDhhZjAzMGRkYTc0MTY0ZGE5MmM3 Mi4uNDRhMWViZGNhYzY1MjA5MmNjNmVjOTlkMzM5YmI2ODJiOTRiMTIxNiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNBcHBsZS5q cworKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9s c0FwcGxlLmpzCkBAIC0zMzMsNiArMzMzLDcgQEAgQ29udHJvbGxlci5wcm90b3R5cGUgPSB7CiAg ICAgICAgIHRpbWVsaW5lLnNldEF0dHJpYnV0ZSgncHNldWRvJywgJy13ZWJraXQtbWVkaWEtY29u dHJvbHMtdGltZWxpbmUnKTsKICAgICAgICAgdGltZWxpbmUuc2V0QXR0cmlidXRlKCdhcmlhLWxh YmVsJywgdGhpcy5VSVN0cmluZygnRHVyYXRpb24nKSk7CiAgICAgICAgIHRpbWVsaW5lLnR5cGUg PSAncmFuZ2UnOworICAgICAgICB0aW1lbGluZS52YWx1ZSA9IDA7CiAgICAgICAgIHRoaXMubGlz dGVuRm9yKHRpbWVsaW5lLCAnaW5wdXQnLCB0aGlzLmhhbmRsZVRpbWVsaW5lQ2hhbmdlKTsKICAg ICAgICAgdGhpcy5saXN0ZW5Gb3IodGltZWxpbmUsICdtb3VzZW92ZXInLCB0aGlzLmhhbmRsZVRp bWVsaW5lTW91c2VPdmVyKTsKICAgICAgICAgdGhpcy5saXN0ZW5Gb3IodGltZWxpbmUsICdtb3Vz ZW91dCcsIHRoaXMuaGFuZGxlVGltZWxpbmVNb3VzZU91dCk7CkBAIC01NjcsOCArNTY4LDggQEAg Q29udHJvbGxlci5wcm90b3R5cGUgPSB7CiAgICAgaGFuZGxlRHVyYXRpb25DaGFuZ2U6IGZ1bmN0 aW9uKGV2ZW50KQogICAgIHsKICAgICAgICAgdGhpcy51cGRhdGVEdXJhdGlvbigpOwotICAgICAg ICB0aGlzLnVwZGF0ZVRpbWUoKTsKLSAgICAgICAgdGhpcy51cGRhdGVQcm9ncmVzcygpOworICAg ICAgICB0aGlzLnVwZGF0ZVRpbWUodHJ1ZSk7CisgICAgICAgIHRoaXMudXBkYXRlUHJvZ3Jlc3Mo dHJ1ZSk7CiAgICAgfSwKIAogICAgIGhhbmRsZVBsYXk6IGZ1bmN0aW9uKGV2ZW50KQpAQCAtOTU2 LDggKzk1NywxMSBAQCBDb250cm9sbGVyLnByb3RvdHlwZSA9IHsKICAgICAgICAgcmV0dXJuIGdy YWRpZW50OwogICAgIH0sCiAKLSAgICB1cGRhdGVQcm9ncmVzczogZnVuY3Rpb24oKQorICAgIHVw ZGF0ZVByb2dyZXNzOiBmdW5jdGlvbihmb3JjZVVwZGF0ZSkKICAgICB7CisgICAgICAgIGlmICgh Zm9yY2VVcGRhdGUgJiYgdGhpcy5jb250cm9sc0FyZUhpZGRlbigpKQorICAgICAgICAgICAgcmV0 dXJuOworCiAgICAgICAgIHRoaXMudXBkYXRlVGltZWxpbmVNZXRyaWNzSWZOZWVkZWQoKTsKIAog ICAgICAgICB2YXIgYmFja2dyb3VuZCA9ICd1cmwoXCdkYXRhOmltYWdlL3N2Zyt4bWwsPHN2ZyB4 bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZpZXdCb3g9IjAgMCAxIDEiIHByZXNl cnZlQXNwZWN0UmF0aW89Im5vbmUiPjxsaW5lYXJHcmFkaWVudCBpZD0iZ3JhZGllbnQiIHgyPSIw IiB5Mj0iMTAwJSIgZ3JhZGllbnRVbml0cz0idXNlclNwYWNlT25Vc2UiPjxzdG9wIG9mZnNldD0i MCIgc3RvcC1jb2xvcj0icmdiKDIsIDIsIDIpIi8+PHN0b3Agb2Zmc2V0PSIxIiBzdG9wLWNvbG9y PSJyZ2IoMjMsIDIzLCAyMykiLz48L2xpbmVhckdyYWRpZW50PjxnIHN0eWxlPSJmaWxsOnVybCgj Z3JhZGllbnQpIj4nCkBAIC0xMDUwLDggKzEwNTQsMTEgQEAgQ29udHJvbGxlci5wcm90b3R5cGUg PSB7CiAgICAgICAgIHRoaXMuc2V0TmVlZHNUaW1lbGluZU1ldHJpY3NVcGRhdGUoKTsKICAgICB9 LAogCi0gICAgdXBkYXRlVGltZTogZnVuY3Rpb24oKQorICAgIHVwZGF0ZVRpbWU6IGZ1bmN0aW9u KGZvcmNlVXBkYXRlKQogICAgIHsKKyAgICAgICAgaWYgKCFmb3JjZVVwZGF0ZSAmJiB0aGlzLmNv bnRyb2xzQXJlSGlkZGVuKCkpCisgICAgICAgICAgICByZXR1cm47CisKICAgICAgICAgdmFyIGN1 cnJlbnRUaW1lID0gdGhpcy52aWRlby5jdXJyZW50VGltZTsKICAgICAgICAgdmFyIHRpbWVSZW1h aW5pbmcgPSBjdXJyZW50VGltZSAtIHRoaXMudmlkZW8uZHVyYXRpb247CiAgICAgICAgIHRoaXMu Y29udHJvbHMuY3VycmVudFRpbWUuaW5uZXJUZXh0ID0gdGhpcy5mb3JtYXRUaW1lKGN1cnJlbnRU aW1lKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9t ZWRpYUNvbnRyb2xzaU9TLmpzIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xz L21lZGlhQ29udHJvbHNpT1MuanMKaW5kZXggMDgwYTg0ZTNkYWVkNzcwMTUwNWQ2ZWYzOGQyZWM3 MWJkMThhYTliZC4uYTk1ZDc2YjdiMTE3YThkZTNlYjFlNTM2ZjQyMGRhNDUyNzQ1NTQ4ZCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJv bHNpT1MuanMKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlh Q29udHJvbHNpT1MuanMKQEAgLTIzOCw4ICsyMzgsMTEgQEAgQ29udHJvbGxlcklPUy5wcm90b3R5 cGUgPSB7CiAgICAgICAgIHJldHVybiAncmdiYSgwLCAwLCAwLCAwLjUpJzsKICAgICB9LAogCi0g ICAgdXBkYXRlUHJvZ3Jlc3M6IGZ1bmN0aW9uKCkgewotICAgICAgICBDb250cm9sbGVyLnByb3Rv dHlwZS51cGRhdGVQcm9ncmVzcy5jYWxsKHRoaXMpOworICAgIHVwZGF0ZVByb2dyZXNzOiBmdW5j dGlvbihmb3JjZVVwZGF0ZSkgeworICAgICAgICBDb250cm9sbGVyLnByb3RvdHlwZS51cGRhdGVQ cm9ncmVzcy5jYWxsKHRoaXMsIGZvcmNlVXBkYXRlKTsKKworICAgICAgICBpZiAoIWZvcmNlVXBk YXRlICYmIHRoaXMuY29udHJvbHNBcmVIaWRkZW4oKSkKKyAgICAgICAgICAgIHJldHVybjsKIAog ICAgICAgICB2YXIgd2lkdGggPSB0aGlzLnRpbWVsaW5lV2lkdGg7CiAgICAgICAgIHZhciBoZWln aHQgPSB0aGlzLnRpbWVsaW5lSGVpZ2h0Owo=