137752 2014-10-15 13:18:16 -0700 glReadPixels on NVidia cards return the wrong values for the alpha channel when alpha is off 2014-10-16 23:44:41 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) PC Unspecified RESOLVED DUPLICATE 137793 P2 Normal --- 137790 1 roger_fong webkit-unassigned bfulgham commit-queue dino jonlee kondapallykalyan noam roger_fong oldest_to_newest 1041938 0 roger_fong 2014-10-15 13:18:16 -0700 When you create a rendering context with alpha:false, this means that the context returned should be opaque. However, with nvidia cards, calling glreadpixels on such contexts returns the wrong value. It returns 0's in the alpha channel, they should be 255 instead. As a workaround for this, after calls to ::glReadPixels we should manually set the alpha channel to 255 if alpha is off for the context. 1041939 1 roger_fong 2014-10-15 13:20:46 -0700 <rdar://problem/15408133> I believe this is the last failing 1.0.2 test on at least the 2 nvidia cards i've tested on. (the 9600M GT and the 750 M) 1041945 2 239892 roger_fong 2014-10-15 13:42:50 -0700 Created attachment 239892 patch 1041951 3 239892 bfulgham 2014-10-15 13:53:30 -0700 Comment on attachment 239892 patch View in context: https://bugs.webkit.org/attachment.cgi?id=239892&action=review Looks good. Could you please mention the two failing tests that you have fixed with this change? Thanks. > ChangeLog:7 > + Reviewed by NOBODY (OOPS!). Can you list the two failing tests that were fixed by this? 1041970 4 roger_fong 2014-10-15 14:41:38 -0700 Committed with mention of fixed test in changelog. http://trac.webkit.org/changeset/174744 1042201 5 commit-queue 2014-10-16 14:50:02 -0700 Re-opened since this is blocked by bug 137790 1042311 6 roger_fong 2014-10-16 23:44:41 -0700 Closing this since I filed another bug for the issue. *** This bug has been marked as a duplicate of bug 137793 *** 239892 2014-10-15 13:42:50 -0700 2014-10-15 13:53:30 -0700 patch patch.patch text/plain 3363 roger_fong SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE3NDQ4 OCkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTEw LTE1ICBSb2dlciBGb25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgZ2xSZWFk UGl4ZWxzIG9uIE5WSURJQSBjYXJkcyByZXR1cm5zIHRoZSB3cm9uZyB2YWx1ZXMgZm9yIHRoZSBh bHBoYSBjaGFubmVsIHdoZW4gYWxwaGEgaXMgb2ZmLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM3NzUyLgorICAgICAgICA8cmRhcjovL3Byb2JsZW0v MTU0MDgxMzM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiAuLi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQz RC5oOgorICAgICAgICAqIC4uL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5n bC9HcmFwaGljc0NvbnRleHQzRE9wZW5HTC5jcHA6CisgICAgICAgIE1hbnVhbGx5IHNldCB0aGUg YWxwaGEgY2hhbm5lbCB0byAyNTUgd2hlbiBhbHBoYSBpcyBvZmYgb24gdGhlIHJlbmRlcmluZyBj b250ZXh0LgorCiAyMDE0LTEwLTA3ICBQYXNjYWwgSmFjcXVlbWFydCAgPHAuamFjcXVlbWFydEBz YW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZMXSBFbmFibGUgY3VzdG9tIFVSSSBzY2hlbWVzIHdp dGggQ3VzdG9tUHJvdG9jb2xzCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9HcmFwaGljc0NvbnRleHQzRC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dDNELmgJKHJldmlzaW9uIDE3NDQ4OCkKKysrIFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dDNELmgJKHdvcmtp bmcgY29weSkKQEAgLTk4OSw2ICs5ODksNyBAQCBwcml2YXRlOgogICAgIC8vIGJhY2tidWZmZXIu CiAgICAgdm9pZCByZWFkUmVuZGVyaW5nUmVzdWx0cyh1bnNpZ25lZCBjaGFyKiBwaXhlbHMsIGlu dCBwaXhlbHNTaXplKTsKICAgICB2b2lkIHJlYWRQaXhlbHNBbmRDb252ZXJ0VG9CR1JBSWZOZWNl c3NhcnkoaW50IHgsIGludCB5LCBpbnQgd2lkdGgsIGludCBoZWlnaHQsIHVuc2lnbmVkIGNoYXIq IHBpeGVscyk7CisgICAgdm9pZCBjYWxsR0xSZWFkUGl4ZWxzKEdDM0RpbnQgeCwgR0MzRGludCB5 LCBHQzNEc2l6ZWkgd2lkdGgsIEdDM0RzaXplaSBoZWlnaHQsIEdDM0RlbnVtIGZvcm1hdCwgR0Mz RGVudW0gdHlwZSwgdW5zaWduZWQgY2hhciogcGl4ZWxzKTsKIAogI2lmIFBMQVRGT1JNKElPUykK ICAgICBib29sIHNldFJlbmRlcmJ1ZmZlclN0b3JhZ2VGcm9tRHJhd2FibGUoR0MzRHNpemVpIHdp ZHRoLCBHQzNEc2l6ZWkgaGVpZ2h0KTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL29wZW5nbC9HcmFwaGljc0NvbnRleHQzRE9wZW5HTC5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dyYXBoaWNzQ29udGV4dDNE T3BlbkdMLmNwcAkocmV2aXNpb24gMTc0NDg4KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3Mvb3BlbmdsL0dyYXBoaWNzQ29udGV4dDNET3BlbkdMLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtNjUsNyArNjUsNyBAQCB2b2lkIEdyYXBoaWNzQ29udGV4dDNEOjpyZWxlYXNlU2hhZGVy Q29tCiAKIHZvaWQgR3JhcGhpY3NDb250ZXh0M0Q6OnJlYWRQaXhlbHNBbmRDb252ZXJ0VG9CR1JB SWZOZWNlc3NhcnkoaW50IHgsIGludCB5LCBpbnQgd2lkdGgsIGludCBoZWlnaHQsIHVuc2lnbmVk IGNoYXIqIHBpeGVscykKIHsKLSAgICA6OmdsUmVhZFBpeGVscyh4LCB5LCB3aWR0aCwgaGVpZ2h0 LCBHTF9CR1JBLCBHTF9VTlNJR05FRF9JTlRfOF84XzhfOF9SRVYsIHBpeGVscyk7CisgICAgY2Fs bEdMUmVhZFBpeGVscyh4LCB5LCB3aWR0aCwgaGVpZ2h0LCBHTF9CR1JBLCBHTF9VTlNJR05FRF9J TlRfOF84XzhfOF9SRVYsIHBpeGVscyk7CiB9CiAKIHZvaWQgR3JhcGhpY3NDb250ZXh0M0Q6OnZh bGlkYXRlQXR0cmlidXRlcygpCkBAIC0zNTYsMTEgKzM1NiwyNCBAQCB2b2lkIEdyYXBoaWNzQ29u dGV4dDNEOjpyZWFkUGl4ZWxzKEdDM0RpCiAgICAgICAgIDo6Z2xCaW5kRnJhbWVidWZmZXJFWFQo R3JhcGhpY3NDb250ZXh0M0Q6OkZSQU1FQlVGRkVSLCBtX2Zibyk7CiAgICAgICAgIDo6Z2xGbHVz aCgpOwogICAgIH0KLSAgICA6OmdsUmVhZFBpeGVscyh4LCB5LCB3aWR0aCwgaGVpZ2h0LCBmb3Jt YXQsIHR5cGUsIGRhdGEpOworICAgIGNhbGxHTFJlYWRQaXhlbHMoeCwgeSwgd2lkdGgsIGhlaWdo dCwgZm9ybWF0LCB0eXBlLCBzdGF0aWNfY2FzdDx1bnNpZ25lZCBjaGFyKj4oZGF0YSkpOworCiAg ICAgaWYgKG1fYXR0cnMuYW50aWFsaWFzICYmIG1fc3RhdGUuYm91bmRGQk8gPT0gbV9tdWx0aXNh bXBsZUZCTykKICAgICAgICAgOjpnbEJpbmRGcmFtZWJ1ZmZlckVYVChHcmFwaGljc0NvbnRleHQz RDo6RlJBTUVCVUZGRVIsIG1fbXVsdGlzYW1wbGVGQk8pOwogfQogCit2b2lkIEdyYXBoaWNzQ29u dGV4dDNEOjpjYWxsR0xSZWFkUGl4ZWxzKEdDM0RpbnQgeCwgR0MzRGludCB5LCBHQzNEc2l6ZWkg d2lkdGgsIEdDM0RzaXplaSBoZWlnaHQsIEdDM0RlbnVtIGZvcm1hdCwgR0MzRGVudW0gdHlwZSwg dW5zaWduZWQgY2hhciogcGl4ZWxzKQoreworICAgIDo6Z2xSZWFkUGl4ZWxzKHgsIHksIHdpZHRo LCBoZWlnaHQsIGZvcm1hdCwgdHlwZSwgcGl4ZWxzKTsKKyAgICBpbnQgdG90YWxCeXRlcyA9IHdp ZHRoKmhlaWdodCo0OworICAgIC8vIEZJWE1FOiBUaGVyZSBpcyBhIGJ1ZyB3aXRoIHRoZSBOVklE SUEgZHJpdmVycyB3aGVyZSBpZiBhbHBoYSBpcyBvZmYsCisgICAgLy8gcmVhZFBpeGVscyByZXR1 cm5zIDAgZm9yIHRoZSBhbHBoYSBjaGFubmVsIGluc3RlYWQgb2YgMjU1LgorICAgIGlmIChnZXRF eHRlbnNpb25zKCktPmlzTlZJRElBKCkgJiYgIW1fYXR0cnMuYWxwaGEpIHsKKyAgICAgICAgZm9y IChpbnQgaSA9IDA7IGkgPCB0b3RhbEJ5dGVzOyBpICs9IDQpCisgICAgICAgICAgICBwaXhlbHNb aSszXSA9IDI1NTsKKyAgICB9Cit9CisKIH0KIAogI2VuZGlmIC8vIFVTRSgzRF9HUkFQSElDUykK