137750 2014-10-15 12:56:07 -0700 webkit-patch should include a test command that only runs RunTests 2014-10-23 10:54:51 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 jake.nielsen.webkit jake.nielsen.webkit ap commit-queue dbates dfarler glenn oldest_to_newest 1041927 0 jake.nielsen.webkit 2014-10-15 12:56:07 -0700 Currently the build-and-test removes local changes, cleans, builds, and then runs tests. When making changes to RunTests, only the last step is of interest. It would be nice to have a command to run in that case. 1041934 1 239888 jake.nielsen.webkit 2014-10-15 13:07:16 -0700 Created attachment 239888 Adds the test command 1042834 2 jake.nielsen.webkit 2014-10-20 09:31:47 -0700 bump 1042947 3 239888 dbates 2014-10-20 13:13:34 -0700 Comment on attachment 239888 Adds the test command View in context: https://bugs.webkit.org/attachment.cgi?id=239888&action=review > Tools/Scripts/webkitpy/tool/commands/download.py:99 > +class Test(AbstractSequencedCommand): > + name = "test" > + help_text = "Run the tests" > + steps = [ > + steps.RunTests, > + ] > + > + def _prepare_state(self, options, args, tool): > + options.test = True > + Notice that steps.RunTests runs test suites that depend on a built product (e.g. Tools/Scripts/run-webkit-tests). How does this command work when we run such test suites? 1042949 4 jake.nielsen.webkit 2014-10-20 13:17:33 -0700 bump(In reply to comment #3) > Comment on attachment 239888 [details] > Adds the test command > > View in context: > https://bugs.webkit.org/attachment.cgi?id=239888&action=review > > > Tools/Scripts/webkitpy/tool/commands/download.py:99 > > +class Test(AbstractSequencedCommand): > > + name = "test" > > + help_text = "Run the tests" > > + steps = [ > > + steps.RunTests, > > + ] > > + > > + def _prepare_state(self, options, args, tool): > > + options.test = True > > + > > Notice that steps.RunTests runs test suites that depend on a built product > (e.g. Tools/Scripts/run-webkit-tests). How does this command work when we > run such test suites? It assumes you've already built. 1042963 5 dbates 2014-10-20 14:02:05 -0700 (In reply to comment #4) > bump(In reply to comment #3) > > Comment on attachment 239888 [details] > > Adds the test command > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=239888&action=review > > > > > Tools/Scripts/webkitpy/tool/commands/download.py:99 > > > +class Test(AbstractSequencedCommand): > > > + name = "test" > > > + help_text = "Run the tests" > > > + steps = [ > > > + steps.RunTests, > > > + ] > > > + > > > + def _prepare_state(self, options, args, tool): > > > + options.test = True > > > + > > > > Notice that steps.RunTests runs test suites that depend on a built product > > (e.g. Tools/Scripts/run-webkit-tests). How does this command work when we > > run such test suites? > > It assumes you've already built. Can you elaborate? Specifically, are you referring to run-webkit-tests when you say "it"? 1042965 6 jake.nielsen.webkit 2014-10-20 14:13:01 -0700 (In reply to comment #5) > (In reply to comment #4) > > bump(In reply to comment #3) > > > Comment on attachment 239888 [details] > > > Adds the test command > > > > > > View in context: > > > https://bugs.webkit.org/attachment.cgi?id=239888&action=review > > > > > > > Tools/Scripts/webkitpy/tool/commands/download.py:99 > > > > +class Test(AbstractSequencedCommand): > > > > + name = "test" > > > > + help_text = "Run the tests" > > > > + steps = [ > > > > + steps.RunTests, > > > > + ] > > > > + > > > > + def _prepare_state(self, options, args, tool): > > > > + options.test = True > > > > + > > > > > > Notice that steps.RunTests runs test suites that depend on a built product > > > (e.g. Tools/Scripts/run-webkit-tests). How does this command work when we > > > run such test suites? > > > > It assumes you've already built. > > Can you elaborate? Specifically, are you referring to run-webkit-tests when > you say "it"? Oh, I meant the "test" command that got added to download.py by this patch. 1043773 7 jake.nielsen.webkit 2014-10-23 10:54:28 -0700 I stand corrected. This is equivalent to ./webkit-patch build-and-test --no-clean --no-update --test so that's what I'll use. 239888 2014-10-15 13:07:16 -0700 2014-10-20 13:13:34 -0700 Adds the test command 0001-webkit-patch-should-include-a-test-command-that-only.patch text/plain 2074 jake.nielsen.webkit RnJvbSAyZGE3Mjg0MzM1NjU3ZDg3MDQ2NGMxYjg0ZmZlNDg0MzUzZTQ2Mjk5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYWtlIE5pZWxzZW4gPGphY29iX25pZWxzZW5AYXBwbGUuY29t PgpEYXRlOiBXZWQsIDE1IE9jdCAyMDE0IDEzOjA2OjE1IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0g d2Via2l0LXBhdGNoIHNob3VsZCBpbmNsdWRlIGEgdGVzdCBjb21tYW5kIHRoYXQgb25seSBydW5z CiBSdW5UZXN0cy4gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNzc1 MAoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgoqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9j b21tYW5kcy9kb3dubG9hZC5weToKQWRkcyB0aGUgdGVzdCBjb21tYW5kIHRvIHdlYmtpdC1wYXRj aC4KKFRlc3QpOgpGb3JjZXMgLS10ZXN0IHRvIGJlIFRydWUuCihUZXN0Ll9wcmVwYXJlX3N0YXRl KToKLS0tCiBUb29scy9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg fCAxMyArKysrKysrKysrKysrCiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMv ZG93bmxvYWQucHkgfCAxMSArKysrKysrKysrKwogMiBmaWxlcyBjaGFuZ2VkLCAyNCBpbnNlcnRp b25zKCspCgpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmlu ZGV4IGE2MTAyMzkuLjk2ZjJhYWUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxNC0xMC0xNSAgSmFrZSBOaWVsc2Vu ICA8amFjb2JfbmllbHNlbkBhcHBsZS5jb20+CisKKyAgICAgICAgd2Via2l0LXBhdGNoIHNob3Vs ZCBpbmNsdWRlIGEgdGVzdCBjb21tYW5kIHRoYXQgb25seSBydW5zIFJ1blRlc3RzLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM3NzUwCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtp dHB5L3Rvb2wvY29tbWFuZHMvZG93bmxvYWQucHk6CisgICAgICAgIEFkZHMgdGhlIHRlc3QgY29t bWFuZCB0byB3ZWJraXQtcGF0Y2guCisgICAgICAgIChUZXN0KToKKyAgICAgICAgRm9yY2VzIC0t dGVzdCB0byBiZSBUcnVlLgorICAgICAgICAoVGVzdC5fcHJlcGFyZV9zdGF0ZSk6CisKIDIwMTQt MTAtMTMgIERhdmlkIEZhcmxlciAgPGRmYXJsZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1Nd IExheW91dFRlc3RSZWxheTogRGV0ZWN0IGJyb2tlbiBwaXBlIHdoZW4gcmVhZGluZyBzaW11bGF0 b3IgYXBwJ3Mgc3Rkb3V0IGFuZCBzdGRlcnIuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L3Rvb2wvY29tbWFuZHMvZG93bmxvYWQucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L3Rvb2wvY29tbWFuZHMvZG93bmxvYWQucHkKaW5kZXggOTZmMDAyNi4uOTEwMjEyOSAxMDA2NDQK LS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL2Rvd25sb2FkLnB5Cisr KyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9kb3dubG9hZC5weQpAQCAt ODcsNiArODcsMTcgQEAgY2xhc3MgQnVpbGRBbmRUZXN0KEFic3RyYWN0U2VxdWVuY2VkQ29tbWFu ZCk6CiAgICAgXQogCiAKK2NsYXNzIFRlc3QoQWJzdHJhY3RTZXF1ZW5jZWRDb21tYW5kKToKKyAg ICBuYW1lID0gInRlc3QiCisgICAgaGVscF90ZXh0ID0gIlJ1biB0aGUgdGVzdHMiCisgICAgc3Rl cHMgPSBbCisgICAgICAgIHN0ZXBzLlJ1blRlc3RzLAorICAgIF0KKworICAgIGRlZiBfcHJlcGFy ZV9zdGF0ZShzZWxmLCBvcHRpb25zLCBhcmdzLCB0b29sKToKKyAgICAgICAgb3B0aW9ucy50ZXN0 ID0gVHJ1ZQorCisKIGNsYXNzIExhbmQoQWJzdHJhY3RTZXF1ZW5jZWRDb21tYW5kKToKICAgICBu YW1lID0gImxhbmQiCiAgICAgaGVscF90ZXh0ID0gIkxhbmQgdGhlIGN1cnJlbnQgd29ya2luZyBk aXJlY3RvcnkgZGlmZiBhbmQgdXBkYXRlcyB0aGUgYXNzb2NpYXRlZCBidWcgaWYgYW55IgotLSAK MS45LjMgKEFwcGxlIEdpdC01MCkKCg==