<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>137742</bug_id>
          
          <creation_ts>2014-10-15 08:29:06 -0700</creation_ts>
          <short_desc>[EFL] Utilize Eail library to support accessibility in EFL</short_desc>
          <delta_ts>2014-11-25 00:08:21 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit EFL</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>139037</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Krzysztof Czech">k.czech</reporter>
          <assigned_to name="Krzysztof Czech">k.czech</assigned_to>
          <cc>buildbot</cc>
    
    <cc>commit-queue</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>jinwoo7.song</cc>
    
    <cc>lucas.de.marchi</cc>
    
    <cc>ossy</cc>
    
    <cc>rniwa</cc>
    
    <cc>ryuan.choi</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1041856</commentid>
    <comment_count>0</comment_count>
    <who name="Krzysztof Czech">k.czech</who>
    <bug_when>2014-10-15 08:29:06 -0700</bug_when>
    <thetext>Enlightenment Accessibility Implementation Library (EAIL) is a component that makes EFL widgets accessible through so called &quot;accessibility stack&quot; in Linux.
Accessibility stack is made of three components ATK, ATK-BRIDGE, AT-SPI2 and having the last puzzle which is EAIL, EFL widgets are properly recognizable by AT clients such as Orca.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1041857</commentid>
    <comment_count>1</comment_count>
      <attachid>239873</attachid>
    <who name="Krzysztof Czech">k.czech</who>
    <bug_when>2014-10-15 08:51:11 -0700</bug_when>
    <thetext>Created attachment 239873
proposed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1041858</commentid>
    <comment_count>2</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-10-15 08:53:06 -0700</bug_when>
    <thetext>Attachment 239873 did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp:45:  _elm_win_list is incorrectly named. Don&apos;t use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1041859</commentid>
    <comment_count>3</comment_count>
    <who name="Krzysztof Czech">k.czech</who>
    <bug_when>2014-10-15 08:57:45 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; Attachment 239873 [details] did not pass style-queue:
&gt; 
&gt; 
&gt; ERROR: Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp:45:  _elm_win_list is incorrectly named. Don&apos;t use underscores in your identifier names.  [readability/naming/underscores] [4]
&gt; Total errors found: 1 in 7 files
&gt; 
&gt; 
&gt; If any of these errors are false positives, please file a bug against check-webkit-style.

Is something that comes from EAIL and should have underscores.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1041869</commentid>
    <comment_count>4</comment_count>
      <attachid>239873</attachid>
    <who name="Ryuan Choi">ryuan.choi</who>
    <bug_when>2014-10-15 09:35:38 -0700</bug_when>
    <thetext>Comment on attachment 239873
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239873&amp;action=review

&gt; Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp:43
&gt; +* It does not make any trouble to Eail, because WebKit does not deal with any eail widget.

I don&apos;t know what it means.

Does elementary depend on external instance(_elm_win_list) implicitly for ACCESSIBILITY?

&gt; Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp:46
&gt; +Eina_List* _elm_win_list = nullptr;
&gt; +

I think that code should be below of all includes.

&gt; Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp:48
&gt; +typedef int (*EailInitFunction)(void*);
&gt; +typedef int (*EailShutdownFunction)(void*);

Should we need two typedef?

&gt; Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp:52
&gt; +    static NeverDestroyed&lt;WebKit::Module&gt; eail(ACCESSIBILITY_EAIL_DIRECTORY&quot;/libeail-1.0.0.so&quot;);

And we need space between ACCESSIBILITY_EAIL_DIRECTORY and ...

&gt; Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp:123
&gt; +            if (EailInitFunction eailInitFunction = eail().functionPointer&lt;EailInitFunction&gt;(&quot;elm_modapi_init&quot;))

Although I don&apos;t have strong objection, the name(elm_xxx) looks not good.

&gt; Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp:124
&gt; +                eailInitFunction(0);

nullptr?

&gt; Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp:149
&gt; +            eailShutdownFunction(0);

Ditto.

&gt; Source/cmake/OptionsEfl.cmake:70
&gt; +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ACCESSIBILITY_EAIL_SUPPORT ON)

Should we need this macro?

In order to support ACCESSIBILITY in ewebkit, can we have another option?
If not, I think that we&apos;d better just to use ENABLE_ACCESSIBILITY.

&gt; Source/cmake/OptionsEfl.cmake:300
&gt; +        set(ACCESSIBILITY_EAIL_DIRECTORY &quot;${CMAKE_SOURCE_DIR}/WebKitBuild/Dependencies/Root/lib&quot;)
&gt; +        add_definitions(-DENABLE_ACCESSIBILITY_EAIL_SUPPORT=1)
&gt; +        add_definitions(-DACCESSIBILITY_EAIL_DIRECTORY=\&quot;${ACCESSIBILITY_EAIL_DIRECTORY}\&quot;)

We should find right path wherever eail is installed.
WebKitBuild directory is only for deverlopers who develop ewebkit without installation.

&gt; Tools/efl/jhbuild.modules:57
&gt; +    &lt;repository type=&quot;git&quot; name=&quot;github&quot;
&gt; +      href=&quot;https://github.com/czechk&quot;/&gt;

Can I know any plan to upstream eail to enlightenment?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1041977</commentid>
    <comment_count>5</comment_count>
    <who name="Krzysztof Czech">k.czech</who>
    <bug_when>2014-10-15 15:10:04 -0700</bug_when>
    <thetext>(In reply to comment #4)
&gt; (From update of attachment 239873 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=239873&amp;action=review
&gt; 
&gt; &gt; Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp:43
&gt; &gt; +* It does not make any trouble to Eail, because WebKit does not deal with any eail widget.
&gt; 
&gt; I don&apos;t know what it means.
Basically, setting this variable here to nullptr will not cause any problems in terms of loading eail later, so we are safe here.
&gt; 
&gt; Does elementary depend on external instance(_elm_win_list) implicitly for ACCESSIBILITY?
Well EAIL depends on external instance (_elm_win_list) that is defined in Elementary. So to not have undefined reference it needs to be defined here.
&gt; 
&gt; &gt; Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp:46
&gt; &gt; +Eina_List* _elm_win_list = nullptr;
&gt; &gt; +
&gt; 
&gt; I think that code should be below of all includes.
I guess here is more consistent place. There won&apos;t be any other place that&apos;ll deal with EAIL. 
&gt; 
&gt; &gt; Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp:48
&gt; &gt; +typedef int (*EailInitFunction)(void*);
&gt; &gt; +typedef int (*EailShutdownFunction)(void*);
&gt; 
&gt; Should we need two typedef?
&gt; 
&gt; &gt; Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp:52
&gt; &gt; +    static NeverDestroyed&lt;WebKit::Module&gt; eail(ACCESSIBILITY_EAIL_DIRECTORY&quot;/libeail-1.0.0.so&quot;);
&gt; 
&gt; And we need space between ACCESSIBILITY_EAIL_DIRECTORY and ...
&gt; 
&gt; &gt; Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp:123
&gt; &gt; +            if (EailInitFunction eailInitFunction = eail().functionPointer&lt;EailInitFunction&gt;(&quot;elm_modapi_init&quot;))
&gt; 
&gt; Although I don&apos;t have strong objection, the name(elm_xxx) looks not good.
That&apos;s how elementary modules work, they call elm_modapi_init/shutdown to load/shutdown modules while elm_init is called. I do not want to change it, because MiniBrowser may use it as well.
Basically loading EAIL should be transparent to the client application.
&gt; 
&gt; &gt; Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp:124
&gt; &gt; +                eailInitFunction(0);
&gt; 
&gt; nullptr?
Right
&gt; 
&gt; &gt; Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp:149
&gt; &gt; +            eailShutdownFunction(0);
&gt; 
&gt; Ditto.
Right
&gt; 
&gt; &gt; Source/cmake/OptionsEfl.cmake:70
&gt; &gt; +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ACCESSIBILITY_EAIL_SUPPORT ON)
&gt; 
&gt; Should we need this macro?
EAIL could be easily turner off.
&gt; 
&gt; In order to support ACCESSIBILITY in ewebkit, can we have another option?
&gt; If not, I think that we&apos;d better just to use ENABLE_ACCESSIBILITY.
There is already a global macro HAVE_ACCESSIBILITY. I could change it to ENABLE_ACCESSIBILITY
&gt; 
&gt; &gt; Source/cmake/OptionsEfl.cmake:300
&gt; &gt; +        set(ACCESSIBILITY_EAIL_DIRECTORY &quot;${CMAKE_SOURCE_DIR}/WebKitBuild/Dependencies/Root/lib&quot;)
&gt; &gt; +        add_definitions(-DENABLE_ACCESSIBILITY_EAIL_SUPPORT=1)
&gt; &gt; +        add_definitions(-DACCESSIBILITY_EAIL_DIRECTORY=\&quot;${ACCESSIBILITY_EAIL_DIRECTORY}\&quot;)
&gt; 
&gt; We should find right path wherever eail is installed.
&gt; WebKitBuild directory is only for deverlopers who develop ewebkit without installation.
Sounds reasonable any ideas where to put it.
&gt; 
&gt; &gt; Tools/efl/jhbuild.modules:57
&gt; &gt; +    &lt;repository type=&quot;git&quot; name=&quot;github&quot;
&gt; &gt; +      href=&quot;https://github.com/czechk&quot;/&gt;
&gt; 
&gt; Can I know any plan to upstream eail to enlightenment?
I wish I could not that either. I will try to get some info about it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1042050</commentid>
    <comment_count>6</comment_count>
      <attachid>239873</attachid>
    <who name="Ryuan Choi">ryuan.choi</who>
    <bug_when>2014-10-15 19:58:46 -0700</bug_when>
    <thetext>Comment on attachment 239873
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239873&amp;action=review

&gt;&gt;&gt; Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp:46
&gt;&gt;&gt; +
&gt;&gt; 
&gt;&gt; I think that code should be below of all includes.
&gt; 
&gt; I guess here is more consistent place. There won&apos;t be any other place that&apos;ll deal with EAIL.

I think that we&apos;d better to separate includes and codes,
although I can see that below ECORE_X related codes look also similar (I also feels not good).

&gt;&gt;&gt; Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp:48
&gt;&gt;&gt; +typedef int (*EailShutdownFunction)(void*);
&gt;&gt; 
&gt;&gt; Should we need two typedef?
&gt; 
&gt; That&apos;s how elementary modules work, they call elm_modapi_init/shutdown to load/shutdown modules while elm_init is called. I do not want to change it, because MiniBrowser may use it as well.
&gt; Basically loading EAIL should be transparent to the client application.

I means that we don&apos;t need to make two typedefs for instances which have same signatures.

&gt;&gt;&gt; Source/cmake/OptionsEfl.cmake:70
&gt;&gt;&gt; +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ACCESSIBILITY_EAIL_SUPPORT ON)
&gt;&gt; 
&gt;&gt; Should we need this macro?
&gt;&gt; 
&gt;&gt; In order to support ACCESSIBILITY in ewebkit, can we have another option?
&gt;&gt; If not, I think that we&apos;d better just to use ENABLE_ACCESSIBILITY.
&gt; 
&gt; EAIL could be easily turner off.

At least, this is only EFL specific. so we don&apos;t need to add it to WebKitFeatures.cmake.

And I want to kwnow whether only ACCESSIBILITY mode is meaningfull.
If not, we can turn off ACCESSIBILITY if eail is not available.
Or, we can check the existance of eail and enable it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1042098</commentid>
    <comment_count>7</comment_count>
    <who name="Krzysztof Czech">k.czech</who>
    <bug_when>2014-10-16 01:24:07 -0700</bug_when>
    <thetext>(In reply to comment #6)
&gt; (From update of attachment 239873 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=239873&amp;action=review
&gt; 
&gt; &gt;&gt;&gt; Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp:46
&gt; &gt;&gt;&gt; +
&gt; &gt;&gt; 
&gt; &gt;&gt; I think that code should be below of all includes.
&gt; &gt; 
&gt; &gt; I guess here is more consistent place. There won&apos;t be any other place that&apos;ll deal with EAIL.
&gt; 
&gt; I think that we&apos;d better to separate includes and codes,
&gt; although I can see that below ECORE_X related codes look also similar (I also feels not good).
Sounds good to me. I guess moving ECORE_* related could go in a separate patch.
&gt; 
&gt; &gt;&gt;&gt; Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp:48
&gt; &gt;&gt;&gt; +typedef int (*EailShutdownFunction)(void*);
&gt; &gt;&gt; 
&gt; &gt;&gt; Should we need two typedef?
&gt; &gt; 
&gt; &gt; That&apos;s how elementary modules work, they call elm_modapi_init/shutdown to load/shutdown modules while elm_init is called. I do not want to change it, because MiniBrowser may use it as well.
&gt; &gt; Basically loading EAIL should be transparent to the client application.
&gt; 
&gt; I means that we don&apos;t need to make two typedefs for instances which have same signatures.
Yes, I agree you are right, thanks.
&gt; 
&gt; &gt;&gt;&gt; Source/cmake/OptionsEfl.cmake:70
&gt; &gt;&gt;&gt; +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ACCESSIBILITY_EAIL_SUPPORT ON)
&gt; &gt;&gt; 
&gt; &gt;&gt; Should we need this macro?
&gt; &gt;&gt; 
&gt; &gt;&gt; In order to support ACCESSIBILITY in ewebkit, can we have another option?
&gt; &gt;&gt; If not, I think that we&apos;d better just to use ENABLE_ACCESSIBILITY.
&gt; &gt; 
&gt; &gt; EAIL could be easily turner off.
&gt; 
&gt; At least, this is only EFL specific. so we don&apos;t need to add it to WebKitFeatures.cmake.
Ok.
&gt; 
&gt; And I want to kwnow whether only ACCESSIBILITY mode is meaningfull.
&gt; If not, we can turn off ACCESSIBILITY if eail is not available.
&gt; Or, we can check the existance of eail and enable it.
Yes, I guess you might have right. Well EAIL seems as a final puzzle to have Accessibility stack working properly in EFL. In the other hand core Accessibility could leave without EAIL and can be easily verified by running LayoutTests. I think we could try only with HAVE_ACCESSIBILITY.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1042809</commentid>
    <comment_count>8</comment_count>
    <who name="Krzysztof Czech">k.czech</who>
    <bug_when>2014-10-20 07:43:35 -0700</bug_when>
    <thetext>&gt; &gt; Source/cmake/OptionsEfl.cmake:300
&gt; &gt; +        set(ACCESSIBILITY_EAIL_DIRECTORY &quot;${CMAKE_SOURCE_DIR}/WebKitBuild/Dependencies/Root/lib&quot;)
&gt; &gt; +        add_definitions(-DENABLE_ACCESSIBILITY_EAIL_SUPPORT=1)
&gt; &gt; +        add_definitions(-DACCESSIBILITY_EAIL_DIRECTORY=\&quot;${ACCESSIBILITY_EAIL_DIRECTORY}\&quot;)
&gt; 
&gt; We should find right path wherever eail is installed.
&gt; WebKitBuild directory is only for deverlopers who develop ewebkit without
&gt; installation.
&gt;
Do you think we could set this path through environment variable and let the user to build it yourself ?. It is publicly available.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1043056</commentid>
    <comment_count>9</comment_count>
    <who name="Ryuan Choi">ryuan.choi</who>
    <bug_when>2014-10-20 18:40:15 -0700</bug_when>
    <thetext>(In reply to comment #8)
&gt; &gt; &gt; Source/cmake/OptionsEfl.cmake:300
&gt; &gt; &gt; +        set(ACCESSIBILITY_EAIL_DIRECTORY &quot;${CMAKE_SOURCE_DIR}/WebKitBuild/Dependencies/Root/lib&quot;)
&gt; &gt; &gt; +        add_definitions(-DENABLE_ACCESSIBILITY_EAIL_SUPPORT=1)
&gt; &gt; &gt; +        add_definitions(-DACCESSIBILITY_EAIL_DIRECTORY=\&quot;${ACCESSIBILITY_EAIL_DIRECTORY}\&quot;)
&gt; &gt; 
&gt; &gt; We should find right path wherever eail is installed.
&gt; &gt; WebKitBuild directory is only for deverlopers who develop ewebkit without
&gt; &gt; installation.
&gt; &gt;
&gt; Do you think we could set this path through environment variable and let the
&gt; user to build it yourself ?. It is publicly available.

Does EAIL provide any information for it?
Like eail.pc? or something which pkg-config or CMakeConfig can read.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1043143</commentid>
    <comment_count>10</comment_count>
    <who name="Krzysztof Czech">k.czech</who>
    <bug_when>2014-10-21 01:30:58 -0700</bug_when>
    <thetext>(In reply to comment #9)
&gt; (In reply to comment #8)
&gt; &gt; &gt; &gt; Source/cmake/OptionsEfl.cmake:300
&gt; &gt; &gt; &gt; +        set(ACCESSIBILITY_EAIL_DIRECTORY &quot;${CMAKE_SOURCE_DIR}/WebKitBuild/Dependencies/Root/lib&quot;)
&gt; &gt; &gt; &gt; +        add_definitions(-DENABLE_ACCESSIBILITY_EAIL_SUPPORT=1)
&gt; &gt; &gt; &gt; +        add_definitions(-DACCESSIBILITY_EAIL_DIRECTORY=\&quot;${ACCESSIBILITY_EAIL_DIRECTORY}\&quot;)
&gt; &gt; &gt; 
&gt; &gt; &gt; We should find right path wherever eail is installed.
&gt; &gt; &gt; WebKitBuild directory is only for deverlopers who develop ewebkit without
&gt; &gt; &gt; installation.
&gt; &gt; &gt;
&gt; &gt; Do you think we could set this path through environment variable and let the
&gt; &gt; user to build it yourself ?. It is publicly available.
&gt; 
&gt; Does EAIL provide any information for it?
&gt; Like eail.pc? or something which pkg-config or CMakeConfig can read.
 Yes, it does provide a .pc file</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1046469</commentid>
    <comment_count>11</comment_count>
      <attachid>241027</attachid>
    <who name="Krzysztof Czech">k.czech</who>
    <bug_when>2014-11-05 08:23:06 -0800</bug_when>
    <thetext>Created attachment 241027
proposed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1046470</commentid>
    <comment_count>12</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-11-05 08:25:21 -0800</bug_when>
    <thetext>Attachment 241027 did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp:44:  _elm_win_list is incorrectly named. Don&apos;t use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1046749</commentid>
    <comment_count>13</comment_count>
    <who name="Krzysztof Czech">k.czech</who>
    <bug_when>2014-11-06 00:21:08 -0800</bug_when>
    <thetext>(In reply to comment #12)
&gt; Attachment 241027 [details] did not pass style-queue:
&gt; 
&gt; 
&gt; ERROR: Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp:44: 
&gt; _elm_win_list is incorrectly named. Don&apos;t use underscores in your identifier
&gt; names.  [readability/naming/underscores] [4]
&gt; Total errors found: 1 in 4 files
&gt; 
&gt; 
&gt; If any of these errors are false positives, please file a bug against
&gt; check-webkit-style.
It&apos;s something that comes from EAIL and should have underscores.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1046750</commentid>
    <comment_count>14</comment_count>
    <who name="Krzysztof Czech">k.czech</who>
    <bug_when>2014-11-06 00:22:06 -0800</bug_when>
    <thetext>gyuyoung, ryuan any comments, review ?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1049148</commentid>
    <comment_count>15</comment_count>
      <attachid>241027</attachid>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2014-11-17 01:28:47 -0800</bug_when>
    <thetext>Comment on attachment 241027
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241027&amp;action=review

&gt; Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp:41
&gt; +* This should be defined and filled in elementary but to avoid undefined reference it&apos;s defined here.

Wrong indentation and use.

&gt; Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp:55
&gt; +    static NeverDestroyed&lt;WebKit::Module&gt; eail(eailLibraryPath());

Don&apos;t you need to check if eailLibraryPath() is null ?

&gt; Tools/ChangeLog:8
&gt; +        Eail, atk-bridge, at-spi2 are not mandatory modules for webkit-efl. They are rather optional.

I wonder how is this file used for us. jhbuild.module will call this file ?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1049436</commentid>
    <comment_count>16</comment_count>
    <who name="Krzysztof Czech">k.czech</who>
    <bug_when>2014-11-18 02:49:44 -0800</bug_when>
    <thetext>(In reply to comment #15)
&gt; Comment on attachment 241027 [details]
&gt; proposed patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=241027&amp;action=review
&gt; 
&gt; &gt; Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp:41
&gt; &gt; +* This should be defined and filled in elementary but to avoid undefined reference it&apos;s defined here.
&gt; 
&gt; Wrong indentation and use.
Thanks
&gt; 
&gt; &gt; Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp:55
&gt; &gt; +    static NeverDestroyed&lt;WebKit::Module&gt; eail(eailLibraryPath());
&gt; 
&gt; Don&apos;t you need to check if eailLibraryPath() is null ?
I do not need it. Result of eailLibraryPath is forwarded directly to Module&apos;s constructor that expects a String. It could be null value, then Module&apos;s load method will take care whether Eina_Module is null or not. Later I&apos;m checking whether load() is ok or not.
&gt; 
&gt; &gt; Tools/ChangeLog:8
&gt; &gt; +        Eail, atk-bridge, at-spi2 are not mandatory modules for webkit-efl. They are rather optional.
&gt; 
&gt; I wonder how is this file used for us. jhbuild.module will call this file ?
I forgot to add a part that modifies jhbuild.modules that includes *optional file.
Basically jhbuild will not use it in regular updates. It should be called on demand by the user to test Accessibility.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1049437</commentid>
    <comment_count>17</comment_count>
      <attachid>241775</attachid>
    <who name="Krzysztof Czech">k.czech</who>
    <bug_when>2014-11-18 02:54:23 -0800</bug_when>
    <thetext>Created attachment 241775
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1049438</commentid>
    <comment_count>18</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-11-18 02:56:55 -0800</bug_when>
    <thetext>Attachment 241775 did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp:44:  _elm_win_list is incorrectly named. Don&apos;t use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1049439</commentid>
    <comment_count>19</comment_count>
    <who name="Krzysztof Czech">k.czech</who>
    <bug_when>2014-11-18 02:58:06 -0800</bug_when>
    <thetext>Thanks Gyuyoung for the review. I corrected my patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1049661</commentid>
    <comment_count>20</comment_count>
      <attachid>241775</attachid>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2014-11-18 16:58:43 -0800</bug_when>
    <thetext>Comment on attachment 241775
patch

LGTM</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1050833</commentid>
    <comment_count>21</comment_count>
      <attachid>241775</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-11-24 03:30:40 -0800</bug_when>
    <thetext>Comment on attachment 241775
patch

Clearing flags on attachment: 241775

Committed r176514: &lt;http://trac.webkit.org/changeset/176514&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1050834</commentid>
    <comment_count>22</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-11-24 03:30:45 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1050881</commentid>
    <comment_count>23</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2014-11-24 12:54:55 -0800</bug_when>
    <thetext>(In reply to comment #21)
&gt; Comment on attachment 241775 [details]
&gt; patch
&gt; 
&gt; Clearing flags on attachment: 241775
&gt; 
&gt; Committed r176514: &lt;http://trac.webkit.org/changeset/176514&gt;

It made all performance tests fail:
lib/eina/eina_module.c:273 eina_module_new() safety check failed: len &gt; 0 is false

Is EAIL optional or not? If it is needed to have a working WebKit,
we should add it non-optional (mandatory) jhbuild module. If it
is really optional, there is a bug near r176514.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1050910</commentid>
    <comment_count>24</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2014-11-24 16:04:52 -0800</bug_when>
    <thetext>new bug report to fix it: bug139037</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1050958</commentid>
    <comment_count>25</comment_count>
    <who name="Krzysztof Czech">k.czech</who>
    <bug_when>2014-11-25 00:08:21 -0800</bug_when>
    <thetext>(In reply to comment #23)
&gt; (In reply to comment #21)
&gt; &gt; Comment on attachment 241775 [details]
&gt; &gt; patch
&gt; &gt; 
&gt; &gt; Clearing flags on attachment: 241775
&gt; &gt; 
&gt; &gt; Committed r176514: &lt;http://trac.webkit.org/changeset/176514&gt;
&gt; 
&gt; It made all performance tests fail:
&gt; lib/eina/eina_module.c:273 eina_module_new() safety check failed: len &gt; 0 is
&gt; false
&gt; 
&gt; Is EAIL optional or not? If it is needed to have a working WebKit,
&gt; we should add it non-optional (mandatory) jhbuild module. If it
&gt; is really optional, there is a bug near r176514.

Thanks I thought eina_module_new does nothing in case of 0 length path.
EAIL is optional that&apos;s way I added it to jhbuild-optional.modules</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>239873</attachid>
            <date>2014-10-15 08:51:11 -0700</date>
            <delta_ts>2014-11-05 08:23:06 -0800</delta_ts>
            <desc>proposed patch</desc>
            <filename>eail.patch</filename>
            <type>text/plain</type>
            <size>7738</size>
            <attacher name="Krzysztof Czech">k.czech</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAzYWJlZTVlLi4zYWJlMjFj
IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAK
KzIwMTQtMTAtMTUgIEtyenlzenRvZiBDemVjaCAgPGsuY3plY2hAc2Ftc3VuZy5jb20+CisKKyAg
ICAgICAgW0VGTF0gVXRpbGl6ZSBFYWlsIGxpYnJhcnkgdG8gc3VwcG9ydCBhY2Nlc3NpYmlsaXR5
IGluIEVGTAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9
MTM3NzQyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg
QWRkIHByb3BlciBmbGFnIHRvIGhlbHAgcXVpY2tseSB0dXJuaW5nIG9mZiBFQUlMLgorICAgICAg
ICBBZGQgcGF0aCB0byBFQUlMIGxpYnJhcnkuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0
aW9uc0VmbC5jbWFrZToKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVyZXMuY21h
a2U6CisKIDIwMTQtMTAtMTEgIEt3YW5nSHl1ayBLaW0gIDxoeXVraS5raW1Ac2Ftc3VuZy5jb20+
CiAKICAgICAgICAgW0VGTF0gRW5hYmxlIFdlYlAgc3VwcG9ydC4KZGlmZiAtLWdpdCBhL1NvdXJj
ZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCBiYWJm
MjgxLi5lZTM1MmVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIv
U291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTQtMTAtMTUgIEty
enlzenRvZiBDemVjaCAgPGsuY3plY2hAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gVXRp
bGl6ZSBFYWlsIGxpYnJhcnkgdG8gc3VwcG9ydCBhY2Nlc3NpYmlsaXR5IGluIEVGTAorICAgICAg
ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM3NzQyCisKKyAgICAg
ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW5pdGlhbGl6ZSBFQUlM
IG1vZHVsZSBzbyB0aGF0IGFsbCB0aGUgbGlzdGVuZXJzIGFuZCBhdGstYnJpZGdlIHN0YXJ0ZWQg
cHJvcGVybHkuCisgICAgICAgIER5bmFtaWMgbG9hZGluZyBvZiBFQUlMIGhlbHAgdXMgdG8gYXZv
aWQgZWxlbWVudGFyeSBkZXBlbmRlbmNpZXMgaW4gV2ViS2l0LgorCisgICAgICAgICogV2ViUHJv
Y2Vzcy9lZmwvV2ViUHJvY2Vzc01haW5FZmwuY3BwOgorICAgICAgICAoZWFpbCk6CisKIDIwMTQt
MTAtMTIgIFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CiAKICAgICAg
ICAgW1NPVVBdIFtXSzJdIFdlYlByb2Nlc3MgYW5kIE5ldHdvcmtQcm9jZXNzIGluaXRpYWxpemF0
aW9uIGNsZWFycyBjYWNoZSBjb250ZW50cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2Vi
UHJvY2Vzcy9lZmwvV2ViUHJvY2Vzc01haW5FZmwuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJv
Y2Vzcy9lZmwvV2ViUHJvY2Vzc01haW5FZmwuY3BwCmluZGV4IDUyZDBhY2MuLmY2ODk1NjAgMTAw
NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvZWZsL1dlYlByb2Nlc3NNYWluRWZs
LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL2VmbC9XZWJQcm9jZXNzTWFpbkVm
bC5jcHAKQEAgLTM1LDYgKzM1LDI1IEBACiAjaW5jbHVkZSA8V2ViQ29yZS9Tb3VwTmV0d29ya1Nl
c3Npb24uaD4KICNpbmNsdWRlIDxsaWJzb3VwL3NvdXAuaD4KIAorI2lmIEhBVkUoQUNDRVNTSUJJ
TElUWSkgJiYgRU5BQkxFKEFDQ0VTU0lCSUxJVFlfRUFJTF9TVVBQT1JUKQorI2luY2x1ZGUgIk1v
ZHVsZS5oIgorCisvKgorKiBUaGlzIHNob3VsZCBiZSBkZWZpbmVkIGFuZCBmaWxsZWQgaW4gZWxl
bWVudGFyeSBidXQgdG8gYXZvaWQgdW5kZWZpbmVkIHJlZmVyZW5jZSBpdCdzIGRlZmluZWQgaGVy
ZS4KKyogSXQgZG9lcyBub3QgbWFrZSBhbnkgdHJvdWJsZSB0byBFYWlsLCBiZWNhdXNlIFdlYktp
dCBkb2VzIG5vdCBkZWFsIHdpdGggYW55IGVhaWwgd2lkZ2V0LgorKi8KK0VpbmFfTGlzdCogX2Vs
bV93aW5fbGlzdCA9IG51bGxwdHI7CisKK3R5cGVkZWYgaW50ICgqRWFpbEluaXRGdW5jdGlvbiko
dm9pZCopOwordHlwZWRlZiBpbnQgKCpFYWlsU2h1dGRvd25GdW5jdGlvbikodm9pZCopOworCitz
dGF0aWMgV2ViS2l0OjpNb2R1bGUmIGVhaWwoKQoreworICAgIHN0YXRpYyBOZXZlckRlc3Ryb3ll
ZDxXZWJLaXQ6Ok1vZHVsZT4gZWFpbChBQ0NFU1NJQklMSVRZX0VBSUxfRElSRUNUT1JZIi9saWJl
YWlsLTEuMC4wLnNvIik7CisgICAgcmV0dXJuIGVhaWw7Cit9CisjZW5kaWYKKwogI2lmZGVmIEhB
VkVfRUNPUkVfWAogI2luY2x1ZGUgPEVjb3JlX1guaD4KICNpbmNsdWRlIDxYMTEvWGxpYi5oPgpA
QCAtOTgsNiArMTE3LDE0IEBAIHB1YmxpYzoKICAgICAgICAgaWYgKCFlY29yZV9tYWluX2xvb3Bf
Z2xpYl9pbnRlZ3JhdGUoKSkKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKIAorI2lmIEhBVkUo
QUNDRVNTSUJJTElUWSkgJiYgRU5BQkxFKEFDQ0VTU0lCSUxJVFlfRUFJTF9TVVBQT1JUKQorICAg
ICAgICAvLyBJbml0aWFsaXplIEVBSUwgbW9kdWxlIChhZGRpbmcgbGlzdGVuZXJzLCBpbml0IGF0
ay1icmlkZ2UpCisgICAgICAgIGlmIChlYWlsKCkubG9hZCgpKSB7CisgICAgICAgICAgICBpZiAo
RWFpbEluaXRGdW5jdGlvbiBlYWlsSW5pdEZ1bmN0aW9uID0gZWFpbCgpLmZ1bmN0aW9uUG9pbnRl
cjxFYWlsSW5pdEZ1bmN0aW9uPigiZWxtX21vZGFwaV9pbml0IikpCisgICAgICAgICAgICAgICAg
ZWFpbEluaXRGdW5jdGlvbigwKTsKKyAgICAgICAgfQorI2VuZGlmCisKICAgICAgICAgU291cE5l
dHdvcmtTZXNzaW9uOjpkZWZhdWx0U2Vzc2lvbigpLnNldHVwSFRUUFByb3h5RnJvbUVudmlyb25t
ZW50KCk7CiAgICAgICAgIHJldHVybiB0cnVlOwogICAgIH0KQEAgLTExNiw2ICsxNDMsMTEgQEAg
cHVibGljOgogI2VuZGlmCiAgICAgICAgIGVjb3JlX3NodXRkb3duKCk7CiAgICAgICAgIGVpbmFf
c2h1dGRvd24oKTsKKworI2lmIEhBVkUoQUNDRVNTSUJJTElUWSkgJiYgRU5BQkxFKEFDQ0VTU0lC
SUxJVFlfRUFJTF9TVVBQT1JUKQorICAgICAgICBpZiAoRWFpbFNodXRkb3duRnVuY3Rpb24gZWFp
bFNodXRkb3duRnVuY3Rpb24gPSBlYWlsKCkuZnVuY3Rpb25Qb2ludGVyPEVhaWxTaHV0ZG93bkZ1
bmN0aW9uPigiZWxtX21vZGFwaV9zaHV0ZG93biIpKQorICAgICAgICAgICAgZWFpbFNodXRkb3du
RnVuY3Rpb24oMCk7CisjZW5kaWYKICAgICB9CiB9OwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21h
a2UvT3B0aW9uc0VmbC5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCmluZGV4
IGMwODM2ZmMuLjNiODZiODEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNt
YWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCkBAIC02Nyw2ICs2Nyw3IEBA
IGVuZGlmICgpCiAKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV8zRF9S
RU5ERVJJTkcgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfQUND
RVNTSUJJTElUWSBPTikKK1dFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9B
Q0NFU1NJQklMSVRZX0VBSUxfU1VQUE9SVCBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JU
X1ZBTFVFKEVOQUJMRV9CQVRURVJZX1NUQVRVUyBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9Q
T1JUX1ZBTFVFKEVOQUJMRV9DU1MzX1RFWFQgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9S
VF9WQUxVRShFTkFCTEVfQ1NTX0RFVklDRV9BREFQVEFUSU9OIE9OKQpAQCAtMjkzLDYgKzI5NCwx
MSBAQCBpZiAoRU5BQkxFX1NQRUxMQ0hFQ0spCiBlbmRpZiAoKQogCiBpZiAoRU5BQkxFX0FDQ0VT
U0lCSUxJVFkpCisgICAgaWYgKEVOQUJMRV9BQ0NFU1NJQklMSVRZX0VBSUxfU1VQUE9SVCkKKyAg
ICAgICAgc2V0KEFDQ0VTU0lCSUxJVFlfRUFJTF9ESVJFQ1RPUlkgIiR7Q01BS0VfU09VUkNFX0RJ
Un0vV2ViS2l0QnVpbGQvRGVwZW5kZW5jaWVzL1Jvb3QvbGliIikKKyAgICAgICAgYWRkX2RlZmlu
aXRpb25zKC1ERU5BQkxFX0FDQ0VTU0lCSUxJVFlfRUFJTF9TVVBQT1JUPTEpCisgICAgICAgIGFk
ZF9kZWZpbml0aW9ucygtREFDQ0VTU0lCSUxJVFlfRUFJTF9ESVJFQ1RPUlk9XCIke0FDQ0VTU0lC
SUxJVFlfRUFJTF9ESVJFQ1RPUll9XCIpCisgICAgZW5kaWYgKCkKICAgICBmaW5kX3BhY2thZ2Uo
QVRLIDIuMTAuMCBSRVFVSVJFRCkKIGVsc2UgKCkKICAgICBhZGRfZGVmaW5pdGlvbnMoLURIQVZF
X0FDQ0VTU0lCSUxJVFk9MCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJl
cy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFrZQppbmRleCAxOWEwOTg3
Li4wNjJmYzY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVyZXMuY21ha2UK
KysrIGIvU291cmNlL2NtYWtlL1dlYktpdEZlYXR1cmVzLmNtYWtlCkBAIC0xOSw2ICsxOSw3IEBA
IG1hY3JvKFdFQktJVF9PUFRJT05fQkVHSU4pCiAgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5B
QkxFX0FDQ0VMRVJBVEVEXzJEX0NBTlZBUyAiVG9nZ2xlIGFjY2VsZXJhdGVkIDJEIGNhbnZhcyBz
dXBwb3J0IiBPRkYpCiAgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX0FDQ0VMRVJBVEVE
X09WRVJGTE9XX1NDUk9MTElORyAiVG9nZ2xlIGFjY2VsZXJhdGVkIHNjcm9sbGluZyBzdXBwb3J0
IiBPRkYpCiAgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX0FDQ0VTU0lCSUxJVFkgIlRv
Z2dsZSBhY2Nlc3NpYmlsaXR5IHN1cHBvcnQiIE9GRikKKyAgICBXRUJLSVRfT1BUSU9OX0RFRklO
RShFTkFCTEVfQUNDRVNTSUJJTElUWV9FQUlMX1NVUFBPUlQgIlRvb2dsZSBhY2Nlc3NpYmlsaXR5
IGVhaWwgc3VwcG9ydCIgT0ZGKQogICAgIFdFQktJVF9PUFRJT05fREVGSU5FKEVOQUJMRV9BUElf
VEVTVFMgIkVuYWJsZSBwdWJsaWMgQVBJIHVuaXQgdGVzdHMiIE9GRikKICAgICBXRUJLSVRfT1BU
SU9OX0RFRklORShFTkFCTEVfQVZGX0NBUFRJT05TICJUb2dnbGUgQVZGb3VuZGF0aW9uIGNhcHRp
b24gc3VwcG9ydCIgT0ZGKQogICAgIFdFQktJVF9PUFRJT05fREVGSU5FKEVOQUJMRV9BU1NFTUJM
RVJfV1hfRVhDTFVTSVZFICJUb2dnbGUgQXNzZW1ibGVyIFdYIEV4Y2x1c2l2ZSBzdXBwb3J0IiBP
RkYpCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXgg
YmFlYWY2YS4uOWVmYjZkYiAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xz
L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE0LTEwLTE1ICBLcnp5c3p0b2YgQ3plY2gg
IDxrLmN6ZWNoQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdIFV0aWxpemUgRWFpbCBsaWJy
YXJ5IHRvIHN1cHBvcnQgYWNjZXNzaWJpbGl0eSBpbiBFRkwKKyAgICAgICAgaHR0cHM6Ly9idWdz
LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNzc0MgorCisgICAgICAgIFJldmlld2VkIGJ5
IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGVkIG5ldyBtb2R1bGVzIChFQUlMLCBhdC1z
cGkyLWF0aywgYXQtc3BpMi1jb3JlKSB0byBqaGJ1aWxkLgorCisgICAgICAgICogZWZsL2poYnVp
bGQubW9kdWxlczoKKwogMjAxNC0xMC0xMiAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFw
cGxlLmNvbT4KIAogICAgICAgICBQYWdlIG5vdCBmdWxseSByZW5kZXJlZCBpbiBpT1MgRFJUIHNu
YXBzaG90cwpkaWZmIC0tZ2l0IGEvVG9vbHMvZWZsL2poYnVpbGQubW9kdWxlcyBiL1Rvb2xzL2Vm
bC9qaGJ1aWxkLm1vZHVsZXMKaW5kZXggYTMwNjVkMi4uMmM4ZTc0OSAxMDA2NDQKLS0tIGEvVG9v
bHMvZWZsL2poYnVpbGQubW9kdWxlcworKysgYi9Ub29scy9lZmwvamhidWlsZC5tb2R1bGVzCkBA
IC0yMiw3ICsyMiwxMCBAQAogICAgICAgPGRlcCBwYWNrYWdlPSJnc3QtcGx1Z2lucy1iYWQiLz4K
ICAgICAgIDxkZXAgcGFja2FnZT0iZ3N0LWxpYmF2Ii8+CiAgICAgICA8ZGVwIHBhY2thZ2U9Imxp
YnNlY2NvbXAiLz4KKyAgICAgIDxkZXAgcGFja2FnZT0iYXQtc3BpMi1jb3JlIi8+CisgICAgICA8
ZGVwIHBhY2thZ2U9ImF0LXNwaTItYXRrIi8+CiAgICAgICA8ZGVwIHBhY2thZ2U9ImF0ayIvPgor
ICAgICAgPGRlcCBwYWNrYWdlPSJlYWlsIi8+CiAgICAgPC9kZXBlbmRlbmNpZXM+CiAgIDwvbWV0
YW1vZHVsZT4KIApAQCAtNTAsNiArNTMsOCBAQAogICAgICAgaHJlZj0iaHR0cDovL2Rvd25sb2Fk
cy5zb3VyY2Vmb3JnZS5uZXQvcHJvamVjdC8iLz4KICAgPHJlcG9zaXRvcnkgdHlwZT0iZ2l0IiBu
YW1lPSJsbHZtLm9yZyIKICAgICAgIGhyZWY9Imh0dHBzOi8vZ2l0aHViLmNvbS9waWxsZTUiLz4K
KyAgICA8cmVwb3NpdG9yeSB0eXBlPSJnaXQiIG5hbWU9ImdpdGh1YiIKKyAgICAgIGhyZWY9Imh0
dHBzOi8vZ2l0aHViLmNvbS9jemVjaGsiLz4KIAogICA8YXV0b3Rvb2xzIGlkPSJjYWlybyIgYXV0
b2dlbi1zaD0iY29uZmlndXJlIgogICAgICAgICAgICAgIG1ha2VhcmdzPSJDRkxBR1M9Jy1mbm8t
bHRvJyBDWFhGTEFHUz0nLWZuby1sdG8nIExERkxBR1M9Jy1mbm8tbHRvJyI+CkBAIC0yODMsNCAr
Mjg4LDMyIEBACiAgICAgPC9kZXBlbmRlbmNpZXM+CiAgIDwvYXV0b3Rvb2xzPgogCisgIDxhdXRv
dG9vbHMgaWQ9ImF0LXNwaTItY29yZSIKKyAgICAgICAgICAgIGF1dG9nZW5hcmdzPSItLWRpc2Fi
bGUtaW50cm9zcGVjdGlvbiI+CisgICAgPGJyYW5jaCBtb2R1bGU9InB1Yi9HTk9NRS9zb3VyY2Vz
L2F0LXNwaTItY29yZS8yLjEwL2F0LXNwaTItY29yZS0yLjEwLjAudGFyLnh6IiB2ZXJzaW9uPSIy
LjEwLjAiCisgICAgICAgICAgICByZXBvPSJmdHAuZ25vbWUub3JnIgorICAgICAgICAgICAgaGFz
aD0ic2hhMjU2Ojk2NDE1NWM3NTc0MjIwYTAwZTExZTFjMGQ5MWYyZDMwMTdlZDYwMzkyMGViMTMz
M2ZmOWNiZGI2YTIyNzQ0ZGIiPgorICAgIDwvYnJhbmNoPgorICAgIDxkZXBlbmRlbmNpZXM+Cisg
ICAgICAgIDxkZXAgcGFja2FnZT0iZ2xpYiIvPgorICAgIDwvZGVwZW5kZW5jaWVzPgorICA8L2F1
dG90b29scz4KKworICA8YXV0b3Rvb2xzIGlkPSJhdC1zcGkyLWF0ayI+CisgICAgPGJyYW5jaCBt
b2R1bGU9InB1Yi9HTk9NRS9zb3VyY2VzL2F0LXNwaTItYXRrLzIuMTAvYXQtc3BpMi1hdGstMi4x
MC4wLnRhci54eiIgdmVyc2lvbj0iMi4xMC4wIgorICAgICAgICAgICAgcmVwbz0iZnRwLmdub21l
Lm9yZyIKKyAgICAgICAgICAgIGhhc2g9InNoYTI1NjpkZWE3ZmYyZjliYzliYmRiMDM1MTExMjYx
NmQ3MzhkZTcxOGI1NTczOWNkMjUxMWFmZWNhYzUxNjA0YzMxYTk0Ij4KKyAgICA8L2JyYW5jaD4K
KyAgICA8ZGVwZW5kZW5jaWVzPgorICAgICAgICA8ZGVwIHBhY2thZ2U9ImdsaWIiLz4KKyAgICAg
ICAgPGRlcCBwYWNrYWdlPSJhdGsiLz4KKyAgICAgICAgPGRlcCBwYWNrYWdlPSJhdC1zcGkyLWNv
cmUiLz4KKyAgICA8L2RlcGVuZGVuY2llcz4KKyAgICA8L2F1dG90b29scz4KKworICA8YXV0b3Rv
b2xzIGlkPSJlYWlsIgorICAgICAgICAgICAgIGF1dG9nZW4tc2g9ImF1dG9nZW4uc2giPgorICAg
IDxicmFuY2ggcmVwbz0iZ2l0aHViIiBtb2R1bGU9ImVhaWwuZ2l0IiBjaGVja291dGRpcj0iZWFp
bC0xLjAuMCIvPgorICA8L2F1dG90b29scz4KKwogPC9tb2R1bGVzZXQ+Cg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>241027</attachid>
            <date>2014-11-05 08:23:06 -0800</date>
            <delta_ts>2014-11-18 02:54:23 -0800</delta_ts>
            <desc>proposed patch</desc>
            <filename>a11y-illume-access.patch</filename>
            <type>text/plain</type>
            <size>4763</size>
            <attacher name="Krzysztof Czech">k.czech</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No
YW5nZUxvZwppbmRleCA5Yzc2MmUyLi42ZGM2Y2NmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0
Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg
QEAKKzIwMTQtMTEtMDUgIEtyenlzenRvZiBDemVjaCAgPGsuY3plY2hAc2Ftc3VuZy5jb20+CisK
KyAgICAgICAgW0VGTF0gVXRpbGl6ZSBFYWlsIGxpYnJhcnkgdG8gc3VwcG9ydCBhY2Nlc3NpYmls
aXR5IGluIEVGTAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/
aWQ9MTM3NzQyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg
ICAgSW5pdGlhbGl6ZSBFQUlMIG1vZHVsZSBzbyB0aGF0IGFsbCB0aGUgbGlzdGVuZXJzIGFuZCBh
dGstYnJpZGdlIHN0YXJ0ZWQgcHJvcGVybHkuCisgICAgICAgIER5bmFtaWMgbG9hZGluZyBvZiBF
QUlMIGhlbHAgdXMgdG8gYXZvaWQgZWxlbWVudGFyeSBkZXBlbmRlbmNpZXMgaW4gV2ViS2l0Lgor
CisgICAgICAgICogV2ViUHJvY2Vzcy9lZmwvV2ViUHJvY2Vzc01haW5FZmwuY3BwOgorICAgICAg
ICAoZWFpbExpYnJhcnlQYXRoKTogcmVhZHMgcGF0aCBwcm92aWRlZCBieSBBQ0NFU1NJQklMSVRZ
X0VBSUxfTElCUkFSWV9QQVRIIHZhcmlhYmxlLgorICAgICAgICAoZWFpbCk6CisKIDIwMTQtMTEt
MDMgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQGdtYWlsLmNvbT4KIAogICAgICAgICBbRUZMXSBS
ZW1vdmUgZGVwZW5kZW5jeSBvZiBQYWdlVmlld3BvcnRDb250cm9sbGVyIGZyb20gUGFnZVZpZXdw
b3J0Q29udHJvbGxlckNsaWVudApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz
cy9lZmwvV2ViUHJvY2Vzc01haW5FZmwuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9l
ZmwvV2ViUHJvY2Vzc01haW5FZmwuY3BwCmluZGV4IDUyZDBhY2MuLjk5NzY0OWIgMTAwNjQ0Ci0t
LSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvZWZsL1dlYlByb2Nlc3NNYWluRWZsLmNwcAor
KysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL2VmbC9XZWJQcm9jZXNzTWFpbkVmbC5jcHAK
QEAgLTM1LDYgKzM1LDI4IEBACiAjaW5jbHVkZSA8V2ViQ29yZS9Tb3VwTmV0d29ya1Nlc3Npb24u
aD4KICNpbmNsdWRlIDxsaWJzb3VwL3NvdXAuaD4KIAorI2lmIEhBVkUoQUNDRVNTSUJJTElUWSkK
KyNpbmNsdWRlICJNb2R1bGUuaCIKKy8qCisqIFRoaXMgc2hvdWxkIGJlIGRlZmluZWQgYW5kIGZp
bGxlZCBpbiBlbGVtZW50YXJ5IGJ1dCB0byBhdm9pZCB1bmRlZmluZWQgcmVmZXJlbmNlIGl0J3Mg
ZGVmaW5lZCBoZXJlLgorKiBTZXR0aW5nIHRoaXMgdmFyaWFibGUgdG8gbnVsbHB0ciB3aWxsIG5v
dCBjYXVzZSBhbnkgdHJvdWJsZSB0byB3ZWJraXQgYW5kIGVhaWwgYXMgd2VsbC4KKyovCitFaW5h
X0xpc3QqIF9lbG1fd2luX2xpc3QgPSBudWxscHRyOworCit0eXBlZGVmIGludCAoKkVhaWxGdW5j
dGlvbikodm9pZCopOworCitzdGF0aWMgY2hhciogZWFpbExpYnJhcnlQYXRoKCkKK3sKKyAgICBy
ZXR1cm4gZ2V0ZW52KCJBQ0NFU1NJQklMSVRZX0VBSUxfTElCUkFSWV9QQVRIIik7Cit9CisKK3N0
YXRpYyBXZWJLaXQ6Ok1vZHVsZSYgZWFpbCgpCit7CisgICAgc3RhdGljIE5ldmVyRGVzdHJveWVk
PFdlYktpdDo6TW9kdWxlPiBlYWlsKGVhaWxMaWJyYXJ5UGF0aCgpKTsKKyAgICByZXR1cm4gZWFp
bDsKK30KKyNlbmRpZgorCiAjaWZkZWYgSEFWRV9FQ09SRV9YCiAjaW5jbHVkZSA8RWNvcmVfWC5o
PgogI2luY2x1ZGUgPFgxMS9YbGliLmg+CkBAIC05OCw2ICsxMjAsMTQgQEAgcHVibGljOgogICAg
ICAgICBpZiAoIWVjb3JlX21haW5fbG9vcF9nbGliX2ludGVncmF0ZSgpKQogICAgICAgICAgICAg
cmV0dXJuIGZhbHNlOwogCisjaWYgSEFWRShBQ0NFU1NJQklMSVRZKQorICAgICAgICAvLyBJbml0
aWFsaXplIEVBSUwgbW9kdWxlIChhZGRpbmcgbGlzdGVuZXJzLCBpbml0IGF0ay1icmlkZ2UpCisg
ICAgICAgIGlmIChlYWlsKCkubG9hZCgpKSB7CisgICAgICAgICAgICBpZiAoRWFpbEZ1bmN0aW9u
IGVhaWxJbml0ID0gZWFpbCgpLmZ1bmN0aW9uUG9pbnRlcjxFYWlsRnVuY3Rpb24+KCJlbG1fbW9k
YXBpX2luaXQiKSkKKyAgICAgICAgICAgICAgICBlYWlsSW5pdChudWxscHRyKTsKKyAgICAgICAg
fQorI2VuZGlmCisKICAgICAgICAgU291cE5ldHdvcmtTZXNzaW9uOjpkZWZhdWx0U2Vzc2lvbigp
LnNldHVwSFRUUFByb3h5RnJvbUVudmlyb25tZW50KCk7CiAgICAgICAgIHJldHVybiB0cnVlOwog
ICAgIH0KQEAgLTExNiw2ICsxNDYsMTEgQEAgcHVibGljOgogI2VuZGlmCiAgICAgICAgIGVjb3Jl
X3NodXRkb3duKCk7CiAgICAgICAgIGVpbmFfc2h1dGRvd24oKTsKKworI2lmIEhBVkUoQUNDRVNT
SUJJTElUWSkKKyAgICAgICAgaWYgKEVhaWxGdW5jdGlvbiBlYWlsU2h1dGRvd24gPSBlYWlsKCku
ZnVuY3Rpb25Qb2ludGVyPEVhaWxGdW5jdGlvbj4oImVsbV9tb2RhcGlfc2h1dGRvd24iKSkKKyAg
ICAgICAgICAgIGVhaWxTaHV0ZG93bihudWxscHRyKTsKKyNlbmRpZgogICAgIH0KIH07CiAKZGlm
ZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAyZTU3Y2Qy
Li5iMDU5M2VmIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdl
TG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTQtMTEtMDUgIEtyenlzenRvZiBDemVjaCAgPGsuY3pl
Y2hAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gVXRpbGl6ZSBFYWlsIGxpYnJhcnkgdG8g
c3VwcG9ydCBhY2Nlc3NpYmlsaXR5IGluIEVGTAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM3NzQyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ
IChPT1BTISkuCisKKyAgICAgICAgRWFpbCwgYXRrLWJyaWRnZSwgYXQtc3BpMiBhcmUgbm90IG1h
bmRhdG9yeSBtb2R1bGVzIGZvciB3ZWJraXQtZWZsLiBUaGV5IGFyZSByYXRoZXIgb3B0aW9uYWwu
CisKKyAgICAgICAgKiBlZmwvamhidWlsZC1vcHRpb25hbC5tb2R1bGVzOiBBZGRlZC4KKwogMjAx
NC0xMS0wMyAgRXZhIEJhbGF6c2ZhbHZpICA8ZXZhYi51LXN6ZWdlZEBwYXJ0bmVyLnNhbXN1bmcu
Y29tPgogCiAgICAgICAgIFtuaW5qYV0gRG9uJ3QgcmVtb3ZlIHJlc3BvbnNlIGZpbGVzIGZvciB2
ZXJib3NlIGJ1aWxkcwpkaWZmIC0tZ2l0IGEvVG9vbHMvZWZsL2poYnVpbGQtb3B0aW9uYWwubW9k
dWxlcyBiL1Rvb2xzL2VmbC9qaGJ1aWxkLW9wdGlvbmFsLm1vZHVsZXMKbmV3IGZpbGUgbW9kZSAx
MDA2NDQKaW5kZXggMDAwMDAwMC4uZjcwZDgxMgotLS0gL2Rldi9udWxsCisrKyBiL1Rvb2xzL2Vm
bC9qaGJ1aWxkLW9wdGlvbmFsLm1vZHVsZXMKQEAgLTAsMCArMSwzOCBAQAorPD94bWwgdmVyc2lv
bj0iMS4wIj8+Cis8IURPQ1RZUEUgbW9kdWxlc2V0IFNZU1RFTSAibW9kdWxlc2V0LmR0ZCI+Cis8
P3htbC1zdHlsZXNoZWV0IHR5cGU9InRleHQveHNsIiBocmVmPSJtb2R1bGVzZXQueHNsIj8+Cis8
bW9kdWxlc2V0PgorCisgIDxyZXBvc2l0b3J5IHR5cGU9InRhcmJhbGwiIG5hbWU9ImZ0cC5nbm9t
ZS5vcmciCisgICAgICBocmVmPSJodHRwOi8vZnRwLmdub21lLm9yZyIvPgorICA8cmVwb3NpdG9y
eSB0eXBlPSJnaXQiIG5hbWU9ImdpdGh1YiIKKyAgICAgaHJlZj0iaHR0cHM6Ly9naXRodWIuY29t
L2N6ZWNoayIvPgorCisgIDxhdXRvdG9vbHMgaWQ9ImF0LXNwaTItY29yZSIKKyAgICAgICAgICBh
dXRvZ2VuYXJncz0iLS1kaXNhYmxlLWludHJvc3BlY3Rpb24iPgorICAgIDxicmFuY2ggbW9kdWxl
PSJwdWIvR05PTUUvc291cmNlcy9hdC1zcGkyLWNvcmUvMi4xMC9hdC1zcGkyLWNvcmUtMi4xMC4w
LnRhci54eiIgdmVyc2lvbj0iMi4xMC4wIgorICAgICAgICAgIHJlcG89ImZ0cC5nbm9tZS5vcmci
CisgICAgICAgICAgaGFzaD0ic2hhMjU2Ojk2NDE1NWM3NTc0MjIwYTAwZTExZTFjMGQ5MWYyZDMw
MTdlZDYwMzkyMGViMTMzM2ZmOWNiZGI2YTIyNzQ0ZGIiPgorICAgIDwvYnJhbmNoPgorICAgIDxk
ZXBlbmRlbmNpZXM+CisgICAgICA8ZGVwIHBhY2thZ2U9ImdsaWIiLz4KKyAgICA8L2RlcGVuZGVu
Y2llcz4KKyAgPC9hdXRvdG9vbHM+CisKKyAgPGF1dG90b29scyBpZD0iYXQtc3BpMi1hdGsiPgor
ICAgIDxicmFuY2ggbW9kdWxlPSJwdWIvR05PTUUvc291cmNlcy9hdC1zcGkyLWF0ay8yLjEwL2F0
LXNwaTItYXRrLTIuMTAuMC50YXIueHoiIHZlcnNpb249IjIuMTAuMCIKKyAgICAgICAgICAgIHJl
cG89ImZ0cC5nbm9tZS5vcmciCisgICAgICAgICAgICBoYXNoPSJzaGEyNTY6ZGVhN2ZmMmY5YmM5
YmJkYjAzNTExMTI2MTZkNzM4ZGU3MThiNTU3MzljZDI1MTFhZmVjYWM1MTYwNGMzMWE5NCI+Cisg
ICAgPC9icmFuY2g+CisgICAgPGRlcGVuZGVuY2llcz4KKyAgICAgIDxkZXAgcGFja2FnZT0iZ2xp
YiIvPgorICAgICAgPGRlcCBwYWNrYWdlPSJhdGsiLz4KKyAgICAgIDxkZXAgcGFja2FnZT0iYXQt
c3BpMi1jb3JlIi8+CisgICAgPC9kZXBlbmRlbmNpZXM+CisgIDwvYXV0b3Rvb2xzPgorCisgIDxh
dXRvdG9vbHMgaWQ9ImVhaWwiIGF1dG9nZW4tc2g9ImF1dG9nZW4uc2giPgorICAgIDxicmFuY2gg
cmVwbz0iZ2l0aHViIiBtb2R1bGU9ImVhaWwuZ2l0IiBjaGVja291dGRpcj0iZWFpbC0xLjAuMCIv
PgorPC9hdXRvdG9vbHM+CisKKzwvbW9kdWxlc2V0Pgo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>241775</attachid>
            <date>2014-11-18 02:54:23 -0800</date>
            <delta_ts>2014-11-24 03:30:40 -0800</delta_ts>
            <desc>patch</desc>
            <filename>a11y-illume-access.patch</filename>
            <type>text/plain</type>
            <size>5159</size>
            <attacher name="Krzysztof Czech">k.czech</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No
YW5nZUxvZwppbmRleCA0YzZmYWJmLi44YmZiZTQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0
Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg
QEAKKzIwMTQtMTEtMDUgIEtyenlzenRvZiBDemVjaCAgPGsuY3plY2hAc2Ftc3VuZy5jb20+CisK
KyAgICAgICAgW0VGTF0gVXRpbGl6ZSBFYWlsIGxpYnJhcnkgdG8gc3VwcG9ydCBhY2Nlc3NpYmls
aXR5IGluIEVGTAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/
aWQ9MTM3NzQyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg
ICAgSW5pdGlhbGl6ZSBFQUlMIG1vZHVsZSBzbyB0aGF0IGFsbCB0aGUgbGlzdGVuZXJzIGFuZCBh
dGstYnJpZGdlIHN0YXJ0ZWQgcHJvcGVybHkuCisgICAgICAgIER5bmFtaWMgbG9hZGluZyBvZiBF
QUlMIGhlbHAgdXMgdG8gYXZvaWQgZWxlbWVudGFyeSBkZXBlbmRlbmNpZXMgaW4gV2ViS2l0Lgor
CisgICAgICAgICogV2ViUHJvY2Vzcy9lZmwvV2ViUHJvY2Vzc01haW5FZmwuY3BwOgorICAgICAg
ICAoZWFpbExpYnJhcnlQYXRoKTogcmVhZHMgcGF0aCBwcm92aWRlZCBieSBBQ0NFU1NJQklMSVRZ
X0VBSUxfTElCUkFSWV9QQVRIIHZhcmlhYmxlLgorICAgICAgICAoZWFpbCk6CisKIDIwMTQtMTEt
MTYgIEJlbmphbWluIFBvdWxhaW4gIDxicG91bGFpbkBhcHBsZS5jb20+CiAKICAgICAgICAgU3Rh
cnQgY2xlYW5pbmcgdXAgbWluaW1hbCBVSSBmcm9tIFdLV2ViVmlldwpkaWZmIC0tZ2l0IGEvU291
cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9lZmwvV2ViUHJvY2Vzc01haW5FZmwuY3BwIGIvU291cmNl
L1dlYktpdDIvV2ViUHJvY2Vzcy9lZmwvV2ViUHJvY2Vzc01haW5FZmwuY3BwCmluZGV4IDUyZDBh
Y2MuLjFiMDcxMzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvZWZsL1dl
YlByb2Nlc3NNYWluRWZsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL2VmbC9X
ZWJQcm9jZXNzTWFpbkVmbC5jcHAKQEAgLTM1LDYgKzM1LDI4IEBACiAjaW5jbHVkZSA8V2ViQ29y
ZS9Tb3VwTmV0d29ya1Nlc3Npb24uaD4KICNpbmNsdWRlIDxsaWJzb3VwL3NvdXAuaD4KIAorI2lm
IEhBVkUoQUNDRVNTSUJJTElUWSkKKyNpbmNsdWRlICJNb2R1bGUuaCIKKy8qCisgKiBUaGlzIHNo
b3VsZCBiZSBkZWZpbmVkIGFuZCBmaWxsZWQgaW4gZWxlbWVudGFyeSBidXQgdG8gYXZvaWQgdW5k
ZWZpbmVkIHJlZmVyZW5jZSBpdCdzIGRlZmluZWQgaGVyZS4KKyAqIFNldHRpbmcgdGhpcyB2YXJp
YWJsZSB0byBudWxscHRyIHdpbGwgbm90IGNhdXNlIGFueSB0cm91YmxlIHRvIHdlYmtpdCBhbmQg
ZWFpbCBhcyB3ZWxsLgorICovCitFaW5hX0xpc3QqIF9lbG1fd2luX2xpc3QgPSBudWxscHRyOwor
Cit0eXBlZGVmIGludCAoKkVhaWxGdW5jdGlvbikodm9pZCopOworCitzdGF0aWMgY2hhciogZWFp
bExpYnJhcnlQYXRoKCkKK3sKKyAgICByZXR1cm4gZ2V0ZW52KCJBQ0NFU1NJQklMSVRZX0VBSUxf
TElCUkFSWV9QQVRIIik7Cit9CisKK3N0YXRpYyBXZWJLaXQ6Ok1vZHVsZSYgZWFpbCgpCit7Cisg
ICAgc3RhdGljIE5ldmVyRGVzdHJveWVkPFdlYktpdDo6TW9kdWxlPiBlYWlsKGVhaWxMaWJyYXJ5
UGF0aCgpKTsKKyAgICByZXR1cm4gZWFpbDsKK30KKyNlbmRpZgorCiAjaWZkZWYgSEFWRV9FQ09S
RV9YCiAjaW5jbHVkZSA8RWNvcmVfWC5oPgogI2luY2x1ZGUgPFgxMS9YbGliLmg+CkBAIC05OCw2
ICsxMjAsMTQgQEAgcHVibGljOgogICAgICAgICBpZiAoIWVjb3JlX21haW5fbG9vcF9nbGliX2lu
dGVncmF0ZSgpKQogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogCisjaWYgSEFWRShBQ0NFU1NJ
QklMSVRZKQorICAgICAgICAvLyBJbml0aWFsaXplIEVBSUwgbW9kdWxlIChhZGRpbmcgbGlzdGVu
ZXJzLCBpbml0IGF0ay1icmlkZ2UpCisgICAgICAgIGlmIChlYWlsKCkubG9hZCgpKSB7CisgICAg
ICAgICAgICBpZiAoRWFpbEZ1bmN0aW9uIGVhaWxJbml0ID0gZWFpbCgpLmZ1bmN0aW9uUG9pbnRl
cjxFYWlsRnVuY3Rpb24+KCJlbG1fbW9kYXBpX2luaXQiKSkKKyAgICAgICAgICAgICAgICBlYWls
SW5pdChudWxscHRyKTsKKyAgICAgICAgfQorI2VuZGlmCisKICAgICAgICAgU291cE5ldHdvcmtT
ZXNzaW9uOjpkZWZhdWx0U2Vzc2lvbigpLnNldHVwSFRUUFByb3h5RnJvbUVudmlyb25tZW50KCk7
CiAgICAgICAgIHJldHVybiB0cnVlOwogICAgIH0KQEAgLTExNiw2ICsxNDYsMTEgQEAgcHVibGlj
OgogI2VuZGlmCiAgICAgICAgIGVjb3JlX3NodXRkb3duKCk7CiAgICAgICAgIGVpbmFfc2h1dGRv
d24oKTsKKworI2lmIEhBVkUoQUNDRVNTSUJJTElUWSkKKyAgICAgICAgaWYgKEVhaWxGdW5jdGlv
biBlYWlsU2h1dGRvd24gPSBlYWlsKCkuZnVuY3Rpb25Qb2ludGVyPEVhaWxGdW5jdGlvbj4oImVs
bV9tb2RhcGlfc2h1dGRvd24iKSkKKyAgICAgICAgICAgIGVhaWxTaHV0ZG93bihudWxscHRyKTsK
KyNlbmRpZgogICAgIH0KIH07CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xz
L0NoYW5nZUxvZwppbmRleCA1ZTcyOWRlLi4xMDA1N2JmIDEwMDY0NAotLS0gYS9Ub29scy9DaGFu
Z2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTQtMTEtMDUg
IEtyenlzenRvZiBDemVjaCAgPGsuY3plY2hAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0g
VXRpbGl6ZSBFYWlsIGxpYnJhcnkgdG8gc3VwcG9ydCBhY2Nlc3NpYmlsaXR5IGluIEVGTAorICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM3NzQyCisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRWFpbCwgYXRrLWJy
aWRnZSwgYXQtc3BpMiBhcmUgbm90IG1hbmRhdG9yeSBtb2R1bGVzIGZvciB3ZWJraXQtZWZsLiBU
aGV5IGFyZSByYXRoZXIgb3B0aW9uYWwuCisKKyAgICAgICAgKiBlZmwvamhidWlsZC1vcHRpb25h
bC5tb2R1bGVzOiBBZGRlZC4KKyAgICAgICAgKiBlZmwvamhidWlsZC5tb2R1bGVzOgorCiAyMDE0
LTExLTE3ICBUaW5nLVdlaSBMYW4gIDxsYW50dzQ0QGdtYWlsLmNvbT4KIAogICAgICAgICBbR1RL
XSBBZGQgbGlicmFyeSBzZWFyY2ggcGF0aHMgZnJvbSBMREZMQUdTIGJlZm9yZSBwa2ctY29uZmln
IC0tbGlicwpkaWZmIC0tZ2l0IGEvVG9vbHMvZWZsL2poYnVpbGQtb3B0aW9uYWwubW9kdWxlcyBi
L1Rvb2xzL2VmbC9qaGJ1aWxkLW9wdGlvbmFsLm1vZHVsZXMKbmV3IGZpbGUgbW9kZSAxMDA2NDQK
aW5kZXggMDAwMDAwMC4uZjcwZDgxMgotLS0gL2Rldi9udWxsCisrKyBiL1Rvb2xzL2VmbC9qaGJ1
aWxkLW9wdGlvbmFsLm1vZHVsZXMKQEAgLTAsMCArMSwzOCBAQAorPD94bWwgdmVyc2lvbj0iMS4w
Ij8+Cis8IURPQ1RZUEUgbW9kdWxlc2V0IFNZU1RFTSAibW9kdWxlc2V0LmR0ZCI+Cis8P3htbC1z
dHlsZXNoZWV0IHR5cGU9InRleHQveHNsIiBocmVmPSJtb2R1bGVzZXQueHNsIj8+Cis8bW9kdWxl
c2V0PgorCisgIDxyZXBvc2l0b3J5IHR5cGU9InRhcmJhbGwiIG5hbWU9ImZ0cC5nbm9tZS5vcmci
CisgICAgICBocmVmPSJodHRwOi8vZnRwLmdub21lLm9yZyIvPgorICA8cmVwb3NpdG9yeSB0eXBl
PSJnaXQiIG5hbWU9ImdpdGh1YiIKKyAgICAgaHJlZj0iaHR0cHM6Ly9naXRodWIuY29tL2N6ZWNo
ayIvPgorCisgIDxhdXRvdG9vbHMgaWQ9ImF0LXNwaTItY29yZSIKKyAgICAgICAgICBhdXRvZ2Vu
YXJncz0iLS1kaXNhYmxlLWludHJvc3BlY3Rpb24iPgorICAgIDxicmFuY2ggbW9kdWxlPSJwdWIv
R05PTUUvc291cmNlcy9hdC1zcGkyLWNvcmUvMi4xMC9hdC1zcGkyLWNvcmUtMi4xMC4wLnRhci54
eiIgdmVyc2lvbj0iMi4xMC4wIgorICAgICAgICAgIHJlcG89ImZ0cC5nbm9tZS5vcmciCisgICAg
ICAgICAgaGFzaD0ic2hhMjU2Ojk2NDE1NWM3NTc0MjIwYTAwZTExZTFjMGQ5MWYyZDMwMTdlZDYw
MzkyMGViMTMzM2ZmOWNiZGI2YTIyNzQ0ZGIiPgorICAgIDwvYnJhbmNoPgorICAgIDxkZXBlbmRl
bmNpZXM+CisgICAgICA8ZGVwIHBhY2thZ2U9ImdsaWIiLz4KKyAgICA8L2RlcGVuZGVuY2llcz4K
KyAgPC9hdXRvdG9vbHM+CisKKyAgPGF1dG90b29scyBpZD0iYXQtc3BpMi1hdGsiPgorICAgIDxi
cmFuY2ggbW9kdWxlPSJwdWIvR05PTUUvc291cmNlcy9hdC1zcGkyLWF0ay8yLjEwL2F0LXNwaTIt
YXRrLTIuMTAuMC50YXIueHoiIHZlcnNpb249IjIuMTAuMCIKKyAgICAgICAgICAgIHJlcG89ImZ0
cC5nbm9tZS5vcmciCisgICAgICAgICAgICBoYXNoPSJzaGEyNTY6ZGVhN2ZmMmY5YmM5YmJkYjAz
NTExMTI2MTZkNzM4ZGU3MThiNTU3MzljZDI1MTFhZmVjYWM1MTYwNGMzMWE5NCI+CisgICAgPC9i
cmFuY2g+CisgICAgPGRlcGVuZGVuY2llcz4KKyAgICAgIDxkZXAgcGFja2FnZT0iZ2xpYiIvPgor
ICAgICAgPGRlcCBwYWNrYWdlPSJhdGsiLz4KKyAgICAgIDxkZXAgcGFja2FnZT0iYXQtc3BpMi1j
b3JlIi8+CisgICAgPC9kZXBlbmRlbmNpZXM+CisgIDwvYXV0b3Rvb2xzPgorCisgIDxhdXRvdG9v
bHMgaWQ9ImVhaWwiIGF1dG9nZW4tc2g9ImF1dG9nZW4uc2giPgorICAgIDxicmFuY2ggcmVwbz0i
Z2l0aHViIiBtb2R1bGU9ImVhaWwuZ2l0IiBjaGVja291dGRpcj0iZWFpbC0xLjAuMCIvPgorPC9h
dXRvdG9vbHM+CisKKzwvbW9kdWxlc2V0PgpkaWZmIC0tZ2l0IGEvVG9vbHMvZWZsL2poYnVpbGQu
bW9kdWxlcyBiL1Rvb2xzL2VmbC9qaGJ1aWxkLm1vZHVsZXMKaW5kZXggNzlkOTY3My4uOWIxMDdm
ZiAxMDA2NDQKLS0tIGEvVG9vbHMvZWZsL2poYnVpbGQubW9kdWxlcworKysgYi9Ub29scy9lZmwv
amhidWlsZC5tb2R1bGVzCkBAIC0yNiw2ICsyNiw4IEBACiAgICAgPC9kZXBlbmRlbmNpZXM+CiAg
IDwvbWV0YW1vZHVsZT4KIAorICA8aW5jbHVkZSBocmVmPSJqaGJ1aWxkLW9wdGlvbmFsLm1vZHVs
ZXMiLz4KKwogICA8cmVwb3NpdG9yeSB0eXBlPSJ0YXJiYWxsIiBuYW1lPSJnaXRodWIuY29tIgog
ICAgICAgaHJlZj0iaHR0cHM6Ly9naXRodWIuY29tIi8+CiAgIDxyZXBvc2l0b3J5IHR5cGU9InRh
cmJhbGwiIG5hbWU9InNvdXJjZXdhcmUub3JnIgo=
</data>

          </attachment>
      

    </bug>

</bugzilla>