137739 2014-10-15 06:12:01 -0700 [GTK]FindHarfBuzz.cmake dose not handle harfbuzz-icu correctly 2023-03-25 10:39:56 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P3 Normal --- 1 iyzsong webkit-unassigned alex_y_xu berto bugs-noreply cgarcia mcatanzaro zan oldest_to_newest 1041847 0 iyzsong 2014-10-15 06:12:01 -0700 Suppose I have harfbuzz and harfbuzz-icu install to two different directories, then paths to hb.h and hb-icu.h should both included in HARFBUZZ_INCLUDE_DIRS. And the ``list APPEND`` method does not really work. Here is a patch I used to package it for NixOS. Version: webkitgtk-2.6.1 1041848 1 239870 iyzsong 2014-10-15 06:14:11 -0700 Created attachment 239870 cmake: finding harfbuzz-icu 1053190 2 berto 2014-12-07 10:46:06 -0800 Why don't you (In reply to comment #0) > Suppose I have harfbuzz and harfbuzz-icu install to two different > directories, > then paths to hb.h and hb-icu.h should both included in > HARFBUZZ_INCLUDE_DIRS. I'm not a cmake expert, but why don't you look for hb.h in the new patch then? In the HarfBuff >= 0.9.18 branch of the if I only see hb-icu.h. 1053613 3 iyzsong 2014-12-08 18:20:13 -0800 (In reply to comment #2) > Why don't you (In reply to comment #0) > > Suppose I have harfbuzz and harfbuzz-icu install to two different > > directories, > > > then paths to hb.h and hb-icu.h should both included in > > HARFBUZZ_INCLUDE_DIRS. > > I'm not a cmake expert, but why don't you look for hb.h in the new patch > then? Obvious, I'm not a cmake expert too :) Ah yes, It's good to add a find_path for hb.h too. Even pkg_check_modules(PC_HARFBUZZ harfbuzz>=0.9.7) should given a corret PC_HARFBUZZ_INCLUDE_DIRS (having hb.h). > In the HarfBuff >= 0.9.18 branch of the if I only see hb-icu.h. 1943956 4 alex_y_xu 2023-03-25 08:56:03 -0700 fixed by https://bugs.webkit.org/show_bug.cgi?id=220082 239870 2014-10-15 06:14:11 -0700 2014-10-15 06:14:11 -0700 cmake: finding harfbuzz-icu url.txt text/plain 112 iyzsong aHR0cHM6Ly9naXRodWIuY29tL2l5enNvbmcvbml4cGtncy9yYXcvd2Via2l0Z3RrL3BrZ3MvZGV2 ZWxvcG1lbnQvbGlicmFyaWVzL3dlYmtpdGd0ay9maW5kaW5nLWhhcmZidXp6LWljdS5wYXRjaA==