137734 2014-10-14 23:42:06 -0700 [GTK] Minibrowser: Escape key does not hide the search box 2014-10-20 01:23:34 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tanay.c webkit-unassigned commit-queue pnormand oldest_to_newest 1041807 0 tanay.c 2014-10-14 23:42:06 -0700 If search box is while page loading is not complete, we observe Current behaviour for 'Esc' key: 1) Stop page load 2) Press 'Esc' again does not hide the Search bar Expected: 1) Hide the search bar. 2) If pressed again , stop page loading. 1041808 1 239853 tanay.c 2014-10-14 23:49:56 -0700 Created attachment 239853 Patch 1042751 2 239853 commit-queue 2014-10-20 01:23:30 -0700 Comment on attachment 239853 Patch Clearing flags on attachment: 239853 Committed r174879: <http://trac.webkit.org/changeset/174879> 1042752 3 commit-queue 2014-10-20 01:23:34 -0700 All reviewed patches have been landed. Closing bug. 239853 2014-10-14 23:49:56 -0700 2014-10-20 01:23:30 -0700 Patch bug-137734-20141015122031.patch text/plain 1319 tanay.c SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE3NDcyMykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE0LTEwLTE0ICBUYW5heSBDICA8dGFuYXkuY0BzYW1zdW5nLmNvbT4KKwor ICAgICAgICBbR1RLXVtNaW5pYnJvd3Nlcl0gRXNjYXBlIGtleSBkb2VzIG5vdCBoaWRlIHRoZSBz ZWFyY2ggYm94CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMzc3MzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIE1pbmlCcm93c2VyL2d0ay9Ccm93c2VyV2luZG93LmM6IEFkZGVkIHRoZSBjaGVjayB0byBo YW5kbGUgc2VhcmNoIGJveCBoaWRlCisgICAgICAgIChzdG9wUGFnZUxvYWQpOiBNb2RpZmllZC4K KwogMjAxNC0xMC0xNCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAog ICAgICAgICBbTWFjXSBEUlQgc3RkZXJyIGxvZ2dpbmcgYWZ0ZXIgdGhlIHRlc3QgY29tcGxldGVz IGdldHMgYXR0cmlidXRlZCB0byB0aGUgbmV4dCB0ZXN0CkluZGV4OiBUb29scy9NaW5pQnJvd3Nl ci9ndGsvQnJvd3NlcldpbmRvdy5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL01pbmlCcm93c2VyL2d0 ay9Ccm93c2VyV2luZG93LmMJKHJldmlzaW9uIDE3NDY3NikKKysrIFRvb2xzL01pbmlCcm93c2Vy L2d0ay9Ccm93c2VyV2luZG93LmMJKHdvcmtpbmcgY29weSkKQEAgLTU0Miw3ICs1NDIsOSBAQCBz dGF0aWMgdm9pZCByZWxvYWRQYWdlSWdub3JpbmdDYWNoZShCcm93CiAKIHN0YXRpYyB2b2lkIHN0 b3BQYWdlTG9hZChCcm93c2VyV2luZG93ICp3aW5kb3csIGdwb2ludGVyIHVzZXJfZGF0YSkKIHsK LSAgICBpZiAod2Via2l0X3dlYl92aWV3X2lzX2xvYWRpbmcod2luZG93LT53ZWJWaWV3KSkKKyAg ICBpZiAoZ3RrX3dpZGdldF9nZXRfdmlzaWJsZShHVEtfV0lER0VUKHdpbmRvdy0+c2VhcmNoQmFy KSkpIAorICAgICAgICBicm93c2VyX3NlYXJjaF9iYXJfY2xvc2Uod2luZG93LT5zZWFyY2hCYXIp OworICAgIGVsc2UgaWYgKHdlYmtpdF93ZWJfdmlld19pc19sb2FkaW5nKHdpbmRvdy0+d2ViVmll dykpCiAgICAgICAgIHdlYmtpdF93ZWJfdmlld19zdG9wX2xvYWRpbmcod2luZG93LT53ZWJWaWV3 KTsKIH0KIAo=