137719 2014-10-14 14:41:09 -0700 REGRESSION (r165356): Issues with Japanese text input 2014-12-09 14:21:07 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=139459 InRadar P2 Normal --- 1 ap ap darin rniwa oldest_to_newest 1041688 0 ap 2014-10-14 14:41:09 -0700 This affects sync text input code path. 1. Kotoeri sometimes doesn't process the first keypress in a web page. 2. ATOK sometimes needs to consume a Return key, but it is passed down to a web page anyway (causing bad misbehavior on google.com). This happens because we EditorState is now tracked incorrectly. There is an async message sent with old state, and then a sync message response with new state. But these are delivered out of order, so UI process ends up with an incorrect idea about input state. Yes, the incorrect data has ignoreCompositionSelectionChange set on it, but that's not sufficient for UI side heuristics to work well. rdar://problem/18431952 rdar://problem/18483741 1041696 1 239827 ap 2014-10-14 14:56:33 -0700 Created attachment 239827 proposed fix 1041706 2 239827 darin 2014-10-14 15:44:31 -0700 Comment on attachment 239827 proposed fix Any way to regression test this? 1041720 3 ap 2014-10-14 16:27:00 -0700 It's likely technically possible to test with an API test, as these drive testing from UI process side, however the complexity of such a test scares. More importantly, an API test would only test sync API, which is on its way out. Committed <http://trac.webkit.org/r174708>. 239827 2014-10-14 14:56:33 -0700 2014-10-14 15:44:31 -0700 proposed fix Japanese.txt text/plain 2277 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NDcwMikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTEwLTE0ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIxNjUz NTYpOiBJc3N1ZXMgd2l0aCBKYXBhbmVzZSB0ZXh0IGlucHV0CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzc3MTkKKyAgICAgICAgcmRhcjovL3Byb2Js ZW0vMTg0MzE5NTIKKyAgICAgICAgcmRhcjovL3Byb2JsZW0vMTg0ODM3NDEKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFn ZS9XZWJQYWdlLmNwcDogKFdlYktpdDo6V2ViUGFnZTo6ZGlkQ2hhbmdlU2VsZWN0aW9uKToKKyAg ICAgICAgSW4gc3luYyBjb2RlIHBhdGgsIGVuc3VyZSBjb25zaXN0ZW50IG1lc3NhZ2UgZGVsaXZl cnkgb3JkZXIgYnkgYWRkaW5nCisgICAgICAgIGEgRGlzcGF0Y2hNZXNzYWdlRXZlbldoZW5XYWl0 aW5nRm9yU3luY1JlcGx5IGZsYWcuIFRoaXMgd2F5LCBkZWxheWVkCisgICAgICAgIEVkaXRvclN0 YXRlQ2hhbmdlZCBtZXNzYWdlcyB3b24ndCBjb25mdXNlIFVJIHByb2Nlc3MuCisKIDIwMTQtMTAt MTQgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBVc2UgaXM8Pigp IC8gZG93bmNhc3Q8PigpIGZvciBSZW5kZXJJbWFnZQpJbmRleDogU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQy L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAkocmV2aXNpb24gMTc0NjU0KQorKysgU291 cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC00MzE3LDcgKzQzMTcsNyBAQCB2b2lkIFdlYlBhZ2U6OmNhbmNlbENvbXBvc2l0aW9uKCkK IAogdm9pZCBXZWJQYWdlOjpkaWRDaGFuZ2VTZWxlY3Rpb24oKQogewotI2lmIChQTEFURk9STShN QUMpICYmIFVTRShBU1lOQ19OU1RFWFRJTlBVVENMSUVOVCkpCisjaWYgUExBVEZPUk0oTUFDKSAm JiBVU0UoQVNZTkNfTlNURVhUSU5QVVRDTElFTlQpCiAgICAgRnJhbWUmIGZyYW1lID0gbV9wYWdl LT5mb2N1c0NvbnRyb2xsZXIoKS5mb2N1c2VkT3JNYWluRnJhbWUoKTsKICAgICAvLyBBYmFuZG9u IHRoZSBjdXJyZW50IGlubGluZSBpbnB1dCBzZXNzaW9uIGlmIHNlbGVjdGlvbiBjaGFuZ2VkIGZv ciBhbnkgb3RoZXIgcmVhc29uIGJ1dCBhbiBpbnB1dCBtZXRob2QgZGlyZWN0IGFjdGlvbi4KICAg ICAvLyBGSVhNRTogTWFueSBjaGFuZ2VzIHRoYXQgYWZmZWN0IGNvbXBvc2l0aW9uIG5vZGUgZG8g bm90IGdvIHRocm91Z2ggZGlkQ2hhbmdlU2VsZWN0aW9uKCkuIFdlIG5lZWQgdG8gZG8gc29tZXRo aW5nIHdoZW4gRE9NIG1hbmlwdWxhdGlvbiBhZmZlY3RzIHRoZSBjb21wb3NpdGlvbiwgYmVjYXVz ZSBvdGhlcndpc2UgaW5wdXQgbWV0aG9kJ3MgaWRlYSBhYm91dCBpdCB3aWxsIGJlIGRpZmZlcmVu dCBmcm9tIEVkaXRvcidzLgpAQCAtNDMyNiw4ICs0MzI2LDEwIEBAIHZvaWQgV2ViUGFnZTo6ZGlk Q2hhbmdlU2VsZWN0aW9uKCkKICAgICAgICAgZnJhbWUuZWRpdG9yKCkuY2FuY2VsQ29tcG9zaXRp b24oKTsKICAgICAgICAgc2VuZChNZXNzYWdlczo6V2ViUGFnZVByb3h5OjpDb21wb3NpdGlvbldh c0NhbmNlbGVkKGVkaXRvclN0YXRlKCkpKTsKICAgICB9IGVsc2UKLSNlbmRpZgogICAgICAgICBz ZW5kKE1lc3NhZ2VzOjpXZWJQYWdlUHJveHk6OkVkaXRvclN0YXRlQ2hhbmdlZChlZGl0b3JTdGF0 ZSgpKSk7CisjZWxzZQorICAgIHNlbmQoTWVzc2FnZXM6OldlYlBhZ2VQcm94eTo6RWRpdG9yU3Rh dGVDaGFuZ2VkKGVkaXRvclN0YXRlKCkpLCBwYWdlSUQoKSwgSVBDOjpEaXNwYXRjaE1lc3NhZ2VF dmVuV2hlbldhaXRpbmdGb3JTeW5jUmVwbHkpOworI2VuZGlmCiAKICNpZiBQTEFURk9STShJT1Mp CiAgICAgbV9kcmF3aW5nQXJlYS0+c2NoZWR1bGVDb21wb3NpdGluZ0xheWVyRmx1c2goKTsK