137696 2014-10-14 09:23:54 -0700 Use is<>() / downcast<>() for RenderFrame / RenderFrameSet 2014-10-14 10:32:05 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 137424 1 cdumez cdumez commit-queue darin esprehn+autocc glenn gyuyoung.kim kondapallykalyan mihnea oldest_to_newest 1041567 0 cdumez 2014-10-14 09:23:54 -0700 Use is<>() / downcast<>() for RenderFrame / RenderFrameSet. 1041570 1 239802 cdumez 2014-10-14 09:25:45 -0700 Created attachment 239802 Patch 1041597 2 239802 commit-queue 2014-10-14 10:32:01 -0700 Comment on attachment 239802 Patch Clearing flags on attachment: 239802 Committed r174686: <http://trac.webkit.org/changeset/174686> 1041598 3 commit-queue 2014-10-14 10:32:05 -0700 All reviewed patches have been landed. Closing bug. 239802 2014-10-14 09:25:45 -0700 2014-10-14 10:32:00 -0700 Patch bug-137696-20141014092551.patch text/plain 6890 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0NjgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGU4MzhiMDZmZjcyZDY3 NjNkYjcwNTU0YWM5Yjg4ZDgzNzZmMzc1Ny4uMGUxMWM2ZDAwYzJjM2M4NTFhZmNkN2Y0MGUzNDFi YzNiMjBkZDBhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE0LTEwLTE0ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgVXNlIGlzPD4oKSAvIGRvd25j YXN0PD4oKSBmb3IgUmVuZGVyRnJhbWUgLyBSZW5kZXJGcmFtZVNldAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM3Njk2CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIGlzPD4oKSAvIGRvd25jYXN0PD4o KSBmb3IgUmVuZGVyRnJhbWUgLyBSZW5kZXJGcmFtZVNldC4KKworICAgICAgICBObyBuZXcgdGVz dHMsIG5vIGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAgICAqIGh0bWwvSFRNTEZyYW1lU2V0RWxl bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MRnJhbWVTZXRFbGVtZW50OjpkZWZhdWx0 RXZlbnRIYW5kbGVyKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyRnJhbWUuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6UmVuZGVyRnJhbWU6OnVwZGF0ZUZyb21FbGVtZW50KToKKyAgICAgICAg KiByZW5kZXJpbmcvUmVuZGVyRnJhbWUuaDoKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyRnJh bWVTZXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyRnJhbWVTZXQ6OmNvbXB1dGVFZGdl SW5mbyk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJGcmFtZVNldDo6cG9zaXRpb25GcmFtZXNX aXRoRmxhdHRlbmluZyk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckZyYW1lU2V0Lmg6CisK IDIwMTQtMTAtMTQgIEFsZWphbmRybyBHLiBDYXN0cm8gIDxhbGV4QGlnYWxpYS5jb20+CiAKICAg ICAgICAgTXVsdGlwbGUgcmVmYWN0b3JzIGluIFJlbmRlck1hdGhNTE9wZXJhdG9yCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxGcmFtZVNldEVsZW1lbnQuY3BwIGIvU291cmNl L1dlYkNvcmUvaHRtbC9IVE1MRnJhbWVTZXRFbGVtZW50LmNwcAppbmRleCA5YTc5NjE3ZGViM2M2 NzM2NTc0OTUwMjBlNTA0NTE1MDcyM2RmZGQwLi43YTRkMDJiZmY1Yzg5YzIwYjJjMWMwMDU3NzEx ZTdhYWM2YThjODA1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxGcmFtZVNl dEVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZyYW1lU2V0RWxlbWVu dC5jcHAKQEAgLTE5MCw4ICsxOTAsOCBAQCB2b2lkIEhUTUxGcmFtZVNldEVsZW1lbnQ6OndpbGxB dHRhY2hSZW5kZXJlcnMoKQogdm9pZCBIVE1MRnJhbWVTZXRFbGVtZW50OjpkZWZhdWx0RXZlbnRI YW5kbGVyKEV2ZW50KiBldmVudCkKIHsKICAgICBBU1NFUlQoZXZlbnQpOwotICAgIGlmIChpczxN b3VzZUV2ZW50PigqZXZlbnQpICYmICFtX25vcmVzaXplICYmIHJlbmRlcmVyKCkgJiYgcmVuZGVy ZXIoKS0+aXNGcmFtZVNldCgpKSB7Ci0gICAgICAgIGlmICh0b1JlbmRlckZyYW1lU2V0KHJlbmRl cmVyKCkpLT51c2VyUmVzaXplKGRvd25jYXN0PE1vdXNlRXZlbnQ+KGV2ZW50KSkpIHsKKyAgICBp ZiAoaXM8TW91c2VFdmVudD4oKmV2ZW50KSAmJiAhbV9ub3Jlc2l6ZSAmJiBpczxSZW5kZXJGcmFt ZVNldD4ocmVuZGVyZXIoKSkpIHsKKyAgICAgICAgaWYgKGRvd25jYXN0PFJlbmRlckZyYW1lU2V0 PigqcmVuZGVyZXIoKSkudXNlclJlc2l6ZShkb3duY2FzdDxNb3VzZUV2ZW50PihldmVudCkpKSB7 CiAgICAgICAgICAgICBldmVudC0+c2V0RGVmYXVsdEhhbmRsZWQoKTsKICAgICAgICAgICAgIHJl dHVybjsKICAgICAgICAgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckZyYW1lLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGcmFtZS5jcHAK aW5kZXggNDM5MzhjZjQwYTMyOTJiYzJmZWNjZjU0NjEyNTZjMDIyZWEzNDQ5Ny4uMzBhMmU2M2U2 MGE1NmRmZTgzYzg0NTgzMjQzOWZjZTI4YTkzYzRkYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckZyYW1lLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyRnJhbWUuY3BwCkBAIC00NSw4ICs0NSw4IEBAIEZyYW1lRWRnZUluZm8gUmVuZGVy RnJhbWU6OmVkZ2VJbmZvKCkgY29uc3QKIAogdm9pZCBSZW5kZXJGcmFtZTo6dXBkYXRlRnJvbUVs ZW1lbnQoKQogewotICAgIGlmIChwYXJlbnQoKSAmJiBwYXJlbnQoKS0+aXNGcmFtZVNldCgpKQot ICAgICAgICB0b1JlbmRlckZyYW1lU2V0KHBhcmVudCgpKS0+bm90aWZ5RnJhbWVFZGdlSW5mb0No YW5nZWQoKTsKKyAgICBpZiAoaXM8UmVuZGVyRnJhbWVTZXQ+KHBhcmVudCgpKSkKKyAgICAgICAg ZG93bmNhc3Q8UmVuZGVyRnJhbWVTZXQ+KCpwYXJlbnQoKSkubm90aWZ5RnJhbWVFZGdlSW5mb0No YW5nZWQoKTsKIH0KIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZyYW1lLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyRnJhbWUuaAppbmRleCBkZGU5YjZiOGEzYmE0YzAyZDNiMDdkNTE5ZjFjNTdmOWJh OTk0OTI5Li43NGY2ODhmNzgzMDFlNTdhNjI3ZTBlZjFlNzAyYzk2NzA0YjE4NTQ4IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRnJhbWUuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRnJhbWUuaApAQCAtNDYsOCArNDYsNiBAQCBwcml2YXRl OgogICAgIHZpcnR1YWwgdm9pZCB1cGRhdGVGcm9tRWxlbWVudCgpIG92ZXJyaWRlOwogfTsKIAot UkVOREVSX09CSkVDVF9UWVBFX0NBU1RTKFJlbmRlckZyYW1lLCBpc0ZyYW1lKCkpCi0KIH0gLy8g bmFtZXNwYWNlIFdlYkNvcmUKIAogU1BFQ0lBTElaRV9UWVBFX1RSQUlUU19SRU5ERVJfT0JKRUNU KFJlbmRlckZyYW1lLCBpc0ZyYW1lKCkpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyRnJhbWVTZXQuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckZyYW1lU2V0LmNwcAppbmRleCA1MjZhMWMwNTJhMmY1NTY0ZjAyOGE5NWJkYTZiNDEwMTQ5ZWQ2 MGJiLi4yYTFjMWQyMGRjM2Q1YTIyNmU5MzI2NjYwM2I4MmVhNTNhYTM5Yjk5IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRnJhbWVTZXQuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGcmFtZVNldC5jcHAKQEAgLTQwOSwxMCArNDA5LDEw IEBAIHZvaWQgUmVuZGVyRnJhbWVTZXQ6OmNvbXB1dGVFZGdlSW5mbygpCiAgICAgZm9yIChzaXpl X3QgciA9IDA7IHIgPCByb3dzOyArK3IpIHsKICAgICAgICAgZm9yIChzaXplX3QgYyA9IDA7IGMg PCBjb2xzOyArK2MpIHsKICAgICAgICAgICAgIEZyYW1lRWRnZUluZm8gZWRnZUluZm87Ci0gICAg ICAgICAgICBpZiAoY2hpbGQtPmlzRnJhbWVTZXQoKSkKLSAgICAgICAgICAgICAgICBlZGdlSW5m byA9IHRvUmVuZGVyRnJhbWVTZXQoY2hpbGQpLT5lZGdlSW5mbygpOworICAgICAgICAgICAgaWYg KGlzPFJlbmRlckZyYW1lU2V0PigqY2hpbGQpKQorICAgICAgICAgICAgICAgIGVkZ2VJbmZvID0g ZG93bmNhc3Q8UmVuZGVyRnJhbWVTZXQ+KCpjaGlsZCkuZWRnZUluZm8oKTsKICAgICAgICAgICAg IGVsc2UKLSAgICAgICAgICAgICAgICBlZGdlSW5mbyA9IHRvUmVuZGVyRnJhbWUoY2hpbGQpLT5l ZGdlSW5mbygpOworICAgICAgICAgICAgICAgIGVkZ2VJbmZvID0gZG93bmNhc3Q8UmVuZGVyRnJh bWU+KCpjaGlsZCkuZWRnZUluZm8oKTsKICAgICAgICAgICAgIGZpbGxGcm9tRWRnZUluZm8oZWRn ZUluZm8sIHIsIGMpOwogICAgICAgICAgICAgY2hpbGQgPSBjaGlsZC0+bmV4dFNpYmxpbmcoKTsK ICAgICAgICAgICAgIGlmICghY2hpbGQpCkBAIC01NTQsMTEgKzU1NCwxMSBAQCB2b2lkIFJlbmRl ckZyYW1lU2V0Ojpwb3NpdGlvbkZyYW1lc1dpdGhGbGF0dGVuaW5nKCkKIAogICAgIC8vIGNhbGN1 bGF0ZSBmcmFtZXNldCBoZWlnaHQgYmFzZWQgb24gYWN0dWFsIGNvbnRlbnQgaGVpZ2h0IHRvIGVs aW1pbmF0ZSBzY3JvbGxpbmcKICAgICBib29sIG91dCA9IGZhbHNlOwotICAgIGZvciAoaW50IHIg PSAwOyByIDwgcm93cyAmJiAhb3V0OyByKyspIHsKKyAgICBmb3IgKGludCByID0gMDsgciA8IHJv d3MgJiYgIW91dDsgKytyKSB7CiAgICAgICAgIGludCBleHRyYSA9IDA7CiAgICAgICAgIGludCBo ZWlnaHQgPSBtX3Jvd3MubV9zaXplc1tyXTsKIAotICAgICAgICBmb3IgKGludCBjID0gMDsgYyA8 IGNvbHM7IGMrKykgeworICAgICAgICBmb3IgKGludCBjID0gMDsgYyA8IGNvbHM7ICsrYykgewog ICAgICAgICAgICAgSW50UmVjdCBvbGRGcmFtZVJlY3QgPSBzbmFwcGVkSW50UmVjdChjaGlsZC0+ ZnJhbWVSZWN0KCkpOwogCiAgICAgICAgICAgICBpbnQgd2lkdGggPSBtX2NvbHMubV9zaXplc1tj XTsKQEAgLTU3NSwxMCArNTc1LDEwIEBAIHZvaWQgUmVuZGVyRnJhbWVTZXQ6OnBvc2l0aW9uRnJh bWVzV2l0aEZsYXR0ZW5pbmcoKQogCiAgICAgICAgICAgICBjaGlsZC0+c2V0TmVlZHNMYXlvdXQo KTsKIAotICAgICAgICAgICAgaWYgKGNoaWxkLT5pc0ZyYW1lU2V0KCkpCi0gICAgICAgICAgICAg ICAgdG9SZW5kZXJGcmFtZVNldChjaGlsZCktPmxheW91dCgpOworICAgICAgICAgICAgaWYgKGlz PFJlbmRlckZyYW1lU2V0PigqY2hpbGQpKQorICAgICAgICAgICAgICAgIGRvd25jYXN0PFJlbmRl ckZyYW1lU2V0PigqY2hpbGQpLmxheW91dCgpOwogICAgICAgICAgICAgZWxzZQotICAgICAgICAg ICAgICAgIHRvUmVuZGVyRnJhbWUoY2hpbGQpLT5sYXlvdXRXaXRoRmxhdHRlbmluZyhmaXhlZFdp ZHRoLCBmaXhlZEhlaWdodCk7CisgICAgICAgICAgICAgICAgZG93bmNhc3Q8UmVuZGVyRnJhbWU+ KCpjaGlsZCkubGF5b3V0V2l0aEZsYXR0ZW5pbmcoZml4ZWRXaWR0aCwgZml4ZWRIZWlnaHQpOwog CiAgICAgICAgICAgICBpZiAoY2hpbGQtPmhlaWdodCgpID4gbV9yb3dzLm1fc2l6ZXNbcl0pCiAg ICAgICAgICAgICAgICAgbV9yb3dzLm1fc2l6ZXNbcl0gPSBjaGlsZC0+aGVpZ2h0KCk7CkBAIC02 MDMsOSArNjAzLDkgQEAgdm9pZCBSZW5kZXJGcmFtZVNldDo6cG9zaXRpb25GcmFtZXNXaXRoRmxh dHRlbmluZygpCiAgICAgaW50IHlQb3MgPSAwOwogICAgIG91dCA9IGZhbHNlOwogICAgIGNoaWxk ID0gZmlyc3RDaGlsZEJveCgpOwotICAgIGZvciAoaW50IHIgPSAwOyByIDwgcm93cyAmJiAhb3V0 OyByKyspIHsKKyAgICBmb3IgKGludCByID0gMDsgciA8IHJvd3MgJiYgIW91dDsgKytyKSB7CiAg ICAgICAgIHhQb3MgPSAwOwotICAgICAgICBmb3IgKGludCBjID0gMDsgYyA8IGNvbHM7IGMrKykg eworICAgICAgICBmb3IgKGludCBjID0gMDsgYyA8IGNvbHM7ICsrYykgewogICAgICAgICAgICAg Ly8gZW5zdXJlIHRoZSByb3dzIGFuZCBjb2x1bW5zIGFyZSBmaWxsZWQKICAgICAgICAgICAgIElu dFJlY3Qgb2xkUmVjdCA9IHNuYXBwZWRJbnRSZWN0KGNoaWxkLT5mcmFtZVJlY3QoKSk7CiAKQEAg LTYxOCwxMCArNjE4LDEwIEBAIHZvaWQgUmVuZGVyRnJhbWVTZXQ6OnBvc2l0aW9uRnJhbWVzV2l0 aEZsYXR0ZW5pbmcoKQogCiAgICAgICAgICAgICAgICAgLy8gdXBkYXRlIHRvIGZpbmFsIHNpemUK ICAgICAgICAgICAgICAgICBjaGlsZC0+c2V0TmVlZHNMYXlvdXQoKTsKLSAgICAgICAgICAgICAg ICBpZiAoY2hpbGQtPmlzRnJhbWVTZXQoKSkKLSAgICAgICAgICAgICAgICAgICAgdG9SZW5kZXJG cmFtZVNldChjaGlsZCktPmxheW91dCgpOworICAgICAgICAgICAgICAgIGlmIChpczxSZW5kZXJG cmFtZVNldD4oKmNoaWxkKSkKKyAgICAgICAgICAgICAgICAgICAgZG93bmNhc3Q8UmVuZGVyRnJh bWVTZXQ+KCpjaGlsZCkubGF5b3V0KCk7CiAgICAgICAgICAgICAgICAgZWxzZQotICAgICAgICAg ICAgICAgICAgICB0b1JlbmRlckZyYW1lKGNoaWxkKS0+bGF5b3V0V2l0aEZsYXR0ZW5pbmcodHJ1 ZSwgdHJ1ZSk7CisgICAgICAgICAgICAgICAgICAgIGRvd25jYXN0PFJlbmRlckZyYW1lPigqY2hp bGQpLmxheW91dFdpdGhGbGF0dGVuaW5nKHRydWUsIHRydWUpOwogICAgICAgICAgICAgfQogCiAg ICAgICAgICAgICB4UG9zICs9IG1fY29scy5tX3NpemVzW2NdICsgYm9yZGVyVGhpY2tuZXNzOwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZyYW1lU2V0LmggYi9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRnJhbWVTZXQuaAppbmRleCBlOWI4YTFlZTMw Y2EyOWM3OWE1NGRhZWU5YThlMGVmNGU0MWQwZTM1Li5iMGVlODlhMzQwN2JiYzkxNTZiNTMxMTY4 OTQyMzA1MDM5MWUzZjUwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyRnJhbWVTZXQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRnJhbWVT ZXQuaApAQCAtMTI2LDggKzEyNiw2IEBAIHByaXZhdGU6CiAgICAgYm9vbCBtX2lzQ2hpbGRSZXNp emluZzsKIH07CiAKLVJFTkRFUl9PQkpFQ1RfVFlQRV9DQVNUUyhSZW5kZXJGcmFtZVNldCwgaXNG cmFtZVNldCgpKQotCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCiAKIFNQRUNJQUxJWkVfVFlQRV9U UkFJVFNfUkVOREVSX09CSkVDVChSZW5kZXJGcmFtZVNldCwgaXNGcmFtZVNldCgpKQo=