137692 2014-10-14 07:06:09 -0700 [EFL] REGRESSION(r173394): MiniBrowser stucked in an infinite loop if NETWORK_CACHE is disabled 2017-02-20 22:39:33 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=168637 P1 Blocker --- 136631 1 mtiborinf ossy commit-queue darin gyuyoung.kim hs85.jeong jh718.park koivisto lucas.de.marchi ossy oldest_to_newest 1041552 0 mtiborinf 2014-10-14 07:06:09 -0700 MiniBrowser stucked in an infinite loop on http://index.hu if NetworkProcess is enabled The new caching method introduced in r173394 causes this problem on EFL. You can easily reproduce it with: MiniBrowser http://index.hu -S 1041553 1 239798 mtiborinf 2014-10-14 07:09:30 -0700 Created attachment 239798 WIP patch If we disable caching, or reduce the caching time, everything works fine. But I started to debug the real bug and try to fix it properly. 1144830 2 ossy 2015-11-30 10:59:10 -0800 Change importance to P1/blocker, because NetworkProcess is mandatory since http://trac.webkit.org/changeset/192796 and now networking is completely broken on EFL WebKit: https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/25715 Any volunteer to pick up this serious regression? 1145889 3 ossy 2015-12-03 00:50:30 -0800 just to note: https://trac.webkit.org/changeset/192994 skipped all wpt tests. They should be unskipped once somebody fixes this very old regression. 1145891 4 gyuyoung.kim 2015-12-03 00:53:55 -0800 (In reply to comment #3) > just to note: https://trac.webkit.org/changeset/192994 skipped all wpt tests. > They should be unskipped once somebody fixes this very old regression. To fix it, I file a new bug - https://bugs.webkit.org/show_bug.cgi?id=151801 1145904 5 ossy 2015-12-03 02:33:30 -0800 (In reply to comment #4) > (In reply to comment #3) > > just to note: https://trac.webkit.org/changeset/192994 skipped all wpt tests. > > They should be unskipped once somebody fixes this very old regression. > > To fix it, I file a new bug - https://bugs.webkit.org/show_bug.cgi?id=151801 Common, why do we need a new bug report for the same bug? REGRESSION(r192994): imported/w3c/web-platform-tests has been timeout since r192994 https://bugs.webkit.org/show_bug.cgi?id=151801 Otherwise the name of the new bug is misleading, because r192994 only made NetworkProcess mandatory, it isn't the real culprit. It is a 15 months old bug caused by r173394. But it was hidden, because EFL didn't use NetworkProcess at all until it became mandatory. https://bugs.webkit.org/show_bug.cgi?id=151801#c2 pointed out that the problem occurs only if NETWORK_CACHE is disabled. So one possible fix can be to enable NETWORK_CACHE on EFL port too similar to Apple Mac and GTK port. In this case can we get rid NETWORK_CACHE guards since all ports enabled it? And we see that networking is broken with disabled NETWORK_CACHE long time ago. Is there any reason to keep this broken configuration in the tree? 1145906 6 ossy 2015-12-03 02:34:35 -0800 *** Bug 151801 has been marked as a duplicate of this bug. *** 1145907 7 ossy 2015-12-03 02:37:10 -0800 @Antti and @Darin: You are the author and the reviewer of r173394 which introduced this regression. What do you think, what would be the proper fix? Should we try to fix the broken !NETWORK_CACHE configuration or should we remove it completely? 1146738 8 darin 2015-12-06 18:46:01 -0800 I think that roughly speaking someone can put: #if !NETWORK_CACHE return 0_ms; #endif in the maximumBufferingTime function. That will turn off the caching Antti’s patch introduced. 1146855 9 gyuyoung.kim 2015-12-07 08:43:45 -0800 (In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #3) > > > just to note: https://trac.webkit.org/changeset/192994 skipped all wpt tests. > > > They should be unskipped once somebody fixes this very old regression. > > > > To fix it, I file a new bug - https://bugs.webkit.org/show_bug.cgi?id=151801 > > Common, why do we need a new bug report for the same bug? > > REGRESSION(r192994): imported/w3c/web-platform-tests has been timeout since > r192994 > https://bugs.webkit.org/show_bug.cgi?id=151801 > > Otherwise the name of the new bug is misleading, because r192994 only > made NetworkProcess mandatory, it isn't the real culprit. It is a 15 > months old bug caused by r173394. But it was hidden, because EFL > didn't use NetworkProcess at all until it became mandatory. For the record, test_ewk2_context_menu has been failing since r192796. - https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/25715 Let's see if this broken test can be fixed as well. 1147249 10 266876 ossy 2015-12-08 03:27:02 -0800 Created attachment 266876 Patch 1147250 11 ossy 2015-12-08 03:32:30 -0800 (In reply to comment #10) > Created attachment 266876 [details] > Patch (In reply to comment #8) > I think that roughly speaking someone can put: > > #if !NETWORK_CACHE > return 0_ms; > #endif > > in the maximumBufferingTime function. That will turn off the caching Antti’s > patch introduced. Thanks for the suggestions, it seems it works fine. 1147276 12 266876 darin 2015-12-08 07:54:38 -0800 Comment on attachment 266876 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=266876&action=review > Source/WebKit2/WebProcess/Network/WebLoaderStrategy.cpp:91 > +#if !ENABLE(NETWORK_CACHE) > + return 0_ms; > +#endif I think we need a comment explaining why we are doing this. It’s a mysterious line of code! 1147289 13 266876 commit-queue 2015-12-08 08:42:20 -0800 Comment on attachment 266876 Patch Clearing flags on attachment: 266876 Committed r193752: <http://trac.webkit.org/changeset/193752> 1147290 14 commit-queue 2015-12-08 08:42:24 -0800 All reviewed patches have been landed. Closing bug. 239798 2014-10-14 07:09:30 -0700 2015-12-08 03:26:51 -0800 WIP patch bug-137692-20141014160933.patch text/plain 1639 mtiborinf U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0NjgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOGI1MjQzNjQ2N2ZkZDc2 MjdhODRlNTM2MzBjMDZmMDMzY2MyZGIzMS4uZDdjNDI1YzZjNDA3NzIxOWViMDA3YWI5NjhlN2Nh ODU4NjIxNTllMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE0LTEwLTE0ICBUaWJv ciBNZXN6YXJvcyAgPHRtZXN6YXJvcy51LXN6ZWdlZEBwYXJ0bmVyLnNhbXN1bmcuY29tPgorCisg ICAgICAgIFtFRkxdIFJFR1JFU1NJT04ocjE3MzM5NCk6IE1pbmlCcm93c2VyIHN0dWNrZWQgaW4g YW4gaW5maW5pdGUgbG9vcCBvbiBodHRwOi8vaW5kZXguaHUgaWYgTmV0d29ya1Byb2Nlc3MgaXMg ZW5hYmxlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTM3NjkyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBXZWJQcm9jZXNzL05ldHdvcmsvV2ViUmVzb3VyY2VMb2FkU2NoZWR1bGVyLmNwcDoKKyAgICAg ICAgKFdlYktpdDo6bWF4aW11bUJ1ZmZlcmluZ1RpbWUpOgorCiAyMDE0LTEwLTE0ICBDaHJpcyBE dW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgVXNlIGlzPD4oKSAvIGRvd25jYXN0 PD4oKSBmb3IgUmVuZGVySW1hZ2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvTmV0d29yay9XZWJSZXNvdXJjZUxvYWRTY2hlZHVsZXIuY3BwIGIvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9OZXR3b3JrL1dlYlJlc291cmNlTG9hZFNjaGVkdWxlci5jcHAKaW5kZXggMWE3 ZjljMWU0NGYyNzAzM2YxZTQyMjFkNTFmNDM1ZGI0ODUwODdkYS4uODU1ODJiY2ExOTFjMTFlNzU4 NjRmYzc2NTBjZDI0NGU2ZDI5MmNhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9OZXR3b3JrL1dlYlJlc291cmNlTG9hZFNjaGVkdWxlci5jcHAKKysrIGIvU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9OZXR3b3JrL1dlYlJlc291cmNlTG9hZFNjaGVkdWxlci5jcHAKQEAg LTkxLDEwICs5MSwxMCBAQCBzdGF0aWMgc3RkOjpjaHJvbm86Om1pbGxpc2Vjb25kcyBtYXhpbXVt QnVmZmVyaW5nVGltZShDYWNoZWRSZXNvdXJjZSogcmVzb3VyY2UpCiAgICAgICAgIHJldHVybiAw X21zOwogCiAgICAgc3dpdGNoIChyZXNvdXJjZS0+dHlwZSgpKSB7Ci0gICAgY2FzZSBDYWNoZWRS ZXNvdXJjZTo6Q1NTU3R5bGVTaGVldDoKLSAgICBjYXNlIENhY2hlZFJlc291cmNlOjpTY3JpcHQ6 CiAgICAgY2FzZSBDYWNoZWRSZXNvdXJjZTo6Rm9udFJlc291cmNlOgogICAgICAgICByZXR1cm4g c3RkOjpjaHJvbm86Om1pbGxpc2Vjb25kczo6bWF4KCk7CisgICAgY2FzZSBDYWNoZWRSZXNvdXJj ZTo6Q1NTU3R5bGVTaGVldDoKKyAgICBjYXNlIENhY2hlZFJlc291cmNlOjpTY3JpcHQ6CiAgICAg Y2FzZSBDYWNoZWRSZXNvdXJjZTo6SW1hZ2VSZXNvdXJjZToKICAgICAgICAgcmV0dXJuIDUwMF9t czsKICAgICBjYXNlIENhY2hlZFJlc291cmNlOjpNYWluUmVzb3VyY2U6Cg== 266876 2015-12-08 03:27:02 -0800 2015-12-08 08:42:20 -0800 Patch bug-137692-20151208122632.patch text/plain 3083 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTkzNzQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZGM1Nzk4OGJkYTljMWZl MjQyYTk0MTcwMTY3NTY1MDAxMjFhNzljMi4uNjcxMzgxODcwNjIyM2QxNWE1NjJiZjExN2Y5YWMy MjRkNjFiNDc2OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE1LTEyLTA4ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgW0VGTF0gUkVHUkVT U0lPTihyMTczMzk0KTogTWluaUJyb3dzZXIgc3R1Y2tlZCBpbiBhbiBpbmZpbml0ZSBsb29wIGlm IE5FVFdPUktfQ0FDSEUgaXMgZGlzYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEzNzY5MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9OZXR3b3JrL1dlYkxvYWRlclN0cmF0ZWd5 LmNwcDoKKyAgICAgICAgKFdlYktpdDo6bWF4aW11bUJ1ZmZlcmluZ1RpbWUpOiBEaXNhYmxlIGNh Y2hpbmcgaWYgTkVUV09SS19DQUNIRSBpcyBkaXNhYmxlZC4KKwogMjAxNS0xMi0wOCAgUnl1YW4g Q2hvaSAgPHJ5dWFuLmNob2lAbmF2ZXJjb3JwLmNvbT4KIAogICAgICAgICBbRUZMXSBBZGQgQVBJ IHRvIHByb3ZpZGUgcHJlZmVyZW5jZXMgYmVmb3JlIGNyZWF0aW5nIGV3a192aWV3CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL05ldHdvcmsvV2ViTG9hZGVyU3RyYXRlZ3ku Y3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9OZXR3b3JrL1dlYkxvYWRlclN0cmF0ZWd5 LmNwcAppbmRleCBjNzZlNzE4NTcxYTUwMGI2MjI3MWU4NGM2NTMzYzU5MjFkMmZhMWRjLi44Nzg4 Mzg5ZTMyZTJjMjQyMDAyMTFkZWRlNTdhZjM2MDc3OTcxN2YxIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL05ldHdvcmsvV2ViTG9hZGVyU3RyYXRlZ3kuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvTmV0d29yay9XZWJMb2FkZXJTdHJhdGVneS5jcHAKQEAg LTg2LDYgKzg2LDEwIEBAIFJlZlB0cjxOZXRzY2FwZVBsdWdJblN0cmVhbUxvYWRlcj4gV2ViTG9h ZGVyU3RyYXRlZ3k6OnNjaGVkdWxlUGx1Z2luU3RyZWFtTG9hZChGCiAKIHN0YXRpYyBzdGQ6OmNo cm9ubzo6bWlsbGlzZWNvbmRzIG1heGltdW1CdWZmZXJpbmdUaW1lKENhY2hlZFJlc291cmNlKiBy ZXNvdXJjZSkKIHsKKyNpZiAhRU5BQkxFKE5FVFdPUktfQ0FDSEUpCisgICAgcmV0dXJuIDBfbXM7 CisjZW5kaWYKKwogICAgIGlmICghcmVzb3VyY2UpCiAgICAgICAgIHJldHVybiAwX21zOwogCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cK aW5kZXggNWNlMDBmYzhmZTI5OGJmOGMxNzk5NjA4ZjY1NGM2NjgwMTVhZmFjNy4uNTg3OGM5MTE5 ZTk3MWE3YWNmMTc5MTVhMDU2YTczZTk0OGVhYWRmOSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisy MDE1LTEyLTA4ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAg ICAgW0VGTF0gUkVHUkVTU0lPTihyMTczMzk0KTogTWluaUJyb3dzZXIgc3R1Y2tlZCBpbiBhbiBp bmZpbml0ZSBsb29wIGlmIE5FVFdPUktfQ0FDSEUgaXMgZGlzYWJsZWQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNzY5MgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZWZsL1Rlc3RFeHBl Y3RhdGlvbnM6IFVuc2tpcCBub3cgcGFzc2luZyB0ZXN0cy4KKwogMjAxNS0xMi0wOCAgRnJlZGVy aWMgV2FuZyAgPGZyZWQud2FuZ0BmcmVlLmZyPgogCiAgICAgICAgIFtjYWlyb10gU29saWQgc3Ry b2tlIG9mIGxpbmVzIHdpdGggdGhpY2tuZXNzIGxlc3MgdGhhbiAxIHBpeGVsIGJyb2tlbiBhZnRl ciByMTkxNjU4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvVGVzdEV4cGVj dGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9UZXN0RXhwZWN0YXRpb25zCmluZGV4 IDY5ODQ5M2Q4ZDgyNjgxMGM5MzY4ZDIxNDVmMzVlMTdiZDdmYzhiMjEuLmFiMGJmNWIyY2QwMTcx MmE5OTY5MmFhOWIyZjUzY2E0N2E0MzU1NjAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRm b3JtL2VmbC9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9U ZXN0RXhwZWN0YXRpb25zCkBAIC0yNzEyLDEwICsyNzEyLDYgQEAgY3NzMi4xL3RhYmxlcy90YWJs ZS1hbm9ueW1vdXMtb2JqZWN0cy0yMDYueGh0IFsgTWlzc2luZyBdCiBjc3MyLjEvdGFibGVzL3Rh YmxlLWFub255bW91cy1vYmplY3RzLTIwNy54aHQgWyBNaXNzaW5nIF0KIGNzczIuMS90YWJsZXMv dGFibGUtYW5vbnltb3VzLW9iamVjdHMtMjA4LnhodCBbIE1pc3NpbmcgXQogCi0jIEVGTCBsYXlv dXQgdGVzdCBoYXMgYmVlbiBicm9rZW4gc2luY2UgcjE5Mjc5Ni4gU0tpcCB3ZWItcGxhdGZvcm0t dGVzdHMgdW50aWwgZml4aW5nIHRoaXMgcHJvYmxlbS4KLSMgaHR0cDovL3RyYWMud2Via2l0Lm9y Zy9jaGFuZ2VzZXQvMTkyNzk2Ci1CdWcoRUZMKSBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRl c3RzIFsgU2tpcCBdCi0KIHdlYmtpdC5vcmcvYi8xNTE5NDMgaW1wb3J0ZWQvYmxpbmsvZWRpdGlu Zy9leGVjQ29tbWFuZC80MTI4MDgwLTIuaHRtbCBbIEZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzE1 MTk0MyBpbXBvcnRlZC9ibGluay9mYXN0L2V2ZW50cy9jbGljay13aXRoLWxhcmdlLW5lZ2F0aXZl LXRleHQtaW5kZW50Lmh0bWwgWyBGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8xNTE5NDMgaW1wb3J0 ZWQvYmxpbmsvZmFzdC9yZXBsYWNlZC9pbWFnZS1tYXAtYWx0LWNvbnRlbnQuaHRtbCBbIEZhaWx1 cmUgXQo=